Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-23 19:43:20 +00:00
Code Issues Projects Releases Packages Wiki Activity
8457 commits 4 branches 212 tags 144 MiB
Commit graph

8457 commits

This branch
This branch
All branches
Author SHA1 Message Date
Rabi Guha
0812a0af4c Improvement: Don't show function body in needless_lifetimes 
Changes the span on which the lint is reported to point to only the
function return type instead of the entire function body.
Fixes #5284
 2020-03-19 12:03:02 +05:30
bors
c036c4f4a5 Auto merge of #5335 - flip1995:changelog, r=Manishearth 
Update changelog to 1.43.0 beta

In the beta changelog update, I accidentally used the commit of the 1.43.0 beta, instead of the 1.42.0 beta. I fixed this in this PR.

[Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md)

r? @Manishearth

changelog: none
 2020-03-18 20:34:58 +00:00
bors
e004b9431d Auto merge of #5329 - matthiaskrgr:int_arith_on_ref_5328, r=flip1995 
integer_arithmetic: detect integer arithmetic on references.

changelog: integer_arithmetic fix false negatives with references on integers

Fixes #5328
 2020-03-18 14:56:05 +00:00
Matthias Krüger
ec1dcde46b tests: arithmetic: split into integer_arithmetic and float_arithmetic files. 2020-03-18 15:50:01 +01:00
bors
08fc39813f Auto merge of #5331 - matthiaskrgr:lint_docs1, r=flip1995 
clean up a few lint docs

changelog: none
 2020-03-18 14:34:34 +00:00
flip1995
f041dcdb4e
Fix limit-stderr-files test 2020-03-18 15:27:25 +01:00
flip1995
a808779441
Split up checked_unwrap test further 2020-03-18 15:26:24 +01:00
bors
89cffe18b1 Auto merge of #5330 - matthiaskrgr:newlint_expl, r=flip1995 
new_lint.rs: encourage authors to write more detailed code samples in lint descriptions (linted as well as fixed code)

changelog: none
 2020-03-18 13:58:41 +00:00
flip1995
552768f092
Update changelog to 1.43.0 beta 2020-03-18 14:55:44 +01:00
Matthias Krüger
c7c7ab23aa integer_arithmetic: detect integer arithmetic on references. 
Also fixes the same for float_arithmetic.

changelog: integer_arithmetic,float_arithmetic: fix false negatives with references on integers

Fixes #5328
 2020-03-18 14:52:01 +01:00
flip1995
ba7a1a4cbf
Merge remote-tracking branch 'upstream/rust-1.43.0' into backport_remerge 2020-03-18 11:54:58 +01:00
Matthias Krüger
b875c53d2c rustup https://github.com/rust-lang/rust/pull/69189 
rustups https://github.com/rust-lang/rust/pull/69189 which is part of https://github.com/rust-lang/rust/pull/70085
(at least I think this is the only pr that changes clippy test stdout)
 2020-03-18 03:27:05 +01:00
Matthias Krüger
2204bf20ae clean up a few lint docs 2020-03-18 02:50:39 +01:00
Matthias Krüger
7545925ffe new_lint.rs: encourage authors to write more detailed code samples in lint descriptions (linted as well as fixed code) 
changelog: none
 2020-03-18 01:43:39 +01:00
bors
204bb9b54b Auto merge of #5314 - ehuss:remove-git2, r=flip1995 
Remove git2 dependency.

This removes the `git2` dependency (used in the integration test).  Updating git2 is awkward because both cargo and clippy have to be updated in sync, so this removes that requirement. It didn't look like it was using the git2 library for any particular reason, so this just launches the `git` executable, which should be available more or less everywhere.

This unblocks updating Cargo.

changelog: none
 2020-03-17 10:00:05 -07:00
Matthias Krüger
b8effecee1 rustup https://github.com/rust-lang/rust/pull/69838 2020-03-17 10:18:22 +01:00
bors
23549a8c36 Auto merge of #5324 - matthiaskrgr:rustup_32, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69738

changelog: none
 2020-03-16 17:44:54 +00:00
Matthias Krüger
a97f60b8e3 rustup https://github.com/rust-lang/rust/pull/69738 2020-03-16 18:38:30 +01:00
bors
24f6d643fe Auto merge of #5322 - phansch:or_patterns, r=matthiaskrgr 
Make use of `or_patterns` feature

changelog: none
 2020-03-16 12:41:04 +00:00
Tim Robinson
52208f3cf3 Lint for pub(crate) items that are not crate visible due to the visibility of the module that contains them 
Closes #5274.
 2020-03-16 12:21:00 +00:00
bors
d556bb73df Auto merge of #5321 - matthiaskrgr:rustup_31, r=phansch 
rustup https://github.com/rust-lang/rust/pull/68944

changelog: none
 2020-03-16 12:11:00 +00:00
Matthias Krüger
ba0884bee3 rustup https://github.com/rust-lang/rust/pull/68944 2020-03-16 11:36:17 +01:00
Philipp Hansch
548c417ec4
Make use of or_patterns feature 2020-03-16 07:25:09 +01:00
bors
d8bcdac9de Auto merge of #5318 - matthiaskrgr:rustup_30, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69589/

changelog: none
 2020-03-15 20:57:14 +00:00
Matthias Krüger
4d8ed5a842 rustup https://github.com/rust-lang/rust/pull/69589/ 2020-03-15 18:23:43 +01:00
bors
c1a138cdd9 Auto merge of #5316 - lzutao:osstr, r=phansch 
Don't convert Path to lossy str

changelog: none
 2020-03-15 12:57:30 +00:00
bors
8fd7e31d1b Auto merge of #5317 - JohnTitor:rustup, r=matthiaskrgr 
Rustup to rust-lang/rust#69076

changelog: none
 2020-03-14 21:45:38 +00:00
Yuki Okushi
00861d100d
Rustup to rust-lang/rust#69076 2020-03-15 05:26:32 +09:00
Lzu Tao
9febcf5e8d Don't convert Path to lossy str 2020-03-14 22:20:16 +07:00
Lzu Tao
6be0220967 Use into_path 2020-03-14 22:20:16 +07:00
Lzu Tao
29df0139dc Use pattern matching instead of manually checking condition 2020-03-14 19:29:48 +07:00
bors
df64ea682c Auto merge of #5312 - joshtriplett:wildcard-prelude-documentation, r=flip1995 
Document that wildcard_imports doesn't warn about `use ...::prelude::*;`

changelog: Improve [`wildcard_imports`] documentation
 2020-03-14 12:17:09 +00:00
bors
ceb9b7d66d Auto merge of #5314 - ehuss:remove-git2, r=flip1995 
Remove git2 dependency.

This removes the `git2` dependency (used in the integration test).  Updating git2 is awkward because both cargo and clippy have to be updated in sync, so this removes that requirement. It didn't look like it was using the git2 library for any particular reason, so this just launches the `git` executable, which should be available more or less everywhere.

This unblocks updating Cargo.

changelog: none
 2020-03-14 09:23:16 +00:00
Philipp Krones
626f2fe1cb
Fix typo 
Co-Authored-By: Mateusz Mikuła <mati865@users.noreply.github.com>
 2020-03-14 10:22:49 +01:00
Eric Huss
34a00fe7f4 Remove git2 dependency. 2020-03-13 18:22:51 -07:00
Josh Triplett
f56b0a1b34 Document that wildcard_imports doesn't warn about use ...::prelude::*; 2020-03-13 17:07:11 +00:00
bors
2d8a362cbe Auto merge of #5308 - flip1995:changelog, r=Manishearth 
Update Changelog

I also changed the formatting of the changelog for the beta changelog. I can also do this for all the previous releases, if this formatting gets accepted.

[Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md)

r? @Manishearth

changelog: none
 2020-03-13 00:07:33 +00:00
bors
8485d40a32 Auto merge of #5304 - sinkuu:redundant_clone_not_consumed, r=flip1995 
Extend `redundant_clone` to the case that cloned value is not consumed

Fixes #5303.

---

changelog: Extend `redundant_clone` to the case that cloned value is not consumed
 2020-03-12 20:22:31 +00:00
bors
b064ea8096 Auto merge of #5307 - JohnTitor:rename-method, r=flip1995 
Rustup to rust-lang/rust#69674

changelog: none
 2020-03-12 20:05:38 +00:00
flip1995
7b08c7a36e
Change changelog formatting 2020-03-12 21:02:15 +01:00
flip1995
6525127c62
Update changelog_update doc to reflect the actual ordering of the changelog 2020-03-12 21:02:08 +01:00
flip1995
da29402d2e
Update CHANGELOG.md 2020-03-12 21:01:19 +01:00
Yuki Okushi
3e3776666e
Rustup to rust-lang/rust#69674 2020-03-13 04:56:55 +09:00
Shotaro Yamada
d9ad33852c Use visit_place 2020-03-13 02:06:47 +09:00
Shotaro Yamada
aca64b8df7 Check for mutation 2020-03-13 01:25:18 +09:00
Shotaro Yamada
a377378528 Only fires on temporaries 
`let y = x.clone()` cannot be turned into `let y = x` without moving x,
regardless of whether `y` is consumed or not.
 2020-03-13 00:54:40 +09:00
Shotaro Yamada
9de642190e Extend redundant_clone to the case that cloned value is not consumed 2020-03-13 00:31:09 +09:00
bors
fdce47ba7d Auto merge of #5272 - jmeyers35:file_read_lint, r=flip1995 
add lint on File::read_to_string and File::read_to_end

Adds lint `verbose_file_reads` which checks for use of File::read_to_end and File::read_to_string.

Closes https://github.com/rust-lang/rust-clippy/issues/4916

changelog: add lint on File::{read_to_end, read_to_string}
 2020-03-10 22:35:15 +00:00
bors
9d5ffe8105 Auto merge of #5300 - JohnTitor:edition-flag, r=flip1995 
Use `edition:2018` flag more widely

Now we recommend using `// edition:2018`, so let's use it more widely.
Also replace a too old example with new one in the docs.

changelog: none
 2020-03-10 22:02:41 +00:00
Jacob Meyers
a4ba1027fc add CR feedback 2020-03-10 18:00:37 -04:00