944 commits

Author	SHA1	Message	Date
Oliver Schneider	7b836dd27c	become rustfmt resistant	2017-01-17 19:27:52 +01:00
Oliver Schneider	25100a8299	fix build	2017-01-17 19:23:32 +01:00
Andre Bogus	27d47f970a	rustfmt tests to fix build	2017-01-17 16:12:09 +01:00
Oliver Schneider	219da6d736	Merge pull request #1444 from Manishearth/or_else_method ... Extend or_fun_call to also cover methods	2017-01-15 14:38:51 +01:00
sinkuu	cdfe002ee1	Use closure body span (fixes #1405)	2017-01-15 13:16:02 +09:00
Andre Bogus	b764b2a7aa	extend or_fun_call lint to cover methods	2017-01-15 00:31:20 +01:00
Andre Bogus	2fdb6e4d1a	deprecate extend_from_slice lint	2017-01-14 14:39:41 +01:00
Oliver Schneider	d944d7df9a	rustup to 2017-01-12	2017-01-13 17:04:56 +01:00
Oliver Schneider	3cc5596466	Merge pull request #1433 from sinkuu/ref ... Don't lint needless_borrow when matching `&&mut` by `&ref`	2017-01-10 17:29:19 +01:00
sinkuu	c9091b71a1	Don't lint when matching &&mut by &ref (Fix #1432)	2017-01-11 00:42:58 +09:00
Oliver Schneider	e066997046	FOR_KV_MAP can now lint on mutable maps due to values_mut()	2017-01-10 08:33:20 +01:00
sinkuu	a2bcce9dbf	Move is_try to util ... Removed unnecessary condition Also changed lint span of `try` from surrounded expression to entire `try` invocation. It turned out that compiletest misses errors for macro invocations.	2017-01-07 23:52:48 +09:00
sinkuu	ce6e037ac5	Implement unused_io_amount lint	2017-01-07 22:23:33 +09:00
Theemathas Chirananthavat	3050d90930	Add forget_ref tests. ... Also rename drop_ref.rs to drop_forget_ref.rs in tests/compile-fail.	2017-01-05 17:41:01 -08:00
Theemathas Chirananthavat	920a2b7468	The drop_ref test does not require implementing the Drop trait.	2017-01-05 17:41:01 -08:00
Oliver Schneider	f145fc44f8	Merge pull request #1414 from samueltardieu/no-short-circuit-if ... Add a new "short_circuit_statement" lint (fixes #1194)	2017-01-05 10:41:14 +01:00
Manish Goregaokar	9a301fd508	Bump to 0.0.106; Fix false positive in wrong_self_convention (fix #1420)	2017-01-04 18:05:04 -08:00
Samuel Tardieu	82b2f5663f	Add a new "short_circuit_statement" lint (fixes #1194)	2016-12-31 01:17:39 +01:00
Manish Goregaokar	b8b54eb0d8	Fix suggestion span on new_without_default (fixes #1407)	2016-12-29 11:19:32 -08:00
Theemathas Chirananthavat	c0c20145d1	Fix compile-fail tests by allowing double_parens.	2016-12-28 12:04:46 -08:00
Theemathas Chirananthavat	e7352877c5	Add test for double_parens lint.	2016-12-28 11:21:53 -08:00
Martin Carton	96d2483b09	Merge pull request #1400 from oli-obk/needed_needless_lifetime ... support impl trait for needless lifetimes	2016-12-25 18:24:39 +01:00
Martin Carton	7c480d0db7	Merge pull request #1394 from Manishearth/absurd_extreme_comparisons_false_positive ... fix absurd extreme comparisons false positive	2016-12-25 17:47:42 +01:00
Oliver Schneider	93333f0d7b	support impl trait for needless lifetimes	2016-12-22 15:51:59 +01:00
Oliver Schneider	2f219b827e	fix an ice related to associated types ... fixes #1341	2016-12-22 14:16:07 +01:00
Oliver Schneider	0b10a41ef3	fix absurd extreme comparisons false positive ... fixes #1387	2016-12-21 16:49:53 +01:00
Oliver Schneider	7a1d85f1de	Merge branch 'master' into allow_deprecated	2016-12-21 15:47:12 +01:00
Oliver Schneider	00a3bfb8eb	Don’t warn for types used in trait implementation	2016-12-21 15:42:20 +01:00
Oliver Schneider	90fc9c389f	split pub_enum_variant_names to new lint	2016-12-21 13:30:57 +01:00
Oliver Schneider	009c6d95d7	manually fix the overlong lines	2016-12-21 12:30:41 +01:00
Oliver Schneider	0a7ae5fec8	run rustfmt	2016-12-20 10:20:41 +01:00
Manish Goregaokar	d61c7fc747	Merge pull request #1355 from philipturnbull/deref-addrof ... Lint usage of `*&` and `*&mut`	2016-12-19 03:35:45 -08:00
Oliver Schneider	5aded99033	don't lint on x = x + y inside an AddAssign impl ... fixes #1302	2016-12-19 11:13:07 +01:00
Oliver Schneider	2e63a5648a	uncomment code that was commented out for testing	2016-12-04 19:31:46 +01:00
mcarton	65ff2df7e7	Fix copy lints	2016-12-02 22:23:24 +01:00
mcarton	fe15880beb	Revert "down to for-loops not comparing as equal" ... This reverts commit cf1fa94be1.	2016-12-02 20:54:05 +01:00
mcarton	42fb11f887	Don't set RUST_BACKTRACE for tests ... It is slow but it can be useful and can be set/unset explicitly before running tests if needed. There is no backtrace by default anyway.	2016-12-02 20:33:37 +01:00
Oliver Schneider	cf1fa94be1	down to for-loops not comparing as equal	2016-12-02 19:19:52 +01:00
Oliver Schneider	16aab71688	enum glob use and copies left	2016-12-02 17:38:31 +01:00
Wim Looman	919feaaec5	Allow allow(deprecated) attribute on use items ... fixes #1372	2016-12-01 22:36:35 +01:00
Phil Turnbull	0ee6128e27	Convert DEREF_ADDROF to EarlyLintPass	2016-11-25 10:33:21 -05:00
Phil Turnbull	8d04038c56	Make deref_addrof suggestions stricter ... SUGGESTION matches a substring so 'aref' in the testcases can match 'let b = *aref', 'let b = **aref', 'let b = *&aref' etc, which are all wrong.	2016-11-25 10:33:01 -05:00
mcarton	c35f82b823	Rustup to *rustc 1.15.0-nightly (7b3eeea22 2016-11-21)*	2016-11-23 21:31:55 +01:00
Phil Turnbull	a9f5b90f0f	Lint usage of *& and *&mut ... fixes #1316	2016-11-22 21:06:20 -05:00
Martin Carton	530083c3b9	Merge pull request #1349 from philipturnbull/extend-chars ... Lint `.extend(s.chars())` (closes #792)	2016-11-22 18:21:30 +01:00
Phil Turnbull	e9f3911899	Suggest &s instead of s.as_str()	2016-11-20 11:19:36 -05:00
sinkuu	5d40965b50	Fix #1346	2016-11-20 10:15:40 +09:00
sinkuu	1973e94550	Allow explicit returns with cfg attributes	2016-11-20 10:02:41 +09:00
Phil Turnbull	73a73638c0	Add lint for string.extend(string.chars()) ... fixes #792	2016-11-19 14:55:47 -05:00
Phil Turnbull	fa78b09fa7	Add lint for string.extend("str".chars()) ... fixes #792	2016-11-19 14:55:02 -05:00
mcarton	7140eac484	Cleanup	2016-11-18 13:40:44 +01:00
mcarton	945c027768	Handle closure with single expression blocks	2016-11-17 19:44:18 +01:00
mcarton	19c5f5394b	Rustup to rustc 1.15.0-nightly (0ed951993 2016-11-14)	2016-11-16 23:05:26 +01:00
Oliver 'ker' Schneider	cfae1e9fda	fix ice in len_zero lint when type has no inherent impls at all ... fixes #1336	2016-11-10 17:06:39 +01:00
Oliver Schneider	a260e65ead	Merge pull request #1312 from devonhollowood/get-unwrap ... Implement `get_unwrap` lint	2016-11-09 09:49:20 +01:00
Oliver Schneider	a56af73fd8	mark cyclomatic complexity attribute as used ... fixes #1315	2016-11-02 10:29:57 +01:00
Devon Hollowood	6a14dc7fd4	Remove false positives from get_unwrap lint ... HashMap and BTreeMap don't implement `IndexMut`, so we shouldn't lint for use of `get_mut().unwrap()` for those types.	2016-11-01 17:48:32 -07:00
Devon Hollowood	4e0d182d1d	Clean up get_unwrap code	2016-11-01 17:48:18 -07:00
Devon Hollowood	1187d333ec	Add tests for get_unwrap lint	2016-11-01 01:08:47 -07:00
Sebastian Ullrich	8664d03ec6	implement 'Re-implementing PartialEq::ne' lint ... closes #86	2016-10-30 15:00:59 -04:00
d-dorazio	d213040381	Add lint for redundant pattern matching in iflet for Result/Option	2016-10-30 15:43:46 +01:00
Devon Hollowood	3a0d342a33	Fix false positive for wrong_self_convention	2016-10-27 01:11:34 -07:00
mcarton	984e15a0c0	Forbid default warnings in dogfood	2016-10-22 16:16:55 +02:00
d-dorazio	62831c6e29	Suggest nth(X) instead of skip(X).next()	2016-10-14 13:38:00 +02:00
mcarton	8d0431fd9a	Test for #1275 ... Close #1275.	2016-10-12 12:00:26 +02:00
d-dorazio	a4d4a372e0	Avoid redundant multiple pattern suggested when one pattern is _	2016-10-08 16:29:19 +02:00
mcarton	47c2271497	Fix FP with print_with_newline and final arguments	2016-10-06 22:30:03 +02:00
Martin Carton	e851bc7404	Merge pull request #1257 from KitFreddura/master ... If let some lint	2016-10-04 23:00:05 +02:00
Manish Goregaokar	7b94ef19bd	aux -> auxiliary (breaks Windows)	2016-10-04 09:15:03 +05:30
Manish Goregaokar	a4198c1108	Merge pull request #1255 from Manishearth/cov ... Improve test coverage	2016-10-03 22:15:23 +05:30
mcarton	6800111c8e	Move all *.toml test files to tests/aux	2016-10-03 17:49:41 +02:00
Kit Freddura	72a653d8d4	readded files	2016-10-02 13:49:29 -07:00
mcarton	7b92fe0387	Test configuration file typing errors	2016-10-02 14:46:46 +02:00
mcarton	019e310861	Add more tests for bad configuration file	2016-10-02 14:43:09 +02:00
mcarton	f6f4af6adc	Add missing tests for ... and array indexing	2016-10-02 14:42:55 +02:00
mcarton	e50cfa7e77	Add a test for a shadow corner case	2016-10-02 02:38:54 +02:00
mcarton	9a3f53dee6	Partially hash let declaration in SpanlessHash ... The hash never needs to be good but before it was simply doing nothing for these.	2016-10-02 02:17:04 +02:00
mcarton	6302e41ccb	Improve test coverage of hir comparison	2016-10-01 22:27:25 +02:00
Martin Carton	8babb2d409	Merge pull request #1250 from elliottneilclark/explicit_into_iter ... Add a lint to warn about un-necessary .into_iter()	2016-10-01 15:01:43 +02:00
Oliver Schneider	9c5d3f3b85	correctly traverse match expressions for diverging_sub_expr	2016-10-01 14:41:20 +02:00
Elliott Clark	5fa004313b	Add a lint to warn about un-necessary .into_iter() ... This should close #1094.	2016-09-30 17:42:43 -07:00
mcarton	84269478b0	chmod -x tests/compile-fail/print_with_newline.rs	2016-10-01 00:50:40 +02:00
Martin Carton	fe27ac5fd2	Merge pull request #1237 from Manishearth/rustup ... Rustup to *rustc 1.13.0-nightly (d0623cf7b 2016-09-26)* and bump to 0.0.91	2016-09-28 01:15:33 +02:00
mcarton	4f3920307a	Rustup to *rustc 1.13.0-nightly (d0623cf7b 2016-09-26)*	2016-09-28 01:09:11 +02:00
mcarton	056b0c1cf2	Remove redundant labels in tests	2016-09-23 19:51:47 +02:00
Manish Goregaokar	fc9f2b99c7	Merge pull request #1235 from Manishearth/transmute_ptr_to_ref-suggs ... Fix wrong suggestion in `TRANSMUTE_PTR_TO_REF` with lts	2016-09-19 22:02:47 +05:30
mcarton	f74dcaac0c	Fix wrong suggestion in TRANSMUTE_PTR_TO_REF with lts	2016-09-19 17:59:12 +02:00
Oliver Schneider	c89c5d21c1	Merge remote-tracking branch 'origin/master' into examples	2016-09-19 15:38:38 +02:00
mcarton	c8986b4676	Fix FP with WHILE_LET_ON_ITERATOR and refutable pats	2016-09-16 15:50:35 +02:00
Martin Carton	dc84759ac5	Merge pull request #1224 from oli-obk/divergence ... lint diverging expressions that are sub-expressions of others	2016-09-13 15:58:31 +02:00
Oliver Schneider	9427a4ae80	also test match statements, return, continue and break	2016-09-13 14:52:21 +02:00
Oliver Schneider	e6bfe4b514	also lint diverging methods	2016-09-13 12:41:37 +02:00
Oliver Schneider	a2257280ec	don't lint expressions referencing ! objects, just expressions creating them	2016-09-13 12:41:20 +02:00
Oliver Schneider	40ce3a8f1c	add tests for stutter lints	2016-09-13 10:20:10 +02:00
Oliver Schneider	12a82b2007	also lint private modules for module_inception, as that is the main issue	2016-09-13 10:19:55 +02:00
Oliver Schneider	f469860dc2	lint diverging expressions that are sub-expressions of others	2016-09-12 14:24:11 +02:00
Oliver Schneider	03fa974855	Let the submodule #[allow] in module_inception	2016-09-12 10:30:42 +02:00
mcarton	8216036193	Add test for #[allow(module_inception)] on the inner module	2016-09-12 10:11:48 +02:00
mcarton	b08c7aa553	Remove EOL space	2016-09-09 20:24:15 +02:00
mcarton	b82f43f38e	Revert "Remove all union stuffs" ... This reverts commit 888c34ad70. This rustups to rustc 1.13.0-nightly (70598e04f 2016-09-03).	2016-09-04 17:45:36 +02:00
mcarton	b2de244cfd	Restrict len_without_is_empty to exported items	2016-09-02 15:30:06 +02:00
kennytm	5f09020e90	Added a lint_without_lint_pass lint. ... Four lints were missing from LintPass, making them unavailable unless the `clippy` lint group is explicitly enabled: * `for_loop_over_result` * `for_loop_over_option` * `match_overlapping_arm` * `filter_next`	2016-09-01 15:07:37 +08:00
mcarton	888c34ad70	Remove all union stuffs ... The rustc's PR wasn't merged. Hopefully this commit can simply be reverted when it's time.	2016-08-31 18:22:36 +02:00
mcarton	01424f5622	Support unions here and there	2016-08-31 18:22:36 +02:00
mcarton	ee3f3bf260	Remove temporary fix now unneeded	2016-08-31 18:22:36 +02:00
mcarton	d87f137254	Add a builtin_type_shadow lint	2016-08-28 19:56:18 +02:00
mcarton	e922fa80ce	Fix FP in ZERO_PREFIXED_LITERAL and 0b/Oo	2016-08-28 18:00:09 +02:00
mcarton	36d8ca04a1	Add a MISSING_DOCS_IN_PRIVATE_ITEMS lint	2016-08-23 18:28:39 +02:00
mcarton	507b626b36	Add zero_prefixed_literal lint	2016-08-23 18:15:12 +02:00
llogiq	cf2b0c8dd6	New cmp_null lint (fixes #1184) (#1186) ... * new cmp_null lint (fixes #1184) * adressed comments (still fails) * fixed tests, dogfood, ran update_lints	2016-08-22 18:29:29 +02:00
Oliver Schneider	6dd003ac39	add regression test	2016-08-19 17:31:14 +02:00
Oliver Schneider	7b717d3152	fallout	2016-08-17 18:35:25 +02:00
Oliver Schneider	3ab6ad59c4	disallow lint attributes on use and extern crate items	2016-08-17 11:36:04 +02:00
Georg Brandl	ffad9a8c8c	Lint print!("...\n") (closes #455)	2016-08-16 20:52:48 +02:00
Oliver Schneider	b6f320a495	address nits and improve docs	2016-08-16 14:36:48 +02:00
Oliver Schneider	7ee4a9a659	lint modules that have the same name as their parent module	2016-08-16 14:29:21 +02:00
scurest	b0a96def09	Add lint for reads and writes that depend on evaluation order	2016-08-11 06:01:40 -05:00
llogiq	ce3be22021	Merge pull request #1151 from oli-obk/clone_ref ... add suggestions to clone_on_copy	2016-08-09 06:30:25 +02:00
llogiq	8ac99162ea	Merge pull request #1152 from oli-obk/wrong_self_conv_fn_level ... enable changing wrong_self_convention's lint level at the function level	2016-08-08 21:13:16 +02:00
Manish Goregaokar	4b8f6a0b0f	Merge pull request #1154 from oli-obk/no_dogfood_for_travis ... don't run clippy on itself twice in travis	2016-08-08 21:48:29 +05:30
Oliver Schneider	dec3250ad6	don't run clippy on itself twice in travis	2016-08-08 17:33:41 +02:00
Oliver Schneider	331afc3246	extern fns often need to adhere to a specific api -> don't suggest api-changes	2016-08-08 17:21:47 +02:00
Oliver Schneider	49f276ec6f	enable changing wrong_self_convention's lint level at the function level	2016-08-08 17:09:36 +02:00
Oliver Schneider	7e67f447ce	add suggestions to clone_on_copy ... also: * don't report clone_on_copy when reporting clone_on_double_ref * don't suggest `((x))`	2016-08-08 16:43:45 +02:00
Manish Goregaokar	74c7880597	Merge pull request #1145 from birkenfeld/issue-703-2 ... Lint literal suffixes not separated by underscores (idea also from #703)	2016-08-07 09:57:16 +05:30
Georg Brandl	fa0df69a97	Add a configurable threshold for enum variants before name lints trigger (fixes #1138)	2016-08-06 20:59:27 +02:00
Georg Brandl	2f8247ada5	Lint literal suffixes not separated by underscores (see #703)	2016-08-05 18:50:23 +02:00
Georg Brandl	ab58331f22	Lint inconsistent casing in hex literals (closes #703)	2016-08-05 18:30:49 +02:00
Oliver Schneider	81c5757f44	lint on by ref patterns for references	2016-08-01 16:59:14 +02:00
Oliver Schneider	100d381d2b	lint a += a + b (possible mis-refactoring of a = a + b)	2016-07-20 15:29:24 +02:00
llogiq	a371558bdb	Merge pull request #1093 from oli-obk/serde_specific_lint ... lint on implementing `visit_string` without also implementing `visit_str`	2016-07-18 11:53:28 +02:00
Oliver Schneider	02c46f057f	add an internal lint that catches misordered paths	2016-07-18 11:19:33 +02:00
Manish Goregaokar	b8c5e5a89c	Fix position of mut in toplevel-ref-arg (fixes #1100, again)	2016-07-15 19:02:41 +05:30
Manish Goregaokar	60f354880f	Suggest mutability and fix type in toplevel-ref-arg	2016-07-15 17:52:34 +05:30
llogiq	b1becf41e4	Merge pull request #1099 from Manishearth/fix ... Some small fixes	2016-07-14 21:32:45 +02:00
mcarton	ea665c38f1	Fix FP with USELESS_VEC and non-copy types	2016-07-14 19:31:17 +02:00
mcarton	c1eb5828fa	Fix suggestion spans for NEEDLESS_RETURN	2016-07-14 18:32:48 +02:00
Taylor Cramer	7450d842ea	Fix different NaNs in if const expressions test	2016-07-13 10:02:28 -07:00
Taylor Cramer	61d1a9b030	Check for comparison of -0.0 and 0.0 in PartialOrd for Constant	2016-07-13 09:55:16 -07:00
Taylor Cramer	0c21a6b0c4	Add test for different NaNs	2016-07-13 09:35:31 -07:00
Taylor Cramer	8907cbc0b8	Added sign check on Constant f64 PartialEq implementation	2016-07-13 00:43:33 -07:00
Oliver Schneider	319c66a2a4	lint on implementing visit_string without also implementing visit_str	2016-07-12 17:36:11 +02:00
Manish Goregaokar	c1421c6e82	Don't warn when boxing large arrays	2016-07-12 18:49:34 +05:30
mcarton	b8b6b7fee6	Try to explain MATCH_SAME_ARMS better	2016-07-10 14:46:39 +02:00
mcarton	eb75d4ee62	Fix suggestions for NEW_WITHOUT_DEFAULT	2016-07-10 14:20:38 +02:00
mcarton	3a7402a6d2	Fix FP with for loops and shadowed loop variable	2016-07-10 14:05:57 +02:00
llogiq	ad1cd99054	Merge pull request #1060 from Manishearth/sugg ... Improve suggestions	2016-07-10 00:06:30 +02:00
mcarton	56d3bc7008	Handle /** and ~~~ in DOC_MARKDOWN	2016-07-08 18:24:47 +02:00
mcarton	c5e91e70d0	Use sugg::Sugg in transmute links	2016-07-04 02:22:57 +02:00
mcarton	9b79b1022c	Fix suggestions for needless_bool	2016-07-04 01:43:47 +02:00
mcarton	7778f314f2	Merge branch 'master' into sugg	2016-07-04 00:51:19 +02:00
mcarton	2f259b8cd3	Use span_suggestion in entry lints	2016-07-03 23:27:44 +02:00
mcarton	ffa840d4f2	Use utils::sugg in match related lints ... Also don't build suggestion when unnecessary.	2016-07-03 23:27:37 +02:00
James Lucas	10b545e30b	Check for constant expression in useless_vec lint	2016-07-03 12:12:43 -07:00
mcarton	0e3dcd1376	Improve NOT_UNSAFE_PTR_ARG_DEREF with functions	2016-07-03 13:29:04 +05:30
mcarton	7781f1d7c5	Add a new not_unsafe_ptr_arg_deref lint	2016-07-03 13:28:34 +05:30
mcarton	2a45a2ab6b	Use utils::sugg in FOR_KV_MAP	2016-07-01 20:55:45 +02:00
mcarton	f6c9490e65	Fix wrong suggestion with ... and for loops	2016-07-01 19:31:14 +02:00
mcarton	9bd7fa05e0	Improve NEEDLESS_RANGE_LOOP error reporting	2016-07-01 18:53:04 +02:00
mcarton	d6182b365c	Merge remote-tracking branch 'origin/rustup' into sugg	2016-07-01 17:48:57 +02:00
mcarton	55b78ae478	Rustup to ea0dc9297283daff6486807f43e190b4eb561412 II	2016-07-01 17:44:17 +02:00
mcarton	3c4af49662	Rustup to ea0dc9297283daff6486807f43e190b4eb561412	2016-07-01 17:44:17 +02:00
mcarton	ebf72cb67f	Use util::sugg in TRANSMUTE_PTR_TO_REF	2016-07-01 17:12:48 +02:00
mcarton	7023988020	Use utils::sugg in TOPLEVEL_REF_ARG	2016-07-01 17:12:48 +02:00
mcarton	7a1fc9fce5	Use utils::sugg in MATCH_BOOL	2016-07-01 17:12:48 +02:00
mcarton	66808c1e77	Use utils::sugg in COLLAPSIBLE_IF	2016-07-01 17:12:48 +02:00
mcarton	2e8edde6e9	Use utils::sugg in FLOAT_CMP	2016-07-01 17:12:48 +02:00
mcarton	8d58a928e5	Use utils::sugg in ASSIGN_OPS	2016-07-01 17:12:48 +02:00
mcarton	580ae5a879	Use span_suggestion in FLOAT_CMP	2016-07-01 17:12:48 +02:00
Andre Bogus	a12e8394d7	new lint: double_neg	2016-06-30 01:00:25 +02:00
mcarton	9e76bcee5d	Improve matches tests	2016-06-29 17:10:21 +02:00
mcarton	ea76ac5562	Make COLLAPSIBLE_IF consider if let	2016-06-29 17:09:39 +02:00
mcarton	7fa38f6787	Fix FP with mut_mut and for loops	2016-06-29 17:09:39 +02:00
Oliver Schneider	9ceb708727	Merge pull request #1053 from oli-obk/char_float_transmute ... lint on unnecessary and plain wrong transmutes	2016-06-28 14:50:39 +02:00
Oliver Schneider	e06bc37477	lint on unnecessary and plain wrong transmutes	2016-06-28 14:08:08 +02:00
Manish Goregaokar	cdce78a4be	Add parentheses when necessary in transmute suggestion (fixes #1049)	2016-06-28 14:03:46 +05:30
Oliver Schneider	a469ee1061	lint transmuting references to pointers	2016-06-27 16:12:48 +02:00
Oliver Schneider	60cc87baba	Merge pull request #1041 from oli-obk/procedural ... don't depend on regex_macros anymore	2016-06-26 14:13:24 +02:00
Oliver 'ker' Schneider	2e86eb88f3	rename mini-macro to clippy-mini-macro-test	2016-06-26 13:26:30 +02:00
Oliver 'ker' Schneider	8c5e617c9a	don't lint on comparing *const f32s	2016-06-25 18:59:37 +02:00
Oliver 'ker' Schneider	d57192d5c1	don't depend on regex_macros anymore	2016-06-25 18:12:29 +02:00
llogiq	f81d253c07	Merge pull request #995 from oli-obk/oh_the_horror ... lint on `filter(x).map(y)`, `filter(x).flat_map(y)`, `filter_map(x).flat_map(y)`	2016-06-22 13:06:12 +02:00
Oliver Schneider	5ccbf3d437	unify the lints	2016-06-22 10:44:46 +02:00
Martin Carton	294aeaf4b3	Merge pull request #1012 from Manishearth/nohyg ... Don't use identifier hygiene in HIR	2016-06-21 21:23:39 +02:00
Oliver Schneider	ac6e7b2957	fix tests	2016-06-21 14:46:02 +02:00
Oliver Schneider	eef439cb78	add tests	2016-06-21 13:48:56 +02:00
Oliver Schneider	44c30ca543	fix tests	2016-06-21 12:35:49 +02:00
Devon Hollowood	12bc90d457	Add tests for extend-iter-nth	2016-06-16 14:39:29 -07:00
llogiq	f3397afacb	Merge pull request #994 from oli-obk/stuttter ... Stuttter lint	2016-06-16 19:00:43 +02:00
Martin Carton	4e8c87ad08	Merge pull request #1021 from Manishearth/issue1017 ... Fix FP with `WHILE_LET_LOOP` and break expressions	2016-06-16 16:30:44 +02:00
mcarton	836554387a	Fix FP with WHILE_LET_LOOP and break expressions	2016-06-16 16:21:11 +02:00
Oliver Schneider	32894d503e	lint enum variants names that start or end with their enum's name	2016-06-16 12:17:15 +02:00
Devon Hollowood	74025be59d	Make iter_nth work for Vecs too	2016-06-16 02:04:32 -07:00
Devon Hollowood	555e4555b1	Add tests for slice_iter_nth	2016-06-16 01:29:03 -07:00
mcarton	e6cbe970c8	Don't use identifier hygiene in HIR	2016-06-15 16:36:22 +02:00
mcarton	90453fd893	Run rustfmt ... Only partially apply suggestions.	2016-06-10 00:08:14 +02:00
llogiq	e6832317fa	Merge pull request #999 from Manishearth/whitelist ... Some small fixes	2016-06-10 00:04:50 +02:00
mcarton	e9360f7675	Fix suggestions for REVERSE_RANGE_LOOP	2016-06-09 23:34:19 +02:00
mcarton	ce2b96abe9	Fix yet another FP in USELESS_LET_IF_SEQ ... The block expression before the assignment must be `None`.	2016-06-09 23:33:38 +02:00
mcarton	c5affa2efc	Whitelist Nan in DOC_MARKDOWN	2016-06-09 23:33:28 +02:00
Carol (Nichols || Goulding)	8e1dc0481c	Include consts in the approx_consts lint for easier copypasting ... If you try to use `f64::PI`, it won't work-- you need to use `f64::consts::PI`, so suggest that in the lint message.	2016-06-08 19:58:29 -04:00
mcarton	1f419a2986	Add missing suggestions and help message to tests	2016-06-07 18:33:24 +02:00
mcarton	dd3fd41a03	Use span_suggestion for WHILE_LET_ON_ITERATOR	2016-06-07 18:32:40 +02:00
mcarton	65c4e391ee	Fix wrong tests and improve some other	2016-06-07 17:32:36 +02:00
mcarton	a7a6c0461d	Add environment variable to deactivate wiki links	2016-06-05 22:03:02 +02:00
mcarton	158183adf5	Fix false-positive in USELESS_LET_IF_SEQ	2016-06-05 21:46:48 +02:00
mcarton	9f70d04000	Fix wrong suggestion with MANUAL_SWAP and slices	2016-06-05 20:19:00 +02:00
llogiq	66c03f980e	Merge pull request #962 from Manishearth/fix-doc ... Fix DOC_MARKDOWN and multiline links and quotes	2016-06-04 09:24:39 +02:00
mcarton	5c2a10d703	Correctly check for variable use in useless_let_if_seq	2016-06-03 19:35:39 +02:00
Manish Goregaokar	bf4ce86e9e	Make new_without_default ignore const fns; fixes #977	2016-06-03 20:17:39 +05:30
Andre Bogus	49982036fc	only lint new_without_default for public items ... This fixes #953.	2016-06-01 23:35:14 +02:00
Andre Bogus	2811dd64ec	added missing PatKind::Path + tests	2016-05-31 23:35:42 +02:00
Andre Bogus	1b112f96b8	added mcarton's test suggestion	2016-05-31 23:30:49 +02:00
Andre Bogus	ef5db37d9d	additional error in copies test annotated	2016-05-31 23:30:49 +02:00
Oliver Schneider	80e81d351d	add version check to the unit tests	2016-05-30 12:47:04 +02:00
mcarton	42879bcdcb	Add a USELESS_LET_IF_SEQ lint	2016-05-29 12:19:12 +02:00
mcarton	a892a96eeb	Rustup to *1.10.0-nightly (7bddce693 2016-05-27)*	2016-05-28 16:35:38 +02:00
mcarton	97c9930a3f	Fix doc_markdown and multiline quotes and links	2016-05-28 03:22:55 +02:00
mcarton	ac0bb4126c	Improve markdown parsing for the doc lint	2016-05-28 02:08:01 +02:00
Oliver Schneider	bf227f4729	split clippy into lints, plugin and cargo-clippy	2016-05-27 13:03:58 +02:00
Oliver Schneider	5eca09793e	needless_borrow reported on &&T when only &T implements Trait and &Trait is required	2016-05-27 12:12:38 +02:00
llogiq	4c347320be	Merge pull request #955 from Manishearth/regexes ... Regexes	2016-05-26 00:00:07 +02:00
mcarton	51d166f17a	Support RegexBuilder	2016-05-25 21:36:51 +02:00
mcarton	4f11f84dee	Lint binary regexes	2016-05-25 21:14:14 +02:00
Oliver Schneider	bb69e60b30	fix no_effect lint	2016-05-25 18:51:35 +02:00
Andre Bogus	9cfc42275d	Split new_without_default and new_without_default_derive. ... This is still very slow, because we do a trait lookup for each field. Perhaps storing the visited types in a set to reuse types would improve performance somewhat. Also we may want to pre-decide some known types (e.g. `Vec<T>`, `Option<T>`).	2016-05-24 18:22:18 +02:00
mcarton	ac2e175c1b	Rustup to *1.10.0-nightly (476fe6eef 2016-05-21)*	2016-05-23 16:36:10 +02:00
mcarton	6dd608e53e	Rustup to *1.10.0-nightly (764ef92ae 2016-05-19)*	2016-05-23 16:11:28 +02:00
mcarton	2a5416d662	Rustup to *1.10.0-nightly (9c6904ca1 2016-05-18)*	2016-05-23 16:11:19 +02:00
mcarton	ca05e93c10	Rustup to *1.10.0-nightly (cd6a40017 2016-05-16)*	2016-05-17 23:25:20 +02:00
Martin Carton	4c4b1af03c	Merge pull request #928 from oli-obk/unnecessary_operation ... add a companion lint to `no_effect` with suggestions for partially (in-)effective statements	2016-05-13 17:45:58 +02:00
Oliver Schneider	1e897f1552	add a companion lint to no_effect with suggestions for partially effective statements	2016-05-13 16:43:47 +02:00
llogiq	ecca55cd9f	Merge pull request #927 from oli-obk/german_windows_32bit ... German windows 32bit	2016-05-13 15:41:49 +02:00
Oliver Schneider	d4e11acc1f	make sure compiletest works on windows	2016-05-13 14:16:08 +02:00
Oliver Schneider	c37300d899	ignore the portability test on 32 bit ... it will fail in rustc	2016-05-13 13:45:53 +02:00
Oliver Schneider	86e4216a56	don't check for an exact error message ... the system might change it, especially if the system language is changed	2016-05-13 13:45:25 +02:00
Andreas Fackler	87df6ae8cb	fix typos	2016-05-13 08:50:51 +03:00
Oliver Schneider	610883b7aa	don't suggest closures over constants ... fixes #917	2016-05-12 10:23:06 +02:00
llogiq	8fa68f1e08	Merge pull request #913 from oli-obk/assign_ops ... suggest `a op= b` over `a = a op b`	2016-05-11 23:36:10 +02:00
Oliver Schneider	0bef7b5f74	merge struct similar_name test into the general test file	2016-05-11 17:01:34 +02:00
Oliver Schneider	49e2570b77	don't lint at the use-site of bad struct field bindings if they're shorthand ... fixes #899	2016-05-11 16:44:43 +02:00
Oliver Schneider	c6b4b19a43	suggest a op= b over a = a op b	2016-05-11 15:32:20 +02:00
Oliver Schneider	654154d8e7	cargo clippy subcommand	2016-05-09 16:47:32 +02:00
Oliver Schneider	87faaec7a3	add needless_borrow lint	2016-05-09 13:07:43 +02:00
Manish Goregaokar	d70e7bb5fc	Merge pull request #906 from Manishearth/birkenfeld-master ... Rustup to *rustc 1.10.0-nightly (62e2b2fb7 2016-05-06)*	2016-05-07 21:31:21 -07:00
mcarton	aa10c93e8f	Fix tests	2016-05-08 01:13:05 +02:00
mcarton	3ce60e9731	Don’t warn in titles in DOC_MARKDOWN	2016-05-05 21:49:57 +02:00
mcarton	cc2774df60	Test previously reported false positive	2016-05-05 21:34:42 +02:00
mcarton	e14e1a7148	Fix issue with DOC_MARKDOWN and punctuation	2016-05-05 21:33:46 +02:00
Oliver Schneider	365644e9e6	doc markdown lint's span shows the line instead of the item	2016-05-02 14:36:33 +02:00