Commit graph

6663 commits

Author SHA1 Message Date
Michael Wright
de7749832c Fix bug in implicit_hasher causing crashes
Skip linting if the type is from an external macro. Closes #4260.
2019-07-11 08:47:05 +02:00
Michael Wright
2c90083f62 Avoid rustfmt bug on Windows 2019-07-11 05:21:44 +00:00
uHOOCCOOHu
a9bec0c8a6
Ignore generated fresh lifetimes in elision check. 2019-07-10 01:57:25 +08:00
bors
032ae96856 Auto merge of #4257 - skade:improve-cast-alignment, r=flip1995
Improve cast_ptr_alignment lint

<!--
Thank you for making Clippy better!

We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.

If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `util/dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo fmt`

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

Delete this line and everything above before opening your PR -->

* print alignment in bytes in the lint message
* ignore ZST left-hand types

Fixes #3797 and #4256
changelog:
* `cast_ptr_alignment`: Print alignment in bytes in the lint message
* `cast_ptr_alignment`: Ignore casting from ZST left-hand types
2019-07-09 15:28:26 +00:00
Florian Gilcher
aa72cac87a
Improve cast_ptr_alignment lint
* print alignment in bytes in the lint message
* ignore ZST left-hand types
2019-07-09 17:02:26 +02:00
bors
f0d217026a Auto merge of #4265 - vks:patch-1, r=flip1995
cast_ptr_alignment: Mention legal use under known problems

Refs #2881.

changelog: Mention know problems for cast_ptr_alignment
2019-07-09 13:15:29 +00:00
Vinzent Steinberg
f831b0979e
cast_ptr_alignment: Mention legal use under known problems
Refs #2881.
2019-07-09 14:48:48 +02:00
bors
5f890d44f5 Auto merge of #4264 - flip1995:appveyor, r=flip1995
Disable AppVeyor builds on the master branch

AppVeyor is already checked on every merge of a PR, rechecking it
immediately after on the master branch is not necessary.

Resolves #4263

changelog: none
2019-07-09 11:40:43 +00:00
flip1995
70cffef3b2
Disable AppVeyor builds on the master branch
AppVeyor is already checked on every merge of a PR, rechecking it
immediately after on the master branch is not necessary.
2019-07-09 13:34:22 +02:00
bors
5c921a9f61 Auto merge of #4233 - thiagoarrais:jens1o-fix-1208, r=phansch,flip1995
Avoid reporting string_lit_as_bytes for long strings

Port of @jens1o code ([b76f939][jens1o_commit])

Fixes #1208

[jens1o_commit]: b76f939ac2

<!--
Thank you for making Clippy better!

We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.

If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `cargo fmt`

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

Delete this line and everything above before opening your PR -->

changelog: bugfix for long strings as bytes
2019-07-09 09:48:33 +00:00
bors
1987bf73a8 Auto merge of #4262 - bara86:master, r=flip1995
Use empty block instead of unit type for needless return

fixes #4238

changelog: Use empty block instead of unit type for needless return
2019-07-09 09:10:07 +00:00
Thiago Arrais
7d1a9447ea Extract semantic constant 2019-07-08 17:51:13 -03:00
Bara
2fb73fe037 Use empty block instead of unit type for needless return 2019-07-08 20:45:51 +02:00
Jens Hausdorf
6d1aaac6c3 Avoid reporting string_lit_as_bytes for long strings
Port of @jens1o code ([b76f939][jens1o_commit])

Fixes #1208

[jens1o_commit]: b76f939ac2

Co-authored-by: Thiago Arrais <thiago.arrais@gmail.com>
2019-07-08 13:13:01 -03:00
Jeremy Stucki
c7da4c26fb
Implement flat_map lint 2019-07-08 17:11:54 +02:00
Jeremy Stucki
1fd617d6df
Add test for unnecessary_flat_map 2019-07-08 17:11:52 +02:00
Michael Wright
186b5b2ee2 Add rustfmt nightly to appveyor install 2019-07-08 07:20:11 +02:00
Michael Wright
c0c2a8d9c1
Work around rustup fallback error on Windows 2019-07-07 15:11:38 +02:00
flip1995
3977843ab5
Update documentation to the dev fmt command 2019-07-07 15:11:38 +02:00
Michael Wright
0c00391ed0
Remove format checks from CI scripts again. 2019-07-07 15:11:38 +02:00
Michael Wright
503474a647
Remove format checks from CI script 2019-07-07 15:11:37 +02:00
Michael Wright
aeac3da2c1
Improve fmt test failure message 2019-07-07 15:11:37 +02:00
Michael Wright
11707f3443
Fix crash on dev --limit-stderr-length 2019-07-07 15:11:37 +02:00
Michael Wright
4c771c3478
Add dev fmt subcommand 2019-07-07 15:11:33 +02:00
bors
316da7eb41 Auto merge of #4258 - mikerite:fix-breakage-20190706, r=Manishearth
Fix breakage due to rust-lang/rust#61988

changelog: none
2019-07-07 02:25:07 +00:00
Michael Wright
c72be0f65a rustfmt 2019-07-06 19:43:34 +02:00
Michael Wright
adcc02ed8a Address reviews 2019-07-06 19:35:08 +02:00
Michael Wright
0579c3e0aa Fix breakage due to rust-lang/rust#61988 2019-07-06 19:06:49 +02:00
bors
5d7f6a10ae Auto merge of #4255 - mikerite:fix-warnings-20190706, r=Manishearth
Fix unknown lint warnings

changelog: none
2019-07-06 07:19:20 +00:00
Michael Wright
ce308910fd Fix unknown lint warnings 2019-07-06 09:15:48 +02:00
bors
8744e8ed26 Auto merge of #4254 - lzutao:hiridification-62168, r=Manishearth
Rustup HirIdification

Rustup https://github.com/rust-lang/rust/pull/62168

changelog: none
2019-07-06 06:30:15 +00:00
Lzu Tao
481499101b Remove lint for ONCE_INIT
ONCE_INIT will be deprecated in rust 1.38.0
2019-07-06 12:34:32 +07:00
Lzu Tao
3a76bea04b Update rustfix tests 2019-07-06 12:34:32 +07:00
Lzu Tao
7293defb34 Rename hir::map::local_def_id_from_hir_id to local_def_id 2019-07-06 10:52:51 +07:00
bors
a9f8d3a034 Auto merge of #4252 - mikerite:fix-unused-import-20190704, r=flip1995
Remove unused import

changelog: none
2019-07-04 08:30:18 +00:00
Michael Wright
c702a623a9 Remove unused import 2019-07-04 06:49:31 +02:00
bors
821ad3746c Auto merge of #4251 - matthiaskrgr:rustup_10, r=Manishearth
rustup https://github.com/rust-lang/rust/pull/61995

changelog: none
2019-07-03 20:22:46 +00:00
Matthias Krüger
f18f81d6a6 rustup https://github.com/rust-lang/rust/pull/61995 2019-07-03 18:00:35 +02:00
bors
e490f491e9 Auto merge of #4250 - mikerite:fix-3992, r=phansch
Fix allow bug in `trivially_copy_pass_by_ref`

Closes #3992

changelog: Fix allow bug in `trivially_copy_pass_by_ref`
2019-07-03 07:03:49 +00:00
bors
8dfc21bbac Auto merge of #4249 - matthiaskrgr:license_url, r=phansch
readme: fix urls in the license

The ">" at the end was detected as part of the url and caused it to 404.

changelog: none
2019-07-03 06:36:32 +00:00
Michael Wright
8fa023272f Fix allow bug in trivially_copy_pass_by_ref
Closes #3992
2019-07-03 07:15:21 +02:00
Matthias Krüger
1bd081c600 readme: fix urls in the license 2019-07-02 20:06:18 +02:00
bors
be3d6cfa33 Auto merge of #4246 - mikerite:fix-4244, r=flip1995
Fix `match_same_arms` false negative

Closes #4244

changelog: Fix `match_same_arms` false negative
2019-07-02 07:25:21 +00:00
Michael Wright
c199d9068e Fix match_same_arms false negative
Closes #4244
2019-07-02 08:18:55 +02:00
bors
cc8b2218e6 Auto merge of #4245 - flip1995:ice_4121, r=matthiaskrgr
Test for melted ICE #4121

resolves #4121

r? @matthiaskrgr

changelog: none
2019-07-01 13:58:48 +00:00
flip1995
cd4e593c96
Reenable cargo and rls tests in travis 2019-07-01 15:56:06 +02:00
flip1995
fb56e90e12
Test for melted ICE #4121 2019-07-01 15:53:48 +02:00
bors
47ada9ae07 Auto merge of #4243 - mikerite:fix-4058, r=flip1995
Fix `never_loop` false positive

Closes #4058

changelog: none
2019-07-01 08:10:25 +00:00
bors
ad638a3e42 Auto merge of #4222 - jfrikker:try_err, r=flip1995
Adding try_err lint

changelog: Adds the "try_err" lint, which catches instances of the following: Err(x)?
fixes #4212
2019-07-01 07:41:33 +00:00
Michael Wright
7c98915da9 Fix never_loop false positive
Closes #4058
2019-07-01 07:22:04 +02:00