Samuel Tardieu
e3c73f17ec
option_if_let_else: do not trigger on expressions returning ()
...
Fix #11893
Trigerring on expressions returning `()` uses the arguments of the
`map_or_else()` rewrite only for their side effects. This does lead
to code which is harder to read than the original.
2023-11-29 19:38:02 +01:00
bors
9f5de6626b
Auto merge of #11460 - J-ZhengLi:issue11429, r=Centri3
...
suggest passing function instead of calling it in closure for [`option_if_let_else`]
fixes : #11429
changelog: suggest passing function instead of calling it in closure for [`option_if_let_else`]
2023-10-23 14:37:13 +00:00
Urgau
a86e758228
Adjust clippy tests with new rustc help suggestion for lints
2023-09-04 14:22:02 +02:00
J-ZhengLi
438f934f1c
suggest passing function instead of calling it in [option_if_let_else]
2023-09-04 16:15:45 +08:00
Philipp Krones
cc61aeea54
Merge commit '080b587854a73f2a8cbaecff1884860a78e2ff37' into clippyup
2023-08-24 21:32:12 +02:00
Oli Scherer
3d88fae050
Update ui test crate
2023-08-11 14:02:28 +00:00
Philipp Krones
b0e64a9c09
Merge commit '5436dba826191964ac1d0dab534b7eb6d4c878f6' into clippyup
2023-07-31 23:53:53 +02:00
Max Niederman
008ba2b8bb
new lint: redundant_local
...
fix dogfood lints in `redundant_local`
keep `redundant_local` from running in proc macros
rewrite `redundant_local` as late pass
make redundant_local's `find_binding` more readable
pluralize `redundant_locals` name
add test for `redundant_locals` in macros
test `redundant_locals` in proc macros
use more destructuring in `redundant_locals`
fix: format redundant_locals.rs
ignore needless_pass_by_mut_ref in redundant_locals test
2023-07-21 18:14:03 -07:00
Philipp Krones
cb3ecf7b79
Merge commit '37f4c1725d3fd7e9c3ffd8783246bc5589debc53' into clippyup
2023-07-02 14:59:02 +02:00
y21
cee4c4169c
allow dead code in the test
2023-06-28 17:00:54 +02:00
y21
733a9ea6b9
[option_if_let_else]: suggest .as_ref() if &Option<_>
2023-06-26 20:13:06 +02:00
Philipp Krones
b76b0aeb63
Merge commit '435a8ad86c7a33bd7ffb91c59039943408d3b6aa' into clippyup
2023-05-20 15:39:26 +02:00
Elias Holzmann
d80ca09f5e
Fix: Some suggestions generated by the option_if_let_else lint did not compile
2023-05-05 22:20:04 +02:00
Camille GILLOT
cb3e0fbb59
Evaluate place expression in PlaceMention.
2023-04-21 21:34:59 +00:00
Jason Newcomb
fb41bfa774
Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup
2022-08-31 09:24:45 -04:00
Fabian Wolff
f232402057
Warn about dead tuple struct fields
2022-08-03 12:17:23 +02:00
flip1995
7cd86aa1be
Merge commit '7c21f91b15b7604f818565646b686d90f99d1baf' into clippyup
2022-05-05 15:12:52 +01:00
flip1995
ece0946d7f
Merge commit '23d11428de3e973b34a5090a78d62887f821c90e' into clippyup
2021-12-17 13:40:22 +01:00
flip1995
8fea1d94f3
Merge commit 'a5d597637dcb78dc73f93561ce474f23d4177c35' into clippyup
2021-12-06 12:33:31 +01:00
flip1995
e674d0a599
Merge commit 'e18101137866b79045fee0ef996e696e68c920b4' into clippyup
2021-11-04 12:52:36 +00:00
flip1995
7631fc5d82
Merge commit '91496c2ac6abf6454c413bb23e8becf6b6dc20ea' into clippyup
2021-10-21 13:11:36 +02:00
flip1995
091ed44b50
Merge commit '27afd6ade4bb1123a8bf82001629b69d23d62aff' into clippyup
2021-09-08 16:31:47 +02:00
Esteban Kuber
652b6a771f
update clippy
2021-08-11 14:21:33 +00:00
flip1995
97705b7ea6
Merge commit '9e3cd88718cd1912a515d26dbd9c4019fd5a9577' into clippyup
2021-05-20 13:07:57 +02:00
flip1995
34244190d4
Merge commit 'b20d4c155d2fe3a8391f86dcf9a8c49e17188703' into clippyup
2020-11-05 14:29:48 +01:00
flip1995
d1f9cad102
Merge commit 'e636b88aa180e8cab9e28802aac90adbc984234d' into clippyup
2020-09-24 14:49:22 +02:00
flip1995
6f25adbd5a
Merge commit '2ca58e7dda4a9eb142599638c59dc04d15961175' into clippyup
2020-07-14 14:59:59 +02:00
