flip1995
dd4e471b3f
Properly deprecate panic_params lint
2020-11-20 09:37:47 +01:00
Mara Bos
113c1476c9
Clippy: Match on assert!() expansions without an inner block.
2020-11-19 19:47:25 +01:00
Mara Bos
78faaef8de
Remove the clippy::panic-params lint.
...
Rustc itself now warns for all cases that triggered this lint.
2020-11-19 18:34:40 +01:00
flip1995
e9afdf0740
Improve changlog update documentation
2020-11-19 11:23:59 +01:00
flip1995
a98acdba3e
Fix trailing whitespaces in CHANGELOG file
2020-11-19 11:23:28 +01:00
flip1995
4bf58bd55d
Add CHANGELOG for 1.48
2020-11-19 11:22:59 +01:00
bors
b2aefb8cc3
Auto merge of #6345 - giraffate:follow_up_of_rustup, r=flip1995
...
Revert "Add `rustfmt::skip` as a work around"
This reverts commit 0e803417f9https://github.com/rust-lang/rustfmt/issues/4528 .
changelog: none
2020-11-19 07:40:14 +00:00
Mara Bos
577ebc8cd6
Rollup merge of #79145 - camelid:clippy-fix-panics, r=flip1995
...
Fix handling of panic calls
This should make Clippy more resilient and will unblock #78343 .
This PR is made against rust-lang/rust to avoid the need for a subtree
sync at ``@flip1995's`` suggestion in rust-lang/rust-clippy#6310 .
r? ``@flip1995``
cc ``@m-ou-se``
2020-11-18 15:46:36 +01:00
Takayuki Nakata
6494bd0bac
Revert "Add rustfmt::skip as a work around"
...
This reverts commit 0e803417f9https://github.com/rust-lang/rustfmt/issues/4528 .
2020-11-18 12:36:47 +09:00
bors
8c2e2fd4ec
Auto merge of #6340 - giraffate:improve_doc_for_map_clone, r=Manishearth
...
Improve doc about `map_clone`
A follow up of https://github.com/rust-lang/rust-clippy/issues/6239#issuecomment-719100677 .
`map_clone` works with not only `Iterator` but `Option` although not written in [doc](https://rust-lang.github.io/rust-clippy/master/#map_clone ). Also, an example in the doc shows a usage of dereferencing, but this isn't also written.
changelog: Improve doc about `map_clone`
2020-11-18 02:49:29 +00:00
Takayuki Nakata
0502ac2a87
Improve doc about map_clone
2020-11-18 08:33:25 +09:00
Christiaan Dirkx
5a83968877
Change redundant_pattern_matching to also lint std::task::Poll
...
Suggest using utility methods `is_pending` and `is_ready`.
2020-11-17 23:40:31 +01:00
bors
44d944586c
Auto merge of #6070 - matsujika:unnecessary_wrap, r=flip1995
...
Add new lint `unnecessary_wrap`
Fixes #5969
changelog: New lint [`unnecessary_wraps`]
2020-11-17 20:28:32 +00:00
Camelid
4e4c4fb8aa
Fix handling of panic calls
...
This should make Clippy more resilient and will unblock #78343 .
This PR is made against rust-lang/rust to avoid the need for a subtree
sync at @flip1995's suggestion in rust-lang/rust-clippy#6310 .
2020-11-17 12:16:15 -08:00
bors
5464cbed2f
Auto merge of #6337 - ThibsG:FixIce6332, r=Manishearth
...
Remove `expect()` calls to avoid ICEs in `deref_addrof` lint
Fixes : #6332
changelog: none
2020-11-17 17:55:46 +00:00
bors
a8cafc6196
Auto merge of #6338 - flip1995:rustup, r=flip1995
...
Rustup
r? `@ghost`
changelog: none
2020-11-17 17:10:04 +00:00
flip1995
bf2d31d053
Run cargo dev fmt
2020-11-17 18:08:12 +01:00
Hirochika Matsumoto
c7445d7f2c
Pluralize lint name
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
1f577c0300
Fix embarrassing grammatical error
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
4e5c02e898
Ignore trait implementations
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
4c8d248190
Update stderr files
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
86331a46e4
Update stderr files
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
bf46f78ca7
Fix clippy error
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
532d205218
Skip functions in PartialOrd
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
9d96311d73
Remove wildcard use
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
e998d61fe6
Downgrade applicability to MaybeIncorrect
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
30632fb8e6
Allow this lint on lint tests
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
c7692cf749
Skip function with no exprs contained
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
c5447eb3c1
Make lint skip macros
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
12474c62ff
Add support for methods
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
2f85aa736e
Make lint skip closures
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
8392bc7946
Run cargo dev fmt
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
1bdac87128
Improve lint message
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
eec7f5c111
Update clippy_lints/src/unnecessary_wrap.rs
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
df0d565e59
Move find_all_ret_expressions into utils
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
6b55f3fec9
Add test case
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
cdb72df6f9
Split lint suggestion into two
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
a433d4690e
Run rustfmt
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
c775856727
Call diag.multipart_suggestion instead
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
3ed8902623
Fix typo
...
Co-authored-by: Philipp Krones <hello@philkrones.com>
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
6a62390c86
Optout rustfix test
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
ebdd4e2c72
Refactor code according to reivews
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
0e9d227c04
Add test cases
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
0335b8d6a7
Fix lint example
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
750c118b34
Add suggestion on type signatures
2020-11-18 01:28:37 +09:00
Hirochika Matsumoto
a7ac441760
Add new lint to detect unnecessarily wrapped value
2020-11-18 01:28:37 +09:00
bors
a467c514a3
Auto merge of #78779 - LeSeulArtichaut:ty-visitor-return, r=oli-obk
...
Introduce `TypeVisitor::BreakTy`
Implements MCP rust-lang/compiler-team#383 .
r? `@ghost`
cc `@lcnr` `@oli-obk`
~~Blocked on FCP in rust-lang/compiler-team#383.~~
2020-11-17 12:24:34 +00:00
ThibsG
5b8f2b6c93
Remove expect() calls to avoid ICEs in deref_addrof lint
2020-11-16 23:30:11 +01:00
Bastian Kauschke
3567ea546f
clippy: fold by value
2020-11-16 22:42:09 +01:00
bors
ad4f82997a
Auto merge of #6119 - rsulli55:find_is_some_on_strs, r=flip1995
...
Add a case to `lint_search_is_some` to handle searching strings
Fixes : #6010
This adds a lint which recommends using `contains()` instead of `find()` followed by `is_some()` on strings as suggested in #6010 .
This was added as an additional case to
5af88e3c2d/clippy_lints/src/methods/mod.rs (L3037)
2020-11-16 08:45:10 +00:00
