Ryan1729
04ba07bdc3
add line_count and max_lines to too_many_lines lint message
2020-09-04 19:26:35 -06:00
Jane Lusby
c31d4730b0
update example to be more idiomatic
2020-09-04 15:55:13 -07:00
bors
f253dd06f9
Auto merge of #6007 - ebroto:sync-from-rust, r=ebroto
...
Rustup
r? @ghost
changelog: none
2020-09-04 22:19:01 +00:00
Eduardo Broto
2905fff936
Run cargo dev fmt
2020-09-04 23:30:55 +02:00
Eduardo Broto
7bcf40a13d
Fix fallout from rustup
2020-09-04 23:30:06 +02:00
Eduardo Broto
23646e6583
Merge remote-tracking branch 'upstream/master' into sync-from-rust
2020-09-04 23:27:01 +02:00
LeSeulArtichaut
4286d9c87a
ty.flags -> ty.flags()
2020-09-04 18:28:20 +02:00
LeSeulArtichaut
28f9b84042
ty.kind -> ty.kind() in rustdoc and clippy
2020-09-04 18:27:33 +02:00
bors
b9e35dfa41
Auto merge of #6004 - mikerite:default-trait-access-20200904, r=ebroto
...
Simplify `clippy::default_trait_access`
Remove repeated matching on the same QPath.
changelog: none
2020-09-04 06:31:04 +00:00
Michael Wright
cf1cc7c449
Simplify clippy::default_trait_access
...
Remove repeated matching on the same QPath.
2020-09-04 05:15:31 +02:00
bors
8829214764
Auto merge of #5994 - taiki-e:useless_attribute, r=phansch
...
useless_attribute: Permit wildcard_imports and enum_glob_use
Fixes #5918
changelog: `useless_attribute`: Permit `wildcard_imports` and `enum_glob_use` on `use` items
2020-09-03 05:33:03 +00:00
bors
a31216b703
Auto merge of #6003 - mikerite:fix-tests-20200903, r=phansch
...
Update ui stderr with improved rustc output
Related rust pull request: rust-lang/rust#76160
changelog: none
2020-09-03 05:12:26 +00:00
Michael Wright
93ce686b5d
Update ui stderr with improved rustc output
...
Related rust pull request: rust-lang/rust#76160
2020-09-03 04:58:14 +02:00
Ricky
2387f68e43
Removed map_err suggestion in lint, and updated lint documentation example
2020-09-02 19:21:34 -04:00
Tim Nielens
b220ddf146
unit-arg - pr remarks
2020-09-02 23:30:40 +02:00
bors
365b13c0e7
Auto merge of #76160 - scileo:format-recovery, r=petrochenkov
...
Improve recovery on malformed format call
The token following a format expression should be a comma. However, when it is replaced with a similar token (such as a dot), then the corresponding error is emitted, but the token is treated as a comma, and the parsing step continues.
r? @petrochenkov
2020-09-02 19:29:27 +00:00
Tim Nielens
b1f0e019fe
Merge branch 'master' into unit-arg
2020-09-02 19:39:54 +02:00
bors
7f27b12288
Auto merge of #5996 - Koxiaet:master, r=ebroto
...
Allow GraphQL in docs without backticks
changelog: Allow "GraphQL" in [`doc_markdown`] without backticks.
2020-09-02 12:24:31 +00:00
Koxiaet
22c9940613
Add tests for allowed non-backticked identifiers in doc
2020-09-02 12:51:44 +01:00
Sasha
246f1f8a8e
Improve recovery on malformed format call
...
If a comma in a format call is replaced with a similar token, then we
emit an error and continue parsing, instead of stopping at this point.
2020-09-02 13:18:19 +02:00
bors
a62bab2076
Auto merge of #6000 - ebroto:sync-from-rust, r=ebroto
...
Sync from rust
r? @ghost
changelog: none
2020-09-02 07:56:44 +00:00
Eduardo Broto
a5754a1fad
Run cargo dev fmt
2020-09-02 08:57:00 +02:00
Eduardo Broto
da86067775
Merge remote-tracking branch 'upstream/master' into sync-from-rust
2020-09-02 08:53:29 +02:00
bors
48248af630
Auto merge of #5999 - rail-rain:fix_fp_transmute_ptr_to_ptr_in_consts, r=ebroto
...
Fix a fp in `transmute_ptr_to_ptr`
fixes #5959
changelog: Fix a false positive in `transmute_ptr_to_ptr` that the lint fires when `transmute` is used to cast a reference in const contexts although dereferencing raw pointers in consts is unstable.
2020-09-01 22:28:55 +00:00
Ricky
337729137b
Ran cargo dev update_lints
2020-09-01 17:05:40 -04:00
Ricky
202a80c927
Added tests for map_err, ignored map_err lint on drop_ref tests
2020-09-01 16:59:37 -04:00
Ricky
e49a29933b
Working map_err_ignore lint
2020-09-01 16:26:59 -04:00
bors
67e18c2d5c
Auto merge of #5993 - taiki-e:default_trait_access, r=phansch
...
default_trait_access: Fix wrong suggestion
https://github.com/rust-lang/rust-clippy/issues/5975#issuecomment-683751131
> I think the underlying problem is clippy suggests code with complete parameters, not clippy triggers this lint even for complex types. AFAIK, If code compiles with `Default::default`, it doesn't need to specify any parameters, as type inference is working. (So, in this case, `default_trait_access` should suggest `RefCell::default`.)
Fixes #5975 Fixes #5990
changelog: `default_trait_access`: fixed wrong suggestion
2020-09-01 15:05:16 +00:00
Takayuki Nakata
aa7ffa5257
Fix FP in same_item_push
...
Don't emit a lint when the pushed item doesn't have Clone trait
2020-09-01 22:39:09 +09:00
Koxiaet
b30422114e
Allow GraphQL in doc without backticks
2020-09-01 14:05:19 +01:00
Taiki Endo
2e4b4cebbb
useless_attribute: Permit wildcard_imports and enum_glob_use
2020-09-01 12:09:32 +09:00
rail
afeb917fca
Fix a fp in transmute_ptr_to_ptr
...
Avoid firing the lint when `transmute` in const contexts
as dereferencing raw pointers in consts is unstable. cc #5959
2020-09-01 11:51:32 +12:00
Vali Schneider
f9fcbbea03
fixed bug
2020-08-31 13:32:05 -07:00
bors
066f105d67
Auto merge of #5992 - giraffate:fix_wrong_seggestion_in_collapsible_if, r=yaahc
...
Fix the wrong suggestion when using macro in `collapsible_if`
Fix #5962
changelog: Fix the wrong suggestion when using macro in `collapsible_if`
2020-08-31 19:41:13 +00:00
bors
8334a58c2f
Auto merge of #5909 - khuey:async_yields_async, r=yaahc
...
Add a lint for an async block/closure that yields a type that is itself awaitable.
This catches bugs of the form
tokio::spawn(async move {
let f = some_async_thing();
f // Oh no I forgot to await f so that work will never complete.
});
See the two XXXkhuey comments and the unfixed `_l` structure for things that need more thought.
*Please keep the line below*
changelog: none
2020-08-31 19:20:30 +00:00
Taiki Endo
8b0aa6a00b
default_trait_access: Fix wrong suggestion
2020-09-01 00:31:53 +09:00
Takayuki Nakata
001f9e45f2
Fix the wrong suggestion when using macro in collapsible_if
2020-09-01 00:05:53 +09:00
Hirochika Matsumoto
451ef78803
Use match_def_path instead of match_qpath
2020-08-31 22:40:47 +09:00
bors
001c1c51d2
Auto merge of #5984 - ebroto:5693_const_assoc_fn, r=flip1995
...
or_fn_call: ignore nullary associated const fns
The fix in #5889 was missing associated functions.
changelog: Ignore also `const fn` methods in [`or_fun_call`]
Fixes #5693
2020-08-31 10:43:58 +00:00
Aaron Hill
fdc48fb90c
Fix clippy
2020-08-30 19:17:17 -04:00
bors
ab64d47c03
Auto merge of #5988 - camelid:patch-2, r=ebroto
...
Syntax-highlight `single_char_push_str` lint
It wasn't being syntax highlighted in the online lint index:
changelog: none
2020-08-30 20:21:00 +00:00
Camelid
17b2ba5ded
Syntax-highlight single_char_push_str lint
2020-08-30 11:29:17 -07:00
Dylan MacKenzie
1c5b0fbe53
Update dataflow analyses to use new interface
2020-08-30 11:15:25 -07:00
Vali Schneider
73a3288282
uncommented fn
2020-08-29 16:22:15 -07:00
Vali Schneider
a424a2c167
changed check_impl_item to check_fn and added a few more test cases
2020-08-29 16:17:53 -07:00
Kyle Huey
04912ca115
Formatting changes requested by ThibsG.
2020-08-29 15:33:54 -07:00
Kyle Huey
c1d2b9376a
Add a test for an async function.
2020-08-29 15:33:54 -07:00
Kyle Huey
4972989b61
Add a lint for an async block/closure that yields a type that is itself awaitable.
...
This catches bugs of the form
tokio::spawn(async move {
let f = some_async_thing();
f // Oh no I forgot to await f so that work will never complete.
});
2020-08-29 15:33:54 -07:00
Hirochika Matsumoto
5b7590f841
Downgrade applicability of create_dir
2020-08-29 14:20:01 +09:00
Eduardo Broto
7a66e6502d
or_fn_call: ignore nullary associated const fns
2020-08-29 01:20:49 +02:00
