Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-21 10:33:27 +00:00
Code Issues Projects Releases Packages Wiki Activity
5116 commits 4 branches 212 tags 142 MiB
Commit graph

5116 commits

This branch
This branch
All branches
Author SHA1 Message Date
Shotaro Yamada
eba44e1c67 question_mark: Suggest Some(opt?) for if-else 2018-12-12 18:13:21 +09:00
Shotaro Yamada
eb54c1a9a0 redundant_field_names: Do not trigger on path with type params 
Fixes #3476
 2018-12-12 17:41:52 +09:00
Shotaro Yamada
28635ff04b question_mark: Lint only early returns 2018-12-12 17:41:51 +09:00
Shotaro Yamada
05d07155b7 question_mark: Fix applicability 2018-12-12 17:40:25 +09:00
bors
921d4da103 Auto merge of #3536 - matthiaskrgr:fix_script, r=oli-obk 
fix typo in script
 2018-12-12 08:27:12 +00:00
Matthias Krüger
7fe39c9c6e fix typo in script 2018-12-12 09:17:43 +01:00
Philipp Hansch
1cfbadb029
Fix doc_markdown off by one issue 2018-12-12 08:21:13 +01:00
Shotaro Yamada
d2e5a8ccf5 Remove obsolete comment 2018-12-12 16:08:06 +09:00
Shotaro Yamada
bcbbb4d09b new_without_default, partialeq_ne_impl: Use span_lint_node 
Fixes #2892, fixes #3199
 2018-12-12 16:08:05 +09:00
bors
f26c39bab7 Auto merge of #3533 - phansch:add_to_doc_valid_idents, r=phansch 
Add 'CamelCase' to doc_valid_idents

Fixes #2395
 2018-12-12 06:46:21 +00:00
Philipp Hansch
194acaf8e7
Update .stderr after rebase 2018-12-12 07:33:23 +01:00
Philipp Hansch
499aad1e04
cargo fmt and remove stabilized feature 2018-12-12 07:31:04 +01:00
Philipp Hansch
752724546a
Make suggestion Applicability::MachineApplicable 2018-12-12 07:31:04 +01:00
Philipp Hansch
9a6216ed05
Address review feedback 
* Fix typo
* Handle None value instead of using `unwrap()`
* `pop()` instead of `x.truncate(x.len() - 1)`
 2018-12-12 07:31:04 +01:00
Philipp Hansch
5f007a88b4
Extract method 2018-12-12 07:31:04 +01:00
Philipp Hansch
7e7a33c726
Check array lengths to prevent OOB access 2018-12-12 07:31:04 +01:00
Philipp Hansch
c4c9d9fc62
Add suggestion for explicit_write lint 2018-12-12 07:31:01 +01:00
bors
e2608fc272 Auto merge of #3529 - matthiaskrgr:rustfmt_tests, r=phansch 
rustfmt tests

also fails CI if tests turn out to not be formatted properly.
 2018-12-12 05:57:31 +00:00
Matthias Krüger
36266b3e6c test reformatting: revert more questionable changes done by rustfmt and add #[rustfmt::skip] 2018-12-11 20:50:55 +01:00
Philipp Hansch
ee2abc36a3
Add 'CamelCase' to doc_valid_idents 2018-12-11 19:37:43 +01:00
bors
82e6dbb07c Auto merge of #3532 - maxencefrenette:fix-contributing-md, r=oli-obk 
Remove dead link in CONTRIBUTING.md

I don't think there was an issue for this, but this is just removing a dead link in CONTRIBUTING.md. The _Linting Clippy with your local changes_ section seems to have been removed without updating the table of contents.

I'm not sure if I should have opened an issue, but it seemed like a trivial fix to me.
 2018-12-11 11:55:59 +00:00
Maxence Frenette
804729cdaa Remove dead link in CONTRIBUTING.md 2018-12-11 05:10:41 -05:00
bors
d6db67793e Auto merge of #3527 - phansch:update_readme2, r=matthiaskrgr 
readme: tool lints are stable now

None
 2018-12-11 06:55:48 +00:00
Michael Wright
c6505aa160 Fix write_with_newline escaping false positive 
Fixes #3514
 2018-12-11 08:44:49 +02:00
Matthias Krüger
743e9e3561 Merge branch 'master' into rustfmt_tests 2018-12-11 01:42:38 +01:00
Matthias Krüger
625ca772b5 tests: fix more cases where rustfmt would have hurt the tests 2018-12-11 01:31:04 +01:00
Matthias Krüger
f1d5194e3d tests: revert some changs and add further rustfmt::skip attributes. 2018-12-11 00:59:59 +01:00
Philipp Hansch
0c93e4cdb2
s/clippy/Clippy in readme 2018-12-10 22:30:16 +01:00
Philipp Hansch
d4da776ea7
Also add note about using -W clippy::lint_group 2018-12-10 22:22:57 +01:00
Philipp Hansch
04e251f623
readme: tool lints are stable now 2018-12-10 22:04:27 +01:00
bors
0fd7fe9a77 Auto merge of #3511 - phansch:remove_allow_doc_markdown, r=phansch 
Remove allow(doc_markdown) in excessive_precision.rs

Closes #3299
 2018-12-10 19:21:25 +00:00
bors
ada0b2b095 Auto merge of #3518 - sinkuu:redundant_clone_tw, r=phansch 
Lint redundant clone of fields

Makes `redundant_clone` warn on unnecessary `foo.field.clone()` sometimes (it can detect an unnecessary clone only if the base of projection, `foo` in this case, is not used at all after that). This is enough for cases like `returns_tuple().0.clone()`.
 2018-12-10 18:55:49 +00:00
Matthias Krüger
0a6e568f07 test formatting: don't format tests/ui/formatting.rs 2018-12-10 15:46:01 +01:00
Matthias Krüger
7bcc2cd9c8 update test stderr 2018-12-10 08:22:07 +01:00
bors
1b93f8d620 Auto merge of #3524 - phansch:update_contributing, r=phansch 
Small updates to CONTRIBUTING.md

None
 2018-12-10 07:06:44 +00:00
Philipp Hansch
740634a154
Document bors/homu 2018-12-10 08:06:07 +01:00
Philipp Hansch
2213904024
Small updates to CONTRIBUTING.md 2018-12-10 08:06:07 +01:00
Shotaro Yamada
e7d18084fb Only check the assignment found at last 
If there are more than one such assignment, the last one may be
the one supplied to `clone` method.
Makes `find_stmt_assigns_to` internally reverses the iterator to make
the intent to "iterate statements backward" clear.
 2018-12-10 15:59:21 +09:00
Shotaro Yamada
fd9f5df36c Add comment and rename 2018-12-10 15:48:34 +09:00
bors
02512c10b2 Auto merge of #3522 - matthiaskrgr:target_dir, r=phansch 
travis: base-tests: share CARGO_TARGET_DIR between check runs of subcrates to avoid unnecessarily recompiling deps.
 2018-12-10 06:01:16 +00:00
Shotaro Yamada
22f396a1c1 Apply redundant_clone on clippy 2018-12-10 08:48:14 +09:00
Shotaro Yamada
109d4b1ab3 Lint redundant clone of projection 2018-12-10 08:48:14 +09:00
Matthias Krüger
435299be30 rustfmt tests 2018-12-09 23:26:16 +01:00
Matthias Krüger
31d3bd92be travis: base-tests: share CARGO_TARGET_DIR between check runs of subcrates to avoid unneccessarily recompiling deps. 2018-12-09 22:47:22 +01:00
Matthias Krüger
1218145bc9 base tests: assert that tests are properly formatted. 2018-12-09 22:43:45 +01:00
bors
1fbcbe4aa1 Auto merge of #3520 - matthiaskrgr:test_rustfmt_skip, r=phansch 
add rustfmt::skip attributes to a couple of tests

part of rustfmt'ing test code
 2018-12-09 18:03:53 +00:00
Matthias Krüger
9b839cd4b5 update line numbers of tests 2018-12-09 17:24:08 +01:00
Matthias Krüger
4583d78156 add rustfmt::skip attributes to some tests 2018-12-09 17:21:49 +01:00
Philipp Hansch
5b01f7a0d6
Merge pull request #3517 from phansch/add_fast_finish 
Add `fast_finish` to travis matrix
 2018-12-09 16:13:37 +01:00
Philipp Hansch
06ded0ea50
Merge pull request #3516 from phansch/remove_run_rustfix_annotation 
Remove a run-rustfix annotation (for now)
 2018-12-09 15:56:29 +01:00