Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-22 02:53:20 +00:00
Code Issues Projects Releases Packages Wiki Activity
6227 commits 4 branches 212 tags 142 MiB
Commit graph

6227 commits

This branch
This branch
All branches
Author SHA1 Message Date
bors
cefddf7843 Auto merge of #4191 - g-bartoszek:redundant-closure-deref, r=flip1995 
redundant_closure_for_method_calls fixes

lint does not trigger when there is a difference in mutability
lint does not trigger when the method belongs to a trait which is not implemebted directly (Deref)

<!--
Thank you for making Clippy better!

We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.

If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `cargo fmt`

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

Delete this line and everything above before opening your PR -->

changelog: none
 2019-06-12 11:56:24 +00:00
Grzegorz
d4ad23bb3f redundant_closure_for_method_calls fixes: 
lint does not trigger when there is a difference in mutability
lint does not trigger when the method belongs to a trait which is not implemebted directly (Deref)
 2019-06-12 13:43:36 +02:00
bors
bd33a97cc4 Auto merge of #4199 - flip1995:implicit_return_docs, r=flip1995 
Fix implicit_return docs

Resolves #4197

changelog: none
 2019-06-12 09:58:24 +00:00
bors
f342ea65d4 Auto merge of #4198 - matthiaskrgr:rustup_8, r=flip1995 
rustup

changelog: none

cc @lzutao

r? @phansch
 2019-06-12 09:29:00 +00:00
flip1995
310c90abb8
Fix implicit_return docs 2019-06-12 10:51:14 +02:00
Matthias Krüger
7c91fb8ded rustup https://github.com/rust-lang/rust/pull/61758/files 2019-06-12 10:28:58 +02:00
Lzu Tao
79e3c7cd55 Remove wrong lifetime from LintContext 2019-06-12 10:28:52 +02:00
bors
ba1702a05f Auto merge of #4190 - projedi:fix-eta, r=flip1995 
Fixing eta with respect to lazy evaluation.

This fixes #4187

changelog: `redundant_closure`: stop linting on expressions returning a function, which is then directly used by the closure
 2019-06-10 19:03:18 +00:00
Alexander Shabalin
41a4ce52dd Workaround for rust-lang/rustfmt#3615 2019-06-10 20:19:29 +03:00
Alexander Shabalin
86bab94631 Fixing eta with respect to lazy evaluation. 2019-06-10 13:58:40 +03:00
bors
c0dbd34ba9 Auto merge of #4188 - matthiaskrgr:rustup_7, r=Manishearth 
rustup https://github.com/rust-lang/rust/pull/61669/

changelog: none
 2019-06-09 18:59:35 +00:00
Matthias Krüger
abfdceca18 travis: disable rls integration test. 2019-06-09 20:53:24 +02:00
Matthias Krüger
7d83e13660 rustup https://github.com/rust-lang/rust/pull/61669/ 2019-06-09 15:21:28 +02:00
bors
01ab9fe653 Auto merge of #4185 - mikerite:outer_expn_info, r=Manishearth 
Add OUTER_EXPN_INFO lint

changelog: none
 2019-06-08 14:00:02 +00:00
Michael Wright
b726b41daf Add OUTER_EXPN_INFO lint 2019-06-08 13:35:04 +02:00
bors
71be6f62fa Auto merge of #4177 - mikerite:compiler_lint_functions_fewer_strings, r=phansch 
Remove `to_string()`s from CompilerLintFunctions

changelog: none
 2019-06-06 10:25:13 +00:00
bors
5be4e71262 Auto merge of #4136 - euclio:println-writeln-suggestions, r=flip1995 
add suggestions for print/write with newline lint

changelog: Add machine-applicable suggestions for `print!`/`write!` with newline lints.
 2019-06-06 08:26:48 +00:00
bors
46d7a0d2b8 Auto merge of #4178 - matthiaskrgr:rustup_6, r=oli-obk 
rustup https://github.com/rust-lang/rust/pull/57428/

changelog: none
 2019-06-06 07:28:10 +00:00
Matthias Krüger
d0ca09883e rustup https://github.com/rust-lang/rust/pull/57428/ 2019-06-06 09:21:19 +02:00
Michael Wright
b36d7a0c61 Remove to_string()s from CompilerLintFunctions 2019-06-06 07:12:12 +02:00
bors
42f96b2558 Auto merge of #4164 - mikerite:fix-4144, r=mikerite 
Fix .map(..).unwrap_or_else(..) bad suggestion

Closes #4144
 2019-06-04 06:28:23 +00:00
mikerite
3b7d6eeb4f
Fix comment grammar 
Co-Authored-By: Philipp Krones <hello@philkrones.com>
 2019-06-04 08:27:31 +02:00
bors
20da8f45c6 Auto merge of #4168 - lzutao:fix-script, r=flip1995 
Do not install rustup-toolchain if it is in PATH

I find it quiet annoying because I manually build `rustup-toolchain-install-master`
and install it in `PATH` other than in `~/.cargo/bin`. So everytime I run the script,
it always reinstall `rustup-toolchain-install-master` for me.

changelog: none
 2019-06-03 09:39:23 +00:00
bors
28a39e9741 Auto merge of #4165 - BO41:needless_range_loop, r=phansch 
Add example to needless_range_loop

adds a "could be written as" example

btw, is it correct that the lint triggers even if the index is used not just for getting the values by index?
So that I have to add `.iter().enumerate()` to still get an index?

changelog: none
 2019-06-03 08:28:15 +00:00
bors
4b45bd94fe Auto merge of #4163 - lzutao:doc-fix-foo-example, r=phansch 
doc: Remove `pub` from trait definition in foo lint example

changelog: none
 2019-06-03 07:59:30 +00:00
bors
5ab867c7f9 Auto merge of #4169 - lzutao:bump-cargo_metadata, r=Manishearth 
Bump cargo metadata

Sorry, I forgot to bump `cargo_metadata` in sub-crates.

changelog: none

r? @matthiaskrgr
 2019-06-03 02:39:06 +00:00
Lzu Tao
352f183429 Bump clap in clippy_dev 2019-06-03 09:36:23 +07:00
Lzu Tao
3fb497c8c8 Do not install rustup-toolchain if it is in PATH 2019-06-03 09:23:15 +07:00
Lzu Tao
6c9ee51ecc Bump cargo_metadata of clippy_lints 2019-06-03 09:13:33 +07:00
BO41
dd007e4477 Change from ignore to rust 2019-06-02 20:06:50 +02:00
bors
b0ec33f661 Auto merge of #4166 - mati865:rustup, r=Manishearth 
Rustup for https://github.com/rust-lang/rust/pull/61276

changelog: none
 2019-06-02 17:07:33 +00:00
Mateusz Mikuła
a3ace5c3ca Cargo fmt 2019-06-02 18:58:11 +02:00
Mateusz Mikuła
9fefe36737 Rustup for https://github.com/rust-lang/rust/pull/61276 2019-06-02 18:30:40 +02:00
BO41
bd8f289247 Add example to needless_range_loop 2019-06-02 15:28:32 +02:00
bors
f5d6804911 Auto merge of #4160 - lzutao:bump-cargo_metadata, r=matthiaskrgr 
Bump cargo_metadata to 0.8.0

changelog: none
 2019-06-02 13:11:34 +00:00
bors
647cc4026f Auto merge of #4159 - lzutao:into-outer_expn_info, r=matthiaskrgr 
Make use of new `outer_expn_info()` function

Find by simple command: `git grep -w expn_info`.

changelog: none

Closes #4151
 2019-06-02 10:01:50 +00:00
Michael Wright
98585a0324 Fix .map(..).unwrap_or_else(..) bad suggestion 
Closes #4144
 2019-06-02 08:50:20 +02:00
Lzu Tao
7f8e7c0772 doc: Remove pub from trait definition in foo lint example 2019-06-01 19:51:49 +07:00
Lzu Tao
d6f580d62b Bump cargo_metadata to 0.8.0 2019-06-01 16:49:10 +07:00
Lzu Tao
f67c3e4b2a Make use of new outer_expn_info() function 2019-06-01 16:25:51 +07:00
bors
f3087c37bf Auto merge of #4158 - phansch:rustup_tests, r=Manishearth 
Fix ellipsis_inclusive_range_patterns lint warnings

Changed from `allow` to `warn` in https://github.com/rust-lang/rust/pull/61342

changelog: none
 2019-06-01 05:57:58 +00:00
Philipp Hansch
6feef17071
Fix ellipsis_inclusive_range_patterns lint warnings 
Changed from `allow` to `warn` in https://github.com/rust-lang/rust/pull/61342
 2019-06-01 07:54:47 +02:00
Andy Russell
2d0c797da6
add suggestions for print/write with newline lint 2019-05-30 13:46:04 -04:00
bors
b1762e3e4a Auto merge of #4157 - phansch:update_pulldown_cmark2, r=matthiaskrgr 
Update pulldown_cmark to 0.5.2

Includes various parsing fixes. Most notably [this PR][pr]

changelog: none

[pr]: https://github.com/raphlinus/pulldown-cmark/pull/325
 2019-05-30 12:07:48 +00:00
bors
0ab3f1762e Auto merge of #4113 - rust-lang:author, r=flip1995 
Fix `Block`  dump in author lint

changelog: The `#[clippy::author]` attribute now emits correct pattern code for block expressions
 2019-05-30 10:34:56 +00:00
Philipp Hansch
a34991228a
Update pulldown_cmark to 0.5.2 
Includes various parsing fixes. Most notably [this PR][pr]

[pr]: https://github.com/raphlinus/pulldown-cmark/pull/325
 2019-05-30 12:26:22 +02:00
bors
d2f5122815 Auto merge of #4155 - phansch:rustup_trait_obj, r=oli-obk 
Rustup to https://github.com/rust-lang/rust/pull/61203

See https://github.com/rust-lang/rust/pull/61203

Migrates all trait objects to use `dyn` in our ui tests

changelog: none
 2019-05-30 07:29:28 +00:00
Philipp Hansch
2c72026fcb
Rustup to https://github.com/rust-lang/rust/pull/61203 
Migrates all trait objects to use `dyn`
 2019-05-30 08:31:09 +02:00
bors
018fa30c56 Auto merge of #4153 - matthiaskrgr:rustup_5, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/60928

changelog: none
 2019-05-29 20:01:57 +00:00
Matthias Krüger
22e77dfa98 rustup https://github.com/rust-lang/rust/pull/60928 2019-05-29 00:41:34 +02:00