Commit graph

3438 commits

Author SHA1 Message Date
sinkuu
159cc8413c Add implicit_hasher lint (#2101) 2017-10-11 12:10:26 +09:00
Cameron Steffen
752900ca3b change expect message 2017-10-10 16:30:10 -05:00
Oliver Schneider
2b491d5bb3 Merge pull request #2128 from lukasstevens/master
Add lint for opt.map_or(None, f)
2017-10-10 16:15:03 +02:00
Lukas Stevens
4438c41d14 Make suggested changes
- Fix copy-paste error
- Check for opt.map_or argument after ensuring that opt is an Option
- Use span_lint_and_then and span_suggestion
- Update reference
2017-10-10 15:35:24 +02:00
Lukas Stevens
c0fac7cf56 Remove unnecessary borrow 2017-10-10 14:04:41 +02:00
Lukas Stevens
eb53cca768 Add lint for opt.map_or(None, f)
Change to Warn and add multiline support

Fix typo

Update reference
2017-10-10 13:37:45 +02:00
Oliver Schneider
af6e2a1e4e
Don't lint accidental "prefixes" on enum variants 2017-10-10 12:37:59 +02:00
Oliver Schneider
b62b1b68ed Merge pull request #2126 from camsteffen/split-tests
Split some UI tests
2017-10-10 10:06:14 +02:00
Oliver Schneider
408b5220a8 Merge pull request #2122 from sinkuu/local_span
Test failure fix with rustc 1.22.0-nightly (150b625a0 2017-10-08)
2017-10-10 09:39:10 +02:00
Oliver Schneider
28c401f9db Merge pull request #2118 from chyvonomys/relax-needless-loop
relax `needless_range_loop` so that it reports only direct indexing
2017-10-10 09:37:51 +02:00
Cameron Steffen
35882b09da move get_unwrap tests 2017-10-10 00:14:47 -05:00
Cameron Steffen
90b428e88d move ok_expect tests 2017-10-10 00:03:39 -05:00
Cameron Steffen
3356d121df move string_extend tests 2017-10-09 23:57:17 -05:00
Cameron Steffen
6d94167014 move cstring tests 2017-10-09 23:39:45 -05:00
Cameron Steffen
5eeadcfc43 move unnecessary clone tests 2017-10-09 23:38:56 -05:00
Cameron Steffen
18717ae088 move single_char_pattern tests 2017-10-09 23:37:46 -05:00
Cameron Steffen
c1a147f48e move starts_ends_with tests 2017-10-09 23:36:29 -05:00
sinkuu
9ebc30cb0c rustc 1.22.0-nightly (150b625a0 2017-10-08) 2017-10-09 22:49:54 +09:00
Cameron Steffen
9ccb7108b5 fix never_loop 2017-10-08 17:26:39 -05:00
Cameron Steffen
533a50547f remove contains_continue functions 2017-10-08 17:24:32 -05:00
Cameron Steffen
a013568f70 add never_loop tests 2017-10-08 17:03:34 -05:00
Andriy S. from cobalt
1dc0b5c9ec tests for needless_range_loop 2017-10-08 22:37:04 +03:00
Oliver Schneider
73a1dd8e7f Merge pull request #2117 from sinkuu/improve_take_by_value
Improve needless_pass_by_value
2017-10-08 20:14:55 +02:00
Oliver Schneider
18483f89aa Merge pull request #2115 from niklasf/fix-manual-testing-docs
Fix manual testing command in docs
2017-10-08 20:12:26 +02:00
Oliver Schneider
8ce9c244ea Merge pull request #2116 from niklasf/range-plus-minus-one
Lint range_plus_one and range_minus_one (closes #329)
2017-10-08 20:10:23 +02:00
Andriy S. from cobalt
52bd7bb662 relax needless_range_loop so that it reports only direct indexing 2017-10-08 18:34:31 +03:00
Niklas Fiekas
16781a1d89 Add tests for range_plus_one and range_minus_one 2017-10-08 14:15:37 +02:00
sinkuu
8ffec33fd3 Remove intermediate vec 2017-10-08 20:17:04 +09:00
Niklas Fiekas
e9be7530c6 Allow range_plus_one while ..= ranges are unstable 2017-10-08 12:51:00 +02:00
Niklas Fiekas
d8e01237e2 Lint range_plus_one and range_minus_one (closes #329) 2017-10-08 12:51:00 +02:00
Niklas Fiekas
ff25013384 Fix manual testing command in docs 2017-10-08 12:05:30 +02:00
Oliver Schneider
a54baad4fa Merge pull request #2112 from topecongiro/issue-2109
Add a suggestion to replace `map(f).unwrap_or(None)` with `and_then(f)`.
2017-10-08 11:51:15 +02:00
Oliver Schneider
45e5f28bb9 Merge pull request #2067 from jugglerchris/no_effect_with_drop
Fix #2061 (don't suggest removing types which implement Drop)
2017-10-08 11:24:41 +02:00
sinkuu
fdc9a649ff Exclude Fn traits 2017-10-08 18:04:45 +09:00
sinkuu
2be6245179 Duplicate ptr_arg's suggestion logic 2017-10-08 17:51:44 +09:00
sinkuu
bf97cd0338 Reduce false-positives for needless_pass_by_value lint
Excluding a type whose reference also fulfills the trait bound.
2017-10-08 17:25:56 +09:00
Chris Emerson
dcaaab3801 Add a test with a struct containing a String. 2017-10-07 23:32:09 +01:00
Chris Emerson
fcdce8fc1d Merge branch 'master' into no_effect_with_drop 2017-10-07 23:24:36 +01:00
Seiichi Uchida
7f4b583c47 Add multiline case for test against map(f).unwrap_or(None) 2017-10-07 21:14:30 +09:00
Seiichi Uchida
63d6df2101 Add a comment that explains about comparing snippet to raw text 2017-10-07 00:12:30 +09:00
Seiichi Uchida
f5c941a404 Update OPTION_MAP_UNWRAP_OR lint
Add a suggestion to replace `map(f).unwrap_or(None)` with `and_then(f)`.
2017-10-06 22:06:47 +09:00
Oliver Schneider
12a7d1489a Merge pull request #2111 from camsteffen/never_loop
Fix never_loop
2017-10-06 09:10:33 +02:00
Cameron Steffen
d92d5a8811 fix never_loop 2017-10-06 00:04:39 -05:00
Cameron Steffen
d6b35f9839 add never_loop test 2017-10-05 23:46:08 -05:00
Oliver Schneider
346936a7c1 Merge pull request #1513 from sinkuu/identical_conversion
Add identity_conversion lint
2017-10-04 16:06:12 +02:00
sinkuu
1b1b41a5e6 Test if #[allow] works 2017-10-04 22:26:41 +09:00
sinkuu
771d2220d2 Add identity_conversion lint (fixes #1051) 2017-10-04 22:16:16 +09:00
Oliver Schneider
1ab7f36e14 Merge pull request #2103 from pizzaiter/fix-2099
Add some more lints for transmute
2017-10-03 14:45:03 +02:00
PizzaIter
47df717229 Add lints transmute_int_to_* 2017-10-03 14:27:42 +02:00
Oliver Schneider
6f36f214a5 Merge pull request #2065 from rust-lang-nursery/cargo_clippy
Cargo clippy refactoring
2017-10-03 13:28:53 +02:00