64 commits

Author	SHA1	Message	Date
Andre Bogus	b764b2a7aa	extend or_fun_call lint to cover methods	2017-01-15 00:31:20 +01:00
Andre Bogus	2fdb6e4d1a	deprecate extend_from_slice lint	2017-01-14 14:39:41 +01:00
Phil Turnbull	e9f3911899	Suggest &s instead of s.as_str()	2016-11-20 11:19:36 -05:00
Phil Turnbull	73a73638c0	Add lint for string.extend(string.chars()) ... fixes #792	2016-11-19 14:55:47 -05:00
Phil Turnbull	fa78b09fa7	Add lint for string.extend("str".chars()) ... fixes #792	2016-11-19 14:55:02 -05:00
Devon Hollowood	6a14dc7fd4	Remove false positives from get_unwrap lint ... HashMap and BTreeMap don't implement `IndexMut`, so we shouldn't lint for use of `get_mut().unwrap()` for those types.	2016-11-01 17:48:32 -07:00
Devon Hollowood	4e0d182d1d	Clean up get_unwrap code	2016-11-01 17:48:18 -07:00
Devon Hollowood	1187d333ec	Add tests for get_unwrap lint	2016-11-01 01:08:47 -07:00
d-dorazio	62831c6e29	Suggest nth(X) instead of skip(X).next()	2016-10-14 13:38:00 +02:00
mcarton	36d8ca04a1	Add a MISSING_DOCS_IN_PRIVATE_ITEMS lint	2016-08-23 18:28:39 +02:00
Oliver Schneider	7e67f447ce	add suggestions to clone_on_copy ... also: * don't report clone_on_copy when reporting clone_on_double_ref * don't suggest `((x))`	2016-08-08 16:43:45 +02:00
Oliver Schneider	ac6e7b2957	fix tests	2016-06-21 14:46:02 +02:00
Devon Hollowood	12bc90d457	Add tests for extend-iter-nth	2016-06-16 14:39:29 -07:00
Devon Hollowood	74025be59d	Make iter_nth work for Vecs too	2016-06-16 02:04:32 -07:00
Devon Hollowood	555e4555b1	Add tests for slice_iter_nth	2016-06-16 01:29:03 -07:00
mcarton	1f419a2986	Add missing suggestions and help message to tests	2016-06-07 18:33:24 +02:00
Andre Bogus	9cfc42275d	Split new_without_default and new_without_default_derive. ... This is still very slow, because we do a trait lookup for each field. Perhaps storing the visited types in a set to reuse types would improve performance somewhat. Also we may want to pre-decide some known types (e.g. `Vec<T>`, `Option<T>`).	2016-05-24 18:22:18 +02:00
mcarton	ac2e175c1b	Rustup to *1.10.0-nightly (476fe6eef 2016-05-21)*	2016-05-23 16:36:10 +02:00
mcarton	6dd608e53e	Rustup to *1.10.0-nightly (764ef92ae 2016-05-19)*	2016-05-23 16:11:28 +02:00
Oliver Schneider	1e897f1552	add a companion lint to no_effect with suggestions for partially effective statements	2016-05-13 16:43:47 +02:00
Oliver Schneider	610883b7aa	don't suggest closures over constants ... fixes #917	2016-05-12 10:23:06 +02:00
mcarton	de9a80cd10	Check type for SINGLE_CHAR_PATTERN ... It’d be nicer to actually check for `Pattern` bounds but in the meantime this needs to be fixed.	2016-04-20 21:16:59 +02:00
mcarton	1789430a49	Add a TEMPORARY_CSTRING_AS_PTR lint	2016-04-14 17:26:07 +02:00
mcarton	941ec6e4f5	Beautify more docs	2016-03-28 21:24:36 +02:00
Manish Goregaokar	3d9a7d9140	Add test for new() -> Self<'static>	2016-03-27 02:46:37 +05:30
mcarton	15e55f5df5	Deprecates 4 lints ... Namely STR_TO_STRING, STRING_TO_STRING, UNSTABLE_AS_SLICE and UNSTABLE_AS_MUT_SLICE.	2016-03-24 19:56:48 +01:00
Oliver Schneider	06ca1fc0a6	lint on binding-names that are too similar	2016-03-18 14:06:39 +01:00
mcarton	a3031e34f9	Add a BLACKLISTED_NAME lint	2016-03-12 14:51:45 +01:00
mcarton	052f5984e7	Fix types comparison	2016-03-08 17:00:44 +01:00
mcarton	d7129f560d	Lint types with fn new() -> Self and no Default impl	2016-03-08 17:00:37 +01:00
Joshua Holmer	b1e4b496e1	Address @ilogiq's nits	2016-02-15 13:36:10 -05:00
Joshua Holmer	7eea67605a	Lint single-character strings as P: Pattern args ... Fixes #650	2016-02-14 22:40:43 -05:00
mcarton	e8c2aa2997	Lint about new methods not returning Self	2016-02-13 13:03:28 +01:00
mcarton	edc0d19a3f	Add new to WRONG_SELF_CONVENTION	2016-02-13 01:42:46 +01:00
mcarton	7f567ce1d1	Fix false negative with OK_EXPECT	2016-02-13 01:38:55 +01:00
Manish Goregaokar	8f7b8524d3	Test for double-ref lint	2016-02-05 16:04:59 +05:30
mcarton	fab10c07e8	Fix confusing message for STRING_TO_STRING	2016-02-03 13:52:19 +01:00
mcarton	db205c82a4	Add a lint about using clone on Copy types	2016-02-02 22:35:01 +01:00
llogiq	a1ac3125de	fixed and extended tests	2016-01-27 20:13:15 +01:00
llogiq	5d5e50d67e	fixed suggestion for iter case	2016-01-27 14:51:30 +01:00
llogiq	d152e5c683	fixed argument check	2016-01-26 23:51:06 +01:00
llogiq	2d97f916eb	added more test, now works with vecs and iter	2016-01-25 19:46:56 +01:00
llogiq	ed96583677	extend_from_slice lint	2016-01-25 14:02:47 +01:00
mcarton	91ff1db5bc	Add a lint for starts_with	2016-01-20 12:57:14 +01:00
mcarton	5ac6659814	Handle Entry types in OR_FUN_CALL lint	2016-01-20 11:42:25 +01:00
mcarton	8642306f09	Add a test for the OR_FUN_CALL lint	2016-01-18 13:36:58 +01:00
mcarton	b5f65ec699	Improve OR_FUN_CALL to suggest unwrap_or_default	2016-01-18 13:11:07 +01:00
mcarton	c6604bb281	Add a lint to warn about call to .*or(foo(..))	2016-01-16 18:47:45 +01:00
Devon Hollowood	093582c102	Make MethodsPass lint notes clearer	2015-12-30 01:07:40 -08:00
Devon Hollowood	a6bd2d0622	Add SEARCH_IS_SOME lint	2015-12-30 00:38:03 -08:00