9 commits

Author	SHA1	Message	Date
Eric Wu	6bb6dd64d4	fix incorrect suggestion in suboptimal_flops ... There was an error when trying to negate an expression like `x - 1.0`. We used to format it as `-x - 1.0` whereas a proper negation would be `-(x - 1.0)`. Therefore, we add parentheses around the expression when it is a Binary ExprKind. We also add parentheses around multiply and divide expressions, even though this is not strictly necessary.	2022-12-25 16:56:46 -05:00
Elliot Bobrow	15431b36bb	Merge branch 'master' into mul-add-negative	2022-10-02 21:27:57 -07:00
Elliot Bobrow	7747032b77	suboptimal_flops lint for multiply and subtract	2022-10-02 21:00:51 -07:00
TennyZhuang	f2043989ca	ignore the lint on some test files ... Signed-off-by: TennyZhuang <zty0826@gmail.com>	2022-10-02 23:02:13 +08:00
Lukas Lueg	9ffc5a5c8d	Fix more parens for suboptimal_flops suggs	2022-08-29 22:36:11 +02:00
Bruno A. Muciño	be540e6596	Remove powi, "square can be computed more efficiently" ... powi(2) produces exactly the same native code as x * x	2021-05-17 21:59:08 -05:00
Thiago Arrais	6be9491eac	Reclassify powi(2) lint under suboptimal_flops	2020-07-06 13:45:43 -03:00
Thiago Arrais	f62798454c	Lint (x * x + y * y).sqrt() => x.hypot(y)	2020-07-06 13:23:17 -03:00
Thiago Arrais	a6f1af75d7	Lint for x.powi(2) => x * x	2020-07-06 13:23:17 -03:00