Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-23 11:33:19 +00:00
Code Issues Projects Releases Packages Wiki Activity
5900 commits 4 branches 212 tags 144 MiB
Commit graph

5900 commits

This branch
This branch
All branches
Author SHA1 Message Date
Philipp Hansch
2b0dc39f5b
Don't emit useless_attribute lint in external macros 2019-04-10 07:30:59 +02:00
Philipp Hansch
0eb7596fdc
Exclude ice-3891.rs from rustfmt run 
Because the code triggers a rustc parse error which makes rustfmt fail.
 2019-04-09 20:53:38 +02:00
bors
37f5c1ec73 Auto merge of #3925 - phansch:3741, r=flip1995 
Fix ICE in suspicious_else_formatting

Fixes #3741
 2019-04-09 07:13:08 +00:00
Philipp Hansch
0307ff020c
Fix ICE in decimal_literal_representation lint 
Handling the integer parsing properly instead of just unwrapping.

Note that the test is not catching the ICE because plain UI tests
[currently hide ICEs][compiletest_issue]. Once that issue is fixed, this
test would fail properly again.

[compiletest_issue]: https://github.com/laumann/compiletest-rs/issues/169
 2019-04-08 22:16:34 +02:00
Philipp Hansch
3ab8038450
Remove force-host and explain no-prefer-dynamic 2019-04-08 21:23:39 +02:00
Sunjay Varma
5fab7ec002
Mention that -D warnings will deny ALL warnings, not just clippy warnings 2019-04-08 13:51:54 -04:00
bors
949f58440b Auto merge of #3929 - KarboniteKream:single-char-pattern, r=oli-obk 
Escape a single quote in single_char_pattern hint

This PR correctly escapes single quotes in the hint for `single_char_pattern`.
For instance, the hint for `x.split("'")` was `'''`, while it should be `'\''`.
 2019-04-08 14:01:20 +00:00
Klemen Košir
560fd163d6
Escape a single quote in single_char_pattern hint 2019-04-08 21:55:50 +09:00
bors
4fdd113bed Auto merge of #3921 - euclio:single-char-names-multispan, r=flip1995 
use a multispan for MANY_SINGLE_CHAR_NAMES
 2019-04-08 08:42:13 +00:00
bors
e91ba8af85 Auto merge of #3848 - felix91gr:null_transmute, r=flip1995 
Transmuting known null ptr to ref

Working on implementing #628
 2019-04-08 07:20:25 +00:00
bors
42e1cf3763 Auto merge of #3901 - rail-rain:issue_1670, r=flip1995 
Fix `explicit_counter_loop` suggestion

#1670

This code seems to me to work, but I have two question.
* Because range expression desugared in hir, `Sugg::hir` doesn't add parenthesis to range expression.  Which function is better to check range do you think, `check_for_loop_explicit_counter` or `hir_from_snippet`?
* Do you think we need to distinguish between range expression and struct expression that creates `std::ops::Range*`?
 2019-04-08 06:28:15 +00:00
bors
e226f17d52 Auto merge of #3885 - mikerite:clippy_dev_toolchain, r=phansch 
Add rust-toolchain for clippy_dev

AFAIK, `clippy_dev` is supposed to be built on stable. (This is why it's not a `[bin]` inside the root `Cargo.toml`.) This adds a `rust-toolchain` file for easy switching.
 2019-04-08 05:58:34 +00:00
Philipp Hansch
547c5c0667
cargo fmt 2019-04-08 07:56:54 +02:00
bors
0849f73595 Auto merge of #3928 - rust-lang:tmpadd, r=Manishearth 
Re-add tmp feature to compiletest

Got accidentally removed in the rustup
 2019-04-07 21:36:51 +00:00
Manish Goregaokar
c7b78234da Re-add tmp feature to compiletest 
Got accidentally removed in the rustup
 2019-04-07 14:36:03 -07:00
bors
cffb416d89 Auto merge of #3927 - rust-lang:rustup, r=Manishearth 
Revert compiletest hacks, use latest compiletest

The libtest changes have been reverted, see https://github.com/rust-lang/rust/pull/59766,  https://github.com/laumann/compiletest-rs/pull/174
 2019-04-07 20:41:39 +00:00
Manish Goregaokar
4c7c39acbc Remove libtest from deps 2019-04-07 12:39:43 -07:00
Manish Goregaokar
ee69237274 Re-allow clippy::identity_conversion in compiletest 2019-04-07 12:07:20 -07:00
Manish Goregaokar
a8ce9d655a Use latest compiletest-rs 2019-04-07 12:02:22 -07:00
Manish Goregaokar
ba8712c5fd Revert tests/compile-test.rs to 61aa5c957c 2019-04-07 12:01:39 -07:00
Philipp Hansch
60c1bb0546
Fix ICE in suspicious_else_formatting 2019-04-07 11:11:06 +02:00
Matthias Krüger
0e455b0466
Merge pull request #3918 from matthiaskrgr/typos 
NFC: fix typos
 2019-04-07 10:29:51 +02:00
Oliver Scherer
b996fd52ff
Merge pull request #3922 from rust-lang/run-pass 
Add missing `// run-pass` annotations to ICE tests
 2019-04-06 18:33:52 +02:00
Andy Russell
0d50d44ea6
use a multispan for MANY_SINGLE_CHAR_NAMES 2019-04-05 10:07:39 -04:00
Philipp Hansch
b545f1c3bb
Add missing // run-pass annotations to ICE tests 
compiletest UI tests do not fail when encountering panics and ICEs
unless the `// run-pass` flag is used.

(This was forgotten in https://github.com/rust-lang/rust-clippy/pull/3743)
 2019-04-05 07:22:36 +02:00
Michael Wright
63cd54ba11 Remove clippy_dev as dev-dependency 2019-04-05 06:00:27 +02:00
Michael Wright
a9d002c8a5 Merge branch 'master' into clippy_dev_toolchain 2019-04-05 05:59:46 +02:00
Matthias Krüger
920e47ceb5 NFC: fix typos 2019-04-04 11:15:30 +02:00
Philipp Krones
17e04ac751
Merge pull request #3916 from matthiaskrgr/rustup 
rustup https://github.com/rust-lang/rust/pull/59657
 2019-04-03 11:43:26 +02:00
Matthias Krüger
c81e43b92c rustup https://github.com/rust-lang/rust/pull/59657 
commit: 4122d2221ec65232bc211a266d0796a4713e0d39
 2019-04-03 10:48:54 +02:00
Félix Fischer
069957a8ad Add TransmutingNull Lint 
* Late Lint pass, catches:
  * One liner: 0 -> null -> transmute
  * One liner: std:null() -> transmute
  * Const (which resolves to null) -> transmute
* UI Test case for Lint
* Updated test for issue 3849, because now the lint that code generated is in Clippy.
* Expanded `const.rs` miri-based Constant Folding code, to cover
  raw pointers
 2019-04-02 11:39:43 -03:00
Philipp Krones
25a11568fc
Merge pull request #3905 from rust-lang/compiletest 
Hacky rustup
 2019-04-01 22:15:42 +02:00
flip1995
41927796bf
Run rustfmt 2019-04-01 20:37:05 +02:00
flip1995
55f67fc7f4
Set level of identity_conversion FP to warn 2019-04-01 20:37:05 +02:00
Philipp Hansch
b253c564d5
Rustup to https://github.com/rust-lang/rust/pull/58805 2019-04-01 20:37:05 +02:00
Matthias Krüger
414c34c300
rustup 41316f0449025394fdca6606d3fdb3b8f37a9872 2019-04-01 20:37:05 +02:00
Félix Fischer
491f72442e
Updated source to match with recent rustc master toolchain changes 2019-04-01 20:37:05 +02:00
flip1995
bbb7963735
Fix dogfood error of question_mark lint fix 2019-04-01 20:37:05 +02:00
flip1995
6f01ecfefd
Fix question_mark lint+test 2019-04-01 20:37:05 +02:00
rail
2b82c71b55 use span_lint_and_sugg in explicit_counter_loop 2019-03-28 08:51:57 +09:00
Félix Fischer
3cff06a0eb Fix some test failures 2019-03-26 13:57:03 -03:00
Oliver Scherer
d020565ed2 Hacky rustup 2019-03-26 10:55:03 +01:00
Manish Goregaokar
61aa5c957c
Merge pull request #3902 from matthiaskrgr/rustup 
rustup https://github.com/rust-lang/rust/pull/59096/
 2019-03-23 16:53:01 -07:00
Matthias Krüger
b5d82524b4 run cargo fmt 2019-03-23 23:39:58 +01:00
Matthias Krüger
e17dd4efa9 rustup https://github.com/rust-lang/rust/pull/59096/ 2019-03-23 23:37:38 +01:00
rail
9698e41994 Change explicit_counter_loop's message to add parentheses if necessary 2019-03-23 15:36:48 +09:00
rail
bd6c2df066 Change explicit_counter_loop's message to reflect original variable name 2019-03-23 15:30:17 +09:00
bors
c7d4445086 Auto merge of #3888 - phansch:extract_mistyped_literal_suffix_tests_and_rustfix, r=flip1995 
Add rustfix tests for mistyped_literal_suffix lint

This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.

cc #3603, #2038

Based on #3887
 2019-03-19 06:26:01 +00:00
bors
dc825a36f2 Auto merge of #3894 - markcatley:adding_lint_documentation_fixes, r=phansch 
Add implementation for the EarlyLintPass trait into the Adding Lints …

…documentation.

To follow along with the adding lint documentation you need to implement this trait in order to register the lint pass.
 2019-03-19 06:05:41 +00:00
Philipp Hansch
0452704978
cargo fmt 2019-03-19 06:57:41 +01:00