Commit graph

6330 commits

Author SHA1 Message Date
Lzu Tao
7293defb34 Rename hir::map::local_def_id_from_hir_id to local_def_id 2019-07-06 10:52:51 +07:00
bors
a9f8d3a034 Auto merge of #4252 - mikerite:fix-unused-import-20190704, r=flip1995
Remove unused import

changelog: none
2019-07-04 08:30:18 +00:00
Michael Wright
c702a623a9 Remove unused import 2019-07-04 06:49:31 +02:00
bors
821ad3746c Auto merge of #4251 - matthiaskrgr:rustup_10, r=Manishearth
rustup https://github.com/rust-lang/rust/pull/61995

changelog: none
2019-07-03 20:22:46 +00:00
Matthias Krüger
f18f81d6a6 rustup https://github.com/rust-lang/rust/pull/61995 2019-07-03 18:00:35 +02:00
bors
e490f491e9 Auto merge of #4250 - mikerite:fix-3992, r=phansch
Fix allow bug in `trivially_copy_pass_by_ref`

Closes #3992

changelog: Fix allow bug in `trivially_copy_pass_by_ref`
2019-07-03 07:03:49 +00:00
bors
8dfc21bbac Auto merge of #4249 - matthiaskrgr:license_url, r=phansch
readme: fix urls in the license

The ">" at the end was detected as part of the url and caused it to 404.

changelog: none
2019-07-03 06:36:32 +00:00
Michael Wright
8fa023272f Fix allow bug in trivially_copy_pass_by_ref
Closes #3992
2019-07-03 07:15:21 +02:00
Matthias Krüger
1bd081c600 readme: fix urls in the license 2019-07-02 20:06:18 +02:00
bors
be3d6cfa33 Auto merge of #4246 - mikerite:fix-4244, r=flip1995
Fix `match_same_arms` false negative

Closes #4244

changelog: Fix `match_same_arms` false negative
2019-07-02 07:25:21 +00:00
Michael Wright
c199d9068e Fix match_same_arms false negative
Closes #4244
2019-07-02 08:18:55 +02:00
bors
cc8b2218e6 Auto merge of #4245 - flip1995:ice_4121, r=matthiaskrgr
Test for melted ICE #4121

resolves #4121

r? @matthiaskrgr

changelog: none
2019-07-01 13:58:48 +00:00
flip1995
cd4e593c96
Reenable cargo and rls tests in travis 2019-07-01 15:56:06 +02:00
flip1995
fb56e90e12
Test for melted ICE #4121 2019-07-01 15:53:48 +02:00
bors
47ada9ae07 Auto merge of #4243 - mikerite:fix-4058, r=flip1995
Fix `never_loop` false positive

Closes #4058

changelog: none
2019-07-01 08:10:25 +00:00
bors
ad638a3e42 Auto merge of #4222 - jfrikker:try_err, r=flip1995
Adding try_err lint

changelog: Adds the "try_err" lint, which catches instances of the following: Err(x)?
fixes #4212
2019-07-01 07:41:33 +00:00
Michael Wright
7c98915da9 Fix never_loop false positive
Closes #4058
2019-07-01 07:22:04 +02:00
Joe Frikker
c96bb2c303 Running rustfmt on test 2019-06-30 18:28:12 -04:00
bors
58e6431f1a Auto merge of #4240 - alex:uninit-intrinsic-prep, r=Manishearth
Removed use of intrinsics::uninit from tests.

This is in preperation for https://github.com/rust-lang/rust/pull/62150

Also allows deprecations in preperations for intrinsics::init being deprecated, which is a planned future step.

changelog: none
2019-06-30 13:14:38 +00:00
Alex Gaynor
fffdbc0e8f Removed use of intrinsics::uninit from tests.
This is in preperation for https://github.com/rust-lang/rust/pull/62150

Also allows deprecations in preperations for intrinsics::init being deprecated, which is a planned future step.
2019-06-29 09:34:42 -04:00
bors
e3cb40e4f7 Auto merge of #4235 - Manishearth:rustup, r=Manishearth
Rustup to 5f9c0448dde167128d668da4555879f64e56af1d

Fixes fallout from https://github.com/rust-lang/rust/pull/62091/files

changelog: none
2019-06-25 22:35:35 +00:00
Manish Goregaokar
e3619a6507 fmt 2019-06-25 14:41:10 -07:00
Manish Goregaokar
4a6914bb8c Remove a hir_to_node_id 2019-06-25 14:34:47 -07:00
Manish Goregaokar
d744dcdaaf find_by_hir_id -> find 2019-06-25 14:34:07 -07:00
Manish Goregaokar
c47a7e4ef2 get_parent_node_by_hir_id -> get_parent_node 2019-06-25 14:33:51 -07:00
Joe Frikker
8880677b4f Making try_err machine applicable 2019-06-24 21:28:46 -04:00
bors
f0edfab44c Auto merge of #4230 - flip1995:unsugar_if, r=Manishearth
Replace `unsugar_if` function with `is_if` function

cc https://github.com/rust-lang/rust-clippy/pull/4123#discussion_r296581719

changelog: none

r? @Manishearth
2019-06-24 16:27:01 +00:00
flip1995
662037bcf2
Simplify unsugar_if to just an if expr check 2019-06-24 09:51:53 +02:00
flip1995
c192c07930
Remove ast:: prefix from types 2019-06-24 09:40:11 +02:00
bors
8c80b65f10 Auto merge of #4123 - Centril:rustup-let-chains-ast, r=Manishearth
Fix fallout from rust-lang/rust PR 60861

Fixes incoming breakage for unlanded https://github.com/rust-lang/rust/pull/60861.

Tests are passing locally; the Rust PR now needs to land first.

@Manishearth also says we'll want to split out to a `collapsible_if_let` once we have let-chains working in Rust nightly or something.
2019-06-24 05:21:52 +00:00
Mazdak Farrokhzad
46a0e54361 Put 'if let' back into comment. 2019-06-24 07:20:52 +02:00
Mazdak Farrokhzad
0373b007da Pacify rustfmt. 2019-06-24 04:54:23 +02:00
Mazdak Farrokhzad
4434bfac01 Fix dogfood test failures. 2019-06-24 04:00:05 +02:00
Joe Frikker
1e6c6976dd PR comments 2019-06-23 18:02:13 -04:00
Andy Russell
4ce100beb2
don't strip blank lines in lint documentation 2019-06-23 16:21:43 -04:00
Mazdak Farrokhzad
6ef8b57e34 Account for let_chains in collapsible_if ui test cases. 2019-06-23 17:24:45 +02:00
Mazdak Farrokhzad
b918594369 Fix fallout from rust-lang/rust PR 60861. 2019-06-23 17:24:45 +02:00
Joe Frikker
60a80849ce Adding try_err lint 2019-06-22 16:37:05 -04:00
bors
c5d1ecd474 Auto merge of #4220 - d-dorazio:4182-needless-return-void-functions, r=flip1995
make needless_return work with void functions

fixes https://github.com/rust-lang/rust-clippy/issues/4181.

changelog: make needless_return work with void functions.

I don't think the failure is related to my changes, but I'm not sure 🤔
2019-06-22 09:38:53 +00:00
bors
6f82ea53c5 Auto merge of #4227 - lzutao:node-pruning, r=flip1995
Fix fallout cause NodeId pruning

Rustup rust-lang/rust#61984

changelog: none
2019-06-22 08:42:09 +00:00
Lzu Tao
6aea41e050 Fix fallout cause NodeId pruning 2019-06-22 13:41:16 +07:00
Daniele D'Orazio
316a9f2711 cargo fmt 2019-06-21 16:47:34 +02:00
bors
9cae8aa9a9 Auto merge of #4225 - jeremystucki:refactoring, r=flip1995
Remove needless lifetimes

changelog: none
2019-06-21 13:47:13 +00:00
Daniele D'Orazio
66dbc02b05 more idiomatic code 2019-06-21 14:46:34 +02:00
bors
9617f970ac Auto merge of #3919 - matthiaskrgr:readme_3, r=flip1995
readme: update

Remove the crates.io badge from the readme.
Installing clippy via crates.io is deprecated and rustup should be used instead, thus we should not promote crates.io here.

Don't have clippy::correctness" lint category in bold letters, I think it looks a little off.
2019-06-21 12:43:15 +00:00
flip1995
6dc8084788
Remove another unnecessary lifetime 2019-06-21 14:41:52 +02:00
Jeremy Stucki
746fbad98a
Remove needless lifetimes 2019-06-21 14:41:19 +02:00
Daniele D'Orazio
e1a78ae528 update tests and fix lints in clippy 2019-06-21 14:17:59 +02:00
Daniele D'Orazio
6396a7a425 make needless_return work with void functions 2019-06-21 13:58:22 +02:00
bors
5a11ed7b92 Auto merge of #4223 - mikerite:fix-breakage-2019-06-21, r=flip1995
Fix breakage due to rust-lang/rust#61968

<!--
Thank you for making Clippy better!

We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.

If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `cargo fmt`

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

Delete this line and everything above before opening your PR -->

changelog: none
2019-06-21 10:33:53 +00:00