Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-27 15:11:30 +00:00
Code Issues Projects Releases Packages Wiki Activity
3135 commits 4 branches 211 tags 112 MiB
Commit graph

1100 commits

Author SHA1 Message Date
Luis de Bethencourt
747a20153c clean tests/ui/neg_multiply.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
cd55b87874 clean tests/ui/needless_return.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
b4a20aedf9 clean tests/ui/needless_bool.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
ac00b1d70b clean tests/ui/mut_mut.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
9ece185c45 clean tests/ui/methods.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
409eea2b51 clean tests/ui/mem_forget.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
86d5ffae8a clean tests/ui/matches.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
a5e66fa34b clean tests/ui/literals.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
cf9370f670 clean tests/ui/lifetimes.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
2df0161973 clean tests/ui/let_if_seq.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
7b2766af4a clean tests/ui/len_zero.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
3ca67910a8 clean tests/ui/if_let_redundant_pattern_matching.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
2389f9e94c clean tests/ui/functions.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
df5d12a3ec clean tests/ui/formatting.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
6d2329f2cb clean tests/ui/for_loop.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
faca269488 clean tests/ui/float.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
bc9cdf1d64 clean tests/ui/eval_order_dependence.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
fbc6b26592 clean tests/ui/eta.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
8fc00c57b6 clean tests/ui/eq_op.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
5013f49195 clean tests/ui/entry.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
856d64d43e clean tests/ui/doc.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
e3aa074033 clean tests/ui/derive.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
e2cce4809b clean tests/ui/copies.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
5e45d09c4f clean tests/ui/conf_french_blacklisted_name.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
aa3d361bec clean tests/ui/collapsible_if.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
ed713d67d6 clean tests/ui/cmp_owned.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
17284bacee clean tests/ui/cast.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
34e4c0f9e3 clean tests/ui/booleans.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
5865c2aacd clean tests/ui/bool_comparison.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
cc923b5d0e clean tests/ui/block_in_if_condition.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
0c9d9d9f6c clean tests/ui/blacklisted_name.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
ac4ce0b2fe clean tests/ui/assign_ops2 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Luis de Bethencourt
e18a250139 clean tests/ui/absurd-extreme-comparisons.rs 
Cleaning the empty lines for clarity.
 2017-05-11 16:22:32 +01:00
Oliver Schneider
81b35d197b Fixes #1735 2017-05-11 16:32:06 +02:00
Oliver Schneider
fb6895836f Address PR comments 2017-05-11 15:36:27 +02:00
Oliver Schneider
2cd3366817 Fixes #443 2017-05-10 13:42:19 +02:00
Oliver Schneider
3b3e47f451 Merge pull request #1738 from Manishearth/serde 
Update serde to 1.0
 2017-05-10 08:55:36 +02:00
Oliver Schneider
dee53fa1e2 Merge pull request #1728 from Manishearth/inspector 
Print type adjustments in the inspector
 2017-05-09 15:26:01 +02:00
Oliver Schneider
31b2bf4ab9 Update our config reading to serde 1.0 2017-05-09 15:23:38 +02:00
Oliver Schneider
8225c23a33 Update to serde 1.0 2017-05-09 15:23:10 +02:00
Luis de Bethencourt
f1434d2023 clean tests/ui/assign_ops.rs 
When all //~ were removed from tests, these were replaced with empty
lines to leave the numbers in the expected stderr untouched.

Cleaning the empty lines for clarity.
 2017-05-08 14:05:02 +01:00
Oliver Schneider
866239b1a8 Add a test showing a false positive on needless_borrow 2017-05-05 14:26:14 +02:00
Oliver Schneider
a6c8464dde Update to rustc 1.19.0-nightly (6a5fc9eec 2017-05-02) 2017-05-03 12:51:47 +02:00
Oliver Schneider
e3084cc085 Fix #1698 (ICE regression in clippy's const eval) 2017-04-28 18:10:10 +02:00
Oliver Schneider
96b25cdaf2 Add regression tests for op_ref 2017-04-28 17:07:39 +02:00
Oliver Schneider
7aa42073f2 Fix op_ref false positives 2017-04-28 17:03:47 +02:00
Oliver Schneider
5381c4fcf6 Update ui tests to new rustc range printing 2017-04-25 10:57:44 +02:00
Oliver Schneider
68369e5d37
Merge remote-tracking branch 'origin/master' into yati_master 2017-04-25 10:31:40 +02:00
mcarton
b20a6a773c
Update tests to new format of multiline errors 2017-04-23 15:39:41 +02:00
Yati Sagade
cac15d24f9 needless_continue: Remove indentation of suggestion code. 
As per a suggestion by Oliver on the PR thread, maintaining indentation
in the suggested code is futile because of the changes in the compiler
and the messiness of real-world code. rustfmt will do the indentation if
required, so we don't need to do it.
 2017-04-13 21:48:52 +02:00
Oliver Schneider
5842463562 Run rustfmt 2017-04-12 11:06:32 +02:00
Oliver Schneider
3534149035 Update ui tests 2017-04-11 16:19:27 +02:00
Oliver Schneider
679e98530a
Merge remote-tracking branch 'origin/master' into yati 2017-04-11 16:16:10 +02:00
Oliver Schneider
21d8fbd082 Don't lint for lifetime bounds required by traits 2017-04-11 15:44:13 +02:00
Oliver Schneider
fae1e646ee Remove useless warning 2017-04-11 14:34:39 +02:00
Oliver Schneider
2eae102cd1 Don't lint lifetimes after trait objects 2017-04-11 14:29:58 +02:00
Oliver Schneider
9a4c0a1c72 Don't lint about unused lifetimes if the lifetimes are used in the body of the function 2017-04-11 14:09:58 +02:00
Oliver Schneider
7b6111677a Latest nightly produces more ellipses in output 2017-04-10 15:36:07 +02:00
Oliver Schneider
b76ce176bb Fix op_ref in case of nonexisting operations 2017-04-10 15:10:19 +02:00
Yati Sagade
62548f447c needless_continue: Add ui test 
The test program contains both conditions tested by the lint, i.e.,
a redundant continue in the `if` and `else` blocks within a loop. Maybe
splitting them out and also having a program that should *not* trigger
the lint warning is better.
 2017-04-09 14:20:14 +02:00
Yati Sagade
69928906f4 needless_continue: Add tests for helper functions to the needless_continue lint. 
Creating a test file per function sounds a bit excessive, so just
clubbing all needless_continue specific function tests into this module.
 2017-04-09 14:12:01 +02:00
Yati Sagade
a099748113 utils: Add tests for the align_blocks helper in utils. 2017-04-09 14:09:54 +02:00
Oliver Schneider
f1e905f620 Reintroduce #768 so we can publish 2017-04-07 11:21:39 +02:00
Oliver Schneider
3052000c73 Merge pull request #1649 from ensch/master 
Fix for rustc 1.18.0-nightly (5c94997b6 2017-03-30)
 2017-04-07 11:13:44 +02:00
Oliver Schneider
f32fab1c8f panic!("{}") lint is broken 2017-04-06 16:49:03 +02:00
Oliver Schneider
6d921b4734 fix various rustup failures 2017-04-06 16:48:48 +02:00
Peter Gerber
71a788cbd7 correct error message for option_map_unwrap_or_else lint 
Remove erroneous "with " in suggested alternative call.
 2017-04-01 15:54:27 +02:00
Enrico Schmitz
7c94a62048 Reenable mut_mut_macro.rs test 2017-04-01 00:25:23 +02:00
Enrico Schmitz
8f9fb97eb6 First try for a fix for rustc 1.18.0-nightly (5c94997b6 2017-03-30 2017-03-31 19:23:35 +02:00
Oliver Schneider
5547fbb770 Fix accidental newline in diagnostic and missing entries in lint_array! 2017-03-24 10:21:12 +01:00
Oliver Schneider
8ae82eb4ab
Merge remote-tracking branch 'origin/master' into 1537-drop_copy 2017-03-24 10:11:46 +01:00
sinkuu
a712271df6 Filter out proc_macro_derive functions (fixes #1615) 2017-03-21 17:09:21 +09:00
Enrico Schmitz
f8df4aed0f Fix for rustc 1.17.0-nightly (6eb9960d3 2017-03-19) 2017-03-21 00:22:19 +01:00
Oliver Schneider
2d145b2ef5 don't lint macro_rules! in items_after_statements 2017-03-13 11:09:56 +01:00
Oliver Schneider
40d50fe8b2 Don't lint nan_cmp and zero_ptr in constants 2017-03-07 12:58:07 +01:00
Oliver Schneider
a33930f815 Fix single-match-else in the presence of macros expressions expanding to blocks 2017-03-03 16:56:16 +01:00
Oliver Schneider
26270c7451 Fix ice 2017-03-03 14:46:33 +01:00
Oliver Schneider
51295960bf Fix invalid_upcast_comparisons lint for same size sign casts 2017-03-02 10:41:20 +01:00
Oliver Schneider
7bfa53f504 Almost there 2017-03-01 18:46:18 +01:00
Enrico Schmitz
d4050c275e Remove old tests for ConstInt::Infer as it has been removed 2017-03-01 15:38:31 +01:00
Enrico Schmitz
887a3c184e Make tests compile for rustc 1.17.0-nightly (be760566c 2017-02-28) 2017-03-01 14:33:17 +01:00
Tristian Celestin
75e28610a7 Merged drop_forget_ref.rs with drop_forget_copy.rs. 
Moved constant message strings out of declare_lint! macros.
 2017-02-26 21:57:47 -05:00
Tristian Celestin
aa037d1ef0 Merge branch 'master' into 1537-drop_copy 2017-02-25 23:11:21 -05:00
Tristian Celestin
b8defc6cc4 Warn on calls to std::mem::drop or std::mem::forget with a Copy type 2017-02-25 23:05:37 -05:00
sinkuu
5906639af5 Enable len_zero for slices 2017-02-25 12:26:33 +09:00
Oliver Schneider
19929790aa Merge pull request #1561 from Manishearth/zero_ptr 
New zero_ptr lint.
 2017-02-22 13:34:28 +01:00
sinkuu
1e26c44010 Suggest assert_ne for assert!(x != y) 2017-02-22 16:47:18 +09:00
Oliver Schneider
a7c049df28 Merge pull request #1564 from Manishearth/cleanup 
Cleanup test suite
 2017-02-21 15:30:39 +01:00
Oliver Schneider
d032b8967c Merge pull request #1491 from Manishearth/into_iter_on_ref 
fix explicit_into_iter_loop on references
 2017-02-21 14:55:52 +01:00
Oliver Schneider
27aa309b3d Merge pull request #1556 from sinkuu/take_by_value 
Lint needless take-by-value
 2017-02-21 13:07:25 +01:00
Oliver Schneider
25e230419c Merge system independent ui-tests back into tests/ui 2017-02-21 12:19:55 +01:00
Oliver Schneider
f10128369b fix ui-posix test paths 2017-02-21 12:16:57 +01:00
Oliver Schneider
f2ff5e2133 Update ui test output 2017-02-21 12:13:44 +01:00
Oliver Schneider
0996f8bb00 Fix more wrong windows ui test paths 2017-02-21 12:12:45 +01:00
Oliver Schneider
ff655a7dbc Ui windows test paths are wrong 2017-02-21 12:12:08 +01:00
Oliver Schneider
21a0b16aee
adjust messages in tests 2017-02-21 12:04:29 +01:00
Oliver Schneider
0bea3e76d4
fix explicit_into_iter_loop on references 
fixes #1398
 2017-02-21 12:01:41 +01:00
Oliver Schneider
89d98a8732 Simplify calling update-all-references.sh 2017-02-21 11:18:05 +01:00
Oliver Schneider
3af04c7816 Cleanup test suite 2017-02-21 11:11:33 +01:00
sinkuu
cb86c57c5f Integrate suggestion spans 2017-02-21 19:03:50 +09:00
sinkuu
3516d45d7c Use multispan_sugg 2017-02-21 18:44:31 +09:00
Oliver Schneider
55ea08102a Merge pull request #1543 from Manishearth/fix-windows-tests 
fix windows tests
 2017-02-21 10:34:49 +01:00
Oliver Schneider
f07f793fa8 Merge pull request #1544 from bood/master 
Add lint for unnecessary casts (cast to same type)
 2017-02-21 09:16:07 +01:00
Andre Bogus
2f7babba82 New zero_ptr lint. 
This fixes #1047. I did not bother to add a full suggestion,
because replacing with `std::ptr::null()` may still lead to
inference failures.
 2017-02-21 04:36:59 +01:00
sinkuu
627d24c80f Fix suggestion for let <pat> 2017-02-21 00:27:12 +09:00
sinkuu
f1b0b774e7 Support non-moving usages at match 
This `match` is not moving the `String`:

```rust
fn foo(x: Option<String>) -> i32 {
    match x {
        Some(_) => 1,
        None => 2,
    }
}
```

With this change, it will be linted and suggested to add `*` to deref it.

```rust
fn foo(x: &Option<String>) -> i32 {
    match *x {
        Some(_) => 1,
        None => 2,
    }
}
```
 2017-02-20 16:45:37 +09:00
sinkuu
0a6bc6031a Rename lint to needless_take_by_value 
And fixes false-positives for generics and `match`
 2017-02-20 16:02:48 +09:00
Phil Ellison
d6a4d2cb18 Fix typo 2017-02-19 15:39:40 +00:00
Phil Ellison
0396756098 Add test that adding allow attribute on impl block containing len silences len_without_is_empty. Add extra impl block to PubOne to check that this doesn't get flagged@ 2017-02-19 15:36:17 +00:00
Phil Ellison
2dd45b7317 Use span of impl/trait in len_without_is_empty error message, rather than the span of the len method 2017-02-19 15:14:30 +00:00
sinkuu
d81d961ba7 Lint needless take-by-value 2017-02-19 07:59:44 +09:00
Bood Qian
97d46232b4 Merge branch 'master' of github.com:Manishearth/rust-clippy 2017-02-18 11:12:13 +08:00
sinkuu
8cb2ec804d Support generic type 2017-02-18 10:14:25 +09:00
sinkuu
6bb426b0e3 Add should_assert_eq lint (fixes #641) 2017-02-18 10:13:56 +09:00
Andre Bogus
505eb53d29 New never loop lint 
This lint detects loops that unconditionally break or return.

Closes #257
 2017-02-17 04:53:14 +01:00
Ben Boeckel
84509ca48a typos: coma -> comma 2017-02-16 11:23:28 -05:00
Bood Qian
2f00ea3a07 Suppress lint for unsuffixed number casts 2017-02-16 22:55:41 +08:00
Bood Qian
afce85e96d Add lint for unnecessary casts (cast to same type) 2017-02-15 22:20:20 +08:00
Oliver Schneider
f158bec188 satisfy rustfmt 2017-02-15 08:36:44 +01:00
Andre Bogus
d904a01140 fix windows tests 
Windows has a different error message than POSIX, so the ui tests fail for the clippy-config-fail tests.
This commit splits those tests up in target-os specific subdirectories and extends compile-test.rs to
run either of them based on the target os. Here's hope we'll get a green appveyor build.
 2017-02-14 17:30:55 +01:00
Oliver Schneider
8b3ad61dd3 update ui tests 2017-02-13 11:57:14 +01:00
Oliver Schneider
2265babe6a
Merge remote-tracking branch 'origin/master' into clonedCollect 2017-02-13 11:40:02 +01:00
Oliver Schneider
637a4590f6
Merge remote-tracking branch 'origin/master' 2017-02-13 11:15:12 +01:00
Martin Carton
9a7597d5af Merge pull request #1528 from Manishearth/mut-from-ref 
New `mut_from_ref` lint
 2017-02-12 16:01:15 +01:00
Andre Bogus
21d226e7d2 fixed multi-span test 2017-02-12 15:10:25 +01:00
Andre Bogus
36b8554cf1 add notes for immutable inputs 2017-02-12 13:53:30 +01:00
f001
b3570db094 update via comments 2017-02-12 20:40:38 +08:00
f001
98aa0db0ac Add a lint for slice.iter().cloned().collect() 
If one uses `slice.iter().cloned().collect()` to create a new `Vec`,
it should be `slice.to_owned()`.

Fix #1292
 2017-02-12 17:03:09 +08:00
Bood Qian
64d2f8af8e Lint on panic! only 2017-02-11 21:42:42 +08:00
Bood Qian
a2d752807a Lint on Err(_) arm of a match 2017-02-11 14:57:50 +08:00
Owen Sanchez
2a8ce7c458 Update large_enum_variant test 2017-02-10 21:04:19 -07:00
Owen Sanchez
1938904fcd Change large_enum_variant to lint against size differences rather than size 2017-02-10 18:12:32 -07:00
Andre Bogus
673ee4800d fix test 2017-02-11 01:41:49 +01:00
Andre Bogus
bff4c30ac7 added test, fixed message & description, rustfmt 2017-02-11 00:32:12 +01:00
Andre Bogus
5650a599a8 New mut_from_ref lint 
This fixes #1507.
 2017-02-10 19:39:03 +01:00
Oliver Schneider
1f2c97a291 remove all //~ from tests 2017-02-08 14:58:07 +01:00
Oliver Schneider
fd1351f6e3 rustup and compile-fail -> ui test move 2017-02-07 21:05:30 +01:00
Martin Carton
4ee839857b Merge pull request #1506 from bood/master 
Lint for possible missing comma in an array #1177
 2017-02-07 18:56:38 +01:00
Owen Sanchez
7570af0557 Make tests pass 2017-02-04 22:59:39 -07:00
Owen Sanchez
49238ad1d2 Implement empty_enum lint and add a test 2017-02-04 21:52:44 -07:00
Oliver Schneider
d198b99472 fix false negatives introduced in the rustup 2017-02-04 16:59:06 +01:00
Bood Qian
cb83a299fa Add test cases for possible missing comma lint 2017-02-04 20:02:53 +08:00
Bood Qian
33577ec3f7 Lint for possible missing comma in an array #1177 2017-02-03 19:10:30 +08:00
Martin Carton
b1be0d6457 Merge pull request #1492 from Manishearth/largeEnumVariant 
large_enum_variants lint suggests to box variants above a configurable limit
 2017-01-31 19:12:43 +01:00
Oliver Schneider
12eeffdf93 place the error checks on the correct lines 2017-01-31 16:00:28 +01:00
Oliver Schneider
19f119caec fix println message in tests 2017-01-31 11:19:49 +01:00
Oliver Schneider
9bda699c80 improve messages and add suggestions 2017-01-31 08:36:39 +01:00
Oliver Schneider
d9ec55e695 address nits 2017-01-31 08:08:54 +01:00
Oliver Schneider
82dd50d0e2 large_enum_variants lint suggests to box variants above a configurable limit 2017-01-30 13:17:56 +01:00
Oliver Schneider
aebdf74e16 correctly check exclusive range patterns for overlap 2017-01-30 12:30:16 +01:00
Pascal Hertleif
2357dfe8ee Remove useless part of test 2017-01-28 14:17:47 +01:00
Pascal Hertleif
6760b35e57 Increase suggestion tests' context 2017-01-28 14:12:35 +01:00
Pascal Hertleif
8cbf548f7e Add suggestions to EXPLICIT_[INTO_]ITER_LOOP 
Also reduces the highlighted span to the expr containing the
`.[into_]iter()` call (so the suggestion is probably applicable by
rustfix.)

Fixes #1484
 2017-01-28 14:02:49 +01:00
Oliver Schneider
4a70a46d2d
run rustfmt 2017-01-26 11:31:26 +01:00
Oliver Schneider
26e8558d8a
remove rustc-serialize dependency and factor util::cargo out into a crate 2017-01-26 11:31:26 +01:00
mcarton
b784f0d736
Use span_suggestion in the precedence lint 2017-01-22 15:00:10 +01:00
Oliver Schneider
7b836dd27c
become rustfmt resistant 2017-01-17 19:27:52 +01:00
Oliver Schneider
25100a8299
fix build 2017-01-17 19:23:32 +01:00
Andre Bogus
27d47f970a rustfmt tests to fix build 2017-01-17 16:12:09 +01:00
Oliver Schneider
219da6d736 Merge pull request #1444 from Manishearth/or_else_method 
Extend or_fun_call to also cover methods
 2017-01-15 14:38:51 +01:00
sinkuu
cdfe002ee1 Use closure body span (fixes #1405) 2017-01-15 13:16:02 +09:00
Andre Bogus
b764b2a7aa extend or_fun_call lint to cover methods 2017-01-15 00:31:20 +01:00
Andre Bogus
2fdb6e4d1a deprecate extend_from_slice lint 2017-01-14 14:39:41 +01:00
Oliver Schneider
d944d7df9a
rustup to 2017-01-12 2017-01-13 17:04:56 +01:00
Oliver Schneider
3cc5596466 Merge pull request #1433 from sinkuu/ref 
Don't lint needless_borrow when matching `&&mut` by `&ref`
 2017-01-10 17:29:19 +01:00
sinkuu
c9091b71a1 Don't lint when matching &&mut by &ref (Fix #1432) 2017-01-11 00:42:58 +09:00
Oliver Schneider
e066997046
FOR_KV_MAP can now lint on mutable maps due to values_mut() 2017-01-10 08:33:20 +01:00
sinkuu
a2bcce9dbf Move is_try to util 
Removed unnecessary condition

Also changed lint span of `try` from surrounded expression to entire `try`
invocation. It turned out that compiletest misses errors for macro invocations.
 2017-01-07 23:52:48 +09:00
sinkuu
ce6e037ac5 Implement unused_io_amount lint 2017-01-07 22:23:33 +09:00
Theemathas Chirananthavat
3050d90930 Add forget_ref tests. 
Also rename drop_ref.rs to drop_forget_ref.rs in tests/compile-fail.
 2017-01-05 17:41:01 -08:00
Theemathas Chirananthavat
920a2b7468 The drop_ref test does not require implementing the Drop trait. 2017-01-05 17:41:01 -08:00
Oliver Schneider
f145fc44f8 Merge pull request #1414 from samueltardieu/no-short-circuit-if 
Add a new "short_circuit_statement" lint (fixes #1194)
 2017-01-05 10:41:14 +01:00
Manish Goregaokar
9a301fd508 Bump to 0.0.106; Fix false positive in wrong_self_convention (fix #1420) 2017-01-04 18:05:04 -08:00
Samuel Tardieu
82b2f5663f Add a new "short_circuit_statement" lint (fixes #1194) 2016-12-31 01:17:39 +01:00
Manish Goregaokar
b8b54eb0d8 Fix suggestion span on new_without_default (fixes #1407) 2016-12-29 11:19:32 -08:00
Theemathas Chirananthavat
c0c20145d1 Fix compile-fail tests by allowing double_parens. 2016-12-28 12:04:46 -08:00
Theemathas Chirananthavat
e7352877c5 Add test for double_parens lint. 2016-12-28 11:21:53 -08:00
Martin Carton
96d2483b09 Merge pull request #1400 from oli-obk/needed_needless_lifetime 
support impl trait for needless lifetimes
 2016-12-25 18:24:39 +01:00
Martin Carton
7c480d0db7 Merge pull request #1394 from Manishearth/absurd_extreme_comparisons_false_positive 
fix absurd extreme comparisons false positive
 2016-12-25 17:47:42 +01:00
Oliver Schneider
93333f0d7b
support impl trait for needless lifetimes 2016-12-22 15:51:59 +01:00
Oliver Schneider
2f219b827e
fix an ice related to associated types 
fixes #1341
 2016-12-22 14:16:07 +01:00
Oliver Schneider
0b10a41ef3
fix absurd extreme comparisons false positive 
fixes #1387
 2016-12-21 16:49:53 +01:00
Oliver Schneider
7a1d85f1de Merge branch 'master' into allow_deprecated 2016-12-21 15:47:12 +01:00
Oliver Schneider
00a3bfb8eb
Don’t warn for types used in trait implementation 2016-12-21 15:42:20 +01:00
Oliver Schneider
90fc9c389f
split pub_enum_variant_names to new lint 2016-12-21 13:30:57 +01:00
Oliver Schneider
009c6d95d7
manually fix the overlong lines 2016-12-21 12:30:41 +01:00
Oliver Schneider
0a7ae5fec8
run rustfmt 2016-12-20 10:20:41 +01:00
Manish Goregaokar
d61c7fc747 Merge pull request #1355 from philipturnbull/deref-addrof 
Lint usage of `*&` and `*&mut`
 2016-12-19 03:35:45 -08:00
Oliver Schneider
5aded99033
don't lint on x = x + y inside an AddAssign impl 
fixes #1302
 2016-12-19 11:13:07 +01:00
Oliver Schneider
2e63a5648a uncomment code that was commented out for testing 2016-12-04 19:31:46 +01:00
mcarton
65ff2df7e7
Fix copy lints 2016-12-02 22:23:24 +01:00
mcarton
fe15880beb Revert "down to for-loops not comparing as equal" 
This reverts commit cf1fa94be1.
 2016-12-02 20:54:05 +01:00
mcarton
42fb11f887
Don't set RUST_BACKTRACE for tests 
It is slow but it can be useful and can be set/unset explicitly before
running tests if needed. There is no backtrace by default anyway.
 2016-12-02 20:33:37 +01:00
Oliver Schneider
cf1fa94be1 down to for-loops not comparing as equal 2016-12-02 19:19:52 +01:00
Oliver Schneider
16aab71688
enum glob use and copies left 2016-12-02 17:38:31 +01:00
Wim Looman
919feaaec5 Allow allow(deprecated) attribute on use items 
fixes #1372
 2016-12-01 22:36:35 +01:00
Phil Turnbull
0ee6128e27 Convert DEREF_ADDROF to EarlyLintPass 2016-11-25 10:33:21 -05:00
Phil Turnbull
8d04038c56 Make deref_addrof suggestions stricter 
SUGGESTION matches a substring so 'aref' in the testcases can match
'let b = *aref', 'let b = **aref', 'let b = *&aref' etc, which are
all wrong.
 2016-11-25 10:33:01 -05:00
mcarton
c35f82b823
Rustup to *rustc 1.15.0-nightly (7b3eeea22 2016-11-21)* 2016-11-23 21:31:55 +01:00
Phil Turnbull
a9f5b90f0f Lint usage of *& and *&mut 
fixes #1316
 2016-11-22 21:06:20 -05:00
Martin Carton
530083c3b9 Merge pull request #1349 from philipturnbull/extend-chars 
Lint `.extend(s.chars())` (closes #792)
 2016-11-22 18:21:30 +01:00
Phil Turnbull
e9f3911899 Suggest &s instead of s.as_str() 2016-11-20 11:19:36 -05:00
sinkuu
5d40965b50 Fix #1346 2016-11-20 10:15:40 +09:00
sinkuu
1973e94550 Allow explicit returns with cfg attributes 2016-11-20 10:02:41 +09:00
Phil Turnbull
73a73638c0 Add lint for string.extend(string.chars()) 
fixes #792
 2016-11-19 14:55:47 -05:00
Phil Turnbull
fa78b09fa7 Add lint for string.extend("str".chars()) 
fixes #792
 2016-11-19 14:55:02 -05:00
mcarton
7140eac484 Cleanup 2016-11-18 13:40:44 +01:00
mcarton
945c027768
Handle closure with single expression blocks 2016-11-17 19:44:18 +01:00
mcarton
19c5f5394b
Rustup to rustc 1.15.0-nightly (0ed951993 2016-11-14) 2016-11-16 23:05:26 +01:00
Oliver 'ker' Schneider
cfae1e9fda fix ice in len_zero lint when type has no inherent impls at all 
fixes #1336
 2016-11-10 17:06:39 +01:00
Oliver Schneider
a260e65ead Merge pull request #1312 from devonhollowood/get-unwrap 
Implement `get_unwrap` lint
 2016-11-09 09:49:20 +01:00
Oliver Schneider
a56af73fd8
mark cyclomatic complexity attribute as used 
fixes #1315
 2016-11-02 10:29:57 +01:00
Devon Hollowood
6a14dc7fd4 Remove false positives from get_unwrap lint 
HashMap and BTreeMap don't implement `IndexMut`, so we shouldn't lint
for use of `get_mut().unwrap()` for those types.
 2016-11-01 17:48:32 -07:00
Devon Hollowood
4e0d182d1d Clean up get_unwrap code 2016-11-01 17:48:18 -07:00
Devon Hollowood
1187d333ec Add tests for get_unwrap lint 2016-11-01 01:08:47 -07:00
Sebastian Ullrich
8664d03ec6 implement 'Re-implementing PartialEq::ne' lint 
closes #86
 2016-10-30 15:00:59 -04:00
d-dorazio
d213040381 Add lint for redundant pattern matching in iflet for Result/Option 2016-10-30 15:43:46 +01:00
Devon Hollowood
3a0d342a33 Fix false positive for wrong_self_convention 2016-10-27 01:11:34 -07:00
mcarton
984e15a0c0
Forbid default warnings in dogfood 2016-10-22 16:16:55 +02:00
d-dorazio
62831c6e29 Suggest nth(X) instead of skip(X).next() 2016-10-14 13:38:00 +02:00
mcarton
8d0431fd9a
Test for #1275 
Close #1275.
 2016-10-12 12:00:26 +02:00
d-dorazio
a4d4a372e0 Avoid redundant multiple pattern suggested when one pattern is _ 2016-10-08 16:29:19 +02:00
mcarton
47c2271497
Fix FP with print_with_newline and final arguments 2016-10-06 22:30:03 +02:00
Martin Carton
e851bc7404 Merge pull request #1257 from KitFreddura/master 
If let some lint
 2016-10-04 23:00:05 +02:00
Manish Goregaokar
7b94ef19bd aux -> auxiliary (breaks Windows) 2016-10-04 09:15:03 +05:30
Manish Goregaokar
a4198c1108 Merge pull request #1255 from Manishearth/cov 
Improve test coverage
 2016-10-03 22:15:23 +05:30
mcarton
6800111c8e
Move all *.toml test files to tests/aux 2016-10-03 17:49:41 +02:00
Kit Freddura
72a653d8d4 readded files 2016-10-02 13:49:29 -07:00
mcarton
7b92fe0387
Test configuration file typing errors 2016-10-02 14:46:46 +02:00
mcarton
019e310861
Add more tests for bad configuration file 2016-10-02 14:43:09 +02:00
mcarton
f6f4af6adc
Add missing tests for ... and array indexing 2016-10-02 14:42:55 +02:00
mcarton
e50cfa7e77
Add a test for a shadow corner case 2016-10-02 02:38:54 +02:00
mcarton
9a3f53dee6
Partially hash let declaration in SpanlessHash 
The hash never needs to be good but before it was simply doing nothing
for these.
 2016-10-02 02:17:04 +02:00
mcarton
6302e41ccb
Improve test coverage of hir comparison 2016-10-01 22:27:25 +02:00
Martin Carton
8babb2d409 Merge pull request #1250 from elliottneilclark/explicit_into_iter 
Add a lint to warn about un-necessary .into_iter()
 2016-10-01 15:01:43 +02:00
Oliver Schneider
9c5d3f3b85 correctly traverse match expressions for diverging_sub_expr 2016-10-01 14:41:20 +02:00
Elliott Clark
5fa004313b Add a lint to warn about un-necessary .into_iter() 
This should close #1094.
 2016-09-30 17:42:43 -07:00
mcarton
84269478b0
chmod -x tests/compile-fail/print_with_newline.rs 2016-10-01 00:50:40 +02:00
Martin Carton
fe27ac5fd2 Merge pull request #1237 from Manishearth/rustup 
Rustup to *rustc 1.13.0-nightly (d0623cf7b 2016-09-26)* and bump to 0.0.91
 2016-09-28 01:15:33 +02:00
mcarton
4f3920307a
Rustup to *rustc 1.13.0-nightly (d0623cf7b 2016-09-26)* 2016-09-28 01:09:11 +02:00
mcarton
056b0c1cf2
Remove redundant labels in tests 2016-09-23 19:51:47 +02:00
Manish Goregaokar
fc9f2b99c7 Merge pull request #1235 from Manishearth/transmute_ptr_to_ref-suggs 
Fix wrong suggestion in `TRANSMUTE_PTR_TO_REF` with lts
 2016-09-19 22:02:47 +05:30
mcarton
f74dcaac0c
Fix wrong suggestion in TRANSMUTE_PTR_TO_REF with lts 2016-09-19 17:59:12 +02:00
Oliver Schneider
c89c5d21c1
Merge remote-tracking branch 'origin/master' into examples 2016-09-19 15:38:38 +02:00
mcarton
c8986b4676
Fix FP with WHILE_LET_ON_ITERATOR and refutable pats 2016-09-16 15:50:35 +02:00
Martin Carton
dc84759ac5 Merge pull request #1224 from oli-obk/divergence 
lint diverging expressions that are sub-expressions of others
 2016-09-13 15:58:31 +02:00
Oliver Schneider
9427a4ae80
also test match statements, return, continue and break 2016-09-13 14:52:21 +02:00
Oliver Schneider
e6bfe4b514
also lint diverging methods 2016-09-13 12:41:37 +02:00
Oliver Schneider
a2257280ec
don't lint expressions referencing ! objects, just expressions creating them 2016-09-13 12:41:20 +02:00
Oliver Schneider
40ce3a8f1c
add tests for stutter lints 2016-09-13 10:20:10 +02:00