52 commits

Author	SHA1	Message	Date
Georg Brandl	92a3394065	all: remove unneeded deref and/or ref operations	2015-08-25 14:41:35 +02:00
Georg Brandl	8f1a237493	&-matches: dogfood fixes!	2015-08-22 14:34:39 +02:00
Georg Brandl	5403e82681	matches: new module, move single_match lint there	2015-08-22 14:34:39 +02:00
Georg Brandl	7f52239cab	consts: convert to using a struct with state ... Struct has the context reference (as an Option) and the needed_resolution flag.	2015-08-17 19:58:21 +02:00
llogiq	0e67c0134f	make float_cmp check for zero	2015-08-17 12:08:45 +02:00
Manish Goregaokar	164907ece2	restrict toplevel_ref_arg to only functions (fixes #170)	2015-08-16 17:24:03 +05:30
Georg Brandl	47b605304d	all: organize imports ... * remove unused imports * separate external and internal imports * consistent import of rustc::lint * move #[allow(unused_imports)] to local impl	2015-08-16 08:55:34 +02:00
Georg Brandl	542bf8d50e	misc: fix check for unit body in "match -> if let" lint (fixes #172)	2015-08-15 09:56:15 +02:00
Manish Goregaokar	83487c060f	Add trim_multiline utility (fixes #139)	2015-08-13 23:18:33 +05:30
Manish Goregaokar	09db7f3fee	fix	2015-08-13 21:45:42 +05:30
Georg Brandl	2c2716f045	all: DRY for lint descriptions ... * use the rustc style for lint descriptions * add a script to parse all lint descriptions and put the generated table into README	2015-08-13 11:14:05 +02:00
Manish Goregaokar	8dfa02938d	Merge branch 'pr-149'	2015-08-13 13:00:29 +05:30
Georg Brandl	a67e55f3f0	lint messages: remove trailing period ... Since lint messages often are suffixed by ", #[warn(xxx)] on by default" this trailing period produces an ugly clash with the comma.	2015-08-13 08:15:42 +02:00
Georg Brandl	225969e8a3	methods: move misc.StrToStringPass to MethodsPass	2015-08-12 13:58:55 +02:00
Georg Brandl	bcd95aec1c	all: make style of lint messages consistent ... * start first sentence lowercased * use backticks to delimit code snippets * use "this is wrong. Consider doing X." consistently	2015-08-12 10:47:09 +02:00
Georg Brandl	02c0cafa14	move NeedlessReturn pass out to its own module and rename to ReturnPass	2015-08-11 22:06:59 +02:00
Georg Brandl	cf96042c65	move walk_ty() to utils module and rename to walk_ptrs_ty	2015-08-11 21:16:10 +02:00
Manish Goregaokar	6bc69fa342	Merge pull request #127 from birkenfeld/better-helptext-if-let ... better help text for "match -> if let" lint	2015-08-12 00:44:51 +05:30
Manish Goregaokar	2cb26126d3	Merge branch 'pr-78' ... Conflicts: src/lib.rs	2015-08-11 23:28:06 +05:30
Manish Goregaokar	efdbfe0d31	nit	2015-08-11 23:11:20 +05:30
Georg Brandl	cab9905705	better help text for "match -> if let" lint ... Implements the suggestion from #87. Changes span_help_and_lint(), which is only used for this lint, to use fileline_help() instead of span_help() to avoid printing the span twice. Also adds complete suggested new code. I had to distinguish between blocks, which need no additionals braces, and other exprs.	2015-08-11 19:26:51 +02:00
Georg Brandl	0ff476b529	new lint for unneeded return stmts	2015-08-11 19:05:11 +02:00
Georg Brandl	7b074d3ac7	Remove tabs and trailing whitespace from lib and misc.	2015-08-11 17:02:04 +02:00
llogiq	f0eb36c2af	added parent method, also changed match-if-let note to help	2015-08-11 15:07:21 +02:00
Manish Goregaokar	de5ccdfab6	Upgrade to rustc 1.3.0-nightly (4d52d7c85 2015-07-30)	2015-07-31 12:00:06 +05:30
Manish Goregaokar	0e8e8cfc9b	Basic framework for structured logging	2015-07-27 00:39:09 +05:30
llogiq	251c5cfffd	rustup, also first time clippy was used on itself, which led to a small refactoring	2015-07-16 08:53:02 +02:00
llogiq	a244750939	new 'snippet' utils method, used where applicable	2015-07-09 17:02:21 +02:00
Zachary Bush	038d540ab1	Fix build for rustc 1.3.0-nightly (bf3c979ec 2015-06-30)	2015-07-01 09:21:46 -07:00
llogiq	9a3dcaabe8	fixed renaming of rustc::middle::ty enums	2015-06-15 13:27:24 +02:00
llogiq	0e5b62c8d8	also included String::from in cmp_owned and fixed deprecation in test	2015-06-11 16:53:23 +02:00
llogiq	cdca2c93c1	now the method lookup actually works (and I understand why! 😄), reduces unnecessary loops, and has a few comments	2015-06-01 12:49:36 +02:00
Matthew Hall	423a9666ca	Implements #45 - any number mod 1 will be 0	2015-05-31 13:43:31 +01:00
llogiq	4b1c72c949	check for str type of .to_owned() callee	2015-05-21 16:37:38 +02:00
llogiq	4292dc77a7	new lint: cmp_owned	2015-05-21 14:51:43 +02:00
llogiq	23525081f9	fixed typo from last commit	2015-05-06 14:19:02 +02:00
llogiq	7a8de35abc	refactored precedence lint	2015-05-06 13:20:47 +02:00
llogiq	17bcf0e865	New lint: precedence, see issue #41	2015-05-06 12:59:08 +02:00
llogiq	ac151bb1f0	Added new 'float_cmp' lint (see issue #46)	2015-05-06 10:01:49 +02:00
llogiq	0936e0617a	new lint to check for doomed comparisons to NAN	2015-05-04 14:11:15 +02:00
Manish Goregaokar	2935c31692	rustup (rustc 1.0.0-nightly (00978a987 2015-04-18) (built 2015-04-19))	2015-04-20 16:18:35 +05:30
Manish Goregaokar	538db34e60	into_string() -> to_owned() (fix #27)	2015-01-10 10:52:03 +05:30
Manish Goregaokar	b7ecb6e7c7	rustup	2015-01-07 09:35:34 +05:30
Manish Goregaokar	e57396bc52	Remove namespacing	2014-12-26 05:24:44 +05:30
Manish Goregaokar	ccf996c348	clippy lint group	2014-12-26 05:12:05 +05:30
Manish Goregaokar	32d060ae11	more rustup	2014-12-26 04:52:18 +05:30
Manish Goregaokar	b790b78eec	Merge branch 'master' of github.com:Manishearth/rust-clippy	2014-12-26 04:51:14 +05:30
Manish Goregaokar	39481a521c	rustup (MatchSource rename, missing copy)	2014-12-26 04:35:12 +05:30
Jonathan Castello	1431fc04af	Implement a lint to check for args like fn foo(ref x: u8), as the ref is effectively ignored by rustc.	2014-12-24 15:20:30 -08:00
Manish Goregaokar	467b1ad9a4	rustup	2014-12-19 14:41:00 +05:30