Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-13 14:52:46 +00:00
Code Issues Projects Releases Packages Wiki Activity
5128 commits 4 branches 212 tags 129 MiB
Commit graph

5128 commits

This branch
This branch
All branches
Author SHA1 Message Date
Devon Hollowood
6528749083 Fix items_after_statements for use statements 2018-10-07 17:09:32 -07:00
Ryan Cumming
9bd4e5469e Don't suggest cloned() for map Box deref 
Boxes are a bit magic in that they need to use `*` to get an owned value
out of the box. They implement `Deref` but that only returns a
reference. This means an easy way to convert an `Option<Box<T>>` to an
`<Option<T>` is:

```
box_option.map(|b| *b)
```

However, since b36bb0a6 the `map_clone` lint is detecting this as an
attempt to copy the box. Fix by excluding boxes completely from the
deref part of this lint.

Fixes #3274
 2018-10-08 06:20:32 +11:00
Josh Mcguigan
8a77a25b8a Fix excessive_precision false positive 2018-10-07 11:38:20 -07:00
Philipp Hansch
63ceabf0cf
Merge pull request #3280 from d-dorazio/fix-new_without_default-should-not-fire-unsafe-new 
new_without_default should not warn about unsafe new
 2018-10-07 13:09:37 +01:00
Manish Goregaokar
5dcb90e29d
Merge pull request #3279 from phansch/fix_fp_in_fn_to_numeric_cast_with_truncation 
Fix FP in `fn_to_numeric_cast_with_truncation`
 2018-10-07 04:27:51 -07:00
Philipp Hansch
d365742bc6
Fix FP in fn_to_numeric_cast_with_truncation 
We only want this lint to check casts to numeric, as per the lint title.
Rust already has a built-in check for all other casts
[here][rust_check].

[rust_check]: 5472b0718f/src/librustc_typeck/check/cast.rs (L430-L433)
 2018-10-07 12:50:36 +02:00
Daniele D'Orazio
59c4ff77f1 new_without_default should not warn about unsafe new 2018-10-07 12:39:54 +02:00
Daniele D'Orazio
e1d7f00e43 fix command to manually test an example 2018-10-07 11:56:13 +02:00
Philipp Hansch
4511f4edf4
Merge pull request #3273 from maccoda/master 
Adding more detail to filter_map lint documentation.
 2018-10-07 10:02:46 +01:00
Manish Goregaokar
492d6852e5 Add license to README 2018-10-06 19:29:01 -07:00
Dylan Maccora
d129d049c6 Adding more detail to filter_map lint documentation. 2018-10-07 11:24:09 +11:00
Manish Goregaokar
1e0729d48a
Merge pull request #3269 from rust-lang-nursery/relicense 
Relicense clippy to the Rust license
 2018-10-06 10:21:57 -07:00
Manish Goregaokar
31bc2827f8 additional people 2018-10-06 10:20:48 -07:00
Manish Goregaokar
23e5e24f52 Add license header to other files 2018-10-06 09:43:08 -07:00
Manish Goregaokar
e9c025ea70 Add license header to Rust files 2018-10-06 09:43:08 -07:00
Manish Goregaokar
ca437e81a7 Relicense clippy 
Documentation on relicensing in previous commit

Fixes #2885

Also fixes #3093, fixes #3094, fixes 3095, fixes #3096, fixes #3097, fixes #3098,
fixes #3099, fixes #3100, fixes #3230
 2018-10-06 09:43:08 -07:00
Manish Goregaokar
8db2092923 Document relicensing process 2018-10-06 09:43:08 -07:00
Manish Goregaokar
32b1d1fc15
Merge pull request #3270 from rust-lang-nursery/rustup 
Rustup for https://github.com/rust-lang/rust/pull/54741
 2018-10-05 22:35:04 -07:00
Manish Goregaokar
53d41e5c50 Rustup for https://github.com/rust-lang/rust/pull/54741 2018-10-05 13:41:40 -07:00
Manish Goregaokar
cbde8201c5 Remove unused utils 2018-10-05 13:26:39 -07:00
Manish Goregaokar
75965030c7
Merge pull request #3251 from rust-lang-nursery/relicense-rewrite 
[do not merge] Relicensing rewrite
 2018-10-05 20:14:55 +02:00
Philipp Krones
87f6d9e7f9
Merge pull request #3268 from matthiaskrgr/rustup_macros_20 
mini-macro: fix tests with latest rustc (rename feature: proc_macro_non_items -> proc_macro_hygiene).
 2018-10-05 18:10:48 +02:00
Matthias Krüger
cd842736d9 mini-macro: fix tests with latest rustc (rename feature: proc_macro_non_items -> proc_macro_hygiene). 2018-10-05 15:54:39 +02:00
Philipp Krones
c9359566ad
Merge pull request #3267 from matthiaskrgr/travis_osx 
travis: reenable osx
 2018-10-05 14:25:30 +02:00
Matthias Krüger
a3dc01edcc travis: reenable osx 2018-10-05 13:50:09 +02:00
Philipp Hansch
78abcab808
Merge pull request #3264 from joelgallant/extern-type-complexity 
Fixes #3222 by checking the BareFnTy Abi type
 2018-10-05 07:04:19 +01:00
Michael Wright
e5b388d865 Fix util/export.py to include lints from methods 2018-10-05 08:04:14 +02:00
Philipp Hansch
8407957ec6
Fix fn_to_numeric_cast UI tests 
This collapses both lint tests into one file.
Somehow allowing the other lint in the respective files did not work
correctly. Maybe that's fixed as part of fixing #3198.
 2018-10-05 07:49:08 +02:00
Philipp Hansch
1544a1a681
Merge remote-tracking branch 'origin/master' into relicense-rewrite 2018-10-05 07:18:24 +02:00
Joel Gallant
163780ee0b Solves #3222 by checking the BareFnTy Abi type 2018-10-04 18:49:03 -06:00
Philipp Hansch
8b3d2073fa
Only run tests if pointer width is 64bit 
If the pointer width of the architechture is 32bit or something else,
then the tests will most likely produce different results.
 2018-10-04 22:26:54 +02:00
Philipp Hansch
391d53db66
Add hidden lifetime parameters to fix warning 2018-10-04 21:59:30 +02:00
Philipp Hansch
eb2cfe62b5
Merge pull request #3259 from matthiaskrgr/build_warnings 
resolve build warnings in clippy_lints/src/format.rs
 2018-10-04 20:45:53 +01:00
Philipp Hansch
c0ab8b2531
Reimplement the fn_to_numeric_cast_with_truncation lint 2018-10-04 21:44:16 +02:00
Philipp Hansch
7adf24ebb0
Improve docs of fn_to_numeric_cast 
Closes #2980
 2018-10-04 18:09:09 +02:00
Philipp Krones
b393d06ab6
Merge pull request #3261 from matthiaskrgr/travis_failure 
make sure travis fails when clippy does not build.
 2018-10-04 18:02:22 +02:00
Matthias Krüger
c1db71dd8c make sure travis fails when clippy does not build. 
Fixes #3260
 2018-10-04 17:38:30 +02:00
Matthias Krüger
fd5ea0ddf7 resolve build warnings in clippy_lints/src/format.rs 2018-10-04 16:34:41 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
93de5fc6c8
Merge pull request #3255 from o01eg/env_logger 
Allow to debug rustc_driver via logs.
 2018-10-04 08:51:23 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
c3e3be374b
Merge pull request #3256 from rust-lang-nursery/fix-2796 
Fix 2796 and 3020
 2018-10-04 08:51:00 +02:00
mcarton
5173ed0c03 Don't suggest to_string().to_string in USELESS_FORMAT 2018-10-03 20:59:59 +02:00
O01eg
8695c2c34b
Allow to debug rustc_driver via logs. 2018-10-03 21:41:02 +03:00
Philipp Hansch
f42272102a
Reimplement the fn_to_numeric_cast lint 2018-10-03 12:02:06 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
c47b9489ab
Merge pull request #3252 from rust-lang-nursery/rustup 
Fix push_item_path call (rustup to 4cf11765dc98536c6eedf33f2df7f72f6e161263)
 2018-10-03 11:48:31 +02:00
Manish Goregaokar
c430147942 Fix push_item_path call (rustup to 4cf11765dc98536c6eedf33f2df7f72f6e161263) 2018-10-03 02:06:26 -07:00
mcarton
7eebd5b20c Ignore format! with precision in USELESS_FORMAT 2018-10-02 23:57:22 +02:00
mcarton
d18c7b2722 Add test for variable width in USELESS_FORMAT 2018-10-02 23:54:50 +02:00
Oliver Schneider
913a5c9b56 Trailing newline 2018-10-02 15:18:56 +02:00
Oliver Schneider
696dc369df FIx dogfood 2018-10-02 15:17:56 +02:00
Oliver Schneider
b36bb0a68d Reimplement the map_clone lint from scratch 2018-10-02 15:13:43 +02:00