1208 commits

Author	SHA1	Message	Date
bors	6985e6592b	Auto merge of #9028 - kyoto7250:issue_8798, r=xFrednet ... confirm using chain in collapsible_span_lint_calls close #8798 This PR fixes false positive when using chain in `collapsible_span_lint_calls`. changelog: None	2022-06-22 22:35:21 +00:00
Serial	890fd0e3c1	Remove cargo_dev dependency	2022-06-21 14:04:37 -04:00
kyoto7250	4a4b5cf061	confirm using chain in collapsible_span_lint_calls	2022-06-20 13:17:54 +09:00
flip1995	c5c8f6122f	Merge remote-tracking branch 'upstream/master' into rustup	2022-06-16 16:04:06 +02:00
bors	5a45805db5	Auto merge of #8947 - Serial-ATA:lint-produces-output, r=xFrednet ... Add lint output to lint list changelog: Add the ability to show the lint output in the lint list This just adds the logic to produce the output, it hasn't been added to any lints yet. It did help find some mistakes in some docs though 😄. ### Screenshots <details> <summary>A single code block</summary>  </details> <details> <summary>A single code block with a "Use instead" section</summary>  </details> <details> <summary>Multiple code blocks</summary>  </details> This is the last task in #7172 🎉. r? `@xFrednet` (?)	2022-06-14 10:42:09 +00:00
Camille GILLOT	7b84a97c3e	Make ExprKind::Closure a struct variant.	2022-06-12 00:16:27 +02:00
bors	4970527296	Auto merge of #8954 - Serial-ATA:doc-comment-issues, r=xFrednet ... Improve lint doc consistency changelog: none This is a continuation of #8908. Notable changes: - Removed empty `Known Problems` sections - Removed "Good"/"Bad" language (replaced with "Use instead") - Removed (and added some 😄) duplication - Ignored the [`create_dir`] example so it doesn't create `clippy_lints/foo` 😄	2022-06-09 11:03:49 +00:00
Serial	fdadebe672	Add lint output to lint list	2022-06-06 20:04:56 -04:00
Serial	9aeed6b9bf	Improve lint doc consistency	2022-06-05 16:03:18 -04:00
xFrednet	c31b4a9d21	List configuration values can now be extended instead of replaced	2022-06-04 16:03:25 +02:00
Philipp Krones	f067783461	Merge commit 'd9ddce8a223cb9916389c039777b6966ea448dc8' into clippyup	2022-06-04 13:34:07 +02:00
bors	8ef490871c	Auto merge of #8843 - Serial-ATA:collect-renamed, r=xFrednet ... Collect renamed lints changelog: Display past names of renamed lints on Clippy's lint list cc #7172 r? `@xFrednet`	2022-06-04 09:49:27 +00:00
lyj	c5410150eb	needless_deref	2022-05-30 01:46:15 +00:00
tamaron	ea06a414f1	fix	2022-05-27 01:30:44 +09:00
Serial	45be175eeb	Collect renamed lints	2022-05-25 17:31:21 -04:00
xFrednet	4587b6628d	Merge 'rust-clippy/master' into clippyup	2022-05-21 13:24:00 +02:00
xFrednet	4e6cf0036e	Merge remote-tracking branch 'upstream/master' into rustup	2022-05-20 20:47:31 +02:00
Samuel E. Moelius III	564725775b	Improve "unknown field" error messages	2022-05-18 05:21:10 -04:00
SparrowLii	47e9afa20b	fix clippy	2022-05-09 21:48:57 +08:00
Samuel E. Moelius III	597f61bbe3	Optionally allow expect and unwrap in tests	2022-05-08 07:18:31 -04:00
flip1995	7cd86aa1be	Merge commit '7c21f91b15b7604f818565646b686d90f99d1baf' into clippyup	2022-05-05 15:12:52 +01:00
Serial	a85dc87c4c	Add large_include_file lint	2022-04-24 10:08:31 -04:00
Camille GILLOT	ec3afba5d4	Make clippy inspector more precise.	2022-04-23 23:03:18 +02:00
Camille GILLOT	04024bacba	Drop vis in Item.	2022-04-23 09:59:24 +02:00
Camille GILLOT	6ec33dfe49	Drop vis in ImplItem.	2022-04-23 09:57:00 +02:00
bors	cbdf17c884	Auto merge of #8707 - OneSignal:await-invalid-types, r=llogiq ... Add `await_holding_invalid_type` lint changelog: [`await_holding_invalid_type`] This lint allows users to create a denylist of types which are not allowed to be held across await points. This is essentially a re-implementation of the language-level [`must_not_suspend` lint](https://github.com/rust-lang/rust/issues/83310). That lint has a lot of work still to be done before it will reach Rust stable, and in the meantime there are a lot of types which can trip up developers if they are used improperly. I originally implemented this specifically for `tracing::span::Entered`, until I discovered #8434 and read the commentary on that PR. Given this implementation is fully user configurable, doesn't tie clippy to any one particular crate, and introduces no additional dependencies, it seems more appropriate.	2022-04-18 18:36:50 +00:00
bors	95de4dcb5e	Auto merge of #8701 - xFrednet:0000-clippy-print-hir-attr, r=flip1995 ... Rework `#[clippy::dump]` attribute for debugging Hey `@rust-lang/clippy,` this adds a new `#[clippy::print_hir]` attribute that prints the node to the console using `{:#?}`. Personally, I use print debugging quite a lot while working on Clippy, and this is a simple shortcut that also works in the playground (Once this has been synced). The question is now, if we want to have this attribute. Are there any concerns? I think it's similar to our `#[clippy::author]` attribute. I haven't added a test, as the `.stdout` file would require updates with every HIR change inside rustc. Here are some examples, for the current implementation <details> <summary>`do_something(&map);`</summary> ```rs Expr { hir_id: HirId { owner: DefId(0:7 ~ aaa[995b]::main), local_id: 21, }, kind: Call( Expr { hir_id: HirId { owner: DefId(0:7 ~ aaa[995b]::main), local_id: 17, }, kind: Path( Resolved( None, Path { span: tests/ui/aaa.rs:23:5: 23:17 (#0), res: Def( Fn, DefId(0:6 ~ aaa[995b]::do_something), ), segments: [ PathSegment { ident: do_something#0, hir_id: Some( HirId { owner: DefId(0:7 ~ aaa[995b]::main), local_id: 16, }, ), res: Some( Err, ), args: None, infer_args: true, }, ], }, ), ), span: tests/ui/aaa.rs:23:5: 23:17 (#0), }, [ Expr { hir_id: HirId { owner: DefId(0:7 ~ aaa[995b]::main), local_id: 20, }, kind: AddrOf( Ref, Not, Expr { hir_id: HirId { owner: DefId(0:7 ~ aaa[995b]::main), local_id: 19, }, kind: Path( Resolved( None, Path { span: tests/ui/aaa.rs:23:19: 23:22 (#0), res: Local( HirId { owner: DefId(0:7 ~ aaa[995b]::main), local_id: 15, }, ), segments: [ PathSegment { ident: map#0, hir_id: Some( HirId { owner: DefId(0:7 ~ aaa[995b]::main), local_id: 18, }, ), res: Some( Local( HirId { owner: DefId(0:7 ~ aaa[995b]::main), local_id: 15, }, ), ), args: None, infer_args: true, }, ], }, ), ), span: tests/ui/aaa.rs:23:19: 23:22 (#0), }, ), span: tests/ui/aaa.rs:23:18: 23:22 (#0), }, ], ), span: tests/ui/aaa.rs:23:5: 23:23 (#0), } ``` </details> <details> <summary>`use std::collections::HashMap;`</summary> ```rs Item { ident: HashMap#0, def_id: DefId(0:5 ~ aaa[995b]::{misc#1}), kind: Use( Path { span: tests/ui/aaa.rs:8:5: 8:30 (#0), res: Def( Struct, DefId(1:1294 ~ std[928b]::collections:#️⃣:map::HashMap), ), segments: [ PathSegment { ident: std#0, hir_id: Some( HirId { owner: DefId(0:5 ~ aaa[995b]::{misc#1}), local_id: 1, }, ), res: Some( Def( Mod, DefId(1:0 ~ std[928b]), ), ), args: None, infer_args: false, }, PathSegment { ident: collections#0, hir_id: Some( HirId { owner: DefId(0:5 ~ aaa[995b]::{misc#1}), local_id: 2, }, ), res: Some( Def( Mod, DefId(1:1193 ~ std[928b]::collections), ), ), args: None, infer_args: false, }, PathSegment { ident: HashMap#0, hir_id: Some( HirId { owner: DefId(0:5 ~ aaa[995b]::{misc#1}), local_id: 3, }, ), res: Some( Err, ), args: None, infer_args: false, }, ], }, Single, ), vis: Spanned { node: Inherited, span: tests/ui/aaa.rs:8:1: 8:1 (#0), }, span: tests/ui/aaa.rs:8:1: 8:31 (#0), } ``` </details> <details> <summary>`"100"`</summary> ```rs Expr { hir_id: HirId { owner: DefId(0:7 ~ aaa[995b]::main), local_id: 27, }, kind: Lit( Spanned { node: Str( "100", Cooked, ), span: tests/ui/aaa.rs:28:9: 28:14 (#0), }, ), span: tests/ui/aaa.rs:28:9: 28:14 (#0), } ``` </details> --- changelog: Added `[clippy::print_hir]` to inspect rustc's internal representation	2022-04-18 13:06:03 +00:00
xFrednet	ccedc64e3a	Add #[clippy::print_hir] attribute for debugging	2022-04-18 00:51:28 +02:00
Lily Mara	4844325faf	Add await_holding_invalid_type lint ... changelog: [`await_holding_invalid_type`] This lint allows users to create a denylist of types which are not allowed to be held across await points. This is essentially a re-implementation of the language-level [`must_not_suspend` lint](https://github.com/rust-lang/rust/issues/83310). That lint has a lot of work still to be done before it will reach Rust stable, and in the meantime there are a lot of types which can trip up developers if they are used improperly.	2022-04-15 14:39:10 -07:00
whodi	29ef80c78a	adding spell checking	2022-04-15 14:18:09 -07:00
Amanieu d'Antras	0de314b3b3	Reimplement lowering of sym operands for asm! so that it also works with global_asm!	2022-04-14 15:32:03 +01:00
flip1995	71131351de	Merge commit '984330a6ee3c4d15626685d6dc8b7b759ff630bd' into clippyup	2022-04-08 10:06:10 +01:00
bors	abc59bb914	Auto merge of #8656 - flip1995:rustup, r=flip1995 ... Rustup r? `@ghost` changelog: none	2022-04-07 15:30:27 +00:00
flip1995	db1d5dca50	Fix internal::INVALID_PATHS lint	2022-04-07 16:24:10 +01:00
flip1995	669fddab37	Merge remote-tracking branch 'upstream/master' into rustup	2022-04-07 15:44:37 +01:00
Paolo Borelli	f2bbb5fac0	conf: fix lint name in comment ... The lint name is ERR_EXPECT, not EXPECT_ERR	2022-04-07 11:29:02 +02:00
Paolo Borelli	b0edbca0e6	new lint cast_abs_to_unsigned ... Add a lint to detect cast to unsigned for abs() and suggest unsigned_abs() to avoid panic when called on MIN.	2022-04-07 11:28:14 +02:00
InfRandomness	cebe575aad	Add .err().expect() lint	2022-04-06 19:25:58 +02:00
flip1995	1fa3d66e62	Merge commit 'd0cf3481a84e3aa68c2f185c460e282af36ebc42' into clippyup	2022-03-24 14:50:04 +01:00
J-ZhengLi	5b6295d663	allowing [map_flatten] to split long suggestions ... add new function `span_lint_and_sugg_` for edges in `clippy_utils::diagnostics`	2022-03-21 14:11:22 +08:00
flip1995	d1b087fdee	Merge commit 'dc5423ad448877e33cca28db2f1445c9c4473c75' into clippyup	2022-03-14 12:02:53 +01:00
flip1995	d5ab347d5c	Merge remote-tracking branch 'upstream/master' into rustup	2022-03-14 11:29:18 +01:00
Liu Dingming	6cc2eeaa56	Suggest into_iter() over drain(..) ... Add doc Add description iter_with_drain dogfood Disable emiting on struct field. Fix clippy Add eq_path for SpanlessEq Fix tests Better error message Fix doc test Fix version Apply suggestions	2022-03-03 13:10:19 +08:00
flip1995	bca4ee7971	Implement internal lint for MSRV lints ... This internal lint checks if the `extract_msrv_attrs!` macro is used if a lint has a MSRV. If not, it suggests to add this attribute to the lint pass implementation.	2022-03-01 09:40:07 +00:00
flip1995	35020280a0	Merge commit 'e329249b6a3a98830d860c74c8234a8dd9407436' into clippyup	2022-02-26 14:26:21 +01:00
Vadim Petrochenkov	83d32701f2	resolve: Fix incorrect results of opt_def_kind query for some built-in macros ... Previously it always returned `MacroKind::Bang` while some of those macros are actually attributes and derives	2022-02-24 22:54:36 +03:00
flip1995	fd495a0654	Merge remote-tracking branch 'upstream/master' into rustup	2022-02-24 19:32:17 +01:00
flip1995	611d039814	Merge commit '57b3c4b90f4346b3990c1be387c3b3ca7b78412c' into clippyup	2022-02-10 18:40:06 +01:00
flip1995	0775c06d32	Merge remote-tracking branch 'upstream/master' into rustup	2022-02-10 18:11:27 +01:00
bors	3d43826e32	Auto merge of #8305 - camsteffen:util-cleanup, r=flip1995 ... Factor out several utils, add `path_def_id` changelog: none This is generally an effort to reduce the total number of utils. `path_def_id` is added which I believe is more "cross-cutting" and also complements `path_to_local`. Best reviewed one commit at a time. Added: * `path_def_id` * `path_res` Removed: * `is_qpath_def_path` * `match_any_diagnostic_items` * `expr_path_res` * `single_segment_path` * `differing_macro_contexts` * `is_ty_param_lang_item` * `is_ty_param_diagnostic_item` * `get_qpath_generics` Renamed: * `path_to_res` to `def_path_res` * `get_qpath_generic_tys` to `qpath_generic_tys` CC `@Jarcho` since this relates to some of your work and you may have input.	2022-02-07 15:23:23 +00:00