Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-23 13:13:34 +00:00
Code Issues Projects Releases Packages Wiki Activity
6254 commits 4 branches 211 tags 120 MiB
Commit graph

6254 commits

This branch
This branch
All branches
Author SHA1 Message Date
bors
28a39e9741 Auto merge of #4165 - BO41:needless_range_loop, r=phansch 
Add example to needless_range_loop

adds a "could be written as" example

btw, is it correct that the lint triggers even if the index is used not just for getting the values by index?
So that I have to add `.iter().enumerate()` to still get an index?

changelog: none
 2019-06-03 08:28:15 +00:00
bors
4b45bd94fe Auto merge of #4163 - lzutao:doc-fix-foo-example, r=phansch 
doc: Remove `pub` from trait definition in foo lint example

changelog: none
 2019-06-03 07:59:30 +00:00
bors
5ab867c7f9 Auto merge of #4169 - lzutao:bump-cargo_metadata, r=Manishearth 
Bump cargo metadata

Sorry, I forgot to bump `cargo_metadata` in sub-crates.

changelog: none

r? @matthiaskrgr
 2019-06-03 02:39:06 +00:00
Lzu Tao
352f183429 Bump clap in clippy_dev 2019-06-03 09:36:23 +07:00
Lzu Tao
3fb497c8c8 Do not install rustup-toolchain if it is in PATH 2019-06-03 09:23:15 +07:00
Lzu Tao
6c9ee51ecc Bump cargo_metadata of clippy_lints 2019-06-03 09:13:33 +07:00
BO41
dd007e4477 Change from ignore to rust 2019-06-02 20:06:50 +02:00
bors
b0ec33f661 Auto merge of #4166 - mati865:rustup, r=Manishearth 
Rustup for https://github.com/rust-lang/rust/pull/61276

changelog: none
 2019-06-02 17:07:33 +00:00
Mateusz Mikuła
a3ace5c3ca Cargo fmt 2019-06-02 18:58:11 +02:00
Mateusz Mikuła
9fefe36737 Rustup for https://github.com/rust-lang/rust/pull/61276 2019-06-02 18:30:40 +02:00
BO41
bd8f289247 Add example to needless_range_loop 2019-06-02 15:28:32 +02:00
bors
f5d6804911 Auto merge of #4160 - lzutao:bump-cargo_metadata, r=matthiaskrgr 
Bump cargo_metadata to 0.8.0

changelog: none
 2019-06-02 13:11:34 +00:00
bors
647cc4026f Auto merge of #4159 - lzutao:into-outer_expn_info, r=matthiaskrgr 
Make use of new `outer_expn_info()` function

Find by simple command: `git grep -w expn_info`.

changelog: none

Closes #4151
 2019-06-02 10:01:50 +00:00
Michael Wright
98585a0324 Fix .map(..).unwrap_or_else(..) bad suggestion 
Closes #4144
 2019-06-02 08:50:20 +02:00
Lzu Tao
7f8e7c0772 doc: Remove pub from trait definition in foo lint example 2019-06-01 19:51:49 +07:00
Lzu Tao
d6f580d62b Bump cargo_metadata to 0.8.0 2019-06-01 16:49:10 +07:00
Lzu Tao
f67c3e4b2a Make use of new outer_expn_info() function 2019-06-01 16:25:51 +07:00
bors
f3087c37bf Auto merge of #4158 - phansch:rustup_tests, r=Manishearth 
Fix ellipsis_inclusive_range_patterns lint warnings

Changed from `allow` to `warn` in https://github.com/rust-lang/rust/pull/61342

changelog: none
 2019-06-01 05:57:58 +00:00
Philipp Hansch
6feef17071
Fix ellipsis_inclusive_range_patterns lint warnings 
Changed from `allow` to `warn` in https://github.com/rust-lang/rust/pull/61342
 2019-06-01 07:54:47 +02:00
Andy Russell
2d0c797da6
add suggestions for print/write with newline lint 2019-05-30 13:46:04 -04:00
bors
b1762e3e4a Auto merge of #4157 - phansch:update_pulldown_cmark2, r=matthiaskrgr 
Update pulldown_cmark to 0.5.2

Includes various parsing fixes. Most notably [this PR][pr]

changelog: none

[pr]: https://github.com/raphlinus/pulldown-cmark/pull/325
 2019-05-30 12:07:48 +00:00
bors
0ab3f1762e Auto merge of #4113 - rust-lang:author, r=flip1995 
Fix `Block`  dump in author lint

changelog: The `#[clippy::author]` attribute now emits correct pattern code for block expressions
 2019-05-30 10:34:56 +00:00
Philipp Hansch
a34991228a
Update pulldown_cmark to 0.5.2 
Includes various parsing fixes. Most notably [this PR][pr]

[pr]: https://github.com/raphlinus/pulldown-cmark/pull/325
 2019-05-30 12:26:22 +02:00
bors
d2f5122815 Auto merge of #4155 - phansch:rustup_trait_obj, r=oli-obk 
Rustup to https://github.com/rust-lang/rust/pull/61203

See https://github.com/rust-lang/rust/pull/61203

Migrates all trait objects to use `dyn` in our ui tests

changelog: none
 2019-05-30 07:29:28 +00:00
Philipp Hansch
2c72026fcb
Rustup to https://github.com/rust-lang/rust/pull/61203 
Migrates all trait objects to use `dyn`
 2019-05-30 08:31:09 +02:00
bors
018fa30c56 Auto merge of #4153 - matthiaskrgr:rustup_5, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/60928

changelog: none
 2019-05-29 20:01:57 +00:00
Matthias Krüger
22e77dfa98 rustup https://github.com/rust-lang/rust/pull/60928 2019-05-29 00:41:34 +02:00
bors
a05f18e794 Auto merge of #4152 - matthiaskrgr:rustup_4, r=matthiaskrgr 
rustup https://github.com/rust-lang/rust/pull/61164

(which is included in https://github.com/rust-lang/rust/pull/61274)

changelog: none
 2019-05-28 22:26:50 +00:00
Matthias Krüger
c9cc11e9fa rustup https://github.com/rust-lang/rust/pull/61164 
(which is included in https://github.com/rust-lang/rust/pull/61274)
 2019-05-28 20:47:16 +02:00
Oliver Scherer
3908d86f8a
Don't rustfmt author test 
Co-Authored-By: Philipp Krones <hello@philkrones.com>
 2019-05-28 15:34:25 +02:00
Oliver Scherer
f98e4bd33b
Fix Block dump in author lint 2019-05-28 13:01:11 +02:00
bors
fb33fad08e Auto merge of #4142 - agnxy:rename-assoc, r=flip1995 
Rename "Associated*" to "Assoc*"

This is to fix the breakage introduced by rust-lang/rust#60163.

changelog: none
 2019-05-28 08:59:06 +00:00
bors
d57845ffdf Auto merge of #4071 - matthiaskrgr:sizeof, r=flip1995 
trivially_copy_pass_by_ref: print size of type and limit in the lint message

changelog: trivially_copy_pass_by_ref: print size of type and limit in the lint message
 2019-05-28 07:56:04 +00:00
bors
e119ab402f Auto merge of #4150 - rust-lang:rustup, r=oli-obk 
Rustup to rustc 1.36.0-nightly (fa40a111f 2019-05-27)

changelog: none
 2019-05-27 19:59:33 +00:00
Oliver Scherer
73d1830812 Rustup to rustc 1.36.0-nightly (fa40a111f 2019-05-27) 2019-05-27 21:58:54 +02:00
bors
7b501f0f6a Auto merge of #4137 - euclio:let-return, r=oli-obk 
tweak `let_and_return` diagnostic

changelog: `let_and_return`: label the unnecessary let binding and convert the note to a structured
suggestion
 2019-05-27 13:04:14 +00:00
bors
eb0a2884d2 Auto merge of #4149 - flip1995:rollup-6knpdqb, r=flip1995 
Rollup of 2 pull requests

Successful merges:

 - #4102 (Fix match_same_arms to fail late)
 - #4119 (Improve non ascii literal)

Failed merges:

r? @ghost
 2019-05-27 11:33:29 +00:00
Philipp Krones
dce670c73c
Rollup merge of #4119 - BO41:non_ascii_literal, r=flip1995 
Improve non ascii literal

This PR improves the example of the [non_ascii_literal](https://rust-lang.github.io/rust-clippy/master/index.html#non_ascii_literal) lint.
It also makes it auto-fixable.

Please review. This is my first PR to this project.
(Thanks @flip1995 for the help :)

changelog: none
fixes #4117
 2019-05-27 13:09:17 +02:00
Philipp Krones
f0a767352b
Rollup merge of #4102 - Urriel:fix/4096_match_same_arms, r=flip1995 
Fix match_same_arms to fail late

Changes:
- Add a function search_same_list which return a list of matched expressions
- Change the match_same_arms implementation behavior. It will lint each same arms found.

fixes #4096

changelog: none
 2019-05-27 13:09:16 +02:00
bors
cf81a3b6d0 Auto merge of #3832 - HarrisonMc555:use_last, r=flip1995 
Implement "Use last" lint

Closes #3673

This lint checks the use of `x.get(x.len() - 1)` and suggests `x.last()` (where `x` is a `Vec`).

There's at least one more thing that needs to happen here. I believe I am correctly checking most of the scenarios and avoiding false positives. However, if different `Vec`s are used for the `x.get` and `y.len`, then it will emit a false positive. In other words, I need to check to make sure the `Vec`s are the same.

Also, a lot of these commits were temporary and not helpful to the project history...am I supposed to squash on merge? If so, how do I do that?

changelog: New lint: `get_last_with_len`
 2019-05-27 11:04:38 +00:00
bors
abe139c7ac Auto merge of #4148 - sanxiyn:typo, r=Manishearth 
Fix typo in comment
 2019-05-27 03:38:19 +00:00
Seo Sanghyeon
2c53a3f970 Fix typo in comment 2019-05-27 12:32:04 +09:00
bors
46e64911ad Auto merge of #4145 - rust-lang:rustup, r=oli-obk 
Rustup to rustc 1.36.0-nightly (2268d9923 2019-05-26)

changelog: none
 2019-05-26 15:36:38 +00:00
Oliver Scherer
637e656451 Rustfmt 2019-05-26 17:36:21 +02:00
Oliver Scherer
fd2ecfcc89 Rustup to rustc 1.36.0-nightly (2268d9923 2019-05-26) 2019-05-26 16:47:26 +02:00
Andrew Xu
dcf064a4f9 Rename "Associated*" to "Assoc*" 
This is to fix the breakage introduced by rust-lang/rust#60163.
 2019-05-25 20:31:34 +08:00
bors
577ee79668 Auto merge of #4141 - phansch:rustup5, r=oli-obk 
Rustup to https://github.com/rust-lang/rust/pull/61026

None
 2019-05-25 07:50:39 +00:00
Philipp Hansch
a650659d63
Rustup to https://github.com/rust-lang/rust/pull/61026 2019-05-25 09:45:07 +02:00
Andy Russell
effea41fe4
tweak let_and_return diagnostic 
Label the unnecessary let binding and convert the note to structured
suggestion.
 2019-05-24 14:52:55 -04:00
bors
d519ed433e Auto merge of #4135 - matthiaskrgr:rustup_obsol, r=phansch 
rustup https://github.com/rust-lang/rust/pull/60803/

changelog: none
 2019-05-24 14:08:09 +00:00