347 commits

Author	SHA1	Message	Date
HMPerson1	3a4ea45821	Fix get_enclosing_block	2018-02-02 01:53:48 -05:00
Frederick Zhang	c5ee8b5dfb	set CodeSuggestion approximate to false. fixes #2429	2018-02-02 16:24:32 +11:00
Devon Hollowood	0413b3f6cf	Add misaligned_transmute lint	2018-01-25 00:48:36 -08:00
Phil Ellison	b73efad600	Add some reviewer comments	2018-01-17 21:06:16 +00:00
Phil Ellison	a64d19cc0e	Fix error span to play nicely with rustfix	2018-01-16 21:20:55 +00:00
Phil Ellison	70a5535ffa	Address some review comments	2018-01-14 18:18:09 +00:00
Phil Ellison	528be23c07	Move get_arg_name into utils	2018-01-14 10:05:01 +00:00
Oliver Schneider	8ddcb81a15	Rustup and lazy_static version mismatch fix ... fixes #2274	2017-12-15 10:05:32 +01:00
Frederick Zhang	e91b01348e	fix usage of LayoutDetails	2017-11-21 16:51:36 +11:00
Oliver Schneider	c6a4eaeb0d	Rustup	2017-11-15 08:38:43 +01:00
Oliver Schneider	299f1270a6	Rustup	2017-11-10 08:58:54 +01:00
topecongiro	7a06d312fd	Cargo fmt	2017-11-05 04:55:56 +09:00
Manish Goregaokar	f76225e388	Handle TyForeign	2017-10-29 05:21:25 -04:00
Alex Burka	24a2c14733	remove if_let_chain	2017-10-23 17:53:30 -04:00
Alex Burka	41840ae3c4	mechanically swap if_let_chain -> if_chain	2017-10-23 15:18:02 -04:00
Paul Florence	406931381b	Fixed some code in clippy to pass the new, removed formatting changes.	2017-10-20 10:17:41 -04:00
sinkuu	5a61d88fa1	Apply suggestions	2017-10-11 22:17:00 +09:00
Oliver Schneider	73a1dd8e7f	Merge pull request #2117 from sinkuu/improve_take_by_value ... Improve needless_pass_by_value	2017-10-08 20:14:55 +02:00
sinkuu	2be6245179	Duplicate ptr_arg's suggestion logic	2017-10-08 17:51:44 +09:00
Chris Emerson	9a0a8a0010	Move has_drop to the utils module.	2017-09-19 21:38:35 +01:00
Andre Bogus	72be166756	add suggestions for .clone() in ptr_arg fns	2017-09-16 09:10:26 +02:00
Oliver Schneider	32a9394490	Rustup	2017-09-13 15:34:04 +02:00
Oliver Schneider	b127ad251f	Rustup	2017-09-12 14:38:59 +02:00
Andre Bogus	e7e8e79020	suggestion for ptr_arg	2017-09-10 19:32:24 +02:00
Aaron Hill	8adc42b5b4	Update for latest Rust ... This is mainly due to https://github.com/rust-lang/rust/commit/dead08cb33134	2017-09-09 01:23:08 -04:00
Oliver Schneider	e4524ac4de	Run nightly rustfmt	2017-09-05 12:39:27 +02:00
M. Hasbini	ee8c51be00	Fix "further information" link ... "further information" link was missing the `v` part from the url. e.g. wrong (404 notfound): https://rust-lang-nursery.github.io/rust-clippy/0.0.157/index.html#map_entry correct: https://rust-lang-nursery.github.io/rust-clippy/v0.0.157/index.html#map_entry	2017-09-04 20:03:51 +03:00
Oliver Schneider	045139613a	Link to current versions docs instead of master docs	2017-09-01 12:34:10 +02:00
Oliver Schneider	ff91c6359a	wiki -> docs	2017-09-01 12:34:10 +02:00
Oliver Schneider	c64073b2f5	Deprecate the wiki and remove the lint list from the README (fixes #1933)	2017-09-01 12:34:05 +02:00
Oliver Schneider	a8cf4e8ecb	Accessing Span internals is deprecated	2017-08-31 14:47:45 +02:00
Oliver Schneider	9d6c0feef2	Rustup (fixes #2002)	2017-08-30 10:54:41 +02:00
Alexey Zabelin	695bedbe27	Rename match_path_old to match_path ... The old `match_path` was renamed to `match_qpath`. As per #1983.	2017-08-24 20:42:50 -04:00
Andre Bogus	6d989c729d	add closure arg check, also catch non-consts	2017-08-23 17:54:35 +02:00
Oliver Schneider	2430e06a60	Run Dogfood for use_self	2017-08-21 13:32:12 +02:00
Oliver Schneider	b005748b85	Merge pull request #1971 from Frederick888/fix-1970 ... Try to fix #1970	2017-08-21 09:35:59 +02:00
Oliver Schneider	5e5478a3c3	Merge pull request #1931 from rust-lang-nursery/move_links ... Change all links to reflect the move to rust-lang-nursery	2017-08-21 09:35:19 +02:00
Frederick Zhang	f770d15350	use CompilerDesugaringKind	2017-08-19 18:03:29 +10:00
Oliver Schneider	f3ae929b2d	Rustup	2017-08-15 11:10:49 +02:00
Oliver Schneider	4470d7a8ca	Merge branch 'master' into move_links	2017-08-14 10:07:26 +02:00
Oliver Schneider	459cf467c5	Rustup	2017-08-14 09:54:47 +02:00
Oliver Schneider	b25b6b3355	Rustfmt	2017-08-14 09:43:26 +02:00
Andre Bogus	f515d7bb67	Change all links to reflect the move to rust-lang-nursery	2017-08-06 23:10:55 +02:00
Oliver Schneider	3a61b452a2	Create a lint authoring helper (generates matching code)	2017-08-01 12:55:52 +02:00
Matt Kraai	de3bdf5826	Set show_code_when_inline to true ... Fixes #1902	2017-07-24 06:37:12 -07:00
Oliver Schneider	a82cd77b2b	Rustup to *rustc 1.20.0-nightly (d84693b93 2017-07-09)*	2017-07-10 10:17:40 +02:00
Oliver Schneider	23b4ad501f	Run rustfmt	2017-06-29 16:07:43 +02:00
messense	8ac0388307	Fix compilation on rustc 1.20.0-nightly (69c65d296 2017-06-28)	2017-06-29 21:38:25 +08:00
Manish Goregaokar	55cb63adfe	Bump to 0.0.139	2017-06-10 22:07:09 -07:00
Eduard-Mihai Burtescu	e073dfe9a2	Abide by the common rustc::ty conventions.	2017-06-11 05:57:25 +03:00
Eduard-Mihai Burtescu	cd89737b21	Update for rustc 1.19.0-nightly (4bf5c99af 2017-06-10).	2017-06-11 05:34:47 +03:00
Anders Kaseorg	00b43687e5	Pass extra parameter to CrateStore::item_children for rustc nightly ... rust-lang/rust#42507 Signed-off-by: Anders Kaseorg <andersk@mit.edu>	2017-06-10 01:41:17 -04:00
Eduard-Mihai Burtescu	010974fafe	Finish rustup.	2017-06-05 00:28:01 +03:00
mcarton	edef6c53c0	Continue work on rustup	2017-06-04 20:42:13 +02:00
messense	67cccc5c16	Try to fix compilation error on rustc 1.19.0-nightly (4ed2edaaf 2017-06-01)	2017-06-02 12:13:04 +08:00
Manish Goregaokar	8d3c48601d	Rustup to rustc 1.19.0-nightly (557967766 2017-05-26)	2017-05-26 22:25:58 -07:00
Oliver Schneider	ff873cc900	Rustup to rustc 1.19.0-nightly (5b13bff52 2017-05-23)	2017-05-24 14:19:30 +02:00
messense	30b94b0fb0	Fix build failure on rustc 1.19.0-nightly (0ed1ec9f9 2017-05-18)	2017-05-19 16:54:02 +08:00
Oliver Schneider	4d5e25f31d	Update to rustc 1.19.0-nightly (826d8f385 2017-05-13) ... fixes #1759, #1758	2017-05-14 09:56:10 +02:00
Oliver Schneider	1522a4913f	Run rustfmt	2017-05-03 14:13:50 +02:00
Oliver Schneider	b84e71c2b1	Update to latest nightly	2017-05-02 16:56:36 +02:00
Oliver Schneider	3b73663506	Update to latest rustc version	2017-04-27 14:00:35 +02:00
Oliver Schneider	68369e5d37	Merge remote-tracking branch 'origin/master' into yati_master	2017-04-25 10:31:40 +02:00
Mrmaxmeier	89f0f323bb	Rustup to 1.18.0-nightly (d5cf1cb64 2017-04-15)	2017-04-16 18:38:17 +02:00
Yati Sagade	cac15d24f9	needless_continue: Remove indentation of suggestion code. ... As per a suggestion by Oliver on the PR thread, maintaining indentation in the suggested code is futile because of the changes in the compiler and the messiness of real-world code. rustfmt will do the indentation if required, so we don't need to do it.	2017-04-13 21:48:52 +02:00
Oliver Schneider	5842463562	Run rustfmt	2017-04-12 11:06:32 +02:00
Oliver Schneider	7ee0d4f9c2	Dogfood tests	2017-04-12 10:55:34 +02:00
Yati Sagade	8ea6d6a8d2	needless_continue: Refactor to use stuff from utils, and move some stuff to utils. ... I had my own implementation of what `trim_multiline()` seems to be doing, so I just started using `trim_multiline()`. Some other functions, like those block alignment, are general enough to be used elsewhere, so moved them to utils.	2017-04-09 14:07:11 +02:00
Oliver Schneider	a679f41fa3	Fix fallout	2017-04-06 16:49:13 +02:00
Oliver Schneider	6d921b4734	fix various rustup failures	2017-04-06 16:48:48 +02:00
Enrico Schmitz	7a4f7c335b	Remove unused cs parameter for is_macro and friends	2017-04-01 00:14:04 +02:00
Enrico Schmitz	8f9fb97eb6	First try for a fix for rustc 1.18.0-nightly (5c94997b6 2017-03-30	2017-03-31 19:23:35 +02:00
Oliver Schneider	0ae1a77a2e	Do some additional cleanup around InternedString and Symbol	2017-03-30 10:21:13 +02:00
Oliver Schneider	d9e69a70df	Fix fallout	2017-03-30 09:46:04 +02:00
Enrico Schmitz	f8df4aed0f	Fix for rustc 1.17.0-nightly (6eb9960d3 2017-03-19)	2017-03-21 00:22:19 +01:00
Oliver Schneider	40d50fe8b2	Don't lint nan_cmp and zero_ptr in constants	2017-03-07 12:58:07 +01:00
Oliver Schneider	2a8fca599b	Mostly apply rustfmt	2017-03-05 10:27:20 +01:00
Oliver Schneider	ac48e09255	Simplify snippet body by forwarding to snippet_opt	2017-03-03 16:56:35 +01:00
Oliver Schneider	51295960bf	Fix invalid_upcast_comparisons lint for same size sign casts	2017-03-02 10:41:20 +01:00
Enrico Schmitz	7e24e1db09	Using f.unsafety() instead of f.skip_binder().unsafety	2017-03-01 14:46:35 +01:00
Enrico Schmitz	f66e0aad84	Fix for rustc 1.17.0-nightly (be760566c 2017-02-28)	2017-03-01 13:24:19 +01:00
Oliver Schneider	b9f183d31f	rustup	2017-02-27 09:45:02 +01:00
sinkuu	5906639af5	Enable len_zero for slices	2017-02-25 12:26:33 +09:00
Oliver Schneider	d032b8967c	Merge pull request #1491 from Manishearth/into_iter_on_ref ... fix explicit_into_iter_loop on references	2017-02-21 14:55:52 +01:00
Oliver Schneider	c46178c518	rustfmt	2017-02-21 12:01:41 +01:00
Oliver Schneider	c1cf5a2cde	cleanup and create another helper function that we should use more often	2017-02-21 12:01:41 +01:00
sinkuu	3516d45d7c	Use multispan_sugg	2017-02-21 18:44:31 +09:00
sinkuu	8cb2ec804d	Support generic type	2017-02-18 10:14:25 +09:00
Mrmaxmeier	2216a890a6	TyCtxt::map is now called TyCtxt::hir	2017-02-03 14:16:07 +01:00
Oliver Schneider	26e8558d8a	remove rustc-serialize dependency and factor util::cargo out into a crate	2017-01-26 11:31:26 +01:00
Pascal Hertleif	6f103de164	Rustup to nightly from 2017-01-20 ... Adjust `multispan_sugg` to rust-lang/rust#38955	2017-01-21 17:20:01 +01:00
Oliver Schneider	713da45906	apply rustfmt	2017-01-17 19:30:32 +01:00
Oliver Schneider	d944d7df9a	rustup to 2017-01-12	2017-01-13 17:04:56 +01:00
sinkuu	a2bcce9dbf	Move is_try to util ... Removed unnecessary condition Also changed lint span of `try` from surrounded expression to entire `try` invocation. It turned out that compiletest misses errors for macro invocations.	2017-01-07 23:52:48 +09:00
Manish Goregaokar	ab42f02003	Rerun rustfmt	2017-01-04 15:53:16 -08:00
Manish Goregaokar	d6dd65620e	Rustup to rustc 1.16.0-nightly (468227129 2017-01-03): Fix self type	2017-01-04 15:50:54 -08:00
Manish Goregaokar	e02fac4896	Rustup to rustc 1.16.0-nightly (468227129 2017-01-03): Recover patterns from arguments	2017-01-04 15:50:43 -08:00
Manish Goregaokar	a262e3bb0b	Rustup to rustc 1.16.0-nightly (468227129 2017-01-03): Eliminate has_self util	2017-01-04 15:50:37 -08:00
Josh Holmer	5aea0b2062	Rustup to rustc 1.16.0-nightly (468227129 2017-01-03): u128 fixes for rustup	2017-01-04 15:50:34 -08:00
Josh Holmer	64f5dbc9f8	Rustup to rustc 1.16.0-nightly (468227129 2017-01-03): Body fixes for rustup	2017-01-04 15:50:30 -08:00
Oliver Schneider	47eead5ada	function definition style simplification	2016-12-21 12:14:54 +01:00
Oliver Schneider	ed9d71f2c9	remove nondeterminism by adjusting thresholds	2016-12-21 10:25:14 +01:00
Oliver Schneider	299d7be132	rustfmt fallout in doc comments	2016-12-21 10:00:13 +01:00
Oliver Schneider	44533f09aa	rustfmt round n	2016-12-21 09:45:24 +01:00
Oliver Schneider	4a4e1ea2c5	also run rustfmt on clippy-lints	2016-12-20 18:21:30 +01:00
Arnavion	3de6f9db20	Use inputs/output getters for rustc::ty::FnSig instead of the now non-existent fields.	2016-12-10 23:57:19 -08:00
Oliver Schneider	c6e2967b9c	rustup to rustc 1.15.0-dev (3b248a184 2016-12-05)	2016-12-06 11:32:21 +01:00
mcarton	1ba8ed96cf	Fix dogfood	2016-12-02 22:33:16 +01:00
Oliver Schneider	16aab71688	enum glob use and copies left	2016-12-02 17:38:31 +01:00
Oliver Schneider	59b0077565	WIP compiles and doesn't crash (much) but tests are failing	2016-12-01 22:31:56 +01:00
mcarton	c7e3cc1e27	Rustup to *rustc 1.15.0-nightly (3bf2be9ce 2016-11-22)*	2016-11-23 22:44:00 +01:00
mcarton	c35f82b823	Rustup to *rustc 1.15.0-nightly (7b3eeea22 2016-11-21)*	2016-11-23 21:31:55 +01:00
mcarton	945c027768	Handle closure with single expression blocks	2016-11-17 19:44:18 +01:00
mcarton	19c5f5394b	Rustup to rustc 1.15.0-nightly (0ed951993 2016-11-14)	2016-11-16 23:05:26 +01:00
Oliver Schneider	a56af73fd8	mark cyclomatic complexity attribute as used ... fixes #1315	2016-11-02 10:29:57 +01:00
Sebastian Ullrich	90f71be4e9	factor out is_automatically_derived util fn	2016-10-30 14:25:06 -04:00
Oliver Schneider	f29ab8c245	Merge branch 'master' of github.com:Manishearth/rust-clippy into deep_code_inspection	2016-10-24 10:39:19 +02:00
mcarton	1c3fce41b6	Rustup to *rustc 1.14.0-nightly (f09420685 2016-10-20)*	2016-10-22 15:57:19 +02:00
Oliver Schneider	ff3efc759e	initial implementation of the code inspector lint	2016-10-18 16:57:39 +02:00
mcarton	0475eae1fa	Rustup to *rustc 1.14.0-nightly (3210fd5c2 2016-10-05)*	2016-10-06 17:46:50 +02:00
mcarton	4f91d66905	Rustup to *rustc 1.14.0-nightly (144af3e97 2016-10-02)*	2016-10-03 21:25:27 +02:00
mcarton	4f3920307a	Rustup to *rustc 1.13.0-nightly (d0623cf7b 2016-09-26)*	2016-09-28 01:09:11 +02:00
mcarton	c8986b4676	Fix FP with WHILE_LET_ON_ITERATOR and refutable pats	2016-09-16 15:50:35 +02:00
mcarton	90c390ec2a	Fix typo ... Who cares? Meh, consistency.	2016-09-16 15:45:19 +02:00
mcarton	ab6669a641	Rustup to *rustc 1.13.0-nightly (f1f40f850 2016-09-09)*	2016-09-10 19:13:49 +02:00
mcarton	d87f137254	Add a builtin_type_shadow lint	2016-08-28 19:56:18 +02:00
mcarton	189c5e5cfc	Rustup to rustc 1.13.0-nightly (a23064af5 2016-08-27)	2016-08-28 17:25:58 +02:00
Oliver Schneider	40720a61e8	rustup for the ! type	2016-08-17 17:58:15 +02:00
David Tolnay	95df2d1bf4	Update to rustc 1.12.0-nightly (1deb02ea6 2016-08-12)	2016-08-13 14:23:38 -07:00
Oliver Schneider	81c5757f44	lint on by ref patterns for references	2016-08-01 16:59:14 +02:00
llogiq	a371558bdb	Merge pull request #1093 from oli-obk/serde_specific_lint ... lint on implementing `visit_string` without also implementing `visit_str`	2016-07-18 11:53:28 +02:00
Oliver Schneider	02c46f057f	add an internal lint that catches misordered paths	2016-07-18 11:19:33 +02:00
mcarton	ea665c38f1	Fix FP with USELESS_VEC and non-copy types	2016-07-14 19:31:17 +02:00
mcarton	7778f314f2	Merge branch 'master' into sugg	2016-07-04 00:51:19 +02:00
mcarton	7781f1d7c5	Add a new not_unsafe_ptr_arg_deref lint	2016-07-03 13:28:34 +05:30
mcarton	e613c8b492	Introduce multispan_sugg	2016-07-01 18:43:42 +02:00
mcarton	4dff4df577	Move more functions to utils::higher	2016-07-01 17:12:49 +02:00
mcarton	92b04129fe	Move unsugar_range to utils::higher	2016-07-01 17:12:49 +02:00
mcarton	9811dea237	Add a module to pretty-print suggestions	2016-07-01 17:12:48 +02:00
Oliver Schneider	799861d7e0	use span_lint_and_then instead of adding to the DiagnosticWrapper	2016-06-27 17:14:04 +02:00
Oliver 'ker' Schneider	8c5e617c9a	don't lint on comparing *const f32s	2016-06-25 18:59:37 +02:00
mcarton	d85b8062e3	Format all if_let_chain consistently	2016-06-10 00:09:17 +02:00
mcarton	90453fd893	Run rustfmt ... Only partially apply suggestions.	2016-06-10 00:08:14 +02:00
mcarton	a7a6c0461d	Add environment variable to deactivate wiki links	2016-06-05 22:03:02 +02:00
Oliver Schneider	80e81d351d	add version check to the unit tests	2016-05-30 12:47:04 +02:00
mcarton	a892a96eeb	Rustup to *1.10.0-nightly (7bddce693 2016-05-27)*	2016-05-28 16:35:38 +02:00
Oliver Schneider	bf227f4729	split clippy into lints, plugin and cargo-clippy	2016-05-27 13:03:58 +02:00

Renamed from src/utils/mod.rs (Browse further)