Commit graph

17240 commits

Author SHA1 Message Date
Manish Goregaokar
0e658afc1b Fix mut_mut false positive, make Allow (fixes #309) 2015-09-08 02:29:13 +05:30
llogiq
54932dee1c Merge pull request #312 from Manishearth/pub_convention
split wrong_self_convention in pub/default visibility part
2015-09-07 11:54:47 +02:00
llogiq
e43f2d7e54 damn autocorrect 2015-09-07 11:49:35 +02:00
llogiq
c79d884450 replace if let by equality check 2015-09-07 11:46:04 +02:00
llogiq
92b04cd75d split wrong_self_convention in pub/default visibility part 2015-09-07 09:17:45 +02:00
Manish Goregaokar
f4c28f8521 Merge pull request #310 from Manishearth/len_zero
fix false positive len_zero in is_empty()
2015-09-07 00:39:24 +05:30
Andre Bogus
468b410d04 de-closured the item name getter 2015-09-06 21:03:09 +02:00
Andre Bogus
87e6099ad7 fix false positive len_zero in is_empty() 2015-09-06 20:57:06 +02:00
llogiq
1569fd8c55 Merge pull request #308 from Manishearth/unit_cmp
macro check for unit_cmp
2015-09-06 19:46:21 +02:00
Andre Bogus
391a5135e8 fixed build 2015-09-06 19:44:54 +02:00
Andre Bogus
0c74304f7b macro check for unit_cmp 2015-09-06 19:41:09 +02:00
Manish Goregaokar
459ef55b25 Merge pull request #304 from Manishearth/bit_mask
fixed bad_bit_mask false positive
2015-09-06 20:04:43 +05:30
Andre Bogus
b76ad366ab fixed bad_bit_mask false positive 2015-09-06 16:09:35 +02:00
llogiq
dc32092ee4 Merge pull request #303 from inrustwetrust/master
Don't show the explicit_iter_loop lint for arrays with more than 32 elements
2015-09-06 13:49:04 +02:00
inrustwetrust
efd553c8a9 Don't show the explicit_iter_loop lint for arrays with more than 32 elements
The IntoIterator trait is currently not implemented for arrays with more than
32 elements, so for longer arrays, the iter() or iter_mut() methods must be
used.
2015-09-06 13:36:21 +02:00
llogiq
1a7db7892d Merge pull request #302 from Manishearth/macro
More strict macro check
2015-09-06 12:55:15 +02:00
Andre Bogus
55729b7caa dogfooding a newly caught problem 2015-09-06 10:59:06 +02:00
Andre Bogus
54393f0ef5 More strict macro check 2015-09-06 10:53:55 +02:00
Manish Goregaokar
d9ecd0b965 bump 2015-09-06 05:47:51 +05:30
llogiq
8be8d84fa0 Merge pull request #300 from Manishearth/minmax
new lint: min_max
2015-09-05 16:27:09 +02:00
llogiq
79bf820170 added test against const lookup 2015-09-05 16:24:41 +02:00
llogiq
b66bccc45a update_lints 2015-09-05 14:22:33 +02:00
llogiq
3848756be0 Made min_max Warn by default 2015-09-05 14:20:35 +02:00
llogiq
b90e4c7bd5 hir naming, removed lookup, match full path 2015-09-05 13:15:18 +02:00
llogiq
cd91110ec0 new lint: min_max 2015-09-05 12:46:34 +02:00
llogiq
0c50d763fc Merge pull request #299 from Manishearth/unicode_str
Unicode lints, second attempt: Lint whole strings, help with replacement

This fixes #85
2015-09-04 14:27:26 +02:00
llogiq
28212e4981 fixed dogfood by using snippet instead of the (escaped) literal string 2015-09-04 14:24:49 +02:00
Manish Goregaokar
fb148a50b2 Add false positive checks to unicode test 2015-09-04 16:27:53 +05:30
llogiq
e11fd49b1c Unicode lints, second attempt: Lint whole strings, help with replacement 2015-09-04 16:18:46 +05:30
Manish Goregaokar
af4d7f9b60 Merge pull request #298 from birkenfeld/as_mut
methods: allow &mut self for as_ methods
2015-09-04 16:16:58 +05:30
Manish Goregaokar
2e412269ac Merge pull request #295 from Manishearth/hir3
Update rust to 0efb9dab8c7c07fa28e9df0eccc5c07ea3c17fbb
2015-09-04 16:14:21 +05:30
Georg Brandl
d659d039b6 methods: allow &mut self for as_ methods 2015-09-04 07:56:52 +02:00
Manish Goregaokar
eca185438b Update rust to 0efb9dab8c7c07fa28e9df0eccc5c07ea3c17fbb (HIR+lints, Thu Sep 3 18:59:56 2015 +0530)
fixes #294
2015-09-03 23:12:19 +05:30
Manish Goregaokar
5b7ec55fc2 Merge pull request #290 from Manishearth/float-cmp
also ignore `ne` functions
2015-09-03 15:49:54 +05:30
llogiq
cb571bf2e2 also ignore functions 2015-09-03 10:57:11 +02:00
Manish Goregaokar
2c3dd4a200 Merge pull request #286 from Manishearth/fix-ice
Fix ICE
2015-09-03 02:17:39 +05:30
Manish Goregaokar
fbdba7f915 Fix ICE 2015-09-03 02:15:02 +05:30
Georg Brandl
d3c53e307d Merge pull request #285 from Manishearth/contains_self
shadow: complete coverage of "contains_self" checker
2015-09-02 18:29:52 +02:00
Georg Brandl
7649d1c2a8 shadow: complete coverage of "contains_self" checker 2015-09-02 18:24:46 +02:00
llogiq
8edc87e3bd Merge pull request #284 from birkenfeld/is_methods
methods: allow multiple self kinds for "is_" methods
2015-09-02 17:21:42 +02:00
Georg Brandl
6b589681c9 methods: allow multiple self kinds for "is_" methods
These can be static method predicates.  (Found one in rust-copperline,
called Term::is_unsupported_term().)
2015-09-02 17:14:27 +02:00
Georg Brandl
2e7496ae7c Merge pull request #283 from birkenfeld/wording
don't say "did you mean to" - use the standard "consider..."
2015-09-02 17:13:08 +02:00
Georg Brandl
846c164709 don't say "did you mean to" - use the standard "consider..."
"Did you mean to ..." sounds a bit condescending to me, since
if I meant to write "if let" I probably wouldn't have written "match" :)
2015-09-02 16:46:14 +02:00
llogiq
a9869e6fe4 Merge pull request #280 from Manishearth/fx-279
Only handle ranges starting with 0 for needless_range_loop (fixes #279)
2015-09-02 12:44:21 +02:00
Manish Goregaokar
73c34e12b3 Only handle ranges starting with 0 for needless_range_loop (fixes #279) 2015-09-02 16:11:54 +05:30
Manish Goregaokar
eb3b9b35da Merge pull request #276 from Manishearth/float_cmp
check item name for eq, fixes #268
2015-09-02 15:47:41 +05:30
llogiq
0c7f05dd76 check item name for eq, fixes #268 2015-09-02 10:30:11 +02:00
llogiq
2086f97bbd Merge pull request #275 from Manishearth/shadow
extended pattern matching
2015-09-02 08:56:12 +02:00
llogiq
0fb7d1d2d9 reporting improvements 2015-09-02 08:19:47 +02:00
llogiq
bc1eb84810 match region patterns 2015-09-02 07:56:13 +02:00