Philipp Hansch
3f978afe8d
Update CONTRIBUTING.md for rustfix tests
2018-12-28 20:53:44 +01:00
Philipp Hansch
7d9bf99df1
Update .fixed files via update-references.sh
2018-12-28 20:53:44 +01:00
Philipp Hansch
2ccfd52f5d
Run rustfix on first UI test
2018-12-28 20:53:43 +01:00
Philipp Hansch
bd74fdce22
Use WIP branch for compiletest_rs
2018-12-28 20:53:01 +01:00
Peter Fürstenau
8be7050b74
Fix formatting
2018-12-28 20:52:46 +01:00
Peter Fürstenau
6ee0e22204
Merge remote-tracking branch 'upstream/master'
2018-12-28 20:19:51 +01:00
Russell Greene
d127aed737
Merge new_without_default_derive into new_without_default
2018-12-28 10:57:58 -07:00
bors
f7bdf500d9
Auto merge of #3587 - flip1995:ui-testing, r=phansch
...
Use the -Zui-testing flag for compile-test tests
Like `@petrochenkov` suggested in https://github.com/rust-lang/rust-clippy/pull/3581#discussion_r243925691
2018-12-28 17:11:47 +00:00
bors
32b3bc231b
Auto merge of #3591 - flip1995:rustup, r=phansch
...
Match on ast/hir::ExprKind::Err
rustup rust-lang/rust#56999
2018-12-28 14:07:53 +00:00
flip1995
909bfd3cd8
Match on ast/hir::ExprKind::Err
2018-12-28 13:31:19 +01:00
flip1995
d2dbd0b8a5
Update *.stderr files
2018-12-28 12:41:12 +01:00
flip1995
9fddb2afce
Use -Zui-testing flag
2018-12-28 12:39:28 +01:00
bors
dfe1232822
Auto merge of #3589 - flip1995:contrib_inactive_prs, r=phansch
...
Mention S-inactive-closed PRs in the CONTRIBUTING.md
Some of these PRs would be great if they could be completed. But I guess no-one would look through closed PRs if they want to contribute. Let's point (new) contributors there by mentioning these PRs in the `CONTRIBUTING.md`
2018-12-27 19:07:21 +00:00
bors
36e3b2e3fb
Auto merge of #3586 - matthiaskrgr:test_fmt_fix, r=oli-obk
...
base tests: switch to nightly toolchain before checking formatting of tests with rustfmt
this errored because rustfmt is not available on the master toolchain
2018-12-27 18:16:18 +00:00
flip1995
b5e545afc2
Mention S-inactive-closed PRs in the CONTRIBUTING.md
2018-12-27 17:34:17 +01:00
Matthias Krüger
38fabcbdf2
tests: fix formatting and update test output
...
fix script one last time™
2018-12-27 17:03:53 +01:00
Matthias Krüger
84ee884cc4
base tests: make sure to fail CI if tests need formatting
2018-12-27 16:56:08 +01:00
Matthias Krüger
bcc309f27d
base tests: switch to nightly toolchain before checking formatting of tests with rustfmt
...
this errored because rustfmt is not available on the master toolchain
2018-12-27 16:56:07 +01:00
bors
721f688eff
Auto merge of #3577 - daxpedda:master, r=flip1995
...
Fix false positives for `implicit_return` and `empty_loop` on macro expansion.
This PR only fixes `implicit_return` and `empty_loop`.
But I suspect this bug may affect a lot of other lints.
2018-12-27 15:21:22 +00:00
bors
44ffda7e76
Auto merge of #3578 - matthiaskrgr:rustc_tools_util, r=oli-obk
...
rustc_tools_util: changes in preparation of release on crates.io
I want to release my [cargo-cache](https://github.com/matthiaskrgr/cargo-cache ) crate on crates.io however it depends on rustc_tools_util, thus I need to publish rustc_tools_util on crates.io first.
This PR expands the Cargo.toml and adds a readme.
2018-12-27 12:27:40 +00:00
bors
c10c515fae
Auto merge of #3585 - matthiaskrgr:rustup, r=phansch
...
rustup https://github.com/rust-lang/rust/pull/57069
2018-12-27 10:48:24 +00:00
Matthias Krüger
99454bc9a1
rustup https://github.com/rust-lang/rust/pull/57069
2018-12-27 11:19:20 +01:00
bors
19af82c0ad
Auto merge of #3579 - matthiaskrgr:tool_lints, r=flip1995
...
update CARGO_CLIPPY_HELP string to suggest tool lints.
2018-12-26 17:35:55 +00:00
daxpedda
2d96ef1315
Rustfmt.
2018-12-26 18:13:33 +01:00
bors
b0a1fac1f6
Auto merge of #3580 - matthiaskrgr:trivial_typos, r=flip1995
...
fix a couple of trivial typos (NFC).
2018-12-26 17:11:47 +00:00
bors
af14342e7b
Auto merge of #3581 - euclio:camel-case, r=flip1995
...
fix breakage from rust-lang/rust#57088
2018-12-26 14:53:17 +00:00
Andy Russell
cd602c8b18
fix breakage from rust-lang/rust#57088
2018-12-25 16:11:28 -05:00
Matthias Krüger
7f5e17f3f1
fix a couple of ftrivial typos (NFC).
2018-12-25 18:22:34 +01:00
Matthias Krüger
5f0617b92f
update CARGO_CLIPPY_HELP string to suggest tool lints.
2018-12-25 17:11:57 +01:00
Matthias Krüger
345fe6d6c6
rustc_tools_util: add readme
2018-12-25 17:03:36 +01:00
Matthias Krüger
6f5c0d2e0a
rustc_tool_utils: expand Cargo.toml with a few keywords in preparation for crates.io release
2018-12-25 16:45:47 +01:00
Philipp Krones
197914439a
Fix macro detection in empty_loop
.
...
Co-Authored-By: daxpedda <1645124+daxpedda@users.noreply.github.com>
2018-12-25 12:57:16 +01:00
daxpedda
a77bcadaa5
Changed macro_backtrace()
to in_macro()
.
2018-12-25 12:48:54 +01:00
daxpedda
b5587a894f
Fix lint detection on macro expansion.
2018-12-24 22:06:08 +01:00
bors
fc24fce73f
Auto merge of #3576 - matthiaskrgr:rustup, r=oli-obk
...
rustup https://github.com/rust-lang/rust/pull/56992
2018-12-23 12:30:43 +00:00
Oliver Scherer
6db409fc0c
FIXME > TODO
2018-12-23 13:29:37 +01:00
Matthias Krüger
ce3e69da1c
rustup https://github.com/rust-lang/rust/pull/56992
2018-12-23 10:42:06 +01:00
bors
52820e588f
Auto merge of #3573 - Vlad-Shcherbina:map_clone_caveat, r=flip1995
...
Document map_clone known problems #498
(cherry picked from commit ada0d2c548
)
This was lost in relicensing (057243f16b
).
However, I [acknowledged](https://github.com/rust-lang/rust-clippy/issues/3099#issuecomment-416482309 ) relicensing so this cherry pick should be fine I guess.
2018-12-22 15:02:50 +00:00
bors
d9cc71fc42
Auto merge of #3341 - HMPerson1:possibly_missing_else, r=phansch
...
Teach `suspicious_else_formatting` about `if .. {..} {..}`
We essentially treat bare blocks `{..}` identically to `if .. {..}`, except for different lint messages.
Fixes #3044
2018-12-22 13:26:22 +00:00
Vlad-Shcherbina
d2c069de1e
Document map_clone known problems #498
...
(cherry picked from commit ada0d2c548
)
2018-12-22 13:44:35 +03:00
bors
19c7885c2a
Auto merge of #3570 - muth:master, r=phansch
...
panic at map_unit_fn.rs:202 for map() without args
map_unit_fn.rs accessed map() arguments before type check which ensures type is Option or Result.
Boiled it down to a simple test case.
FWIW: Found this panic when running clippy against code which used a gtk::Window's map() fn inherited from gtk::WidgetExt http://gtk-rs.org/docs/gtk/trait.WidgetExt.html#tymethod.map
2018-12-22 10:23:57 +00:00
bors
d3c747c752
Auto merge of #3569 - phansch:update_contributing, r=flip1995
...
Change contrib.md hierarchy, link to it from readme
'How Clippy works' and 'How to fix nightly failures' are not exactly part
of 'Writing code'.
2018-12-22 09:18:39 +00:00
Philipp Hansch
cef8f57082
Remove header link
2018-12-22 10:16:52 +01:00
Mark Nieweglowski
d395d45ca7
test: panic at map_unit_fn.rs:202 for map() without args
2018-12-22 01:06:02 -05:00
Mark Nieweglowski
a24853709a
rm unused file map_unit_fn.stderr
...
There is no map_unit_fn.rs whose output would be diffed with map_unit_fn.stderr
map_unit_fn.stderr was renamed 8 months ago from option_map_unit_fn.stderr
but option_map_unit_fn.{stderr,rs} both remain and are in use.
2018-12-22 01:04:03 -05:00
Mark Nieweglowski
c6031221e0
panic at map_unit_fn.rs:202 for map() without args
2018-12-22 00:58:07 -05:00
Philipp Hansch
ff634e2350
Change contrib.md hierarchy, link to it from readme
...
'How Clippy works' and 'How to fix nightly failures' are not exactly part
of 'Writing code'.
2018-12-21 08:11:06 +01:00
HMPerson1
05ae391e2c
Workaround rust-lang/rust#43081
2018-12-20 22:45:44 -05:00
HMPerson1
88564b743e
Teach suspicious_else_formatting
about if .. {..} {..}
2018-12-20 22:45:37 -05:00
bors
80c07d4c28
Auto merge of #3564 - alexcrichton:rustc-driver, r=phansch
...
Link to `rustc_driver` crate in plugin
This is in anticipation for rust-lang/rust#56987 where the
`rustc_driver` crate being linked in will be required to link correctly
against the compiler. In the meantime it should be harmless otherwise!
2018-12-20 05:52:04 +00:00