Commit graph

2586 commits

Author SHA1 Message Date
mcarton
d77ccdc338 Fix USELESS_FORMAT wiki 2016-02-21 13:21:04 +01:00
llogiq
9c36736f51 Merge pull request #692 from mcarton/format
Lint about `format!("string lit")` with no argument
2016-02-21 03:16:41 +01:00
mcarton
1a64a4890c Small cleanup 2016-02-20 21:20:56 +01:00
mcarton
ba3be83488 Lint about format!("{}", foo) 2016-02-20 21:15:05 +01:00
mcarton
b6443b9928 Replace all format!("{}", foo) calls 2016-02-20 21:03:45 +01:00
mcarton
ef4401d4ac Lint about usage of format!("string literal") 2016-02-20 17:46:20 +01:00
mcarton
222086d62b Remove all use of format!("string literal") 2016-02-20 17:46:20 +01:00
mcarton
5fe6e9f911 Build the import lint in update_lints.py 2016-02-20 17:46:16 +01:00
quininer kel
35a48bf512 fix nightly
9b40e1e5b3
2016-02-19 04:16:39 +08:00
Manish Goregaokar
78b31c61bd Merge pull request #688 from Manishearth/fix-671
improve str_add_assign lint description
2016-02-19 01:43:23 +05:30
mcarton
aa1df8e9ff Improve the MAP_ENTRY lint
Don’t span a suggestion when not appropriate but use a note and don’t
force it to be `if !cond`.
2016-02-18 20:19:16 +01:00
llogiq
1fd0676fa3 improve str_add_assign lint description 2016-02-18 20:12:33 +01:00
Martin Carton
eabc54406e Merge pull request #687 from oli-obk/fix_glob_enum_use
fix enum glob use (again)
2016-02-18 16:23:11 +01:00
Oliver Schneider
add483afed fix enum glob use (again) 2016-02-18 16:08:45 +01:00
Manish Goregaokar
05afde821c Merge pull request #673 from oli-obk/fix/665
don't lint on all caps enum variants starting with the same char
2016-02-18 11:12:58 +05:30
Manish Goregaokar
31db60ccc5 Bump and publish to 0.0.41 (fix #683) 2016-02-18 10:52:53 +05:30
Manish Goregaokar
e659ce1437 Merge pull request #664 from Manishearth/fix_regex
remove Visitor from regex_macro
2016-02-18 10:28:12 +05:30
Martin Carton
7250738edf Merge pull request #679 from mcarton/rustup
Rustup to 1.8.0-nightly (57c357d89 2016-02-16)
2016-02-17 15:53:28 +01:00
mcarton
227ff8c4ad Rustup to 1.8.0-nightly (57c357d89 2016-02-16) 2016-02-17 13:38:44 +01:00
Oliver Schneider
cf536d7a4f fallout 2016-02-17 13:33:32 +01:00
Oliver Schneider
e809eb61d7 fix enum_variant_names linting on all caps enum variants 2016-02-17 13:33:32 +01:00
llogiq
59c8f6210b Merge pull request #669 from shssoichiro/single-char-pattern
Lint single-character strings as P: Pattern args
2016-02-16 14:24:22 +01:00
Manish Goregaokar
09ef38b30b Merge pull request #676 from mcarton/hash_eq
Make DERIVE_HASH_NOT_EQ symmetric
2016-02-16 05:20:30 +05:30
mcarton
b5ba621f61 Make DERIVE_HASH_NOT_EQ symmetric 2016-02-16 00:15:11 +01:00
Manish Goregaokar
2641c4e126 Merge pull request #670 from Manishearth/better-ice-fix
Make derive lint handle generics correctly
2016-02-16 04:41:23 +05:30
mcarton
cd35b9e38d Fix wrong reported lint for EXPL_IMPL_CLONE_ON_COPY 2016-02-15 22:29:07 +01:00
Joshua Holmer
b1e4b496e1 Address @ilogiq's nits 2016-02-15 13:36:10 -05:00
Martin Carton
2a0a35c6d0 Merge pull request #674 from mcarton/fix-collapsible_if
Fix suggestion in `COLLAPSIBLE_IF` lint
2016-02-15 17:48:37 +01:00
mcarton
00b27bf7be Fix suggestion in COLLAPSIBLE_IF lint 2016-02-15 17:43:16 +01:00
Joshua Holmer
c22ded11e5 Reword lint documentation
char is faster, proven by benchmark.
2016-02-15 10:32:04 -05:00
Joshua Holmer
643a223f71 Address nits 2016-02-15 09:10:31 -05:00
mcarton
570b963535 Replace potentially ICEgen ast_ty_to_ty_cache 2016-02-15 13:44:59 +01:00
mcarton
d755b1ebe2 Cleanup 2016-02-15 13:25:29 +01:00
Manish Goregaokar
1ca5903138 Make derive lint handle generics correctly 2016-02-15 10:20:26 +05:30
Joshua Holmer
7eea67605a Lint single-character strings as P: Pattern args
Fixes #650
2016-02-14 22:40:43 -05:00
Manish Goregaokar
7843f3f863 Merge pull request #667 from mcarton/fix-ice
Fix ICE in `EXPL_IMPL_CLONE_ON_COPY`
2016-02-15 07:28:58 +05:30
mcarton
1b93d71645 Fix ICE in EXPL_IMPL_CLONE_ON_COPY 2016-02-14 20:31:23 +01:00
llogiq
30a8dfb31a remove Visitor from regex_macro 2016-02-14 16:55:02 +01:00
llogiq
6a624fe77c Merge pull request #662 from mcarton/#601
Fix #601
2016-02-14 12:58:36 +01:00
mcarton
cbe2de7fd2 Address small nit 2016-02-14 12:07:56 +01:00
llogiq
5521a75707 Merge pull request #654 from mcarton/new
Lints about `new` methods
2016-02-13 22:19:36 +01:00
mcarton
4562040d6b Fix false positive in NEEDLESS_RANGE_LOOP 2016-02-13 22:09:17 +01:00
mcarton
d589a2d516 Fix comment 2016-02-13 22:08:15 +01:00
Manish Goregaokar
ed60e41917 Merge pull request #660 from mcarton/copies
Fix false positive for `ifs_same_cond` and `cfg!`
2016-02-13 20:10:21 +05:30
mcarton
49e2501c63 Fix false positive for ifs_same_cond and cfg! 2016-02-13 15:36:57 +01:00
Manish Goregaokar
1e176cae5d Bump twice 2016-02-13 18:04:46 +05:30
Martin Carton
5860ca4cbd Merge pull request #658 from mcarton/rustup
Rustup to 1.8.0-nightly (ce4b75f25 2016-02-12)
2016-02-13 13:20:45 +01:00
mcarton
1efc88f10a Rustup to 1.8.0-nightly (ce4b75f25 2016-02-12) 2016-02-13 13:17:48 +01:00
Manish Goregaokar
d964e18b90 Wrong crate 2016-02-13 17:43:28 +05:30
Manish Goregaokar
26e9dcdf5a Merge pull request #655 from Manishearth/clearer-readme
Clarify readme
2016-02-13 17:38:53 +05:30