Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-26 21:13:31 +00:00
Code Issues Projects Releases Packages Wiki Activity
9000 commits 4 branches 212 tags 149 MiB
Commit graph

9000 commits

This branch
This branch
All branches
Author SHA1 Message Date
bors
cdd134764a Auto merge of #5010 - lzutao:recurse-remove_blocks, r=phansch 
Make utils::remove_blocks non-recursive

changelog: none
 2020-01-07 07:46:00 +00:00
bors
79509bed5d Auto merge of #5002 - lzutao:fmt-fallout, r=flip1995 
build: Use rustfmt from lastest nightly that contains it

changelog: none
 2020-01-07 07:10:58 +00:00
bors
a86301fbfc Auto merge of #4999 - krishna-veerareddy:issue-4679-atomic-ordering, r=phansch 
Add lint to detect usage of invalid atomic ordering

Detect usage of invalid atomic ordering modes such as `Ordering::{Release, AcqRel}` in atomic loads and `Ordering::{Acquire, AcqRel}` in atomic stores.

Fixes #4679

changelog: Add lint [`invalid_atomic_ordering`]
 2020-01-07 06:32:15 +00:00
Yuki Okushi
175c78bc17 Split up collapsible_if ui test 2020-01-07 15:06:23 +09:00
bors
6271f56169 Auto merge of #5009 - lzutao:travis-windows-msvc, r=phansch 
Travis: Use windows-msvc target for Windows build

changelog: none
closes #5005
 2020-01-07 06:03:28 +00:00
Lzu Tao
3801d216e2 Make utils::remove_blocks non-recursive 2020-01-07 10:50:35 +07:00
Lzu Tao
a2b3b5a7b7 Travis: Use windows-msvc target for Windows build 2020-01-07 10:13:33 +07:00
Krishna Sai Veera Reddy
fe21ef4e8b Prevent doc-tests from running and fix lint description 2020-01-06 17:33:28 -08:00
Krishna Sai Veera Reddy
18060eb81e Split test cases into separate files 2020-01-06 16:39:31 -08:00
Krishna Sai Veera Reddy
9e6a6069a7 Add lint to detect usage of invalid atomic ordering 
Detect usage of invalid atomic ordering modes such as
`Ordering::{Release, AcqRel}` in atomic loads and
`Ordering::{Acquire, AcqRel}` in atomic stores.
 2020-01-06 16:39:31 -08:00
bors
62ff63917c Auto merge of #5008 - JohnTitor:let-on-macros, r=flip1995 
Do not trigger `let_and_return` lint on macros

Fixes #4997

changelog: Fix false positive in `let_and_return`
 2020-01-06 22:48:22 +00:00
Yuki Okushi
2213989a01 Do not trigger let_and_return lint on macros 2020-01-07 05:26:20 +09:00
Lzu Tao
abd76076b0 build: Use rustfmt from lastest nightly that contains it 2020-01-07 01:51:49 +07:00
bors
e8642c7a29 Auto merge of #5003 - JohnTitor:rustup, r=flip1995 
Rustup to rust-lang/rust#67886

changelog: none
 2020-01-06 18:15:48 +00:00
Yuki Okushi
65d15340cd Fix test again 2020-01-07 02:04:10 +09:00
Yuki Okushi
ce36335cf0 Pick up lost property 2020-01-07 01:54:51 +09:00
Yuki Okushi
2f2eaf8b7e Rustup to rust-lang/rust#67886 2020-01-07 01:46:33 +09:00
bors
390eacff80 Auto merge of #4998 - JohnTitor:revive-rls, r=llogiq 
Re-enable rls integration test

It seems rls integration test passes correctly: https://travis-ci.com/rust-lang/rust-clippy/builds/143133541

changelog: none
 2020-01-05 19:32:20 +00:00
Yuki Okushi
fe919b4231 Fix space size 2020-01-06 03:16:19 +09:00
Yuki Okushi
2ebcf28b32 Re-enable rls integration test 2020-01-06 01:22:01 +09:00
bors
732825dcff Auto merge of #4996 - JohnTitor:rustup, r=matthiaskrgr 
Rustup to rust-lang/rust#67803 and rust-lang/rust#67137

changelog: none
 2020-01-05 08:41:37 +00:00
Yuki Okushi
17cfc77bd6 Rustup to rust-lang/rust#67137 2020-01-05 15:50:06 +09:00
Yuki Okushi
07f061563d Rustup to rust-lang/rust#67803 2020-01-05 15:50:06 +09:00
bors
a0fdca5a13 Auto merge of #4993 - rust-lang:doc-unsafe-macro-check, r=flip1995 
External macro check for missing_*_doc

This fixes #4949

changelog: none
 2020-01-04 20:50:41 +00:00
Andre Bogus
539cd25262 External macro check for missing_*_doc 2020-01-04 20:19:14 +01:00
bors
d9d20138ec Auto merge of #4966 - bradsherman:iter-nth-zero, r=flip1995 
New Lint: Iter nth zero

Check for the use of `iter.nth(0)` and encourage `iter.next()` instead as it is more readable

changelog: add new lint when `iter.nth(0)` is used

Fixes #4957
 2020-01-04 18:32:33 +00:00
Brad Sherman
ab5ff0352e Add lint for iter.nth(0) 
- Encourage iter.next() rather than iter.nth(0), which is less readable
 2020-01-04 11:20:11 -06:00
Brad Sherman
8ef53bf196 Fix existing iter-nth-zero violations 2020-01-04 09:00:54 -06:00
bors
05b46034ea Auto merge of #4992 - phansch:rustup_foobar, r=matthiaskrgr 
Rustup to https://github.com/rust-lang/rust/pull/67853

Specifically caused by https://github.com/rust-lang/rust/pull/67786

changelog: none
 2020-01-04 12:26:02 +00:00
Philipp Hansch
c5178e82b4
Rustup to https://github.com/rust-lang/rust/pull/67853 
Specifically caused by https://github.com/rust-lang/rust/pull/67786
 2020-01-04 11:30:03 +01:00
bors
fa9b85d4df Auto merge of #4881 - krishna-veerareddy:issue-4871-use-mem-take, r=flip1995 
Use `mem::take` instead of `mem::replace` when applicable

`std::mem::take` can be used to replace a value of type `T` with `T::default()` instead of `std::mem::replace`.

Fixes issue #4871

changelog: Added lint for [`mem_replace_with_default`]
 2020-01-04 08:09:43 +00:00
bors
611bd898c0 Auto merge of #4990 - JohnTitor:remove-try, r=phansch 
Remove use of `try!` from documentation

Makes documentation more modern and directer

changelog: none
 2020-01-04 07:44:04 +00:00
Yuki Okushi
1102b87e3a Remove use of try! from documentation 2020-01-04 13:47:01 +09:00
bors
fddc9801dd Auto merge of #4989 - rust-lang:no-unmangled-must-use, r=flip1995 
No #[no_mangle] must_use_candidate functions

This fixes #4984.

changelog: none
 2020-01-03 17:04:52 +00:00
Andre Bogus
47972cdf12 No #[no_mangle] must_use_candidate functions 2020-01-03 17:21:36 +01:00
bors
2e8c3c3e9e Auto merge of #4975 - JohnTitor:fix-4968, r=phansch 
Fix ICE on `unsound_collection_transmute`

Fixes #4968

Check if `Ty`s are normalizable. It might show hidden false negative, I'm not sure.
Also, the regression tests are placed on two dirs, so move them to `/crashes`. I think it will be easier to find the right place.

changelog: Fix ICE on `unsound_collection_transmute`
 2020-01-03 08:48:05 +00:00
Yuki Okushi
c6aeda7bd5 Move use_self_macro into crashes/auxiliary 2020-01-03 17:03:07 +09:00
bors
304edf39c3 Auto merge of #4978 - mikerite:fix-4958, r=phansch 
Fix bad `explicit_into_iter_loop` suggestion

Fixes #4958

changelog: Fix bad `explicit_into_iter_loop` suggestion
 2020-01-03 05:59:19 +00:00
bors
5b710eef97 Auto merge of #4977 - krishna-veerareddy:issue-4969-replace-consts-fp, r=phansch 
Prevent `replace_consts` lint within match patterns

Currently `replace_consts` lint applies within match patterns but the suggestion is incorrect as function calls are disallowed in them. To fix this we prevent the lint from firing within patterns.

Fixes #4969

changelog: Fix false positive in `replace_consts` lint
 2020-01-02 11:37:19 +00:00
Krishna Veera Reddy
8b36196cb6 Add if let test case 2020-01-01 23:22:57 -08:00
Yuki Okushi
bf67fcf5a9 Move is_normalizable into utils 2020-01-02 11:48:06 +09:00
Yuki Okushi
20318e00ef Add attribute 2020-01-02 09:32:55 +09:00
Michael Wright
ea829bd8c6 Fix bad explicit_into_iter_loop suggestion 
Fixes #4958
 2020-01-01 07:09:09 +02:00
Krishna Veera Reddy
84a60c3186 Prevent replace_consts lint within match patterns 
Currently `replace_consts` lint applies within match patterns but
the suggestion is incorrect as function calls are disallowed in
them. To fix this we prevent the lint from firing within patterns.
 2019-12-31 10:33:15 -08:00
Krishna Veera Reddy
42e4595d3a Indicate anonymous lifetimes for types 2019-12-31 09:22:35 -08:00
Krishna Veera Reddy
a8413a32b3 Remove unnecessary import 2019-12-31 09:22:35 -08:00
Krishna Veera Reddy
c09e79e226 Lint within internal macros without a suggestion 2019-12-31 09:22:35 -08:00
Krishna Veera Reddy
aa66f760c3 Destructure mem:replace arguments 2019-12-31 09:22:35 -08:00
Krishna Veera Reddy
78b4dfc57c Move mem_replace_with_default out of nursery 2019-12-31 09:22:34 -08:00
Krishna Veera Reddy
26812f733d Prevent mem_replace_with_default lint within macros 
Also added test cases for internal and external macros.
 2019-12-31 09:22:34 -08:00