bors
b064ea8096
Auto merge of #5307 - JohnTitor:rename-method, r=flip1995
...
Rustup to rust-lang/rust#69674
changelog: none
2020-03-12 20:05:38 +00:00
flip1995
7b08c7a36e
Change changelog formatting
2020-03-12 21:02:15 +01:00
flip1995
6525127c62
Update changelog_update doc to reflect the actual ordering of the changelog
2020-03-12 21:02:08 +01:00
flip1995
da29402d2e
Update CHANGELOG.md
2020-03-12 21:01:19 +01:00
Yuki Okushi
3e3776666e
Rustup to rust-lang/rust#69674
2020-03-13 04:56:55 +09:00
Shotaro Yamada
d9ad33852c
Use visit_place
2020-03-13 02:06:47 +09:00
Shotaro Yamada
aca64b8df7
Check for mutation
2020-03-13 01:25:18 +09:00
Shotaro Yamada
a377378528
Only fires on temporaries
...
`let y = x.clone()` cannot be turned into `let y = x` without moving x,
regardless of whether `y` is consumed or not.
2020-03-13 00:54:40 +09:00
Shotaro Yamada
9de642190e
Extend redundant_clone
to the case that cloned value is not consumed
2020-03-13 00:31:09 +09:00
bors
fdce47ba7d
Auto merge of #5272 - jmeyers35:file_read_lint, r=flip1995
...
add lint on File::read_to_string and File::read_to_end
Adds lint `verbose_file_reads` which checks for use of File::read_to_end and File::read_to_string.
Closes https://github.com/rust-lang/rust-clippy/issues/4916
changelog: add lint on File::{read_to_end, read_to_string}
2020-03-10 22:35:15 +00:00
bors
9d5ffe8105
Auto merge of #5300 - JohnTitor:edition-flag, r=flip1995
...
Use `edition:2018` flag more widely
Now we recommend using `// edition:2018`, so let's use it more widely.
Also replace a too old example with new one in the docs.
changelog: none
2020-03-10 22:02:41 +00:00
Jacob Meyers
a4ba1027fc
add CR feedback
2020-03-10 18:00:37 -04:00
Yuki Okushi
d4eb496856
Improve documentation
2020-03-11 06:35:46 +09:00
Yuki Okushi
515847dad1
Use edition:2018
flag more widely
2020-03-11 06:35:07 +09:00
bors
23bd427f92
Auto merge of #5298 - rust-lang:needless_doc_main_code, r=flip1995,Manishearth
...
needless_doc_main: only check rust code
This fixes #5280 by checking the language attribute on code blocks.
---
changelog: none
2020-03-10 21:30:44 +00:00
Manish Goregaokar
d5c8b783b8
Update tests/ui/needless_doc_main.rs
...
Co-Authored-By: Philipp Krones <hello@philkrones.com>
2020-03-10 14:30:07 -07:00
bors
16b925b748
Auto merge of #5299 - JohnTitor:contrib, r=flip1995
...
Clean-up docs
Fixes #5268
changelog: none
2020-03-10 21:05:46 +00:00
Yuki Okushi
0de71b0e3a
Move links to the end of each chapter on adding_lints
2020-03-11 06:01:26 +09:00
Yuki Okushi
19e72a24ae
Move links to the end of each chapter on CONTRIBUTING
2020-03-11 05:41:11 +09:00
Yuki Okushi
459fb53f8d
Clean-up adding_lints.md
2020-03-11 05:21:40 +09:00
Yuki Okushi
8cdd75ca29
Clean-up CONTRIBUTING.md
2020-03-11 05:21:40 +09:00
Andre Bogus
2fa3da4869
needless_doc_main: only check rust code
2020-03-10 20:19:37 +01:00
bors
557f6848bd
Auto merge of #5296 - sinkuu:fix_ice_trivial_bounds, r=flip1995
...
Fix ICE with trivial_bounds feature
https://github.com/rust-lang/rust/issues/69874#issuecomment-596890446
changelog: Fix ICE with trivial_bounds feature
2020-03-10 12:25:07 +00:00
bors
3aa8da3e07
Auto merge of #5297 - JohnTitor:shadow, r=phansch
...
Use `node_type_opt` over `node_type`
Fix ICE reported in rust-lang/rust#69873 .
changelog: Fix ICE in checking bindings
2020-03-10 10:37:51 +00:00
Yuki Okushi
8d2a3e0a61
Use node_type_opt
over node_type
2020-03-10 18:18:34 +09:00
Shotaro Yamada
227ef60a2b
Fix doc
2020-03-10 13:28:45 +09:00
Shotaro Yamada
a3d9355bef
Fix ICE with trivial_bounds feature
2020-03-10 13:17:35 +09:00
bors
187bbf0e7b
Auto merge of #5295 - matthiaskrgr:lints_readme, r=flip1995
...
clippy_lints: readme: don't mention crates.io since it is no longer used to publish clippy
changelog: none
2020-03-10 00:09:26 +00:00
Matthias Krüger
5fd74a9a6a
clippy_lints: readme: don't mention crates.io since it is no longer used to publish clippy.
2020-03-10 01:05:54 +01:00
bors
c3d3c50253
Auto merge of #5277 - chrissimpkins:rustc-dev-guide-transition, r=flip1995
...
Update rustc-guide to rustc-dev-guide
The rustc-guide is being renamed to the rustc-dev-guide. The discussion is in rust-lang/rustc-guide#470 .
This PR revises rustc-guide to rustc-dev-guide in the Readme Markdown file.
Transition tracker: rust-lang/rustc-guide#602
changelog: none
2020-03-09 23:46:50 +00:00
Chris Simpkins
58dec1ca9c
update rust-lang.github.io to rustc-dev-guide.rust-lang.org
2020-03-09 17:58:39 -04:00
bors
64b7624141
Auto merge of #5292 - jpospychala:map-placeholder, r=flip1995
...
Improve placeholder in map_unit_fn
Instead of using `_` as a default placeholder use `a`.
fixes #5180
changelog: Improve default placeholder in map_unit_fn
2020-03-09 19:51:13 +00:00
Jacek Pospychala
697e3c89a7
Improve placeholder in map_unit_fn
2020-03-09 20:37:06 +01:00
bors
d8f64b6eba
Auto merge of #5287 - matthiaskrgr:pat_isref, r=flip1995
...
redundant_pattern: take binding (ref, ref mut) into account in suggestion
fixes #5271
changelog: redundant_pattern: take binding (ref, ref mut) into account in suggestion (#5271 )
2020-03-09 17:25:09 +00:00
bors
92e25bb7e1
Auto merge of #5286 - matthiaskrgr:delay_vec_creation, r=flip1995
...
check_pat: delay creation of the "normal" vec until we reach the branch where it is actually needed
changelog: none
2020-03-09 17:09:38 +00:00
bors
118594ffa2
Auto merge of #5291 - ThibsG:FixSingleBinding, r=flip1995
...
Fix match single binding when in a let stmt
Fix bad suggestion when `match_single_binding` lints when inside a local (let) statement.
Fixes #5267
changelog: none
2020-03-09 16:04:26 +00:00
ThibsG
40a04f2657
Fix match single binding when in a let stmt
2020-03-09 16:59:24 +01:00
bors
a5477c500c
Auto merge of #5285 - matthiaskrgr:dep_it, r=flip1995
...
deps: bump itertools 0.8 -> 0.9
changelog: none
2020-03-09 14:29:40 +00:00
bors
c7b395fdf9
Auto merge of #5290 - polybuildr:map-message, r=phansch
...
Improve error messages for {option,result}_map_unit_fn
Instead of saying "unit function", use the phrase the description uses: "function that returns the unit type".
Fixes #5180 .
changelog: Improve error messages for {option,result}_map_unit_fn
2020-03-09 13:11:23 +00:00
bors
bc51a1a1e9
Auto merge of #5289 - polybuildr:setup, r=matthiaskrgr
...
Mention the setup instructions in CONTRIBUTING
Multiple people seem to have missed this based on questions asked in the Discord channel. Might as well mention it up front.
changelog: none
2020-03-08 22:24:26 +00:00
Vivek Ghaisas
ab6e709ee6
Improve error messages for {option,result}_map_unit_fn
...
Instead of saying "unit function", use the phrase the description
uses: "function that returns the unit type".
Fixes #5180 .
2020-03-08 21:28:06 +00:00
Vivek Ghaisas
3b3e5ea2a2
Mention the setup instructions in CONTRIBUTING
...
Multiple people seem to have missed this based on questions asked in the
Discord channel. Might as well mention it up front.
2020-03-08 21:07:18 +00:00
Matthias Krüger
75a2300e27
redundant_pattern: take binding (ref, ref mut) into account in suggestion.
...
fixes #5271
2020-03-08 10:47:18 +01:00
Matthias Krüger
a412b3423e
check_pat: delay creation of the "normal" vec until we reach the branch where is is actually needed
2020-03-08 02:50:33 +01:00
Matthias Krüger
806699342e
deps: bump itertools 0.8 -> 0.9
...
changelog: none
2020-03-08 01:33:17 +01:00
Jacob Meyers
0f7f30711e
add lint on File::read_to_string and File::read_to_end
2020-03-06 09:50:49 -05:00
Chris Simpkins
d8167128fc
transition rustc-guide to rustc-dev-guide
2020-03-05 23:32:04 -05:00
bors
3d0f0e33af
Auto merge of #5276 - flip1995:macro_use, r=flip1995
...
Rename macro_use_import -> macro_use_imports
I missed this during review of #5230 . We can just do this, without deprecating the old name, since this lint didn't hit nightly rustc yet.
changelog: none
2020-03-05 18:25:07 +00:00
flip1995
57393b5106
Rename macro_use_import -> macro_use_imports
2020-03-05 19:22:17 +01:00
bors
23d2b21297
Auto merge of #5230 - DevinR528:macro-use, r=flip1995
...
Macro use
---
changelog: This lint enforces Rust 2018 idiom of importing macro's directly without `#[macro_use]` fixes #5179 .
2020-03-05 17:30:52 +00:00