Commit graph

4760 commits

Author SHA1 Message Date
Philipp Krones
49b1a8c775
README: More detailed explanation of tool_lints
cc #3164
2018-09-13 11:27:01 +02:00
Matthias Krüger
28424ecbfa fix warnings about trivial casts, mostly {i,u}128 -> {i,u}128, such as "i128::min_value() as i128" 2018-09-13 07:59:12 +02:00
Philipp Hansch
e8400061bd
Merge pull request #3085 from mikerite/revert-98dbce
Revert "Fix E0502 warnings"
2018-09-13 06:33:26 +01:00
mikerite
5c5f2a8412
Merge pull request #3169 from yangby-cryptape/fix-typo-in-examples
Fix typo in examples.
2018-09-13 07:24:41 +02:00
Boyu Yang
4827ab978e
Remove a wrong suggestion. 2018-09-13 13:01:23 +08:00
Boyu Yang
60e8da1647
Fix typo in examples. 2018-09-13 11:51:58 +08:00
flip1995
e28440d2e0
Change Hash{Map, Set} to FxHash{Map, Set} 2018-09-12 01:34:52 +02:00
flip1995
cfa3c33b1d
Fix lint_without_lint_pass lint 2018-09-12 01:34:04 +02:00
flip1995
146b25e39b
Also run internal lints on the code base 2018-09-12 01:33:28 +02:00
Oliver Schneider
1128505fdd Revert "the cargo feature: edition 2018 is stabilized in current nightly"
This reverts commit 404a09d61c.
2018-09-10 16:02:17 +02:00
Oliver Schneider
3e4f7fc4c0 Don't use the old feature gate 2018-09-10 15:44:41 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
c884357849
Merge pull request #3160 from matthiaskrgr/ed_2018
the cargo feature: edition 2018 is stabilized in current nightly
2018-09-10 13:57:55 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
1c1030f83f
Merge pull request #3152 from PSeitz/master
fixes #3151 by skipping the lint instead of crashing
2018-09-10 13:44:47 +02:00
Pascal Seitz
d512c2bcce add spaces 2018-09-10 09:03:33 +02:00
Philipp Hansch
5209ac1429
Merge pull request #3157 from matthiaskrgr/Vinfo_impl_debug
impl std::fmt::Debug for VersionInfo
2018-09-10 06:46:49 +01:00
Matthias Krüger
404a09d61c the cargo feature: edition 2018 is stabilized in current nightly 2018-09-10 03:01:51 +02:00
Philipp Krones
f30cf51a70
Merge pull request #3135 from JoshMcguigan/explicit_counter_loop-1219
Closes #1219 false positive for explicit_counter_loop
2018-09-09 23:49:03 +02:00
Matthias Krüger
61249b360e impl std::fmt::Debug for VersionInfo
For clippy, this would print:
VersionInfo { crate_name: "clippy", major: 0, minor: 0, patch: 212, commit_hash: "084be7ba", commit_date: "2018-09-09" }
2018-09-09 23:45:29 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
2d3298b8c4
Merge pull request #3148 from matthiaskrgr/rustc_tools_util_tests
rustc_tools_util: add tests
2018-09-09 13:17:13 +02:00
mikerite
055b5eb31b
Merge pull request #3149 from matthiaskrgr/test_3075
add tests for #3057.
2018-09-09 07:15:39 +02:00
Pascal Seitz
43549ebbf8 fixes #3151 by skipping the lint instead of crashing 2018-09-08 15:30:50 +02:00
mikerite
fdd830f52c
Merge pull request #3150 from matthiaskrgr/crate_vis_feat
clippy_lints: enable crate_visibility_modifier since it is used but no longer part of 2018 edition.
2018-09-08 09:28:38 +02:00
Matthias Krüger
160959d27f add tests for #3057 and #2651
Fixes #3057
Fixes #2651
2018-09-08 09:04:04 +02:00
Josh Mcguigan
9168746c38 Corrected explicit_counter_loop behavior with nested loops 2018-09-07 20:46:36 -07:00
Josh Mcguigan
53c262048c Fix #1219 false positive for explicit_counter_loop 2018-09-07 19:58:19 -07:00
Matthias Krüger
f6935be71e clippy_lints: enable crate_visibility_modifier since it is used but no longer part of 2018 edition.
Fixes build with https://github.com/rust-lang/rust/pull/53999
2018-09-08 01:32:40 +02:00
Philipp Krones
404dd8245e
Merge pull request #3146 from flip1995/fix-3145
Fix 3145
2018-09-07 20:30:05 +02:00
Matthias Krüger
a14155088b rustc_tools_util: add test 2018-09-07 19:18:45 +02:00
Matthias Krüger
202db3e09c rustc_tools_util: don't hardcode crate name 2018-09-07 18:03:03 +02:00
flip1995
90f7997771
Add regression test 2018-09-07 17:41:03 +02:00
flip1995
fa3e3cb6ea
Fix #3145 by removing assert 2018-09-07 17:18:00 +02:00
Josh Mcguigan
ce554267b8 Updated explicit_counter_loop tests based on discussion in #3135 2018-09-07 05:32:56 -07:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
63a46b1e1a
Merge pull request #3129 from mipli/3091-numeric-typo
Add lint for misstyped literal casting
2018-09-07 09:54:43 +02:00
Philipp Hansch
cafef7b576
Merge pull request #3137 from matthiaskrgr/clippy_git_version
print git commit hash and commit date in version output
2018-09-06 18:21:14 +01:00
Philipp Hansch
5fca61409f
Merge pull request #3139 from matthiaskrgr/toml_clippy_dev_warn
Cargo.toml: remove clippy-dev entry referencing src/main.rs as its main.rs
2018-09-06 18:15:41 +01:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
8af69273d0
Merge pull request #3138 from matthiaskrgr/3126__no_warn_multi_newline
print_with_newline / write_with_newline: don't warn about string with several `\n`s in them.
2018-09-06 17:41:23 +02:00
Michael A. Plikk
7bf8d8ba09 Simplified boolean expression for checking literal suffixes 2018-09-06 17:19:38 +02:00
Michael A. Plikk
986c772c24 Reduce number of split_at calls 2018-09-06 16:26:17 +02:00
Josh Mcguigan
edfa9feac2 Corrected explicit_counter_loop missing lints if variable used after loop 2018-09-06 06:20:25 -07:00
Matthias Krüger
fa11aad92a print git commit hash and commit date in version output
clippy 0.0.212 (964fcbe0 2018-09-06)
2018-09-06 14:45:12 +02:00
Matthias Krüger
86679e230c Cargo.toml: remove clippy-dev entry referencing src/main.rs as its main.rs.
Resolves warning:
warning: file found to be present in multiple build targets: ./src/main.rs
2018-09-06 13:03:38 +02:00
Matthias Krüger
a0f56edfc3 print_with_newline / write_with_newline: don't warn about string with several \ns in them.
Fixes #3126
2018-09-06 12:59:34 +02:00
Matthias Krüger
0a8ceaf8b0 rustfmt clippy_lints/src/write.rs 2018-09-06 12:33:00 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
3262f9283f
Merge pull request #3136 from mikerite/driver-rustc-arg-2
driver: Improve check for rustc arg
2018-09-06 09:26:11 +02:00
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
dc164f4c46
Merge pull request #2985 from phansch/riir_update_lints
update_lints rewrite: Add structure and --print-only
2018-09-06 09:24:26 +02:00
Philipp Hansch
3bdc691a91
Pass by ref instead of value 2018-09-06 08:19:09 +02:00
Philipp Hansch
de36d42e80
More refactoring 2018-09-06 07:15:31 +02:00
Philipp Hansch
ca753c4af1
Merge pull request #3133 from matthiaskrgr/link
remove "clippy::" lint prefix from lint name in doc url.
2018-09-06 07:10:45 +02:00
Michael Wright
4f7a260472 driver: Improve check for rustc arg
The rustc arg might not be exactly "rustc". It may be any path to a rustc
executable (especially if the RUSTC environment variable is set when
executing cargo). Rather check that it is a path with 'rustc' file stem.
2018-09-06 07:01:56 +02:00
Josh Mcguigan
4b668159d2 Closes #1219 false positive for explicit_counter_loop 2018-09-05 19:14:01 -07:00