Commit graph

4760 commits

Author SHA1 Message Date
Michael Wright
cc87dc7539 Move some range lints to complexity
Recategorize `range_plus_one` and `range_minus_one` to `complexity`.
This moves `range_plus_one` out of the nursery as the inclusive range
syntax is now stable. Both are moved to `complexity` as it is more
consistent with other lints such as `int_plus_one`.
2018-08-26 10:57:04 +02:00
Michael Wright
6256ad05ba fix-3078: verify test case
Check the crash test case by commenting out the fix
2018-08-25 22:35:06 +02:00
Michael Wright
45ceecc79c Fix #3078 2018-08-25 14:49:56 +02:00
Philipp Hansch
296b79bdb8
Merge pull request #3079 from matthiaskrgr/update_cargo_metadata
deps: update cargo_metadata from 0.5 to 0.6.
2018-08-24 20:09:50 +02:00
Philipp Krones
b1620f5d3a
Merge pull request #3080 from matthiaskrgr/manual_swap_example
add how-to example for std::mem::transmute() usage instead of manual swap
2018-08-24 19:47:17 +02:00
Matthias Krüger
f7be2a0416 add how-to example for std::mem::transmute() usage instead of manual swap 2018-08-24 18:41:49 +02:00
Philipp Krones
e91147832c
Merge pull request #3048 from goodmanjonathan/assign_op
deprecate assign_ops lint
2018-08-24 18:29:31 +02:00
Philipp Krones
562c576ed3
Merge pull request #3059 from elpiel/writeln_empty_string_harcoded-suggestion
#3016 writeln_empty_string Hardcoded suggestion
2018-08-24 18:28:50 +02:00
Matthias Krüger
2224fbb5f7 deps: update cargo_metadata from 0.5 to 0.6. 2018-08-24 18:14:49 +02:00
Philipp Krones
72344f466f
Merge pull request #2924 from niklasf/copy-iterator
Add copy_iterator lint (#1534)
2018-08-24 12:27:48 +02:00
Niklas Fiekas
afdf350060 Add copy_iterator lint (#1534) 2018-08-24 11:57:48 +02:00
Philipp Krones
dda656652e
Merge pull request #3077 from matthiaskrgr/rustup_2
fix clippy breakage due to https://github.com/rust-lang/rust/pull/52602
2018-08-23 23:29:00 +02:00
Matthias Krüger
c98987f390 fix clippy breakage due to https://github.com/rust-lang/rust/pull/52602 2018-08-23 21:41:30 +02:00
Matt Brubeck
6a0703664b
Remove incorrect note from string_add_assign docs
The docs claim that `String::push_str` is better than `String::add` because `String::add` allocates a new string and drops the old one, but this is not true.  In fact, `add` reuses the existing string and grows it only if its capacity is exceeded, exactly like `push_str`.  Their performance is identical since `add` is just a wrapper for `push_str`:

```
    fn add(mut self, other: &str) -> String {
        self.push_str(other);
        self
    }
```

35bf1ae257/src/liballoc/string.rs (L1922-L1925)
2018-08-23 08:38:41 -07:00
Philipp Krones
e9c3d3d502
Merge pull request #3072 from matthiaskrgr/rustup
rustup, fix breakage introduced by rust-lang/rust#53581 and rust-lang/rust#53459
2018-08-23 15:53:07 +02:00
Matthias Krüger
8ab16b678c
remove macro_vis_matcher feature gate since it is stable now.
Warning was:
warning: the feature `macro_vis_matcher` has been stable since 1.29.0 and no longer requires an attribute to enable
 --> src/lib.rs:4:12
  |
4 | #![feature(macro_vis_matcher)]
  |            ^^^^^^^^^^^^^^^^^
  |
  = note: #[warn(stable_features)] on by default
2018-08-23 15:40:51 +02:00
flip1995
37099ae034
Remove now stable tool_attributes feature 2018-08-23 15:36:07 +02:00
Matthias Krüger
712d2d4fa1 rustup, fix breakage introduced by https://github.com/rust-lang/rust/pull/53581 2018-08-22 23:34:52 +02:00
flip1995
205db6f686
Add LD_LIBRARY_PATH and GITHUB_TOKEN 2018-08-22 18:08:52 +02:00
flip1995
97a9332014
Remove MinGW from CI 2018-08-22 18:07:39 +02:00
flip1995
efeed9aefc
Remove unused code 2018-08-22 17:47:54 +02:00
Oliver Schneider
f969cf2cb6 Remove rust-toolchain file in CI 2018-08-20 11:21:32 -07:00
Oliver Schneider
d6af6886e7 Keep the rustc master install in the travis file so we can use travis_retry 2018-08-20 11:21:32 -07:00
Oliver Schneider
f8a38140a0 Try running appveyor on master instead of nightly 2018-08-20 11:21:32 -07:00
Lachezar Lechev
76f7bfcefd #3016 Add backticks for the msg 2018-08-20 15:50:15 +02:00
Lachezar Lechev
c292b80783 #3016 Add feedback and implement test for fixed hardcoded suggestion 2018-08-20 15:33:43 +02:00
Lachezar Lechev
3015987f27 #3016 [WIP] Implement feedback and suggestions 2018-08-20 14:03:13 +02:00
Manish Goregaokar
f05a1038b5
Merge pull request #3065 from rust-lang-nursery/rustup
Rustup to rustc 1.30.0-nightly (6bf6d50a6 2018-08-19)
2018-08-19 19:16:54 -07:00
Manish Goregaokar
a7bea134d3 Remove implied rust_2018 feature
We are already on the edition and this feature is implied.
2018-08-19 19:14:47 -07:00
Manish Goregaokar
76321d3300 codemap -> source_map
https://github.com/rust-lang/rust/pull/52953
2018-08-19 19:06:54 -07:00
Lachezar Lechev
6cb94630fb WIP of #3016 for hardocded suggestion for writeln on empty string 2018-08-16 18:20:06 +02:00
Oliver Schneider
07c2e61436
Merge pull request #3056 from mikerite/fix-2927
Fix #2927
2018-08-16 08:20:51 +02:00
Michael Wright
1c681b6ab6 fix-2927: Update formatting 2018-08-16 07:13:52 +02:00
Michael Wright
bbd67c9b78 Fix #2927 2018-08-15 08:11:07 +02:00
Manish Goregaokar
bac76afb5a Rustup to rustc 1.30.0-nightly (23f09bbed 2018-08-14) 2018-08-14 11:26:28 -07:00
Philipp Krones
84aa49935d
Merge pull request #3026 from dwijnand/fxhash
Add an internal lint for FxHashMap/FxHashSet
2018-08-14 13:04:48 +02:00
Philipp Krones
72b8c9b211
Merge pull request #3049 from mikerite/fix-2799
Add a test to ensure that #2799 is fixed
2018-08-14 12:55:13 +02:00
Philipp Krones
b2a4013c14
Merge pull request #3014 from estk/allow-write-multi-newline
Allow print/write with multiple newlines
2018-08-14 12:54:05 +02:00
Philipp Krones
826d998cd2
Merge pull request #3036 from matthiaskrgr/clippy_self
fix 2 clippy warnings
2018-08-14 12:53:01 +02:00
Philipp Krones
7392f6c3ba
Merge pull request #3022 from dwijnand/move-shadow_unrelated
Move shadow_unrelated to pedantic
2018-08-14 12:50:46 +02:00
Dale Wijnand
7933d445d1
Move shadow_unrelated to pedantic 2018-08-14 09:52:27 +01:00
Dale Wijnand
22ff5a3ef1
Avoid new_without_default_derive in DefaultHashTypes 2018-08-14 09:25:09 +01:00
Michael Wright
a1f8e129fd Add a test to ensure that #2799 is fixed
Closes #2799
2018-08-14 07:27:56 +02:00
Jonathan Goodman
160b41dae3 deprecate assign_ops lint 2018-08-13 16:12:41 -05:00
Dale Wijnand
1812707d39
Use utils::span_lint_and_sugg in default_hash_types 2018-08-13 11:49:57 +01:00
Martin Carton
e6d92f95c6
Merge pull request #3038 from matthiaskrgr/clippy_docs
docs: add more suggestions on how to fix clippy findings to the online lint list
2018-08-12 21:35:52 +02:00
Martin Carton
b6f08780de
Merge pull request #3042 from matthiaskrgr/py3
update_lints.py: port another print to print() for python3 compatibility.
2018-08-12 19:11:07 +02:00
Dale Wijnand
8fc425b676
Add an internal lint for FxHashMap/FxHashSet 2018-08-12 16:15:36 +01:00
Matthias Krüger
7ded77fe7d update_lints.py: port another print to print() for python3 compatibility. 2018-08-12 11:33:44 +02:00
Matthias Krüger
88d693918f docs: add more suggestions on how to fix clippy findings to the online lint list. 2018-08-12 11:29:44 +02:00