Commit graph

2620 commits

Author SHA1 Message Date
Oliver Schneider
b76ce176bb Fix op_ref in case of nonexisting operations 2017-04-10 15:10:19 +02:00
Yati Sagade
62548f447c needless_continue: Add ui test
The test program contains both conditions tested by the lint, i.e.,
a redundant continue in the `if` and `else` blocks within a loop. Maybe
splitting them out and also having a program that should *not* trigger
the lint warning is better.
2017-04-09 14:20:14 +02:00
Yati Sagade
69928906f4 needless_continue: Add tests for helper functions to the needless_continue lint.
Creating a test file per function sounds a bit excessive, so just
clubbing all needless_continue specific function tests into this module.
2017-04-09 14:12:01 +02:00
Yati Sagade
a099748113 utils: Add tests for the align_blocks helper in utils. 2017-04-09 14:09:54 +02:00
Yati Sagade
8ea6d6a8d2 needless_continue: Refactor to use stuff from utils, and move some stuff to utils.
I had my own implementation of what `trim_multiline()` seems to be doing, so
I just started using `trim_multiline()`. Some other functions, like
those block alignment, are general enough to be used elsewhere, so moved
them to utils.
2017-04-09 14:07:11 +02:00
Yati Sagade
1ee34e7851 Run update_lints.py 2017-04-08 23:31:23 +02:00
Yati Sagade
38238f576d [needless_continue] Add comments explaining terminology used thoughout in the code. 2017-04-08 23:30:34 +02:00
Yati Sagade
9396120008 More dogfood test fixes. 2017-04-08 23:30:34 +02:00
Yati Sagade
7b4a12fd21 Fix lint warnings from dogfooding tests. 2017-04-08 23:30:34 +02:00
Yati Sagade
240471f926 Needless continue: This is a complete rewrite of this lint as an early-pass lint.
The previous version had troubles computing suggestions without macro expansions
creeping in. This fixes it by using original_sp, which works on AST nodes.
2017-04-08 23:30:34 +02:00
Oliver Schneider
0432f1efd3 Add wiki updating to publish steps 2017-04-07 16:42:08 +02:00
Oliver Schneider
c657d603ba
Bump the version 2017-04-07 11:25:00 +02:00
Oliver Schneider
f1e905f620 Reintroduce #768 so we can publish 2017-04-07 11:21:39 +02:00
Oliver Schneider
3052000c73 Merge pull request #1649 from ensch/master
Fix for rustc 1.18.0-nightly (5c94997b6 2017-03-30)
2017-04-07 11:13:44 +02:00
Oliver Schneider
13408e2ac8 Enable rls on this repo 2017-04-06 16:49:25 +02:00
Oliver Schneider
a679f41fa3 Fix fallout 2017-04-06 16:49:13 +02:00
Oliver Schneider
f32fab1c8f panic!("{}") lint is broken 2017-04-06 16:49:03 +02:00
Oliver Schneider
6d921b4734 fix various rustup failures 2017-04-06 16:48:48 +02:00
Martin Carton
60f4863cbe Merge pull request #1652 from pgerber/with
correct message for `option_map_unwrap_or_else` lint
2017-04-02 00:54:40 +02:00
Peter Gerber
71a788cbd7 correct error message for option_map_unwrap_or_else lint
Remove erroneous "with " in suggested alternative call.
2017-04-01 15:54:27 +02:00
Enrico Schmitz
7c94a62048 Reenable mut_mut_macro.rs test 2017-04-01 00:25:23 +02:00
Enrico Schmitz
7a4f7c335b Remove unused cs parameter for is_macro and friends 2017-04-01 00:14:04 +02:00
Enrico Schmitz
8aef64dfe8 Fix src/needless_bool.rs by using ExprBlock(block) = then 2017-03-31 23:46:08 +02:00
Enrico Schmitz
8297c19fcc Fixing src/copies.rs and src/entries.rs by using ExprBlock(block) = then.node 2017-03-31 23:36:45 +02:00
Enrico Schmitz
8f9fb97eb6 First try for a fix for rustc 1.18.0-nightly (5c94997b6 2017-03-30 2017-03-31 19:23:35 +02:00
Oliver Schneider
9c3c938761 Merge pull request #1613 from Manishearth/dont_ref_operator_args
Dont ref operator args
2017-03-30 11:16:20 +02:00
Oliver Schneider
0ae1a77a2e Do some additional cleanup around InternedString and Symbol 2017-03-30 10:21:13 +02:00
Oliver Schneider
d9e69a70df
Fix fallout 2017-03-30 09:46:04 +02:00
Oliver Schneider
5de367f793
Don't create additional references when invoking binary operators 2017-03-30 09:46:00 +02:00
Martin Carton
813daf236f Merge pull request #1640 from Manishearth/multiple_matching_crates
Remove some legacy code
2017-03-27 19:47:45 +02:00
Oliver Schneider
8f88ead7d6 Remove some legacy code 2017-03-27 14:51:37 +02:00
Oliver Schneider
269b8d33c9 Merge pull request #1575 from tristianc/1537-drop_copy
Calls to mem::drop on Copy types
2017-03-24 13:39:30 +01:00
Oliver Schneider
5547fbb770 Fix accidental newline in diagnostic and missing entries in lint_array! 2017-03-24 10:21:12 +01:00
Oliver Schneider
8ae82eb4ab
Merge remote-tracking branch 'origin/master' into 1537-drop_copy 2017-03-24 10:11:46 +01:00
Oliver Schneider
4f473f7f60 Merge pull request #1617 from sinkuu/proc_macro_pass_by_value
Filter out proc_macro_derive functions
2017-03-24 10:10:24 +01:00
Oliver Schneider
b1b43da20a Merge pull request #1627 from Manishearth/dont-panic
Don't panic if traits not found
2017-03-24 10:09:59 +01:00
sinkuu
a712271df6 Filter out proc_macro_derive functions (fixes #1615) 2017-03-21 17:09:21 +09:00
Oliver Schneider
f2e8f526e6 Run rustfmt 2017-03-21 08:57:54 +01:00
Oliver Schneider
9bdd84cfdb
Bump the version 2017-03-21 08:57:19 +01:00
Oliver Schneider
b7bc8d923b Merge pull request #1634 from ensch/master
Fix for rustc 1.17.0-nightly (6eb9960d3 2017-03-19)
2017-03-21 08:50:52 +01:00
Enrico Schmitz
b409356a04 Fix appveyor curl path 2017-03-21 00:52:52 +01:00
Enrico Schmitz
fa0a670201 Simplify attr_is_cfg in returns.rs 2017-03-21 00:34:05 +01:00
Enrico Schmitz
f8df4aed0f Fix for rustc 1.17.0-nightly (6eb9960d3 2017-03-19) 2017-03-21 00:22:19 +01:00
Manish Goregaokar
2a04fe9652 Merge pull request #1629 from Manishearth/typos
fix typos
2017-03-17 16:41:44 -07:00
Andre Bogus
30e0c0fc96 fix typos 2017-03-17 21:21:32 +01:00
Oliver Schneider
f5e66bbb47 Run rustfmt 2017-03-17 17:19:47 +01:00
Oliver Schneider
c59c7c1194
Bump the version 2017-03-17 17:19:17 +01:00
Andre Bogus
c2ff30375a Don't panic if traits not found 2017-03-16 08:57:17 +01:00
llogiq
bed96fb3da Merge pull request #1625 from Manishearth/rustup_catch
Rustup: Add ExprKind::Catch
2017-03-16 08:56:29 +01:00
Andre Bogus
bc934a3ed9 Rustup: Add ExprKind::Catch 2017-03-16 00:56:21 +01:00