Commit graph

8528 commits

Author SHA1 Message Date
flip1995
50a2f971fc
Adapt gen_lint_group_list test to also generate internal lints 2020-02-14 14:42:24 +01:00
flip1995
07026983f5
Rename lint_count -> usable_lint_count 2020-02-14 14:37:56 +01:00
flip1995
2635a602bc
Update some documentation 2020-02-14 14:37:56 +01:00
flip1995
4a9bfe4184
Let update_lints also generate the internal lints 2020-02-14 14:37:56 +01:00
flip1995
3da2c9183a
Save Lint::module as full path of module 2020-02-14 14:37:56 +01:00
flip1995
560559bafe
Make Lint::by_lint_group take impl Iterator as argument 2020-02-14 14:37:55 +01:00
bors
bdd4046f01 Auto merge of #5171 - flip1995:deploy, r=Manishearth
Improve deployment and documentation

**This should be merged shortly after** #5172

This extracts the python code that generated the `versions.json` file and now sorts the versions. in addition to that it improves the order on the website, respecting the new `rust-*` directories.

The new appearance of the documentation site can be previewed here: https://flip1995.github.io/rust-clippy/

changelog: Add documentation for Clippy stable releases at https://rust-lang.github.io/rust-clippy/
2020-02-14 13:05:29 +00:00
flip1995
0f7918266f
Rename current -> stable 2020-02-14 12:03:48 +01:00
bors
41d90d3b8e Auto merge of #5173 - matthiaskrgr:pulldown, r=flip1995
deps: update pulldown-cmark from 0.6 to 0.7

changelog: none
2020-02-13 22:09:38 +00:00
Matthias Krüger
fa0ad30465 deps: update pulldown-cmark from 0.6 to 0.7 2020-02-13 22:01:26 +01:00
flip1995
0533cff125
Use python3 instead of python
This changes the formatting a bit of json.dump(..)
2020-02-13 18:07:56 +01:00
flip1995
2044931cbe
Better version ordering of documentation 2020-02-13 17:59:37 +01:00
flip1995
5e03d5bb06
Sort versions in json output 2020-02-13 17:59:37 +01:00
bors
96c2e62d57 Auto merge of #5168 - lily-commure:chars_next_style, r=flip1995
Reclassify chars_next_cmp as a style lint.

This makes it consistent with chars_last_cmp.

changelog: none
2020-02-13 12:54:28 +00:00
bors
06777d509e Auto merge of #5170 - JohnTitor:fix-prefix, r=flip1995
Fix false positive in `zero_prefixed_literal`

Fixes #5169

changelog: Fix false positive in `zero_prefixed_literal`
2020-02-13 12:26:29 +00:00
Yuki Okushi
f77158bc14 Fix false positive in zero_prefixed_literal 2020-02-13 14:39:29 +09:00
Lily Chung
385fd7cd0a change in the right place, run update_lints 2020-02-12 17:03:49 -08:00
Lily Chung
7e0af69f1c Reclassify chars_next_cmp as a style lint.
This makes it consistent with chars_last_cmp.
2020-02-12 16:50:29 -08:00
bors
f8576c7bf4 Auto merge of #5163 - flip1995:gha_fix, r=flip1995
Change badge branch from master to auto

For some reason GHA classifies the bors merges on the master branch as a
push to the auto branch, even though the workflow got triggered by a
push to the master branch. I guess this has something to do with the
same commit hash on master+auto directly after the merge?

changelog: none
2020-02-12 15:41:03 +00:00
bors
eaed72f537 Auto merge of #5165 - matthiaskrgr:ci_cargo_cache_autoclean, r=flip1995
gha: install cargo-cache with ci-autoclean feature which speeds up build time by a large margin.

changelog: none
2020-02-12 15:11:32 +00:00
Matthias Krüger
b755a7d714 gha: install cargo-cache with ci-autoclean feature which speeds up build time by a large margin. 2020-02-12 15:40:49 +01:00
bors
15c7841de0 Auto merge of #5164 - flip1995:gha_deploy_fix, r=flip1995
Fix tag deployment on GHA

I just want to test some things here currently.

changelog: none
2020-02-12 14:08:20 +00:00
flip1995
3241e4fed4
Run deploy workflow on tags, instead of releases 2020-02-12 15:01:39 +01:00
flip1995
fb59043621
Change badge branch master -> auto
For some reason GHA classifies the bors merges on the master branch as a
push to the auto branch, even though the workflow got triggered by a
push to the master branch. I guess this has something to do with the
same commit hash on master+auto directly after the merge?
2020-02-12 12:13:59 +01:00
bors
2432a16973 Auto merge of #5162 - flip1995:gha_fix, r=flip1995
Fix GHA after the merge

changelog: none
2020-02-12 10:24:27 +00:00
flip1995
b0d25de54a
Use list instead of array for branch names
This is the officially supported method
2020-02-12 11:03:39 +01:00
bors
71a5379bda Auto merge of #5088 - rust-lang:gha, r=Manishearth,flip1995
Switch to GitHub Actions - Part 2 - From within

This is a continuation of #5071. This time from a branch inside the rust-lang/rust-clippy repo, not from my fork, since secrets are not available in PRs from forks.

Copying the description of #5071 to here:

Closes #4577

~~This is just an experiment. I don't think we have a consensus _if_ we should move away from travis/appveyor.~~ We have consensus: https://github.com/rust-lang/rust-clippy/pull/5071#issuecomment-576647638

~~GHA would let us run up to 20 concurrent jobs. Since we have 15 integration tests and 4 (linux, linux 32-bit, macos, windows) basic tests, we would be able to run everything concurrently.~~ The org has a limit of 60 jobs across the org, so we limit the matrix of the integration tests to 6 concurrent jobs.

~~Also IIUC we only have to build Clippy once for every initegration test and then only check the repos.~~ Nope, dependent jobs exist, but they won't keep the artifacts (not even the checkout).

TODO before merge:

- [x] Add `DEPLOY_KEY` secret to github repo
- [x] test deployment on test branch `gh-test`#
  - [x] Test normal deployment
  - [x] Test deployment no changes
  - [x] Test deployment of tag
- [x] talk with `@rust-lang/infra` for bors, `@rust-lang/infra` is good with the move (crater also uses GHA+bors)
- [x] ~~Get remark + clippy_dev check to work on pushes (https://github.community/t5/GitHub-Actions/~Builds-are-not-triggered-with-on-paths/m-p/44075; I contacted GH support about this) ~~That seems to start working again yesterday. Let's hope it keeps working.~~ Or not: df9be48. Now it works again: 723786a. I think we should wait, until this is reliable. It appears, that it doesn't work on force pushes (sometimes?): 5814142~~ We need to run the bors tests unconditionally anyway (47138d1) so it doesn't really matter.
- [x] ~~impl homu checks for GHA https://github.com/rust-lang/rust-clippy/pull/5071#issuecomment-576642983 -- I prepared: f40230dc3c. I'd suggest to first add GHA and keep the travis and appveyor checks for a few days and to remove them in a second pass. The bors dummy jobs are added in 1a83b7ad7a and work as expected: https://github.com/rust-lang/rust-clippy/pull/5088#issuecomment-582055695. I opened https://github.com/rust-lang/rust-central-station/pull/578~~ See https://github.com/rust-lang/rust-clippy/pull/5088#issuecomment-584581420
- [x] ~Add GHA badge to Cargo.toml (blocked on rust-lang/crates.io # 1838)~ Added a FIXME in
2332b57
- [x] ~Maybe we should also wait until GHA supports yaml anchors. https://github.community/t5/GitHub-Actions/Support-for-YAML-anchors/td-p/30336/~ WIll probably not be implemented in the near future.
- [x] Add back travis + appveyor files for transition period (!)

changelog: none
2020-02-12 09:02:18 +00:00
flip1995
3fac289c3d
Don't upload target/release in integration_build
This dir was generated by compiling RTIM, when no cache is available
2020-02-12 10:01:19 +01:00
flip1995
a0a21a8752
Use nightly cargo to install cargo-cache
Stable cargo install still errors when packages exists, instead of updating it
2020-02-12 09:34:28 +01:00
flip1995
27453463f2
Install all required remark packages in travis 2020-02-12 09:34:28 +01:00
flip1995
622ece3153
Remove deployment from travis 2020-02-12 09:34:28 +01:00
flip1995
b47dada167
Apply review comments 2020-02-12 09:34:28 +01:00
flip1995
abb095dded
Run bors checks unconditionally
This is important, since bors doesn't know optional jobs. Otherwise bors
would time out, when a check doesn't get run.
2020-02-12 09:34:28 +01:00
flip1995
b8b47ab6fe
Add bors dummy jobs 2020-02-12 09:34:28 +01:00
flip1995
813d3192bb
Use hash of Cargo.lock file in cache name 2020-02-12 09:34:28 +01:00
flip1995
095287dbc8
Add two more error causes to integration test 2020-02-12 09:34:27 +01:00
flip1995
1ceeb13e0a
Build Clippy before running integration tests 2020-02-12 09:34:27 +01:00
flip1995
ab43951d41
Allow non-ascii characters in changelog check 2020-02-12 09:34:27 +01:00
flip1995
dfdea56e99
Extract deployment 2020-02-12 09:34:27 +01:00
flip1995
ea780a69f3
Extract driver test 2020-02-12 09:34:27 +01:00
flip1995
935b94d80b
Sort output of export.py script 2020-02-12 09:34:27 +01:00
flip1995
e59361f723
Limit parallel jobs on try/r+ runs
Rate limit of 60 applies org wide, let's not spam.
Thanks pietroalbini for the hint
2020-02-12 09:34:27 +01:00
flip1995
b9580fcef7
Cancle builds on new commits 2020-02-12 09:34:27 +01:00
flip1995
d7620a3e62
Add GHA badge to README.md
Add a FIXME to Cargo.toml
2020-02-12 09:34:26 +01:00
flip1995
8f45387490
Small change to comment in .gitignore 2020-02-12 09:34:26 +01:00
flip1995
893e261a99
Add deployment to GHA 2020-02-12 09:34:26 +01:00
flip1995
92811675ce
Move integration tests in clippy_bors.yml
Some call it the integration integration
2020-02-12 09:34:26 +01:00
flip1995
66b5e2212d
Add Clippy Test to GHA 2020-02-12 09:34:26 +01:00
flip1995
f5db351a1d
Get {RUSTUP,MULTIRUST}_{HOME,TOOLCHAIN} from runtime environment
Keep the fallback to compile-time environment
2020-02-12 09:34:26 +01:00
flip1995
ff8336b0a0
Check if changelog exists 2020-02-12 09:34:26 +01:00