Jane Lusby
|
14feb3670f
|
Lint for chaining flatten after map
This change adds a lint to check for instances of `map(..).flatten()`
that can be trivially shortened to `flat_map(..)`
Closes #3196
|
2018-09-24 14:29:16 -07:00 |
|
Michael Wright
|
ab71f08663
|
Fix single_char_pattern crash (#3204)
This commit fixes the crash by removing constant checking from the lint.
Closes #3204.
|
2018-09-24 08:33:57 +02:00 |
|
Philipp Krones
|
bc6d85ceaf
|
Merge pull request #3207 from mikerite/fix-3206
Fix double_parens false positive
|
2018-09-23 18:24:27 +02:00 |
|
Philipp Krones
|
af2d6a0c14
|
Merge pull request #3191 from vi/suggest_with_applicability
Use span_suggestion_with_applicability instead of span_suggestion
|
2018-09-23 15:45:55 +02:00 |
|
Michael Wright
|
867ac98d38
|
Fix double_parens false positive
Closes #3206
|
2018-09-22 17:20:34 +02:00 |
|
flip1995
|
987b34d090
|
Another Applicability adjustment
|
2018-09-20 14:38:48 +02:00 |
|
Vitaly _Vi Shukela
|
52fb7d461e
|
Applicability adjustment per additional comments
|
2018-09-20 14:38:48 +02:00 |
|
Vitaly _Vi Shukela
|
58729346be
|
Fill in Applicability from review comments by @flip1995
|
2018-09-20 14:38:48 +02:00 |
|
Vitaly _Vi Shukela
|
3eccccb367
|
Fix indents
|
2018-09-20 14:38:48 +02:00 |
|
Vitaly _Vi Shukela
|
2781cac839
|
Apply subset of "cargo fmt".
|
2018-09-20 14:38:47 +02:00 |
|
Vitaly _Vi Shukela
|
3e853a632e
|
Add forgotten function: span_suggestion*s* to the previous refactoting
|
2018-09-20 14:38:47 +02:00 |
|
Vitaly _Vi Shukela
|
d4c994e670
|
Supplement DiagnosticBuilderExt with Applicability
|
2018-09-20 14:38:47 +02:00 |
|
Vitaly _Vi Shukela
|
92034e20c8
|
Use span_suggestion_with_applicability instead of span_suggestion
|
2018-09-20 14:38:47 +02:00 |
|
Jay Kickliter
|
79cda3bb1e
|
mem_replace: fix grammar.
|
2018-09-19 14:54:38 -07:00 |
|
Jay Kickliter
|
2f53aaa5bd
|
mem_replace: match on path.
|
2018-09-19 14:41:22 -07:00 |
|
Jay Kickliter
|
12c7bc1e58
|
mem_replace: apply update_lints tool.
|
2018-09-19 14:41:22 -07:00 |
|
Jay Kickliter
|
1b6d739ce3
|
mem_replace: make examples compilable.
|
2018-09-19 14:38:34 -07:00 |
|
Jay Kickliter
|
598df08d88
|
Add lint for mem::replace(.., None).
Suggest `Option::take()` as an alternative.
|
2018-09-19 14:38:34 -07:00 |
|
Philipp Hansch
|
b6707ffc42
|
Merge pull request #3187 from flip1995/internal_fn
New internal lint: compiler_lint_functions
|
2018-09-19 19:43:48 +01:00 |
|
flip1995
|
a8b681cc2c
|
Fix c_void path
This got changed in rust-lang/rust#53910
|
2018-09-17 11:20:27 +02:00 |
|
Michael Wright
|
c78cf042ff
|
Remove unneeded check for method call
The check can be removed because the call to `method_chains_args`
already performs this check.
|
2018-09-16 13:08:00 +02:00 |
|
flip1995
|
021748eb6a
|
Replace another occurrence of "".to_owned()
|
2018-09-15 11:25:40 +02:00 |
|
Matthias Krüger
|
f3add4acb4
|
convert "".to_string() and "".to_owned() to String::new()
|
2018-09-15 11:20:35 +02:00 |
|
flip1995
|
144281c537
|
Formatting
|
2018-09-15 11:02:00 +02:00 |
|
flip1995
|
a4e1a90705
|
Fix warnings of compiler_lint_functions
|
2018-09-15 11:02:00 +02:00 |
|
flip1995
|
aaeeaa5330
|
Add internal lint compiler_lint_functions
|
2018-09-15 11:01:16 +02:00 |
|
Eduard-Mihai Burtescu
|
85caaf5905
|
Fix useless_attribute to also whitelist unused_extern_crates.
|
2018-09-15 11:16:45 +03:00 |
|
Eduard-Mihai Burtescu
|
9219fc6c5c
|
Reintroduce extern crate for non-Cargo dependencies.
|
2018-09-15 11:10:51 +03:00 |
|
flip1995
|
f49f133cba
|
Fix pedantic filter_map warnings
|
2018-09-14 12:56:25 +02:00 |
|
Manish Goregaokar
|
7b530c79b2
|
Add match on StructCtor
|
2018-09-14 12:41:20 +05:30 |
|
Philipp Hansch
|
dac5e2d3a5
|
Merge pull request #3140 from matthiaskrgr/redundant_casts
fix warnings about trivial casts, mostly {i,u}128 -> {i,u}128, such as "i128::min_value() as i128"
|
2018-09-13 20:37:13 +01:00 |
|
Philipp Hansch
|
07cb45bc85
|
Merge pull request #3166 from flip1995/travis_internal
Run internal lints on the Clippy code base
|
2018-09-13 17:22:48 +01:00 |
|
Matthias Krüger
|
28424ecbfa
|
fix warnings about trivial casts, mostly {i,u}128 -> {i,u}128, such as "i128::min_value() as i128"
|
2018-09-13 07:59:12 +02:00 |
|
Philipp Hansch
|
e8400061bd
|
Merge pull request #3085 from mikerite/revert-98dbce
Revert "Fix E0502 warnings"
|
2018-09-13 06:33:26 +01:00 |
|
Boyu Yang
|
4827ab978e
|
Remove a wrong suggestion.
|
2018-09-13 13:01:23 +08:00 |
|
Boyu Yang
|
60e8da1647
|
Fix typo in examples.
|
2018-09-13 11:51:58 +08:00 |
|
flip1995
|
e28440d2e0
|
Change Hash{Map, Set} to FxHash{Map, Set}
|
2018-09-12 01:34:52 +02:00 |
|
flip1995
|
cfa3c33b1d
|
Fix lint_without_lint_pass lint
|
2018-09-12 01:34:04 +02:00 |
|
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
|
1c1030f83f
|
Merge pull request #3152 from PSeitz/master
fixes #3151 by skipping the lint instead of crashing
|
2018-09-10 13:44:47 +02:00 |
|
Pascal Seitz
|
d512c2bcce
|
add spaces
|
2018-09-10 09:03:33 +02:00 |
|
Philipp Krones
|
f30cf51a70
|
Merge pull request #3135 from JoshMcguigan/explicit_counter_loop-1219
Closes #1219 false positive for explicit_counter_loop
|
2018-09-09 23:49:03 +02:00 |
|
Pascal Seitz
|
43549ebbf8
|
fixes #3151 by skipping the lint instead of crashing
|
2018-09-08 15:30:50 +02:00 |
|
Josh Mcguigan
|
9168746c38
|
Corrected explicit_counter_loop behavior with nested loops
|
2018-09-07 20:46:36 -07:00 |
|
Josh Mcguigan
|
53c262048c
|
Fix #1219 false positive for explicit_counter_loop
|
2018-09-07 19:58:19 -07:00 |
|
Matthias Krüger
|
f6935be71e
|
clippy_lints: enable crate_visibility_modifier since it is used but no longer part of 2018 edition.
Fixes build with https://github.com/rust-lang/rust/pull/53999
|
2018-09-08 01:32:40 +02:00 |
|
flip1995
|
fa3e3cb6ea
|
Fix #3145 by removing assert
|
2018-09-07 17:18:00 +02:00 |
|
Josh Mcguigan
|
ce554267b8
|
Updated explicit_counter_loop tests based on discussion in #3135
|
2018-09-07 05:32:56 -07:00 |
|
Oliver S̶c̶h̶n̶e̶i̶d̶e̶r Scherer
|
63a46b1e1a
|
Merge pull request #3129 from mipli/3091-numeric-typo
Add lint for misstyped literal casting
|
2018-09-07 09:54:43 +02:00 |
|
Michael A. Plikk
|
7bf8d8ba09
|
Simplified boolean expression for checking literal suffixes
|
2018-09-06 17:19:38 +02:00 |
|
Michael A. Plikk
|
986c772c24
|
Reduce number of split_at calls
|
2018-09-06 16:26:17 +02:00 |
|