Lzu Tao
08ce6bc6d9
Fix macro expansion in toplevel_ref_arg lint
2019-09-26 08:46:51 +07:00
Lzu Tao
3b9e5dfda5
Add regression test for macro expansion
2019-09-26 08:14:58 +07:00
bors
1366629262
Auto merge of #4575 - Manishearth:suggestions, r=oli-obk
...
Make more tests rustfixable
Fixes https://github.com/rust-lang/rust-clippy/issues/3630
changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy`
r? @phansch @yaahc
2019-09-25 21:54:14 +00:00
Manish Goregaokar
49374a4380
Downgrade op_ref to a MaybeIncorrect suggestion
2019-09-25 14:53:48 -07:00
Manish Goregaokar
b94f2e89fd
unnecessary_operation: make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
04dd580f37
unnecessary_clone: split rustfixable lint out into separate test
2019-09-25 14:45:18 -07:00
Manish Goregaokar
363e382f5b
string_add, string_add_assign: split tests, make one rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
1a4dcfca35
redundant_static_lifetimes: split test, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
ea16ab56d5
renamed_builtin_attr: make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
d28dacb33a
redundant_pattern_matching: make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
a83a8dccba
redundant_closure_call: split tests into fixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
e4ff86dcd4
map_unit_fn: make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
ad0e7c8e7f
map_unit_fn: fix applicability
2019-09-25 14:45:18 -07:00
Manish Goregaokar
24c283ea12
option_map_unit_fn: Split into fixable/unfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
38a0785436
map_unit_fn: rename tests to fixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
1090509564
non_copy_const: remove incorrect suggestion
2019-09-25 14:45:18 -07:00
Manish Goregaokar
a9a3350455
needless_return: add allow()s to test, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
980650eec2
needless_collect: fix suggestion, make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
7f822e742d
needless_borrowed_ref: fix false positive, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
622b167eb8
needless_borrow: allow other lints, make fixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
0d8e4d7c37
mem_discriminant: split test, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
483e140bce
map_flatten: make it a rustfix test
2019-09-25 14:45:18 -07:00
Manish Goregaokar
d29f6d28b5
Leave note on non-rustfixable tests
2019-09-25 14:45:18 -07:00
Manish Goregaokar
329e224eba
Remove large-digit-groups test from literals.rs
2019-09-25 14:45:18 -07:00
Manish Goregaokar
4368771548
map_entry test: Fix semicolon, add run-rustfix
2019-09-25 14:45:18 -07:00
Manish Goregaokar
e2f4b60661
Split map_entry tests into fixable and unfixable
2019-09-25 14:45:18 -07:00
bors
d5570e44e8
Auto merge of #4574 - Manishearth:rustup, r=yaahc,centril
...
Rustup to rustc 1.39.0-nightly (acf7b50c7 2019-09-25)
changelog: none
fixes https://github.com/rust-lang/rust/issues/64777
r? @phansch @yaahc
2019-09-25 20:56:22 +00:00
Manish Goregaokar
d445bf2e89
Remove suggestion for complex map_entry cases
2019-09-25 13:54:53 -07:00
Manish Goregaokar
a756b9bd2d
allow osx failures
2019-09-25 13:51:45 -07:00
Manish Goregaokar
b5cadd734e
ignore single-match for or patterns
2019-09-25 13:34:55 -07:00
Manish Goregaokar
982c51e769
arm.pats -> arm.pat
2019-09-25 12:52:16 -07:00
Manish Goregaokar
68c26b325b
Rustup to rustc 1.39.0-nightly (acf7b50c7 2019-09-25)
...
- Addresses inference error
- Updates compiletest
2019-09-25 11:11:14 -07:00
bors
d5ec41c442
Auto merge of #4567 - phansch:toplevel_ref_arg, r=flip1995
...
Add run-rustfix for toplevel_ref_arg lint
changelog: none
cc #3630
2019-09-23 17:01:13 +00:00
Philipp Hansch
df83732f09
Add run-rustfix for toplevel_ref_arg lint
2019-09-23 11:22:31 +02:00
bors
4d566b6959
Auto merge of #4561 - rust-lang:let-return-fix, r=phansch
...
Fix let_and_return lint
This fixes #4555 (false positive for the `let_and_return` lint).
changelog: none
2019-09-23 08:25:38 +00:00
Andre Bogus
2b7514154d
Fix let_and_return lint
2019-09-23 09:17:18 +02:00
bors
0fcb49ee30
Auto merge of #4566 - phansch:update_changelog2, r=flip1995
...
Update the changelog for Rust 1.38
[Rendered](https://github.com/phansch/rust-clippy/blob/update_changelog2/CHANGELOG.md#rust-138 )
changelog: none
2019-09-23 07:11:21 +00:00
bors
c23b3755f3
Auto merge of #4537 - mikerite:unneeded_wildcard_pattern, r=phansch
...
Add `unneeded-wildcard-pattern` lint
changelog: Add `unneeded-wildcard-pattern` lint
2019-09-23 05:51:04 +00:00
Michael Wright
ca6d36ba22
Merge branch 'master' into unneeded_wildcard_pattern
2019-09-23 05:26:47 +02:00
Philipp Hansch
b451e43098
Update the changelog for Rust 1.38
2019-09-22 19:19:59 +02:00
bors
157edad620
Auto merge of #4518 - imp:4517_license-file, r=phansch
...
clippy::cargo_common_metadata: check for license-file
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.
Fixes #4517
changelog: clippy::cargo_common_metadata now checks for license-file when license is missing
2019-09-22 11:40:35 +00:00
bors
dbb1bdea87
Auto merge of #4565 - matthiaskrgr:rustup_16, r=phansch
...
rustup https://github.com/rust-lang/rust/pull/64666
changelog: none
2019-09-22 10:36:32 +00:00
Matthias Krüger
d7b3e237db
rustup https://github.com/rust-lang/rust/pull/64666
2019-09-22 12:35:20 +02:00
Cyril Plisko
4c881d108a
clippy::cargo_common_metadata: check for license-file
...
When license property is missing in Cargo.toml check for license-file
as it may be used instead of the former. The check implemented here is
very naive as it only verifies that the field is present and is not
empty. More scrutiny can be applied by verifying the file is actually
present.
Fixes #4517
2019-09-22 10:49:36 +03:00
Michael Wright
be4e41562a
Add additional tests to unneeded_wildcard_pattern
2019-09-22 09:10:39 +02:00
Michael Wright
d04bf15114
Merge branch 'master' into unneeded_wildcard_pattern
2019-09-22 08:59:23 +02:00
bors
d07d001b74
Auto merge of #4562 - phansch:wildcard_enum_match_rustfix, r=llogiq
...
Add run-rustfix for wildcard_enum_match_arm lint
changelog: none
cc #3630
2019-09-21 11:42:15 +00:00
Philipp Hansch
afd7b180e5
Add run-rustfix for wildcard_enum_match_arm lint
2019-09-21 07:26:18 +02:00
bors
f21cd81949
Auto merge of #4558 - Manishearth:suggestions, r=phansch
...
Make more tests rustfixable
changelog: Fix various lint suggestions
Progress towards https://github.com/rust-lang/rust-clippy/issues/3630
r? @phansch
2019-09-21 01:01:21 +00:00
Manish Goregaokar
2fecf756f7
inline_fn_without_body: make it use a rustfix page
2019-09-21 10:01:06 +09:00