2514 commits

Author	SHA1	Message	Date
Michael Wright	b726b41daf	Add OUTER_EXPN_INFO lint	2019-06-08 13:35:04 +02:00
bors	71be6f62fa	Auto merge of #4177 - mikerite:compiler_lint_functions_fewer_strings, r=phansch ... Remove `to_string()`s from CompilerLintFunctions changelog: none	2019-06-06 10:25:13 +00:00
bors	5be4e71262	Auto merge of #4136 - euclio:println-writeln-suggestions, r=flip1995 ... add suggestions for print/write with newline lint changelog: Add machine-applicable suggestions for `print!`/`write!` with newline lints.	2019-06-06 08:26:48 +00:00
Matthias Krüger	d0ca09883e	rustup https://github.com/rust-lang/rust/pull/57428/	2019-06-06 09:21:19 +02:00
Michael Wright	b36d7a0c61	Remove to_string()s from CompilerLintFunctions	2019-06-06 07:12:12 +02:00
bors	42f96b2558	Auto merge of #4164 - mikerite:fix-4144, r=mikerite ... Fix .map(..).unwrap_or_else(..) bad suggestion Closes #4144	2019-06-04 06:28:23 +00:00
mikerite	3b7d6eeb4f	Fix comment grammar ... Co-Authored-By: Philipp Krones <hello@philkrones.com>	2019-06-04 08:27:31 +02:00
bors	28a39e9741	Auto merge of #4165 - BO41:needless_range_loop, r=phansch ... Add example to needless_range_loop adds a "could be written as" example btw, is it correct that the lint triggers even if the index is used not just for getting the values by index? So that I have to add `.iter().enumerate()` to still get an index? changelog: none	2019-06-03 08:28:15 +00:00
BO41	dd007e4477	Change from ignore to rust	2019-06-02 20:06:50 +02:00
Mateusz Mikuła	a3ace5c3ca	Cargo fmt	2019-06-02 18:58:11 +02:00
Mateusz Mikuła	9fefe36737	Rustup for https://github.com/rust-lang/rust/pull/61276	2019-06-02 18:30:40 +02:00
BO41	bd8f289247	Add example to needless_range_loop	2019-06-02 15:28:32 +02:00
Michael Wright	98585a0324	Fix .map(..).unwrap_or_else(..) bad suggestion ... Closes #4144	2019-06-02 08:50:20 +02:00
Lzu Tao	f67c3e4b2a	Make use of new outer_expn_info() function	2019-06-01 16:25:51 +07:00
Andy Russell	2d0c797da6	add suggestions for print/write with newline lint	2019-05-30 13:46:04 -04:00
bors	0ab3f1762e	Auto merge of #4113 - rust-lang:author, r=flip1995 ... Fix `Block` dump in author lint changelog: The `#[clippy::author]` attribute now emits correct pattern code for block expressions	2019-05-30 10:34:56 +00:00
bors	018fa30c56	Auto merge of #4153 - matthiaskrgr:rustup_5, r=flip1995 ... rustup https://github.com/rust-lang/rust/pull/60928 changelog: none	2019-05-29 20:01:57 +00:00
Matthias Krüger	22e77dfa98	rustup https://github.com/rust-lang/rust/pull/60928	2019-05-29 00:41:34 +02:00
Matthias Krüger	c9cc11e9fa	rustup https://github.com/rust-lang/rust/pull/61164 ... (which is included in https://github.com/rust-lang/rust/pull/61274)	2019-05-28 20:47:16 +02:00
Oliver Scherer	f98e4bd33b	Fix Block dump in author lint	2019-05-28 13:01:11 +02:00
bors	fb33fad08e	Auto merge of #4142 - agnxy:rename-assoc, r=flip1995 ... Rename "Associated*" to "Assoc*" This is to fix the breakage introduced by rust-lang/rust#60163. changelog: none	2019-05-28 08:59:06 +00:00
bors	d57845ffdf	Auto merge of #4071 - matthiaskrgr:sizeof, r=flip1995 ... trivially_copy_pass_by_ref: print size of type and limit in the lint message changelog: trivially_copy_pass_by_ref: print size of type and limit in the lint message	2019-05-28 07:56:04 +00:00
Oliver Scherer	73d1830812	Rustup to rustc 1.36.0-nightly (fa40a111f 2019-05-27)	2019-05-27 21:58:54 +02:00
bors	7b501f0f6a	Auto merge of #4137 - euclio:let-return, r=oli-obk ... tweak `let_and_return` diagnostic changelog: `let_and_return`: label the unnecessary let binding and convert the note to a structured suggestion	2019-05-27 13:04:14 +00:00
bors	eb0a2884d2	Auto merge of #4149 - flip1995:rollup-6knpdqb, r=flip1995 ... Rollup of 2 pull requests Successful merges: - #4102 (Fix match_same_arms to fail late) - #4119 (Improve non ascii literal) Failed merges: r? @ghost	2019-05-27 11:33:29 +00:00
Philipp Krones	dce670c73c	Rollup merge of #4119 - BO41:non_ascii_literal, r=flip1995 ... Improve non ascii literal This PR improves the example of the [non_ascii_literal](https://rust-lang.github.io/rust-clippy/master/index.html#non_ascii_literal) lint. It also makes it auto-fixable. Please review. This is my first PR to this project. (Thanks @flip1995 for the help :) changelog: none fixes #4117	2019-05-27 13:09:17 +02:00
Philipp Krones	f0a767352b	Rollup merge of #4102 - Urriel:fix/4096_match_same_arms, r=flip1995 ... Fix match_same_arms to fail late Changes: - Add a function search_same_list which return a list of matched expressions - Change the match_same_arms implementation behavior. It will lint each same arms found. fixes #4096 changelog: none	2019-05-27 13:09:16 +02:00
bors	cf81a3b6d0	Auto merge of #3832 - HarrisonMc555:use_last, r=flip1995 ... Implement "Use last" lint Closes #3673 This lint checks the use of `x.get(x.len() - 1)` and suggests `x.last()` (where `x` is a `Vec`). There's at least one more thing that needs to happen here. I believe I am correctly checking most of the scenarios and avoiding false positives. However, if different `Vec`s are used for the `x.get` and `y.len`, then it will emit a false positive. In other words, I need to check to make sure the `Vec`s are the same. Also, a lot of these commits were temporary and not helpful to the project history...am I supposed to squash on merge? If so, how do I do that? changelog: New lint: `get_last_with_len`	2019-05-27 11:04:38 +00:00
Seo Sanghyeon	2c53a3f970	Fix typo in comment	2019-05-27 12:32:04 +09:00
Oliver Scherer	637e656451	Rustfmt	2019-05-26 17:36:21 +02:00
Oliver Scherer	fd2ecfcc89	Rustup to rustc 1.36.0-nightly (2268d9923 2019-05-26)	2019-05-26 16:47:26 +02:00
Andrew Xu	dcf064a4f9	Rename "Associated*" to "Assoc*" ... This is to fix the breakage introduced by rust-lang/rust#60163.	2019-05-25 20:31:34 +08:00
Philipp Hansch	a650659d63	Rustup to https://github.com/rust-lang/rust/pull/61026	2019-05-25 09:45:07 +02:00
Andy Russell	effea41fe4	tweak let_and_return diagnostic ... Label the unnecessary let binding and convert the note to structured suggestion.	2019-05-24 14:52:55 -04:00
Matthias Krüger	c67d2b121a	rustup https://github.com/rust-lang/rust/pull/60803/	2019-05-24 15:25:36 +02:00
Philipp Hansch	aca56727db	Rustup to https://github.com/rust-lang/rust/pull/59545	2019-05-24 08:19:51 +02:00
Matthias Krüger	5d58163f7d	trivially_copy_pass_by_ref: print size of type and limit in the lint message	2019-05-23 23:48:20 +02:00
Philipp Hansch	7e9db162b5	Rollup merge of #4129 - matthiaskrgr:if_chain, r=phansch ... update if_chain to 1.0.0	2019-05-23 21:28:49 +02:00
Philipp Hansch	a316179850	Rustup to https://github.com/rust-lang/rust/pull/60965	2019-05-23 20:19:00 +02:00
Matthias Krüger	655aef7c6c	update if_chain to 1.0.0	2019-05-23 17:23:59 +02:00
Philipp Hansch	edb698105f	cargo fmt ... Roses are red Violets are blue `Add rustfmt to a pre-commit hook` is what I should do.	2019-05-23 07:24:53 +02:00
Philipp Hansch	635a2fa5df	Rustup to https://github.com/rust-lang/rust/pull/60740 ... changelog: none	2019-05-23 07:19:25 +02:00
Manish Goregaokar	a6cf35264f	Rustup to rustc 1.36.0-nightly (dbfe70dfc 2019-05-22)	2019-05-21 21:58:27 -07:00
Vincent Dal Maso	fa9f744c2c	Add the common case search ... Changes: - Refactor the common case search into a function. - Fix the useless Option around the vec in the search_same_list.	2019-05-21 13:08:19 +02:00
Philipp Krones	42d849c185	Formatting inside if_chain! macro	2019-05-21 10:45:38 +02:00
Harrison McCullough	f32c2fcb7e	Implement get_last_with_len lint	2019-05-20 18:01:21 -06:00
BO41	36c8aaba8f	Fix tests and make other ascii lints auto-fixable	2019-05-20 16:02:50 +02:00
BO41	859b329603	Make non_ascii_literal auto-fixable	2019-05-20 15:23:38 +02:00
BO41	874de889dc	Improve verbosity of non_ascii_literal lint example	2019-05-20 15:08:53 +02:00
bors	fd56381015	Auto merge of #4088 - pJunger:check1, r=oli-obk ... Added lint for TryFrom for checked integer conversion. works towards #3947 Added lint for try_from for checked integer conversion. Should recognize simple & straight-forward checked integer conversions.	2019-05-20 09:31:09 +00:00