Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-24 05:33:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

update error message, refactor disallowed_method

Browse source
This commit is contained in:
Frank 2020-09-25 09:38:19 -05:00
parent 3886edb05a
commit f9da2946d8
3 changed files with 13 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
clippy_lints/src/disallowed_method.rs
View file

@ -27,7 +27,7 @@ declare_clippy_lint! {
/// ``` /// ```
pub DISALLOWED_METHOD, pub DISALLOWED_METHOD,
nursery, nursery,
"used disallowed method call" "use of a disallowed method call"
} }
#[derive(Clone, Debug)] #[derive(Clone, Debug)]
@ -55,18 +55,17 @@ impl<'tcx> LateLintPass<'tcx> for DisallowedMethod {
let method_call = cx.get_def_path(def_id); let method_call = cx.get_def_path(def_id);
if self.disallowed.contains(&method_call) { if self.disallowed.contains(&method_call) {
let method = method_call
.iter()
.map(|s| s.to_ident_string())
.collect::<Vec<_>>()
.join("::");
span_lint( span_lint(
cx, cx,
DISALLOWED_METHOD, DISALLOWED_METHOD,
expr.span, expr.span,
&format!( &format!("use of a disallowed method `{}`", method),
"Use of a disallowed method `{}`",
method_call
.iter()
.map(|s| s.to_ident_string())
.collect::<Vec<_>>()
.join("::"),
),
); );
} }
} }

4
tests/ui-toml/toml_disallowed_method/conf_disallowed_method.stderr
View file

@ -1,4 +1,4 @@
error: Use of a disallowed method `regex::re_unicode::Regex::is_match` error: use of a disallowed method `regex::re_unicode::Regex::is_match`
--> $DIR/conf_disallowed_method.rs:10:5 --> $DIR/conf_disallowed_method.rs:10:5
| |
LL | re.is_match("abc"); LL | re.is_match("abc");
@ -6,7 +6,7 @@ LL | re.is_match("abc");
| |
= note: `-D clippy::disallowed-method` implied by `-D warnings` = note: `-D clippy::disallowed-method` implied by `-D warnings`
error: Use of a disallowed method `core::iter::traits::iterator::Iterator::sum` error: use of a disallowed method `core::iter::traits::iterator::Iterator::sum`
--> $DIR/conf_disallowed_method.rs:12:5 --> $DIR/conf_disallowed_method.rs:12:5
| |
LL | a.iter().sum::<i32>(); LL | a.iter().sum::<i32>();

6
tests/ui/disallowed_method.stderr
View file

@ -1,4 +1,4 @@
error: Use of a disallowed method `disallowed_method::Baz::bad_method` error: use of a disallowed method `disallowed_method::Baz::bad_method`
--> $DIR/disallowed_method.rs:48:5 --> $DIR/disallowed_method.rs:48:5
| |
LL | b.bad_method(); LL | b.bad_method();
@ -6,13 +6,13 @@ LL | b.bad_method();
| |
= note: `-D clippy::disallowed-method` implied by `-D warnings` = note: `-D clippy::disallowed-method` implied by `-D warnings`
error: Use of a disallowed method `disallowed_method::Baz::bad_method` error: use of a disallowed method `disallowed_method::Baz::bad_method`
--> $DIR/disallowed_method.rs:49:5 --> $DIR/disallowed_method.rs:49:5
| |
LL | c.bad_method(); LL | c.bad_method();
| ^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^
error: Use of a disallowed method `disallowed_method::Foo::bad_method` error: use of a disallowed method `disallowed_method::Foo::bad_method`
--> $DIR/disallowed_method.rs:50:5 --> $DIR/disallowed_method.rs:50:5
| |
LL | f.bad_method(); LL | f.bad_method();