mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-11 07:34:18 +00:00
Handle --no-deps
flag same as --fix
flag.
As proposed in the pull request thread, there is some inconsistency in handling the `--no-deps` flag which requires `--` before it, and `--fix` flag which does not. In this commit the `--no-deps` flag does not need the `--` anymore. However, it can still be used that way: `cargo clipyy -- --no-deps`.
This commit is contained in:
parent
0e5802ef5d
commit
f7af8bf2c1
2 changed files with 7 additions and 4 deletions
|
@ -19,8 +19,6 @@ Common options:
|
|||
-h, --help Print this message
|
||||
-V, --version Print version info and exit
|
||||
|
||||
Note: --no-deps flag is used with `cargo clippy --`. Example: `cargo clippy -- --no-deps`
|
||||
|
||||
Other options are the same as `cargo check`.
|
||||
|
||||
To allow or deny a lint from the command line you can use `cargo clippy --`
|
||||
|
@ -75,6 +73,7 @@ impl ClippyCmd {
|
|||
{
|
||||
let mut cargo_subcommand = "check";
|
||||
let mut args = vec![];
|
||||
let mut clippy_args: Vec<String> = vec![];
|
||||
|
||||
for arg in old_args.by_ref() {
|
||||
match arg.as_str() {
|
||||
|
@ -82,6 +81,10 @@ impl ClippyCmd {
|
|||
cargo_subcommand = "fix";
|
||||
continue;
|
||||
},
|
||||
"--no-deps" => {
|
||||
clippy_args.push("--no-deps".into());
|
||||
continue;
|
||||
},
|
||||
"--" => break,
|
||||
_ => {},
|
||||
}
|
||||
|
@ -89,7 +92,7 @@ impl ClippyCmd {
|
|||
args.push(arg);
|
||||
}
|
||||
|
||||
let mut clippy_args: Vec<String> = old_args.collect();
|
||||
clippy_args.append(&mut (old_args.collect()));
|
||||
if cargo_subcommand == "fix" && !clippy_args.iter().any(|arg| arg == "--no-deps") {
|
||||
clippy_args.push("--no-deps".into());
|
||||
}
|
||||
|
|
|
@ -76,8 +76,8 @@ fn test_no_deps_ignores_path_deps_in_workspaces() {
|
|||
.env("CARGO_INCREMENTAL", "0")
|
||||
.arg("clippy")
|
||||
.args(&["-p", "subcrate"])
|
||||
.arg("--")
|
||||
.arg("--no-deps")
|
||||
.arg("--")
|
||||
.arg("-Cdebuginfo=0") // disable debuginfo to generate less data in the target dir
|
||||
.args(&["--cfg", r#"feature="primary_package_test""#])
|
||||
.output()
|
||||
|
|
Loading…
Reference in a new issue