From f515d7bb67d228be306d285e9ee7d5dd41ab1602 Mon Sep 17 00:00:00 2001 From: Andre Bogus Date: Sun, 6 Aug 2017 13:10:21 +0200 Subject: [PATCH] Change all links to reflect the move to rust-lang-nursery --- CHANGELOG.md | 420 ++++++++++++++++----------------- CONTRIBUTING.md | 10 +- Cargo.toml | 6 +- PUBLISH.md | 2 +- README.md | 422 +++++++++++++++++----------------- clippy_lints/Cargo.toml | 2 +- clippy_lints/README.md | 2 +- clippy_lints/src/copies.rs | 2 +- clippy_lints/src/types.rs | 2 +- clippy_lints/src/utils/mod.rs | 2 +- mini-macro/Cargo.toml | 2 +- tests/ui/doc.rs | 4 +- tests/ui/methods.rs | 2 +- tests/ui/module_inception.rs | 2 +- util/gh-pages/index.html | 2 +- util/update_lints.py | 2 +- 16 files changed, 442 insertions(+), 442 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c145618db..208255eec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -392,214 +392,214 @@ All notable changes to this project will be documented in this file. [configuration file]: ./rust-clippy#configuration -[`absurd_extreme_comparisons`]: https://github.com/Manishearth/rust-clippy/wiki#absurd_extreme_comparisons -[`almost_swapped`]: https://github.com/Manishearth/rust-clippy/wiki#almost_swapped -[`approx_constant`]: https://github.com/Manishearth/rust-clippy/wiki#approx_constant -[`assign_op_pattern`]: https://github.com/Manishearth/rust-clippy/wiki#assign_op_pattern -[`assign_ops`]: https://github.com/Manishearth/rust-clippy/wiki#assign_ops -[`bad_bit_mask`]: https://github.com/Manishearth/rust-clippy/wiki#bad_bit_mask -[`blacklisted_name`]: https://github.com/Manishearth/rust-clippy/wiki#blacklisted_name -[`block_in_if_condition_expr`]: https://github.com/Manishearth/rust-clippy/wiki#block_in_if_condition_expr -[`block_in_if_condition_stmt`]: https://github.com/Manishearth/rust-clippy/wiki#block_in_if_condition_stmt -[`bool_comparison`]: https://github.com/Manishearth/rust-clippy/wiki#bool_comparison -[`borrowed_box`]: https://github.com/Manishearth/rust-clippy/wiki#borrowed_box -[`box_vec`]: https://github.com/Manishearth/rust-clippy/wiki#box_vec -[`boxed_local`]: https://github.com/Manishearth/rust-clippy/wiki#boxed_local -[`builtin_type_shadow`]: https://github.com/Manishearth/rust-clippy/wiki#builtin_type_shadow -[`cast_possible_truncation`]: https://github.com/Manishearth/rust-clippy/wiki#cast_possible_truncation -[`cast_possible_wrap`]: https://github.com/Manishearth/rust-clippy/wiki#cast_possible_wrap -[`cast_precision_loss`]: https://github.com/Manishearth/rust-clippy/wiki#cast_precision_loss -[`cast_sign_loss`]: https://github.com/Manishearth/rust-clippy/wiki#cast_sign_loss -[`char_lit_as_u8`]: https://github.com/Manishearth/rust-clippy/wiki#char_lit_as_u8 -[`chars_next_cmp`]: https://github.com/Manishearth/rust-clippy/wiki#chars_next_cmp -[`clone_double_ref`]: https://github.com/Manishearth/rust-clippy/wiki#clone_double_ref -[`clone_on_copy`]: https://github.com/Manishearth/rust-clippy/wiki#clone_on_copy -[`cmp_nan`]: https://github.com/Manishearth/rust-clippy/wiki#cmp_nan -[`cmp_null`]: https://github.com/Manishearth/rust-clippy/wiki#cmp_null -[`cmp_owned`]: https://github.com/Manishearth/rust-clippy/wiki#cmp_owned -[`collapsible_if`]: https://github.com/Manishearth/rust-clippy/wiki#collapsible_if -[`crosspointer_transmute`]: https://github.com/Manishearth/rust-clippy/wiki#crosspointer_transmute -[`cyclomatic_complexity`]: https://github.com/Manishearth/rust-clippy/wiki#cyclomatic_complexity -[`deprecated_semver`]: https://github.com/Manishearth/rust-clippy/wiki#deprecated_semver -[`deref_addrof`]: https://github.com/Manishearth/rust-clippy/wiki#deref_addrof -[`derive_hash_xor_eq`]: https://github.com/Manishearth/rust-clippy/wiki#derive_hash_xor_eq -[`diverging_sub_expression`]: https://github.com/Manishearth/rust-clippy/wiki#diverging_sub_expression -[`doc_markdown`]: https://github.com/Manishearth/rust-clippy/wiki#doc_markdown -[`double_neg`]: https://github.com/Manishearth/rust-clippy/wiki#double_neg -[`double_parens`]: https://github.com/Manishearth/rust-clippy/wiki#double_parens -[`drop_copy`]: https://github.com/Manishearth/rust-clippy/wiki#drop_copy -[`drop_ref`]: https://github.com/Manishearth/rust-clippy/wiki#drop_ref -[`duplicate_underscore_argument`]: https://github.com/Manishearth/rust-clippy/wiki#duplicate_underscore_argument -[`empty_enum`]: https://github.com/Manishearth/rust-clippy/wiki#empty_enum -[`empty_loop`]: https://github.com/Manishearth/rust-clippy/wiki#empty_loop -[`enum_clike_unportable_variant`]: https://github.com/Manishearth/rust-clippy/wiki#enum_clike_unportable_variant -[`enum_glob_use`]: https://github.com/Manishearth/rust-clippy/wiki#enum_glob_use -[`enum_variant_names`]: https://github.com/Manishearth/rust-clippy/wiki#enum_variant_names -[`eq_op`]: https://github.com/Manishearth/rust-clippy/wiki#eq_op -[`eval_order_dependence`]: https://github.com/Manishearth/rust-clippy/wiki#eval_order_dependence -[`expl_impl_clone_on_copy`]: https://github.com/Manishearth/rust-clippy/wiki#expl_impl_clone_on_copy -[`explicit_counter_loop`]: https://github.com/Manishearth/rust-clippy/wiki#explicit_counter_loop -[`explicit_into_iter_loop`]: https://github.com/Manishearth/rust-clippy/wiki#explicit_into_iter_loop -[`explicit_iter_loop`]: https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop -[`extend_from_slice`]: https://github.com/Manishearth/rust-clippy/wiki#extend_from_slice -[`filter_map`]: https://github.com/Manishearth/rust-clippy/wiki#filter_map -[`filter_next`]: https://github.com/Manishearth/rust-clippy/wiki#filter_next -[`float_arithmetic`]: https://github.com/Manishearth/rust-clippy/wiki#float_arithmetic -[`float_cmp`]: https://github.com/Manishearth/rust-clippy/wiki#float_cmp -[`for_kv_map`]: https://github.com/Manishearth/rust-clippy/wiki#for_kv_map -[`for_loop_over_option`]: https://github.com/Manishearth/rust-clippy/wiki#for_loop_over_option -[`for_loop_over_result`]: https://github.com/Manishearth/rust-clippy/wiki#for_loop_over_result -[`forget_copy`]: https://github.com/Manishearth/rust-clippy/wiki#forget_copy -[`forget_ref`]: https://github.com/Manishearth/rust-clippy/wiki#forget_ref -[`get_unwrap`]: https://github.com/Manishearth/rust-clippy/wiki#get_unwrap -[`identity_op`]: https://github.com/Manishearth/rust-clippy/wiki#identity_op -[`if_let_redundant_pattern_matching`]: https://github.com/Manishearth/rust-clippy/wiki#if_let_redundant_pattern_matching -[`if_let_some_result`]: https://github.com/Manishearth/rust-clippy/wiki#if_let_some_result -[`if_not_else`]: https://github.com/Manishearth/rust-clippy/wiki#if_not_else -[`if_same_then_else`]: https://github.com/Manishearth/rust-clippy/wiki#if_same_then_else -[`ifs_same_cond`]: https://github.com/Manishearth/rust-clippy/wiki#ifs_same_cond -[`inconsistent_digit_grouping`]: https://github.com/Manishearth/rust-clippy/wiki#inconsistent_digit_grouping -[`indexing_slicing`]: https://github.com/Manishearth/rust-clippy/wiki#indexing_slicing -[`ineffective_bit_mask`]: https://github.com/Manishearth/rust-clippy/wiki#ineffective_bit_mask -[`inline_always`]: https://github.com/Manishearth/rust-clippy/wiki#inline_always -[`integer_arithmetic`]: https://github.com/Manishearth/rust-clippy/wiki#integer_arithmetic -[`invalid_regex`]: https://github.com/Manishearth/rust-clippy/wiki#invalid_regex -[`invalid_upcast_comparisons`]: https://github.com/Manishearth/rust-clippy/wiki#invalid_upcast_comparisons -[`items_after_statements`]: https://github.com/Manishearth/rust-clippy/wiki#items_after_statements -[`iter_cloned_collect`]: https://github.com/Manishearth/rust-clippy/wiki#iter_cloned_collect -[`iter_next_loop`]: https://github.com/Manishearth/rust-clippy/wiki#iter_next_loop -[`iter_nth`]: https://github.com/Manishearth/rust-clippy/wiki#iter_nth -[`iter_skip_next`]: https://github.com/Manishearth/rust-clippy/wiki#iter_skip_next -[`iterator_step_by_zero`]: https://github.com/Manishearth/rust-clippy/wiki#iterator_step_by_zero -[`large_digit_groups`]: https://github.com/Manishearth/rust-clippy/wiki#large_digit_groups -[`large_enum_variant`]: https://github.com/Manishearth/rust-clippy/wiki#large_enum_variant -[`len_without_is_empty`]: https://github.com/Manishearth/rust-clippy/wiki#len_without_is_empty -[`len_zero`]: https://github.com/Manishearth/rust-clippy/wiki#len_zero -[`let_and_return`]: https://github.com/Manishearth/rust-clippy/wiki#let_and_return -[`let_unit_value`]: https://github.com/Manishearth/rust-clippy/wiki#let_unit_value -[`linkedlist`]: https://github.com/Manishearth/rust-clippy/wiki#linkedlist -[`logic_bug`]: https://github.com/Manishearth/rust-clippy/wiki#logic_bug -[`manual_swap`]: https://github.com/Manishearth/rust-clippy/wiki#manual_swap -[`many_single_char_names`]: https://github.com/Manishearth/rust-clippy/wiki#many_single_char_names -[`map_clone`]: https://github.com/Manishearth/rust-clippy/wiki#map_clone -[`map_entry`]: https://github.com/Manishearth/rust-clippy/wiki#map_entry -[`match_bool`]: https://github.com/Manishearth/rust-clippy/wiki#match_bool -[`match_overlapping_arm`]: https://github.com/Manishearth/rust-clippy/wiki#match_overlapping_arm -[`match_ref_pats`]: https://github.com/Manishearth/rust-clippy/wiki#match_ref_pats -[`match_same_arms`]: https://github.com/Manishearth/rust-clippy/wiki#match_same_arms -[`match_wild_err_arm`]: https://github.com/Manishearth/rust-clippy/wiki#match_wild_err_arm -[`mem_forget`]: https://github.com/Manishearth/rust-clippy/wiki#mem_forget -[`min_max`]: https://github.com/Manishearth/rust-clippy/wiki#min_max -[`misrefactored_assign_op`]: https://github.com/Manishearth/rust-clippy/wiki#misrefactored_assign_op -[`missing_docs_in_private_items`]: https://github.com/Manishearth/rust-clippy/wiki#missing_docs_in_private_items -[`mixed_case_hex_literals`]: https://github.com/Manishearth/rust-clippy/wiki#mixed_case_hex_literals -[`module_inception`]: https://github.com/Manishearth/rust-clippy/wiki#module_inception -[`modulo_one`]: https://github.com/Manishearth/rust-clippy/wiki#modulo_one -[`mut_from_ref`]: https://github.com/Manishearth/rust-clippy/wiki#mut_from_ref -[`mut_mut`]: https://github.com/Manishearth/rust-clippy/wiki#mut_mut -[`mutex_atomic`]: https://github.com/Manishearth/rust-clippy/wiki#mutex_atomic -[`mutex_integer`]: https://github.com/Manishearth/rust-clippy/wiki#mutex_integer -[`needless_bool`]: https://github.com/Manishearth/rust-clippy/wiki#needless_bool -[`needless_borrow`]: https://github.com/Manishearth/rust-clippy/wiki#needless_borrow -[`needless_borrowed_reference`]: https://github.com/Manishearth/rust-clippy/wiki#needless_borrowed_reference -[`needless_continue`]: https://github.com/Manishearth/rust-clippy/wiki#needless_continue -[`needless_lifetimes`]: https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes -[`needless_pass_by_value`]: https://github.com/Manishearth/rust-clippy/wiki#needless_pass_by_value -[`needless_range_loop`]: https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop -[`needless_return`]: https://github.com/Manishearth/rust-clippy/wiki#needless_return -[`needless_update`]: https://github.com/Manishearth/rust-clippy/wiki#needless_update -[`neg_multiply`]: https://github.com/Manishearth/rust-clippy/wiki#neg_multiply -[`never_loop`]: https://github.com/Manishearth/rust-clippy/wiki#never_loop -[`new_ret_no_self`]: https://github.com/Manishearth/rust-clippy/wiki#new_ret_no_self -[`new_without_default`]: https://github.com/Manishearth/rust-clippy/wiki#new_without_default -[`new_without_default_derive`]: https://github.com/Manishearth/rust-clippy/wiki#new_without_default_derive -[`no_effect`]: https://github.com/Manishearth/rust-clippy/wiki#no_effect -[`non_ascii_literal`]: https://github.com/Manishearth/rust-clippy/wiki#non_ascii_literal -[`nonminimal_bool`]: https://github.com/Manishearth/rust-clippy/wiki#nonminimal_bool -[`nonsensical_open_options`]: https://github.com/Manishearth/rust-clippy/wiki#nonsensical_open_options -[`not_unsafe_ptr_arg_deref`]: https://github.com/Manishearth/rust-clippy/wiki#not_unsafe_ptr_arg_deref -[`ok_expect`]: https://github.com/Manishearth/rust-clippy/wiki#ok_expect -[`op_ref`]: https://github.com/Manishearth/rust-clippy/wiki#op_ref -[`option_map_unwrap_or`]: https://github.com/Manishearth/rust-clippy/wiki#option_map_unwrap_or -[`option_map_unwrap_or_else`]: https://github.com/Manishearth/rust-clippy/wiki#option_map_unwrap_or_else -[`option_unwrap_used`]: https://github.com/Manishearth/rust-clippy/wiki#option_unwrap_used -[`or_fun_call`]: https://github.com/Manishearth/rust-clippy/wiki#or_fun_call -[`out_of_bounds_indexing`]: https://github.com/Manishearth/rust-clippy/wiki#out_of_bounds_indexing -[`overflow_check_conditional`]: https://github.com/Manishearth/rust-clippy/wiki#overflow_check_conditional -[`panic_params`]: https://github.com/Manishearth/rust-clippy/wiki#panic_params -[`partialeq_ne_impl`]: https://github.com/Manishearth/rust-clippy/wiki#partialeq_ne_impl -[`possible_missing_comma`]: https://github.com/Manishearth/rust-clippy/wiki#possible_missing_comma -[`precedence`]: https://github.com/Manishearth/rust-clippy/wiki#precedence -[`print_stdout`]: https://github.com/Manishearth/rust-clippy/wiki#print_stdout -[`print_with_newline`]: https://github.com/Manishearth/rust-clippy/wiki#print_with_newline -[`ptr_arg`]: https://github.com/Manishearth/rust-clippy/wiki#ptr_arg -[`pub_enum_variant_names`]: https://github.com/Manishearth/rust-clippy/wiki#pub_enum_variant_names -[`range_step_by_zero`]: https://github.com/Manishearth/rust-clippy/wiki#range_step_by_zero -[`range_zip_with_len`]: https://github.com/Manishearth/rust-clippy/wiki#range_zip_with_len -[`redundant_closure`]: https://github.com/Manishearth/rust-clippy/wiki#redundant_closure -[`redundant_closure_call`]: https://github.com/Manishearth/rust-clippy/wiki#redundant_closure_call -[`redundant_pattern`]: https://github.com/Manishearth/rust-clippy/wiki#redundant_pattern -[`regex_macro`]: https://github.com/Manishearth/rust-clippy/wiki#regex_macro -[`result_unwrap_used`]: https://github.com/Manishearth/rust-clippy/wiki#result_unwrap_used -[`reverse_range_loop`]: https://github.com/Manishearth/rust-clippy/wiki#reverse_range_loop -[`search_is_some`]: https://github.com/Manishearth/rust-clippy/wiki#search_is_some -[`serde_api_misuse`]: https://github.com/Manishearth/rust-clippy/wiki#serde_api_misuse -[`shadow_reuse`]: https://github.com/Manishearth/rust-clippy/wiki#shadow_reuse -[`shadow_same`]: https://github.com/Manishearth/rust-clippy/wiki#shadow_same -[`shadow_unrelated`]: https://github.com/Manishearth/rust-clippy/wiki#shadow_unrelated -[`short_circuit_statement`]: https://github.com/Manishearth/rust-clippy/wiki#short_circuit_statement -[`should_assert_eq`]: https://github.com/Manishearth/rust-clippy/wiki#should_assert_eq -[`should_implement_trait`]: https://github.com/Manishearth/rust-clippy/wiki#should_implement_trait -[`similar_names`]: https://github.com/Manishearth/rust-clippy/wiki#similar_names -[`single_char_pattern`]: https://github.com/Manishearth/rust-clippy/wiki#single_char_pattern -[`single_match`]: https://github.com/Manishearth/rust-clippy/wiki#single_match -[`single_match_else`]: https://github.com/Manishearth/rust-clippy/wiki#single_match_else -[`str_to_string`]: https://github.com/Manishearth/rust-clippy/wiki#str_to_string -[`string_add`]: https://github.com/Manishearth/rust-clippy/wiki#string_add -[`string_add_assign`]: https://github.com/Manishearth/rust-clippy/wiki#string_add_assign -[`string_extend_chars`]: https://github.com/Manishearth/rust-clippy/wiki#string_extend_chars -[`string_lit_as_bytes`]: https://github.com/Manishearth/rust-clippy/wiki#string_lit_as_bytes -[`string_to_string`]: https://github.com/Manishearth/rust-clippy/wiki#string_to_string -[`stutter`]: https://github.com/Manishearth/rust-clippy/wiki#stutter -[`suspicious_assignment_formatting`]: https://github.com/Manishearth/rust-clippy/wiki#suspicious_assignment_formatting -[`suspicious_else_formatting`]: https://github.com/Manishearth/rust-clippy/wiki#suspicious_else_formatting -[`temporary_assignment`]: https://github.com/Manishearth/rust-clippy/wiki#temporary_assignment -[`temporary_cstring_as_ptr`]: https://github.com/Manishearth/rust-clippy/wiki#temporary_cstring_as_ptr -[`too_many_arguments`]: https://github.com/Manishearth/rust-clippy/wiki#too_many_arguments -[`toplevel_ref_arg`]: https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg -[`transmute_ptr_to_ref`]: https://github.com/Manishearth/rust-clippy/wiki#transmute_ptr_to_ref -[`trivial_regex`]: https://github.com/Manishearth/rust-clippy/wiki#trivial_regex -[`type_complexity`]: https://github.com/Manishearth/rust-clippy/wiki#type_complexity -[`unicode_not_nfc`]: https://github.com/Manishearth/rust-clippy/wiki#unicode_not_nfc -[`unit_cmp`]: https://github.com/Manishearth/rust-clippy/wiki#unit_cmp -[`unnecessary_cast`]: https://github.com/Manishearth/rust-clippy/wiki#unnecessary_cast -[`unnecessary_mut_passed`]: https://github.com/Manishearth/rust-clippy/wiki#unnecessary_mut_passed -[`unnecessary_operation`]: https://github.com/Manishearth/rust-clippy/wiki#unnecessary_operation -[`unneeded_field_pattern`]: https://github.com/Manishearth/rust-clippy/wiki#unneeded_field_pattern -[`unreadable_literal`]: https://github.com/Manishearth/rust-clippy/wiki#unreadable_literal -[`unsafe_removed_from_name`]: https://github.com/Manishearth/rust-clippy/wiki#unsafe_removed_from_name -[`unseparated_literal_suffix`]: https://github.com/Manishearth/rust-clippy/wiki#unseparated_literal_suffix -[`unstable_as_mut_slice`]: https://github.com/Manishearth/rust-clippy/wiki#unstable_as_mut_slice -[`unstable_as_slice`]: https://github.com/Manishearth/rust-clippy/wiki#unstable_as_slice -[`unused_collect`]: https://github.com/Manishearth/rust-clippy/wiki#unused_collect -[`unused_io_amount`]: https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount -[`unused_label`]: https://github.com/Manishearth/rust-clippy/wiki#unused_label -[`unused_lifetimes`]: https://github.com/Manishearth/rust-clippy/wiki#unused_lifetimes -[`use_debug`]: https://github.com/Manishearth/rust-clippy/wiki#use_debug -[`used_underscore_binding`]: https://github.com/Manishearth/rust-clippy/wiki#used_underscore_binding -[`useless_attribute`]: https://github.com/Manishearth/rust-clippy/wiki#useless_attribute -[`useless_format`]: https://github.com/Manishearth/rust-clippy/wiki#useless_format -[`useless_let_if_seq`]: https://github.com/Manishearth/rust-clippy/wiki#useless_let_if_seq -[`useless_transmute`]: https://github.com/Manishearth/rust-clippy/wiki#useless_transmute -[`useless_vec`]: https://github.com/Manishearth/rust-clippy/wiki#useless_vec -[`verbose_bit_mask`]: https://github.com/Manishearth/rust-clippy/wiki#verbose_bit_mask -[`while_let_loop`]: https://github.com/Manishearth/rust-clippy/wiki#while_let_loop -[`while_let_on_iterator`]: https://github.com/Manishearth/rust-clippy/wiki#while_let_on_iterator -[`wrong_pub_self_convention`]: https://github.com/Manishearth/rust-clippy/wiki#wrong_pub_self_convention -[`wrong_self_convention`]: https://github.com/Manishearth/rust-clippy/wiki#wrong_self_convention -[`wrong_transmute`]: https://github.com/Manishearth/rust-clippy/wiki#wrong_transmute -[`zero_divided_by_zero`]: https://github.com/Manishearth/rust-clippy/wiki#zero_divided_by_zero -[`zero_prefixed_literal`]: https://github.com/Manishearth/rust-clippy/wiki#zero_prefixed_literal -[`zero_ptr`]: https://github.com/Manishearth/rust-clippy/wiki#zero_ptr -[`zero_width_space`]: https://github.com/Manishearth/rust-clippy/wiki#zero_width_space +[`absurd_extreme_comparisons`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#absurd_extreme_comparisons +[`almost_swapped`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#almost_swapped +[`approx_constant`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#approx_constant +[`assign_op_pattern`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#assign_op_pattern +[`assign_ops`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#assign_ops +[`bad_bit_mask`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#bad_bit_mask +[`blacklisted_name`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#blacklisted_name +[`block_in_if_condition_expr`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#block_in_if_condition_expr +[`block_in_if_condition_stmt`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#block_in_if_condition_stmt +[`bool_comparison`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#bool_comparison +[`borrowed_box`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#borrowed_box +[`box_vec`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#box_vec +[`boxed_local`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#boxed_local +[`builtin_type_shadow`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#builtin_type_shadow +[`cast_possible_truncation`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#cast_possible_truncation +[`cast_possible_wrap`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#cast_possible_wrap +[`cast_precision_loss`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#cast_precision_loss +[`cast_sign_loss`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#cast_sign_loss +[`char_lit_as_u8`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#char_lit_as_u8 +[`chars_next_cmp`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#chars_next_cmp +[`clone_double_ref`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#clone_double_ref +[`clone_on_copy`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#clone_on_copy +[`cmp_nan`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#cmp_nan +[`cmp_null`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#cmp_null +[`cmp_owned`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#cmp_owned +[`collapsible_if`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#collapsible_if +[`crosspointer_transmute`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#crosspointer_transmute +[`cyclomatic_complexity`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#cyclomatic_complexity +[`deprecated_semver`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#deprecated_semver +[`deref_addrof`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#deref_addrof +[`derive_hash_xor_eq`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#derive_hash_xor_eq +[`diverging_sub_expression`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#diverging_sub_expression +[`doc_markdown`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#doc_markdown +[`double_neg`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#double_neg +[`double_parens`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#double_parens +[`drop_copy`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#drop_copy +[`drop_ref`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#drop_ref +[`duplicate_underscore_argument`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#duplicate_underscore_argument +[`empty_enum`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#empty_enum +[`empty_loop`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#empty_loop +[`enum_clike_unportable_variant`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#enum_clike_unportable_variant +[`enum_glob_use`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#enum_glob_use +[`enum_variant_names`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#enum_variant_names +[`eq_op`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#eq_op +[`eval_order_dependence`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#eval_order_dependence +[`expl_impl_clone_on_copy`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#expl_impl_clone_on_copy +[`explicit_counter_loop`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#explicit_counter_loop +[`explicit_into_iter_loop`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#explicit_into_iter_loop +[`explicit_iter_loop`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#explicit_iter_loop +[`extend_from_slice`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#extend_from_slice +[`filter_map`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#filter_map +[`filter_next`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#filter_next +[`float_arithmetic`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#float_arithmetic +[`float_cmp`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#float_cmp +[`for_kv_map`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#for_kv_map +[`for_loop_over_option`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#for_loop_over_option +[`for_loop_over_result`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#for_loop_over_result +[`forget_copy`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#forget_copy +[`forget_ref`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#forget_ref +[`get_unwrap`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#get_unwrap +[`identity_op`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#identity_op +[`if_let_redundant_pattern_matching`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#if_let_redundant_pattern_matching +[`if_let_some_result`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#if_let_some_result +[`if_not_else`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#if_not_else +[`if_same_then_else`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#if_same_then_else +[`ifs_same_cond`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#ifs_same_cond +[`inconsistent_digit_grouping`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#inconsistent_digit_grouping +[`indexing_slicing`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#indexing_slicing +[`ineffective_bit_mask`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#ineffective_bit_mask +[`inline_always`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#inline_always +[`integer_arithmetic`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#integer_arithmetic +[`invalid_regex`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#invalid_regex +[`invalid_upcast_comparisons`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#invalid_upcast_comparisons +[`items_after_statements`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#items_after_statements +[`iter_cloned_collect`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#iter_cloned_collect +[`iter_next_loop`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#iter_next_loop +[`iter_nth`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#iter_nth +[`iter_skip_next`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#iter_skip_next +[`iterator_step_by_zero`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#iterator_step_by_zero +[`large_digit_groups`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#large_digit_groups +[`large_enum_variant`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#large_enum_variant +[`len_without_is_empty`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#len_without_is_empty +[`len_zero`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#len_zero +[`let_and_return`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#let_and_return +[`let_unit_value`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#let_unit_value +[`linkedlist`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#linkedlist +[`logic_bug`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#logic_bug +[`manual_swap`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#manual_swap +[`many_single_char_names`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#many_single_char_names +[`map_clone`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#map_clone +[`map_entry`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#map_entry +[`match_bool`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#match_bool +[`match_overlapping_arm`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#match_overlapping_arm +[`match_ref_pats`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#match_ref_pats +[`match_same_arms`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#match_same_arms +[`match_wild_err_arm`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#match_wild_err_arm +[`mem_forget`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#mem_forget +[`min_max`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#min_max +[`misrefactored_assign_op`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#misrefactored_assign_op +[`missing_docs_in_private_items`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#missing_docs_in_private_items +[`mixed_case_hex_literals`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#mixed_case_hex_literals +[`module_inception`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#module_inception +[`modulo_one`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#modulo_one +[`mut_from_ref`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#mut_from_ref +[`mut_mut`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#mut_mut +[`mutex_atomic`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#mutex_atomic +[`mutex_integer`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#mutex_integer +[`needless_bool`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_bool +[`needless_borrow`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_borrow +[`needless_borrowed_reference`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_borrowed_reference +[`needless_continue`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_continue +[`needless_lifetimes`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_lifetimes +[`needless_pass_by_value`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_pass_by_value +[`needless_range_loop`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_range_loop +[`needless_return`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_return +[`needless_update`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_update +[`neg_multiply`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#neg_multiply +[`never_loop`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#never_loop +[`new_ret_no_self`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#new_ret_no_self +[`new_without_default`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#new_without_default +[`new_without_default_derive`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#new_without_default_derive +[`no_effect`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#no_effect +[`non_ascii_literal`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#non_ascii_literal +[`nonminimal_bool`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#nonminimal_bool +[`nonsensical_open_options`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#nonsensical_open_options +[`not_unsafe_ptr_arg_deref`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#not_unsafe_ptr_arg_deref +[`ok_expect`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#ok_expect +[`op_ref`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#op_ref +[`option_map_unwrap_or`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#option_map_unwrap_or +[`option_map_unwrap_or_else`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#option_map_unwrap_or_else +[`option_unwrap_used`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#option_unwrap_used +[`or_fun_call`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#or_fun_call +[`out_of_bounds_indexing`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#out_of_bounds_indexing +[`overflow_check_conditional`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#overflow_check_conditional +[`panic_params`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#panic_params +[`partialeq_ne_impl`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#partialeq_ne_impl +[`possible_missing_comma`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#possible_missing_comma +[`precedence`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#precedence +[`print_stdout`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#print_stdout +[`print_with_newline`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#print_with_newline +[`ptr_arg`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#ptr_arg +[`pub_enum_variant_names`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#pub_enum_variant_names +[`range_step_by_zero`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#range_step_by_zero +[`range_zip_with_len`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#range_zip_with_len +[`redundant_closure`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#redundant_closure +[`redundant_closure_call`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#redundant_closure_call +[`redundant_pattern`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#redundant_pattern +[`regex_macro`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#regex_macro +[`result_unwrap_used`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#result_unwrap_used +[`reverse_range_loop`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#reverse_range_loop +[`search_is_some`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#search_is_some +[`serde_api_misuse`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#serde_api_misuse +[`shadow_reuse`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#shadow_reuse +[`shadow_same`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#shadow_same +[`shadow_unrelated`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#shadow_unrelated +[`short_circuit_statement`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#short_circuit_statement +[`should_assert_eq`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#should_assert_eq +[`should_implement_trait`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#should_implement_trait +[`similar_names`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#similar_names +[`single_char_pattern`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#single_char_pattern +[`single_match`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#single_match +[`single_match_else`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#single_match_else +[`str_to_string`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#str_to_string +[`string_add`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#string_add +[`string_add_assign`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#string_add_assign +[`string_extend_chars`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#string_extend_chars +[`string_lit_as_bytes`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#string_lit_as_bytes +[`string_to_string`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#string_to_string +[`stutter`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#stutter +[`suspicious_assignment_formatting`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#suspicious_assignment_formatting +[`suspicious_else_formatting`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#suspicious_else_formatting +[`temporary_assignment`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#temporary_assignment +[`temporary_cstring_as_ptr`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#temporary_cstring_as_ptr +[`too_many_arguments`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#too_many_arguments +[`toplevel_ref_arg`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#toplevel_ref_arg +[`transmute_ptr_to_ref`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#transmute_ptr_to_ref +[`trivial_regex`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#trivial_regex +[`type_complexity`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#type_complexity +[`unicode_not_nfc`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unicode_not_nfc +[`unit_cmp`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unit_cmp +[`unnecessary_cast`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unnecessary_cast +[`unnecessary_mut_passed`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unnecessary_mut_passed +[`unnecessary_operation`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unnecessary_operation +[`unneeded_field_pattern`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unneeded_field_pattern +[`unreadable_literal`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unreadable_literal +[`unsafe_removed_from_name`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unsafe_removed_from_name +[`unseparated_literal_suffix`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unseparated_literal_suffix +[`unstable_as_mut_slice`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unstable_as_mut_slice +[`unstable_as_slice`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unstable_as_slice +[`unused_collect`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unused_collect +[`unused_io_amount`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unused_io_amount +[`unused_label`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unused_label +[`unused_lifetimes`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#unused_lifetimes +[`use_debug`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#use_debug +[`used_underscore_binding`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#used_underscore_binding +[`useless_attribute`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#useless_attribute +[`useless_format`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#useless_format +[`useless_let_if_seq`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#useless_let_if_seq +[`useless_transmute`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#useless_transmute +[`useless_vec`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#useless_vec +[`verbose_bit_mask`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#verbose_bit_mask +[`while_let_loop`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#while_let_loop +[`while_let_on_iterator`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#while_let_on_iterator +[`wrong_pub_self_convention`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#wrong_pub_self_convention +[`wrong_self_convention`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#wrong_self_convention +[`wrong_transmute`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#wrong_transmute +[`zero_divided_by_zero`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#zero_divided_by_zero +[`zero_prefixed_literal`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#zero_prefixed_literal +[`zero_ptr`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#zero_ptr +[`zero_width_space`]: https://github.com/rust-lang-nursery/rust-clippy/wiki#zero_width_space diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 71a54d852..277e0f09b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,16 +6,16 @@ Hello fellow Rustacean! Great to see your interest in compiler internals and lin All issues on Clippy are mentored, if you want help with a bug just ask @Manishearth or @llogiq. -Some issues are easier than others. The [E-easy](https://github.com/Manishearth/rust-clippy/labels/E-easy) +Some issues are easier than others. The [E-easy](https://github.com/rust-lang-nursery/rust-clippy/labels/E-easy) label can be used to find the easy issues. If you want to work on an issue, please leave a comment so that we can assign it to you! -Issues marked [T-AST](https://github.com/Manishearth/rust-clippy/labels/T-AST) involve simple +Issues marked [T-AST](https://github.com/rust-lang-nursery/rust-clippy/labels/T-AST) involve simple matching of the syntax tree structure, and are generally easier than -[T-middle](https://github.com/Manishearth/rust-clippy/labels/T-middle) issues, which involve types +[T-middle](https://github.com/rust-lang-nursery/rust-clippy/labels/T-middle) issues, which involve types and resolved paths. -Issues marked [E-medium](https://github.com/Manishearth/rust-clippy/labels/E-medium) are generally +Issues marked [E-medium](https://github.com/rust-lang-nursery/rust-clippy/labels/E-medium) are generally pretty easy too, though it's recommended you work on an E-easy issue first. [Llogiq's blog post on lints](https://llogiq.github.io/2015/06/04/workflows.html) is a nice primer @@ -28,7 +28,7 @@ how this syntax structure is encoded in the AST, it is recommended to run `rustc example of the structure and compare with the [nodes in the AST docs](http://manishearth.github.io/rust-internals-docs/syntax/ast/). Usually the lint will end up to be a nested series of matches and ifs, -[like so](https://github.com/Manishearth/rust-clippy/blob/de5ccdfab68a5e37689f3c950ed1532ba9d652a0/src/misc.rs#L34). +[like so](https://github.com/rust-lang-nursery/rust-clippy/blob/de5ccdfab68a5e37689f3c950ed1532ba9d652a0/src/misc.rs#L34). T-middle issues can be more involved and require verifying types. The [`ty`](http://manishearth.github.io/rust-internals-docs/rustc/ty) module contains a diff --git a/Cargo.toml b/Cargo.toml index ef54f1523..560cb528a 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -9,15 +9,15 @@ authors = [ "Oliver Schneider " ] description = "A bunch of helpful lints to avoid common pitfalls in Rust" -repository = "https://github.com/Manishearth/rust-clippy" +repository = "https://github.com/rust-lang-nursery/rust-clippy" readme = "README.md" license = "MPL-2.0" keywords = ["clippy", "lint", "plugin"] categories = ["development-tools", "development-tools::cargo-plugins"] [badges] -travis-ci = { repository = "Manishearth/rust-clippy" } -appveyor = { repository = "Manishearth/rust-clippy" } +travis-ci = { repository = "rust-lang-nursery/rust-clippy" } +appveyor = { repository = "rust-lang-nursery/rust-clippy" } [lib] name = "clippy" diff --git a/PUBLISH.md b/PUBLISH.md index 9dcfc52a2..4a910c268 100644 --- a/PUBLISH.md +++ b/PUBLISH.md @@ -12,7 +12,7 @@ Steps to publish a new clippy version - `git pull`. - `git tag -s v0.0.X -m "v0.0.X"`. - `git push --tags`. -- `git clone git@github.com:Manishearth/rust-clippy.wiki.git ../rust-clippy.wiki` +- `git clone git@github.com:rust-lang-nursery/rust-clippy.wiki.git ../rust-clippy.wiki` - `./util/update_wiki.py` - `cd ../rust-clippy.wiki` - `git add *` diff --git a/README.md b/README.md index 2d711bd9e..b5cc1f094 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,8 @@ # rust-clippy -[![Build Status](https://travis-ci.org/Manishearth/rust-clippy.svg?branch=master)](https://travis-ci.org/Manishearth/rust-clippy) -[![Windows build status](https://ci.appveyor.com/api/projects/status/github/Manishearth/rust-clippy?svg=true)](https://ci.appveyor.com/project/Manishearth/rust-clippy) -[![Clippy Linting Result](http://clippy.bashy.io/github/Manishearth/rust-clippy/master/badge.svg)](http://clippy.bashy.io/github/Manishearth/rust-clippy/master/log) +[![Build Status](https://travis-ci.org/rust-lang-nursery/rust-clippy.svg?branch=master)](https://travis-ci.org/rust-lang-nursery/rust-clippy) +[![Windows build status](https://ci.appveyor.com/api/projects/status/github/rust-lang-nursery/rust-clippy?svg=true)](https://ci.appveyor.com/project/rust-lang-nursery/rust-clippy) +[![Clippy Linting Result](http://clippy.bashy.io/github/rust-lang-nursery/rust-clippy/master/badge.svg)](http://clippy.bashy.io/github/rust-lang-nursery/rust-clippy/master/log) [![Current Version](http://meritbadge.herokuapp.com/clippy)](https://crates.io/crates/clippy) [![License: MPL-2.0](https://img.shields.io/crates/l/clippy.svg)](#License) @@ -83,7 +83,7 @@ in your code, you can use: cargo rustc -- -L /path/to/clippy_so/dir/ -Z extra-plugins=clippy ``` -*[Note](https://github.com/Manishearth/rust-clippy/wiki#a-word-of-warning):* +*[Note](https://github.com/rust-lang-nursery/rust-clippy/wiki#a-word-of-warning):* Be sure that clippy was compiled with the same version of rustc that cargo invokes here! ### As a Compiler Plugin @@ -182,214 +182,214 @@ transparently: There are 204 lints included in this crate: -name | default | triggers on ------------------------------------------------------------------------------------------------------------------------|---------|---------------------------------------------------------------------------------------------------------------------------------- -[absurd_extreme_comparisons](https://github.com/Manishearth/rust-clippy/wiki#absurd_extreme_comparisons) | warn | a comparison with a maximum or minimum value that is always true or false -[almost_swapped](https://github.com/Manishearth/rust-clippy/wiki#almost_swapped) | warn | `foo = bar; bar = foo` sequence -[approx_constant](https://github.com/Manishearth/rust-clippy/wiki#approx_constant) | warn | the approximate of a known float constant (in `std::fXX::consts`) -[assign_op_pattern](https://github.com/Manishearth/rust-clippy/wiki#assign_op_pattern) | warn | assigning the result of an operation on a variable to that same variable -[assign_ops](https://github.com/Manishearth/rust-clippy/wiki#assign_ops) | allow | any compound assignment operation -[bad_bit_mask](https://github.com/Manishearth/rust-clippy/wiki#bad_bit_mask) | warn | expressions of the form `_ & mask == select` that will only ever return `true` or `false` -[blacklisted_name](https://github.com/Manishearth/rust-clippy/wiki#blacklisted_name) | warn | usage of a blacklisted/placeholder name -[block_in_if_condition_expr](https://github.com/Manishearth/rust-clippy/wiki#block_in_if_condition_expr) | warn | braces that can be eliminated in conditions, e.g. `if { true } ...` -[block_in_if_condition_stmt](https://github.com/Manishearth/rust-clippy/wiki#block_in_if_condition_stmt) | warn | complex blocks in conditions, e.g. `if { let x = true; x } ...` -[bool_comparison](https://github.com/Manishearth/rust-clippy/wiki#bool_comparison) | warn | comparing a variable to a boolean, e.g. `if x == true` -[borrowed_box](https://github.com/Manishearth/rust-clippy/wiki#borrowed_box) | warn | a borrow of a boxed type -[box_vec](https://github.com/Manishearth/rust-clippy/wiki#box_vec) | warn | usage of `Box>`, vector elements are already on the heap -[boxed_local](https://github.com/Manishearth/rust-clippy/wiki#boxed_local) | warn | using `Box` where unnecessary -[builtin_type_shadow](https://github.com/Manishearth/rust-clippy/wiki#builtin_type_shadow) | warn | shadowing a builtin type -[cast_possible_truncation](https://github.com/Manishearth/rust-clippy/wiki#cast_possible_truncation) | allow | casts that may cause truncation of the value, e.g. `x as u8` where `x: u32`, or `x as i32` where `x: f32` -[cast_possible_wrap](https://github.com/Manishearth/rust-clippy/wiki#cast_possible_wrap) | allow | casts that may cause wrapping around the value, e.g. `x as i32` where `x: u32` and `x > i32::MAX` -[cast_precision_loss](https://github.com/Manishearth/rust-clippy/wiki#cast_precision_loss) | allow | casts that cause loss of precision, e.g. `x as f32` where `x: u64` -[cast_sign_loss](https://github.com/Manishearth/rust-clippy/wiki#cast_sign_loss) | allow | casts from signed types to unsigned types, e.g. `x as u32` where `x: i32` -[char_lit_as_u8](https://github.com/Manishearth/rust-clippy/wiki#char_lit_as_u8) | warn | casting a character literal to u8 -[chars_next_cmp](https://github.com/Manishearth/rust-clippy/wiki#chars_next_cmp) | warn | using `.chars().next()` to check if a string starts with a char -[clone_double_ref](https://github.com/Manishearth/rust-clippy/wiki#clone_double_ref) | warn | using `clone` on `&&T` -[clone_on_copy](https://github.com/Manishearth/rust-clippy/wiki#clone_on_copy) | warn | using `clone` on a `Copy` type -[cmp_nan](https://github.com/Manishearth/rust-clippy/wiki#cmp_nan) | deny | comparisons to NAN, which will always return false, probably not intended -[cmp_null](https://github.com/Manishearth/rust-clippy/wiki#cmp_null) | warn | comparing a pointer to a null pointer, suggesting to use `.is_null()` instead. -[cmp_owned](https://github.com/Manishearth/rust-clippy/wiki#cmp_owned) | warn | creating owned instances for comparing with others, e.g. `x == "foo".to_string()` -[collapsible_if](https://github.com/Manishearth/rust-clippy/wiki#collapsible_if) | warn | `if`s that can be collapsed (e.g. `if x { if y { ... } }` and `else { if x { ... } }`) -[crosspointer_transmute](https://github.com/Manishearth/rust-clippy/wiki#crosspointer_transmute) | warn | transmutes that have to or from types that are a pointer to the other -[cyclomatic_complexity](https://github.com/Manishearth/rust-clippy/wiki#cyclomatic_complexity) | warn | functions that should be split up into multiple functions -[deprecated_semver](https://github.com/Manishearth/rust-clippy/wiki#deprecated_semver) | warn | use of `#[deprecated(since = "x")]` where x is not semver -[deref_addrof](https://github.com/Manishearth/rust-clippy/wiki#deref_addrof) | warn | use of `*&` or `*&mut` in an expression -[derive_hash_xor_eq](https://github.com/Manishearth/rust-clippy/wiki#derive_hash_xor_eq) | warn | deriving `Hash` but implementing `PartialEq` explicitly -[diverging_sub_expression](https://github.com/Manishearth/rust-clippy/wiki#diverging_sub_expression) | warn | whether an expression contains a diverging sub expression -[doc_markdown](https://github.com/Manishearth/rust-clippy/wiki#doc_markdown) | warn | presence of `_`, `::` or camel-case outside backticks in documentation -[double_neg](https://github.com/Manishearth/rust-clippy/wiki#double_neg) | warn | `--x`, which is a double negation of `x` and not a pre-decrement as in C/C++ -[double_parens](https://github.com/Manishearth/rust-clippy/wiki#double_parens) | warn | Warn on unnecessary double parentheses -[drop_copy](https://github.com/Manishearth/rust-clippy/wiki#drop_copy) | warn | calls to `std::mem::drop` with a value that implements Copy -[drop_ref](https://github.com/Manishearth/rust-clippy/wiki#drop_ref) | warn | calls to `std::mem::drop` with a reference instead of an owned value -[duplicate_underscore_argument](https://github.com/Manishearth/rust-clippy/wiki#duplicate_underscore_argument) | warn | function arguments having names which only differ by an underscore -[empty_enum](https://github.com/Manishearth/rust-clippy/wiki#empty_enum) | allow | enum with no variants -[empty_loop](https://github.com/Manishearth/rust-clippy/wiki#empty_loop) | warn | empty `loop {}`, which should block or sleep -[enum_clike_unportable_variant](https://github.com/Manishearth/rust-clippy/wiki#enum_clike_unportable_variant) | warn | C-like enums that are `repr(isize/usize)` and have values that don't fit into an `i32` -[enum_glob_use](https://github.com/Manishearth/rust-clippy/wiki#enum_glob_use) | allow | use items that import all variants of an enum -[enum_variant_names](https://github.com/Manishearth/rust-clippy/wiki#enum_variant_names) | warn | enums where all variants share a prefix/postfix -[eq_op](https://github.com/Manishearth/rust-clippy/wiki#eq_op) | warn | equal operands on both sides of a comparison or bitwise combination (e.g. `x == x`) -[eval_order_dependence](https://github.com/Manishearth/rust-clippy/wiki#eval_order_dependence) | warn | whether a variable read occurs before a write depends on sub-expression evaluation order -[expl_impl_clone_on_copy](https://github.com/Manishearth/rust-clippy/wiki#expl_impl_clone_on_copy) | warn | implementing `Clone` explicitly on `Copy` types -[explicit_counter_loop](https://github.com/Manishearth/rust-clippy/wiki#explicit_counter_loop) | warn | for-looping with an explicit counter when `_.enumerate()` would do -[explicit_into_iter_loop](https://github.com/Manishearth/rust-clippy/wiki#explicit_into_iter_loop) | warn | for-looping over `_.into_iter()` when `_` would do -[explicit_iter_loop](https://github.com/Manishearth/rust-clippy/wiki#explicit_iter_loop) | warn | for-looping over `_.iter()` or `_.iter_mut()` when `&_` or `&mut _` would do -[filter_map](https://github.com/Manishearth/rust-clippy/wiki#filter_map) | allow | using combinations of `filter`, `map`, `filter_map` and `flat_map` which can usually be written as a single method call -[filter_next](https://github.com/Manishearth/rust-clippy/wiki#filter_next) | warn | using `filter(p).next()`, which is more succinctly expressed as `.find(p)` -[float_arithmetic](https://github.com/Manishearth/rust-clippy/wiki#float_arithmetic) | allow | any floating-point arithmetic statement -[float_cmp](https://github.com/Manishearth/rust-clippy/wiki#float_cmp) | warn | using `==` or `!=` on float values instead of comparing difference with an epsilon -[for_kv_map](https://github.com/Manishearth/rust-clippy/wiki#for_kv_map) | warn | looping on a map using `iter` when `keys` or `values` would do -[for_loop_over_option](https://github.com/Manishearth/rust-clippy/wiki#for_loop_over_option) | warn | for-looping over an `Option`, which is more clearly expressed as an `if let` -[for_loop_over_result](https://github.com/Manishearth/rust-clippy/wiki#for_loop_over_result) | warn | for-looping over a `Result`, which is more clearly expressed as an `if let` -[forget_copy](https://github.com/Manishearth/rust-clippy/wiki#forget_copy) | warn | calls to `std::mem::forget` with a value that implements Copy -[forget_ref](https://github.com/Manishearth/rust-clippy/wiki#forget_ref) | warn | calls to `std::mem::forget` with a reference instead of an owned value -[get_unwrap](https://github.com/Manishearth/rust-clippy/wiki#get_unwrap) | warn | using `.get().unwrap()` or `.get_mut().unwrap()` when using `[]` would work instead -[identity_op](https://github.com/Manishearth/rust-clippy/wiki#identity_op) | warn | using identity operations, e.g. `x + 0` or `y / 1` -[if_let_redundant_pattern_matching](https://github.com/Manishearth/rust-clippy/wiki#if_let_redundant_pattern_matching) | warn | use the proper utility function avoiding an `if let` -[if_let_some_result](https://github.com/Manishearth/rust-clippy/wiki#if_let_some_result) | warn | usage of `ok()` in `if let Some(pat)` statements is unnecessary, match on `Ok(pat)` instead -[if_not_else](https://github.com/Manishearth/rust-clippy/wiki#if_not_else) | allow | `if` branches that could be swapped so no negation operation is necessary on the condition -[if_same_then_else](https://github.com/Manishearth/rust-clippy/wiki#if_same_then_else) | warn | if with the same *then* and *else* blocks -[ifs_same_cond](https://github.com/Manishearth/rust-clippy/wiki#ifs_same_cond) | warn | consecutive `ifs` with the same condition -[inconsistent_digit_grouping](https://github.com/Manishearth/rust-clippy/wiki#inconsistent_digit_grouping) | warn | integer literals with digits grouped inconsistently -[indexing_slicing](https://github.com/Manishearth/rust-clippy/wiki#indexing_slicing) | allow | indexing/slicing usage -[ineffective_bit_mask](https://github.com/Manishearth/rust-clippy/wiki#ineffective_bit_mask) | warn | expressions where a bit mask will be rendered useless by a comparison, e.g. `(x | 1) > 2` -[inline_always](https://github.com/Manishearth/rust-clippy/wiki#inline_always) | warn | use of `#[inline(always)]` -[integer_arithmetic](https://github.com/Manishearth/rust-clippy/wiki#integer_arithmetic) | allow | any integer arithmetic statement -[invalid_regex](https://github.com/Manishearth/rust-clippy/wiki#invalid_regex) | deny | invalid regular expressions -[invalid_upcast_comparisons](https://github.com/Manishearth/rust-clippy/wiki#invalid_upcast_comparisons) | allow | a comparison involving an upcast which is always true or false -[items_after_statements](https://github.com/Manishearth/rust-clippy/wiki#items_after_statements) | allow | blocks where an item comes after a statement -[iter_cloned_collect](https://github.com/Manishearth/rust-clippy/wiki#iter_cloned_collect) | warn | using `.cloned().collect()` on slice to create a `Vec` -[iter_next_loop](https://github.com/Manishearth/rust-clippy/wiki#iter_next_loop) | warn | for-looping over `_.next()` which is probably not intended -[iter_nth](https://github.com/Manishearth/rust-clippy/wiki#iter_nth) | warn | using `.iter().nth()` on a standard library type with O(1) element access -[iter_skip_next](https://github.com/Manishearth/rust-clippy/wiki#iter_skip_next) | warn | using `.skip(x).next()` on an iterator -[iterator_step_by_zero](https://github.com/Manishearth/rust-clippy/wiki#iterator_step_by_zero) | warn | using `Iterator::step_by(0)`, which produces an infinite iterator -[large_digit_groups](https://github.com/Manishearth/rust-clippy/wiki#large_digit_groups) | warn | grouping digits into groups that are too large -[large_enum_variant](https://github.com/Manishearth/rust-clippy/wiki#large_enum_variant) | warn | large size difference between variants on an enum -[len_without_is_empty](https://github.com/Manishearth/rust-clippy/wiki#len_without_is_empty) | warn | traits or impls with a public `len` method but no corresponding `is_empty` method -[len_zero](https://github.com/Manishearth/rust-clippy/wiki#len_zero) | warn | checking `.len() == 0` or `.len() > 0` (or similar) when `.is_empty()` could be used instead -[let_and_return](https://github.com/Manishearth/rust-clippy/wiki#let_and_return) | warn | creating a let-binding and then immediately returning it like `let x = expr; x` at the end of a block -[let_unit_value](https://github.com/Manishearth/rust-clippy/wiki#let_unit_value) | warn | creating a let binding to a value of unit type, which usually can't be used afterwards -[linkedlist](https://github.com/Manishearth/rust-clippy/wiki#linkedlist) | warn | usage of LinkedList, usually a vector is faster, or a more specialized data structure like a VecDeque -[logic_bug](https://github.com/Manishearth/rust-clippy/wiki#logic_bug) | warn | boolean expressions that contain terminals which can be eliminated -[manual_swap](https://github.com/Manishearth/rust-clippy/wiki#manual_swap) | warn | manual swap of two variables -[many_single_char_names](https://github.com/Manishearth/rust-clippy/wiki#many_single_char_names) | warn | too many single character bindings -[map_clone](https://github.com/Manishearth/rust-clippy/wiki#map_clone) | warn | using `.map(|x| x.clone())` to clone an iterator or option's contents -[map_entry](https://github.com/Manishearth/rust-clippy/wiki#map_entry) | warn | use of `contains_key` followed by `insert` on a `HashMap` or `BTreeMap` -[match_bool](https://github.com/Manishearth/rust-clippy/wiki#match_bool) | warn | a match on a boolean expression instead of an `if..else` block -[match_overlapping_arm](https://github.com/Manishearth/rust-clippy/wiki#match_overlapping_arm) | warn | a match with overlapping arms -[match_ref_pats](https://github.com/Manishearth/rust-clippy/wiki#match_ref_pats) | warn | a match or `if let` with all arms prefixed with `&` instead of deref-ing the match expression -[match_same_arms](https://github.com/Manishearth/rust-clippy/wiki#match_same_arms) | warn | `match` with identical arm bodies -[match_wild_err_arm](https://github.com/Manishearth/rust-clippy/wiki#match_wild_err_arm) | warn | a match with `Err(_)` arm and take drastic actions -[mem_forget](https://github.com/Manishearth/rust-clippy/wiki#mem_forget) | allow | `mem::forget` usage on `Drop` types, likely to cause memory leaks -[min_max](https://github.com/Manishearth/rust-clippy/wiki#min_max) | warn | `min(_, max(_, _))` (or vice versa) with bounds clamping the result to a constant -[misrefactored_assign_op](https://github.com/Manishearth/rust-clippy/wiki#misrefactored_assign_op) | warn | having a variable on both sides of an assign op -[missing_docs_in_private_items](https://github.com/Manishearth/rust-clippy/wiki#missing_docs_in_private_items) | allow | detects missing documentation for public and private members -[mixed_case_hex_literals](https://github.com/Manishearth/rust-clippy/wiki#mixed_case_hex_literals) | warn | hex literals whose letter digits are not consistently upper- or lowercased -[module_inception](https://github.com/Manishearth/rust-clippy/wiki#module_inception) | warn | modules that have the same name as their parent module -[modulo_one](https://github.com/Manishearth/rust-clippy/wiki#modulo_one) | warn | taking a number modulo 1, which always returns 0 -[mut_from_ref](https://github.com/Manishearth/rust-clippy/wiki#mut_from_ref) | warn | fns that create mutable refs from immutable ref args -[mut_mut](https://github.com/Manishearth/rust-clippy/wiki#mut_mut) | allow | usage of double-mut refs, e.g. `&mut &mut ...` -[mutex_atomic](https://github.com/Manishearth/rust-clippy/wiki#mutex_atomic) | warn | using a mutex where an atomic value could be used instead -[mutex_integer](https://github.com/Manishearth/rust-clippy/wiki#mutex_integer) | allow | using a mutex for an integer type -[needless_bool](https://github.com/Manishearth/rust-clippy/wiki#needless_bool) | warn | if-statements with plain booleans in the then- and else-clause, e.g. `if p { true } else { false }` -[needless_borrow](https://github.com/Manishearth/rust-clippy/wiki#needless_borrow) | warn | taking a reference that is going to be automatically dereferenced -[needless_borrowed_reference](https://github.com/Manishearth/rust-clippy/wiki#needless_borrowed_reference) | warn | taking a needless borrowed reference -[needless_continue](https://github.com/Manishearth/rust-clippy/wiki#needless_continue) | warn | `continue` statements that can be replaced by a rearrangement of code -[needless_lifetimes](https://github.com/Manishearth/rust-clippy/wiki#needless_lifetimes) | warn | using explicit lifetimes for references in function arguments when elision rules would allow omitting them -[needless_pass_by_value](https://github.com/Manishearth/rust-clippy/wiki#needless_pass_by_value) | warn | functions taking arguments by value, but not consuming them in its body -[needless_range_loop](https://github.com/Manishearth/rust-clippy/wiki#needless_range_loop) | warn | for-looping over a range of indices where an iterator over items would do -[needless_return](https://github.com/Manishearth/rust-clippy/wiki#needless_return) | warn | using a return statement like `return expr;` where an expression would suffice -[needless_update](https://github.com/Manishearth/rust-clippy/wiki#needless_update) | warn | using `Foo { ..base }` when there are no missing fields -[neg_multiply](https://github.com/Manishearth/rust-clippy/wiki#neg_multiply) | warn | multiplying integers with -1 -[never_loop](https://github.com/Manishearth/rust-clippy/wiki#never_loop) | warn | any loop that will always `break` or `return` -[new_ret_no_self](https://github.com/Manishearth/rust-clippy/wiki#new_ret_no_self) | warn | not returning `Self` in a `new` method -[new_without_default](https://github.com/Manishearth/rust-clippy/wiki#new_without_default) | warn | `fn new() -> Self` method without `Default` implementation -[new_without_default_derive](https://github.com/Manishearth/rust-clippy/wiki#new_without_default_derive) | warn | `fn new() -> Self` without `#[derive]`able `Default` implementation -[no_effect](https://github.com/Manishearth/rust-clippy/wiki#no_effect) | warn | statements with no effect -[non_ascii_literal](https://github.com/Manishearth/rust-clippy/wiki#non_ascii_literal) | allow | using any literal non-ASCII chars in a string literal instead of using the `\\u` escape -[nonminimal_bool](https://github.com/Manishearth/rust-clippy/wiki#nonminimal_bool) | allow | boolean expressions that can be written more concisely -[nonsensical_open_options](https://github.com/Manishearth/rust-clippy/wiki#nonsensical_open_options) | warn | nonsensical combination of options for opening a file -[not_unsafe_ptr_arg_deref](https://github.com/Manishearth/rust-clippy/wiki#not_unsafe_ptr_arg_deref) | warn | public functions dereferencing raw pointer arguments but not marked `unsafe` -[ok_expect](https://github.com/Manishearth/rust-clippy/wiki#ok_expect) | warn | using `ok().expect()`, which gives worse error messages than calling `expect` directly on the Result -[op_ref](https://github.com/Manishearth/rust-clippy/wiki#op_ref) | warn | taking a reference to satisfy the type constraints on `==` -[option_map_unwrap_or](https://github.com/Manishearth/rust-clippy/wiki#option_map_unwrap_or) | allow | using `Option.map(f).unwrap_or(a)`, which is more succinctly expressed as `map_or(a, f)` -[option_map_unwrap_or_else](https://github.com/Manishearth/rust-clippy/wiki#option_map_unwrap_or_else) | allow | using `Option.map(f).unwrap_or_else(g)`, which is more succinctly expressed as `map_or_else(g, f)` -[option_unwrap_used](https://github.com/Manishearth/rust-clippy/wiki#option_unwrap_used) | allow | using `Option.unwrap()`, which should at least get a better message using `expect()` -[or_fun_call](https://github.com/Manishearth/rust-clippy/wiki#or_fun_call) | warn | using any `*or` method with a function call, which suggests `*or_else` -[out_of_bounds_indexing](https://github.com/Manishearth/rust-clippy/wiki#out_of_bounds_indexing) | deny | out of bounds constant indexing -[overflow_check_conditional](https://github.com/Manishearth/rust-clippy/wiki#overflow_check_conditional) | warn | overflow checks inspired by C which are likely to panic -[panic_params](https://github.com/Manishearth/rust-clippy/wiki#panic_params) | warn | missing parameters in `panic!` calls -[partialeq_ne_impl](https://github.com/Manishearth/rust-clippy/wiki#partialeq_ne_impl) | warn | re-implementing `PartialEq::ne` -[possible_missing_comma](https://github.com/Manishearth/rust-clippy/wiki#possible_missing_comma) | warn | possible missing comma in array -[precedence](https://github.com/Manishearth/rust-clippy/wiki#precedence) | warn | operations where precedence may be unclear -[print_stdout](https://github.com/Manishearth/rust-clippy/wiki#print_stdout) | allow | printing on stdout -[print_with_newline](https://github.com/Manishearth/rust-clippy/wiki#print_with_newline) | warn | using `print!()` with a format string that ends in a newline -[ptr_arg](https://github.com/Manishearth/rust-clippy/wiki#ptr_arg) | warn | fn arguments of the type `&Vec<...>` or `&String`, suggesting to use `&[...]` or `&str` instead, respectively -[pub_enum_variant_names](https://github.com/Manishearth/rust-clippy/wiki#pub_enum_variant_names) | allow | enums where all variants share a prefix/postfix -[range_zip_with_len](https://github.com/Manishearth/rust-clippy/wiki#range_zip_with_len) | warn | zipping iterator with a range when `enumerate()` would do -[redundant_closure](https://github.com/Manishearth/rust-clippy/wiki#redundant_closure) | warn | redundant closures, i.e. `|a| foo(a)` (which can be written as just `foo`) -[redundant_closure_call](https://github.com/Manishearth/rust-clippy/wiki#redundant_closure_call) | warn | throwaway closures called in the expression they are defined -[redundant_pattern](https://github.com/Manishearth/rust-clippy/wiki#redundant_pattern) | warn | using `name @ _` in a pattern -[regex_macro](https://github.com/Manishearth/rust-clippy/wiki#regex_macro) | warn | use of `regex!(_)` instead of `Regex::new(_)` -[result_unwrap_used](https://github.com/Manishearth/rust-clippy/wiki#result_unwrap_used) | allow | using `Result.unwrap()`, which might be better handled -[reverse_range_loop](https://github.com/Manishearth/rust-clippy/wiki#reverse_range_loop) | warn | iteration over an empty range, such as `10..0` or `5..5` -[search_is_some](https://github.com/Manishearth/rust-clippy/wiki#search_is_some) | warn | using an iterator search followed by `is_some()`, which is more succinctly expressed as a call to `any()` -[serde_api_misuse](https://github.com/Manishearth/rust-clippy/wiki#serde_api_misuse) | warn | various things that will negatively affect your serde experience -[shadow_reuse](https://github.com/Manishearth/rust-clippy/wiki#shadow_reuse) | allow | rebinding a name to an expression that re-uses the original value, e.g. `let x = x + 1` -[shadow_same](https://github.com/Manishearth/rust-clippy/wiki#shadow_same) | allow | rebinding a name to itself, e.g. `let mut x = &mut x` -[shadow_unrelated](https://github.com/Manishearth/rust-clippy/wiki#shadow_unrelated) | allow | rebinding a name without even using the original value -[short_circuit_statement](https://github.com/Manishearth/rust-clippy/wiki#short_circuit_statement) | warn | using a short circuit boolean condition as a statement -[should_assert_eq](https://github.com/Manishearth/rust-clippy/wiki#should_assert_eq) | warn | using `assert` macro for asserting equality -[should_implement_trait](https://github.com/Manishearth/rust-clippy/wiki#should_implement_trait) | warn | defining a method that should be implementing a std trait -[similar_names](https://github.com/Manishearth/rust-clippy/wiki#similar_names) | allow | similarly named items and bindings -[single_char_pattern](https://github.com/Manishearth/rust-clippy/wiki#single_char_pattern) | warn | using a single-character str where a char could be used, e.g. `_.split("x")` -[single_match](https://github.com/Manishearth/rust-clippy/wiki#single_match) | warn | a match statement with a single nontrivial arm (i.e. where the other arm is `_ => {}`) instead of `if let` -[single_match_else](https://github.com/Manishearth/rust-clippy/wiki#single_match_else) | allow | a match statement with a two arms where the second arm's pattern is a wildcard instead of `if let` -[string_add](https://github.com/Manishearth/rust-clippy/wiki#string_add) | allow | using `x + ..` where x is a `String` instead of `push_str()` -[string_add_assign](https://github.com/Manishearth/rust-clippy/wiki#string_add_assign) | allow | using `x = x + ..` where x is a `String` instead of `push_str()` -[string_extend_chars](https://github.com/Manishearth/rust-clippy/wiki#string_extend_chars) | warn | using `x.extend(s.chars())` where s is a `&str` or `String` -[string_lit_as_bytes](https://github.com/Manishearth/rust-clippy/wiki#string_lit_as_bytes) | warn | calling `as_bytes` on a string literal instead of using a byte string literal -[stutter](https://github.com/Manishearth/rust-clippy/wiki#stutter) | allow | type names prefixed/postfixed with their containing module's name -[suspicious_assignment_formatting](https://github.com/Manishearth/rust-clippy/wiki#suspicious_assignment_formatting) | warn | suspicious formatting of `*=`, `-=` or `!=` -[suspicious_else_formatting](https://github.com/Manishearth/rust-clippy/wiki#suspicious_else_formatting) | warn | suspicious formatting of `else if` -[temporary_assignment](https://github.com/Manishearth/rust-clippy/wiki#temporary_assignment) | warn | assignments to temporaries -[temporary_cstring_as_ptr](https://github.com/Manishearth/rust-clippy/wiki#temporary_cstring_as_ptr) | warn | getting the inner pointer of a temporary `CString` -[too_many_arguments](https://github.com/Manishearth/rust-clippy/wiki#too_many_arguments) | warn | functions with too many arguments -[toplevel_ref_arg](https://github.com/Manishearth/rust-clippy/wiki#toplevel_ref_arg) | warn | an entire binding declared as `ref`, in a function argument or a `let` statement -[transmute_ptr_to_ref](https://github.com/Manishearth/rust-clippy/wiki#transmute_ptr_to_ref) | warn | transmutes from a pointer to a reference type -[trivial_regex](https://github.com/Manishearth/rust-clippy/wiki#trivial_regex) | warn | trivial regular expressions -[type_complexity](https://github.com/Manishearth/rust-clippy/wiki#type_complexity) | warn | usage of very complex types that might be better factored into `type` definitions -[unicode_not_nfc](https://github.com/Manishearth/rust-clippy/wiki#unicode_not_nfc) | allow | using a unicode literal not in NFC normal form (see [unicode tr15](http://www.unicode.org/reports/tr15/) for further information) -[unit_cmp](https://github.com/Manishearth/rust-clippy/wiki#unit_cmp) | warn | comparing unit values -[unnecessary_cast](https://github.com/Manishearth/rust-clippy/wiki#unnecessary_cast) | warn | cast to the same type, e.g. `x as i32` where `x: i32` -[unnecessary_mut_passed](https://github.com/Manishearth/rust-clippy/wiki#unnecessary_mut_passed) | warn | an argument passed as a mutable reference although the callee only demands an immutable reference -[unnecessary_operation](https://github.com/Manishearth/rust-clippy/wiki#unnecessary_operation) | warn | outer expressions with no effect -[unneeded_field_pattern](https://github.com/Manishearth/rust-clippy/wiki#unneeded_field_pattern) | warn | struct fields bound to a wildcard instead of using `..` -[unreadable_literal](https://github.com/Manishearth/rust-clippy/wiki#unreadable_literal) | warn | long integer literal without underscores -[unsafe_removed_from_name](https://github.com/Manishearth/rust-clippy/wiki#unsafe_removed_from_name) | warn | `unsafe` removed from API names on import -[unseparated_literal_suffix](https://github.com/Manishearth/rust-clippy/wiki#unseparated_literal_suffix) | allow | literals whose suffix is not separated by an underscore -[unused_collect](https://github.com/Manishearth/rust-clippy/wiki#unused_collect) | warn | `collect()`ing an iterator without using the result; this is usually better written as a for loop -[unused_io_amount](https://github.com/Manishearth/rust-clippy/wiki#unused_io_amount) | deny | unused written/read amount -[unused_label](https://github.com/Manishearth/rust-clippy/wiki#unused_label) | warn | unused labels -[unused_lifetimes](https://github.com/Manishearth/rust-clippy/wiki#unused_lifetimes) | warn | unused lifetimes in function definitions -[use_debug](https://github.com/Manishearth/rust-clippy/wiki#use_debug) | allow | use of `Debug`-based formatting -[used_underscore_binding](https://github.com/Manishearth/rust-clippy/wiki#used_underscore_binding) | allow | using a binding which is prefixed with an underscore -[useless_attribute](https://github.com/Manishearth/rust-clippy/wiki#useless_attribute) | warn | use of lint attributes on `extern crate` items -[useless_format](https://github.com/Manishearth/rust-clippy/wiki#useless_format) | warn | useless use of `format!` -[useless_let_if_seq](https://github.com/Manishearth/rust-clippy/wiki#useless_let_if_seq) | warn | unidiomatic `let mut` declaration followed by initialization in `if` -[useless_transmute](https://github.com/Manishearth/rust-clippy/wiki#useless_transmute) | warn | transmutes that have the same to and from types or could be a cast/coercion -[useless_vec](https://github.com/Manishearth/rust-clippy/wiki#useless_vec) | warn | useless `vec!` -[verbose_bit_mask](https://github.com/Manishearth/rust-clippy/wiki#verbose_bit_mask) | warn | expressions where a bit mask is less readable than the corresponding method call -[while_let_loop](https://github.com/Manishearth/rust-clippy/wiki#while_let_loop) | warn | `loop { if let { ... } else break }`, which can be written as a `while let` loop -[while_let_on_iterator](https://github.com/Manishearth/rust-clippy/wiki#while_let_on_iterator) | warn | using a while-let loop instead of a for loop on an iterator -[wrong_pub_self_convention](https://github.com/Manishearth/rust-clippy/wiki#wrong_pub_self_convention) | allow | defining a public method named with an established prefix (like "into_") that takes `self` with the wrong convention -[wrong_self_convention](https://github.com/Manishearth/rust-clippy/wiki#wrong_self_convention) | warn | defining a method named with an established prefix (like "into_") that takes `self` with the wrong convention -[wrong_transmute](https://github.com/Manishearth/rust-clippy/wiki#wrong_transmute) | warn | transmutes that are confusing at best, undefined behaviour at worst and always useless -[zero_divided_by_zero](https://github.com/Manishearth/rust-clippy/wiki#zero_divided_by_zero) | warn | usage of `0.0 / 0.0` to obtain NaN instead of std::f32::NaN or std::f64::NaN -[zero_prefixed_literal](https://github.com/Manishearth/rust-clippy/wiki#zero_prefixed_literal) | warn | integer literals starting with `0` -[zero_ptr](https://github.com/Manishearth/rust-clippy/wiki#zero_ptr) | warn | using 0 as *{const, mut} T -[zero_width_space](https://github.com/Manishearth/rust-clippy/wiki#zero_width_space) | deny | using a zero-width space in a string literal, which is confusing +name | default | triggers on +-----------------------------------------------------------------------------------------------------------------------------|---------|---------------------------------------------------------------------------------------------------------------------------------- +[absurd_extreme_comparisons](https://github.com/rust-lang-nursery/rust-clippy/wiki#absurd_extreme_comparisons) | warn | a comparison with a maximum or minimum value that is always true or false +[almost_swapped](https://github.com/rust-lang-nursery/rust-clippy/wiki#almost_swapped) | warn | `foo = bar; bar = foo` sequence +[approx_constant](https://github.com/rust-lang-nursery/rust-clippy/wiki#approx_constant) | warn | the approximate of a known float constant (in `std::fXX::consts`) +[assign_op_pattern](https://github.com/rust-lang-nursery/rust-clippy/wiki#assign_op_pattern) | warn | assigning the result of an operation on a variable to that same variable +[assign_ops](https://github.com/rust-lang-nursery/rust-clippy/wiki#assign_ops) | allow | any compound assignment operation +[bad_bit_mask](https://github.com/rust-lang-nursery/rust-clippy/wiki#bad_bit_mask) | warn | expressions of the form `_ & mask == select` that will only ever return `true` or `false` +[blacklisted_name](https://github.com/rust-lang-nursery/rust-clippy/wiki#blacklisted_name) | warn | usage of a blacklisted/placeholder name +[block_in_if_condition_expr](https://github.com/rust-lang-nursery/rust-clippy/wiki#block_in_if_condition_expr) | warn | braces that can be eliminated in conditions, e.g. `if { true } ...` +[block_in_if_condition_stmt](https://github.com/rust-lang-nursery/rust-clippy/wiki#block_in_if_condition_stmt) | warn | complex blocks in conditions, e.g. `if { let x = true; x } ...` +[bool_comparison](https://github.com/rust-lang-nursery/rust-clippy/wiki#bool_comparison) | warn | comparing a variable to a boolean, e.g. `if x == true` +[borrowed_box](https://github.com/rust-lang-nursery/rust-clippy/wiki#borrowed_box) | warn | a borrow of a boxed type +[box_vec](https://github.com/rust-lang-nursery/rust-clippy/wiki#box_vec) | warn | usage of `Box>`, vector elements are already on the heap +[boxed_local](https://github.com/rust-lang-nursery/rust-clippy/wiki#boxed_local) | warn | using `Box` where unnecessary +[builtin_type_shadow](https://github.com/rust-lang-nursery/rust-clippy/wiki#builtin_type_shadow) | warn | shadowing a builtin type +[cast_possible_truncation](https://github.com/rust-lang-nursery/rust-clippy/wiki#cast_possible_truncation) | allow | casts that may cause truncation of the value, e.g. `x as u8` where `x: u32`, or `x as i32` where `x: f32` +[cast_possible_wrap](https://github.com/rust-lang-nursery/rust-clippy/wiki#cast_possible_wrap) | allow | casts that may cause wrapping around the value, e.g. `x as i32` where `x: u32` and `x > i32::MAX` +[cast_precision_loss](https://github.com/rust-lang-nursery/rust-clippy/wiki#cast_precision_loss) | allow | casts that cause loss of precision, e.g. `x as f32` where `x: u64` +[cast_sign_loss](https://github.com/rust-lang-nursery/rust-clippy/wiki#cast_sign_loss) | allow | casts from signed types to unsigned types, e.g. `x as u32` where `x: i32` +[char_lit_as_u8](https://github.com/rust-lang-nursery/rust-clippy/wiki#char_lit_as_u8) | warn | casting a character literal to u8 +[chars_next_cmp](https://github.com/rust-lang-nursery/rust-clippy/wiki#chars_next_cmp) | warn | using `.chars().next()` to check if a string starts with a char +[clone_double_ref](https://github.com/rust-lang-nursery/rust-clippy/wiki#clone_double_ref) | warn | using `clone` on `&&T` +[clone_on_copy](https://github.com/rust-lang-nursery/rust-clippy/wiki#clone_on_copy) | warn | using `clone` on a `Copy` type +[cmp_nan](https://github.com/rust-lang-nursery/rust-clippy/wiki#cmp_nan) | deny | comparisons to NAN, which will always return false, probably not intended +[cmp_null](https://github.com/rust-lang-nursery/rust-clippy/wiki#cmp_null) | warn | comparing a pointer to a null pointer, suggesting to use `.is_null()` instead. +[cmp_owned](https://github.com/rust-lang-nursery/rust-clippy/wiki#cmp_owned) | warn | creating owned instances for comparing with others, e.g. `x == "foo".to_string()` +[collapsible_if](https://github.com/rust-lang-nursery/rust-clippy/wiki#collapsible_if) | warn | `if`s that can be collapsed (e.g. `if x { if y { ... } }` and `else { if x { ... } }`) +[crosspointer_transmute](https://github.com/rust-lang-nursery/rust-clippy/wiki#crosspointer_transmute) | warn | transmutes that have to or from types that are a pointer to the other +[cyclomatic_complexity](https://github.com/rust-lang-nursery/rust-clippy/wiki#cyclomatic_complexity) | warn | functions that should be split up into multiple functions +[deprecated_semver](https://github.com/rust-lang-nursery/rust-clippy/wiki#deprecated_semver) | warn | use of `#[deprecated(since = "x")]` where x is not semver +[deref_addrof](https://github.com/rust-lang-nursery/rust-clippy/wiki#deref_addrof) | warn | use of `*&` or `*&mut` in an expression +[derive_hash_xor_eq](https://github.com/rust-lang-nursery/rust-clippy/wiki#derive_hash_xor_eq) | warn | deriving `Hash` but implementing `PartialEq` explicitly +[diverging_sub_expression](https://github.com/rust-lang-nursery/rust-clippy/wiki#diverging_sub_expression) | warn | whether an expression contains a diverging sub expression +[doc_markdown](https://github.com/rust-lang-nursery/rust-clippy/wiki#doc_markdown) | warn | presence of `_`, `::` or camel-case outside backticks in documentation +[double_neg](https://github.com/rust-lang-nursery/rust-clippy/wiki#double_neg) | warn | `--x`, which is a double negation of `x` and not a pre-decrement as in C/C++ +[double_parens](https://github.com/rust-lang-nursery/rust-clippy/wiki#double_parens) | warn | Warn on unnecessary double parentheses +[drop_copy](https://github.com/rust-lang-nursery/rust-clippy/wiki#drop_copy) | warn | calls to `std::mem::drop` with a value that implements Copy +[drop_ref](https://github.com/rust-lang-nursery/rust-clippy/wiki#drop_ref) | warn | calls to `std::mem::drop` with a reference instead of an owned value +[duplicate_underscore_argument](https://github.com/rust-lang-nursery/rust-clippy/wiki#duplicate_underscore_argument) | warn | function arguments having names which only differ by an underscore +[empty_enum](https://github.com/rust-lang-nursery/rust-clippy/wiki#empty_enum) | allow | enum with no variants +[empty_loop](https://github.com/rust-lang-nursery/rust-clippy/wiki#empty_loop) | warn | empty `loop {}`, which should block or sleep +[enum_clike_unportable_variant](https://github.com/rust-lang-nursery/rust-clippy/wiki#enum_clike_unportable_variant) | warn | C-like enums that are `repr(isize/usize)` and have values that don't fit into an `i32` +[enum_glob_use](https://github.com/rust-lang-nursery/rust-clippy/wiki#enum_glob_use) | allow | use items that import all variants of an enum +[enum_variant_names](https://github.com/rust-lang-nursery/rust-clippy/wiki#enum_variant_names) | warn | enums where all variants share a prefix/postfix +[eq_op](https://github.com/rust-lang-nursery/rust-clippy/wiki#eq_op) | warn | equal operands on both sides of a comparison or bitwise combination (e.g. `x == x`) +[eval_order_dependence](https://github.com/rust-lang-nursery/rust-clippy/wiki#eval_order_dependence) | warn | whether a variable read occurs before a write depends on sub-expression evaluation order +[expl_impl_clone_on_copy](https://github.com/rust-lang-nursery/rust-clippy/wiki#expl_impl_clone_on_copy) | warn | implementing `Clone` explicitly on `Copy` types +[explicit_counter_loop](https://github.com/rust-lang-nursery/rust-clippy/wiki#explicit_counter_loop) | warn | for-looping with an explicit counter when `_.enumerate()` would do +[explicit_into_iter_loop](https://github.com/rust-lang-nursery/rust-clippy/wiki#explicit_into_iter_loop) | warn | for-looping over `_.into_iter()` when `_` would do +[explicit_iter_loop](https://github.com/rust-lang-nursery/rust-clippy/wiki#explicit_iter_loop) | warn | for-looping over `_.iter()` or `_.iter_mut()` when `&_` or `&mut _` would do +[filter_map](https://github.com/rust-lang-nursery/rust-clippy/wiki#filter_map) | allow | using combinations of `filter`, `map`, `filter_map` and `flat_map` which can usually be written as a single method call +[filter_next](https://github.com/rust-lang-nursery/rust-clippy/wiki#filter_next) | warn | using `filter(p).next()`, which is more succinctly expressed as `.find(p)` +[float_arithmetic](https://github.com/rust-lang-nursery/rust-clippy/wiki#float_arithmetic) | allow | any floating-point arithmetic statement +[float_cmp](https://github.com/rust-lang-nursery/rust-clippy/wiki#float_cmp) | warn | using `==` or `!=` on float values instead of comparing difference with an epsilon +[for_kv_map](https://github.com/rust-lang-nursery/rust-clippy/wiki#for_kv_map) | warn | looping on a map using `iter` when `keys` or `values` would do +[for_loop_over_option](https://github.com/rust-lang-nursery/rust-clippy/wiki#for_loop_over_option) | warn | for-looping over an `Option`, which is more clearly expressed as an `if let` +[for_loop_over_result](https://github.com/rust-lang-nursery/rust-clippy/wiki#for_loop_over_result) | warn | for-looping over a `Result`, which is more clearly expressed as an `if let` +[forget_copy](https://github.com/rust-lang-nursery/rust-clippy/wiki#forget_copy) | warn | calls to `std::mem::forget` with a value that implements Copy +[forget_ref](https://github.com/rust-lang-nursery/rust-clippy/wiki#forget_ref) | warn | calls to `std::mem::forget` with a reference instead of an owned value +[get_unwrap](https://github.com/rust-lang-nursery/rust-clippy/wiki#get_unwrap) | warn | using `.get().unwrap()` or `.get_mut().unwrap()` when using `[]` would work instead +[identity_op](https://github.com/rust-lang-nursery/rust-clippy/wiki#identity_op) | warn | using identity operations, e.g. `x + 0` or `y / 1` +[if_let_redundant_pattern_matching](https://github.com/rust-lang-nursery/rust-clippy/wiki#if_let_redundant_pattern_matching) | warn | use the proper utility function avoiding an `if let` +[if_let_some_result](https://github.com/rust-lang-nursery/rust-clippy/wiki#if_let_some_result) | warn | usage of `ok()` in `if let Some(pat)` statements is unnecessary, match on `Ok(pat)` instead +[if_not_else](https://github.com/rust-lang-nursery/rust-clippy/wiki#if_not_else) | allow | `if` branches that could be swapped so no negation operation is necessary on the condition +[if_same_then_else](https://github.com/rust-lang-nursery/rust-clippy/wiki#if_same_then_else) | warn | if with the same *then* and *else* blocks +[ifs_same_cond](https://github.com/rust-lang-nursery/rust-clippy/wiki#ifs_same_cond) | warn | consecutive `ifs` with the same condition +[inconsistent_digit_grouping](https://github.com/rust-lang-nursery/rust-clippy/wiki#inconsistent_digit_grouping) | warn | integer literals with digits grouped inconsistently +[indexing_slicing](https://github.com/rust-lang-nursery/rust-clippy/wiki#indexing_slicing) | allow | indexing/slicing usage +[ineffective_bit_mask](https://github.com/rust-lang-nursery/rust-clippy/wiki#ineffective_bit_mask) | warn | expressions where a bit mask will be rendered useless by a comparison, e.g. `(x | 1) > 2` +[inline_always](https://github.com/rust-lang-nursery/rust-clippy/wiki#inline_always) | warn | use of `#[inline(always)]` +[integer_arithmetic](https://github.com/rust-lang-nursery/rust-clippy/wiki#integer_arithmetic) | allow | any integer arithmetic statement +[invalid_regex](https://github.com/rust-lang-nursery/rust-clippy/wiki#invalid_regex) | deny | invalid regular expressions +[invalid_upcast_comparisons](https://github.com/rust-lang-nursery/rust-clippy/wiki#invalid_upcast_comparisons) | allow | a comparison involving an upcast which is always true or false +[items_after_statements](https://github.com/rust-lang-nursery/rust-clippy/wiki#items_after_statements) | allow | blocks where an item comes after a statement +[iter_cloned_collect](https://github.com/rust-lang-nursery/rust-clippy/wiki#iter_cloned_collect) | warn | using `.cloned().collect()` on slice to create a `Vec` +[iter_next_loop](https://github.com/rust-lang-nursery/rust-clippy/wiki#iter_next_loop) | warn | for-looping over `_.next()` which is probably not intended +[iter_nth](https://github.com/rust-lang-nursery/rust-clippy/wiki#iter_nth) | warn | using `.iter().nth()` on a standard library type with O(1) element access +[iter_skip_next](https://github.com/rust-lang-nursery/rust-clippy/wiki#iter_skip_next) | warn | using `.skip(x).next()` on an iterator +[iterator_step_by_zero](https://github.com/rust-lang-nursery/rust-clippy/wiki#iterator_step_by_zero) | warn | using `Iterator::step_by(0)`, which produces an infinite iterator +[large_digit_groups](https://github.com/rust-lang-nursery/rust-clippy/wiki#large_digit_groups) | warn | grouping digits into groups that are too large +[large_enum_variant](https://github.com/rust-lang-nursery/rust-clippy/wiki#large_enum_variant) | warn | large size difference between variants on an enum +[len_without_is_empty](https://github.com/rust-lang-nursery/rust-clippy/wiki#len_without_is_empty) | warn | traits or impls with a public `len` method but no corresponding `is_empty` method +[len_zero](https://github.com/rust-lang-nursery/rust-clippy/wiki#len_zero) | warn | checking `.len() == 0` or `.len() > 0` (or similar) when `.is_empty()` could be used instead +[let_and_return](https://github.com/rust-lang-nursery/rust-clippy/wiki#let_and_return) | warn | creating a let-binding and then immediately returning it like `let x = expr; x` at the end of a block +[let_unit_value](https://github.com/rust-lang-nursery/rust-clippy/wiki#let_unit_value) | warn | creating a let binding to a value of unit type, which usually can't be used afterwards +[linkedlist](https://github.com/rust-lang-nursery/rust-clippy/wiki#linkedlist) | warn | usage of LinkedList, usually a vector is faster, or a more specialized data structure like a VecDeque +[logic_bug](https://github.com/rust-lang-nursery/rust-clippy/wiki#logic_bug) | warn | boolean expressions that contain terminals which can be eliminated +[manual_swap](https://github.com/rust-lang-nursery/rust-clippy/wiki#manual_swap) | warn | manual swap of two variables +[many_single_char_names](https://github.com/rust-lang-nursery/rust-clippy/wiki#many_single_char_names) | warn | too many single character bindings +[map_clone](https://github.com/rust-lang-nursery/rust-clippy/wiki#map_clone) | warn | using `.map(|x| x.clone())` to clone an iterator or option's contents +[map_entry](https://github.com/rust-lang-nursery/rust-clippy/wiki#map_entry) | warn | use of `contains_key` followed by `insert` on a `HashMap` or `BTreeMap` +[match_bool](https://github.com/rust-lang-nursery/rust-clippy/wiki#match_bool) | warn | a match on a boolean expression instead of an `if..else` block +[match_overlapping_arm](https://github.com/rust-lang-nursery/rust-clippy/wiki#match_overlapping_arm) | warn | a match with overlapping arms +[match_ref_pats](https://github.com/rust-lang-nursery/rust-clippy/wiki#match_ref_pats) | warn | a match or `if let` with all arms prefixed with `&` instead of deref-ing the match expression +[match_same_arms](https://github.com/rust-lang-nursery/rust-clippy/wiki#match_same_arms) | warn | `match` with identical arm bodies +[match_wild_err_arm](https://github.com/rust-lang-nursery/rust-clippy/wiki#match_wild_err_arm) | warn | a match with `Err(_)` arm and take drastic actions +[mem_forget](https://github.com/rust-lang-nursery/rust-clippy/wiki#mem_forget) | allow | `mem::forget` usage on `Drop` types, likely to cause memory leaks +[min_max](https://github.com/rust-lang-nursery/rust-clippy/wiki#min_max) | warn | `min(_, max(_, _))` (or vice versa) with bounds clamping the result to a constant +[misrefactored_assign_op](https://github.com/rust-lang-nursery/rust-clippy/wiki#misrefactored_assign_op) | warn | having a variable on both sides of an assign op +[missing_docs_in_private_items](https://github.com/rust-lang-nursery/rust-clippy/wiki#missing_docs_in_private_items) | allow | detects missing documentation for public and private members +[mixed_case_hex_literals](https://github.com/rust-lang-nursery/rust-clippy/wiki#mixed_case_hex_literals) | warn | hex literals whose letter digits are not consistently upper- or lowercased +[module_inception](https://github.com/rust-lang-nursery/rust-clippy/wiki#module_inception) | warn | modules that have the same name as their parent module +[modulo_one](https://github.com/rust-lang-nursery/rust-clippy/wiki#modulo_one) | warn | taking a number modulo 1, which always returns 0 +[mut_from_ref](https://github.com/rust-lang-nursery/rust-clippy/wiki#mut_from_ref) | warn | fns that create mutable refs from immutable ref args +[mut_mut](https://github.com/rust-lang-nursery/rust-clippy/wiki#mut_mut) | allow | usage of double-mut refs, e.g. `&mut &mut ...` +[mutex_atomic](https://github.com/rust-lang-nursery/rust-clippy/wiki#mutex_atomic) | warn | using a mutex where an atomic value could be used instead +[mutex_integer](https://github.com/rust-lang-nursery/rust-clippy/wiki#mutex_integer) | allow | using a mutex for an integer type +[needless_bool](https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_bool) | warn | if-statements with plain booleans in the then- and else-clause, e.g. `if p { true } else { false }` +[needless_borrow](https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_borrow) | warn | taking a reference that is going to be automatically dereferenced +[needless_borrowed_reference](https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_borrowed_reference) | warn | taking a needless borrowed reference +[needless_continue](https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_continue) | warn | `continue` statements that can be replaced by a rearrangement of code +[needless_lifetimes](https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_lifetimes) | warn | using explicit lifetimes for references in function arguments when elision rules would allow omitting them +[needless_pass_by_value](https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_pass_by_value) | warn | functions taking arguments by value, but not consuming them in its body +[needless_range_loop](https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_range_loop) | warn | for-looping over a range of indices where an iterator over items would do +[needless_return](https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_return) | warn | using a return statement like `return expr;` where an expression would suffice +[needless_update](https://github.com/rust-lang-nursery/rust-clippy/wiki#needless_update) | warn | using `Foo { ..base }` when there are no missing fields +[neg_multiply](https://github.com/rust-lang-nursery/rust-clippy/wiki#neg_multiply) | warn | multiplying integers with -1 +[never_loop](https://github.com/rust-lang-nursery/rust-clippy/wiki#never_loop) | warn | any loop that will always `break` or `return` +[new_ret_no_self](https://github.com/rust-lang-nursery/rust-clippy/wiki#new_ret_no_self) | warn | not returning `Self` in a `new` method +[new_without_default](https://github.com/rust-lang-nursery/rust-clippy/wiki#new_without_default) | warn | `fn new() -> Self` method without `Default` implementation +[new_without_default_derive](https://github.com/rust-lang-nursery/rust-clippy/wiki#new_without_default_derive) | warn | `fn new() -> Self` without `#[derive]`able `Default` implementation +[no_effect](https://github.com/rust-lang-nursery/rust-clippy/wiki#no_effect) | warn | statements with no effect +[non_ascii_literal](https://github.com/rust-lang-nursery/rust-clippy/wiki#non_ascii_literal) | allow | using any literal non-ASCII chars in a string literal instead of using the `\\u` escape +[nonminimal_bool](https://github.com/rust-lang-nursery/rust-clippy/wiki#nonminimal_bool) | allow | boolean expressions that can be written more concisely +[nonsensical_open_options](https://github.com/rust-lang-nursery/rust-clippy/wiki#nonsensical_open_options) | warn | nonsensical combination of options for opening a file +[not_unsafe_ptr_arg_deref](https://github.com/rust-lang-nursery/rust-clippy/wiki#not_unsafe_ptr_arg_deref) | warn | public functions dereferencing raw pointer arguments but not marked `unsafe` +[ok_expect](https://github.com/rust-lang-nursery/rust-clippy/wiki#ok_expect) | warn | using `ok().expect()`, which gives worse error messages than calling `expect` directly on the Result +[op_ref](https://github.com/rust-lang-nursery/rust-clippy/wiki#op_ref) | warn | taking a reference to satisfy the type constraints on `==` +[option_map_unwrap_or](https://github.com/rust-lang-nursery/rust-clippy/wiki#option_map_unwrap_or) | allow | using `Option.map(f).unwrap_or(a)`, which is more succinctly expressed as `map_or(a, f)` +[option_map_unwrap_or_else](https://github.com/rust-lang-nursery/rust-clippy/wiki#option_map_unwrap_or_else) | allow | using `Option.map(f).unwrap_or_else(g)`, which is more succinctly expressed as `map_or_else(g, f)` +[option_unwrap_used](https://github.com/rust-lang-nursery/rust-clippy/wiki#option_unwrap_used) | allow | using `Option.unwrap()`, which should at least get a better message using `expect()` +[or_fun_call](https://github.com/rust-lang-nursery/rust-clippy/wiki#or_fun_call) | warn | using any `*or` method with a function call, which suggests `*or_else` +[out_of_bounds_indexing](https://github.com/rust-lang-nursery/rust-clippy/wiki#out_of_bounds_indexing) | deny | out of bounds constant indexing +[overflow_check_conditional](https://github.com/rust-lang-nursery/rust-clippy/wiki#overflow_check_conditional) | warn | overflow checks inspired by C which are likely to panic +[panic_params](https://github.com/rust-lang-nursery/rust-clippy/wiki#panic_params) | warn | missing parameters in `panic!` calls +[partialeq_ne_impl](https://github.com/rust-lang-nursery/rust-clippy/wiki#partialeq_ne_impl) | warn | re-implementing `PartialEq::ne` +[possible_missing_comma](https://github.com/rust-lang-nursery/rust-clippy/wiki#possible_missing_comma) | warn | possible missing comma in array +[precedence](https://github.com/rust-lang-nursery/rust-clippy/wiki#precedence) | warn | operations where precedence may be unclear +[print_stdout](https://github.com/rust-lang-nursery/rust-clippy/wiki#print_stdout) | allow | printing on stdout +[print_with_newline](https://github.com/rust-lang-nursery/rust-clippy/wiki#print_with_newline) | warn | using `print!()` with a format string that ends in a newline +[ptr_arg](https://github.com/rust-lang-nursery/rust-clippy/wiki#ptr_arg) | warn | fn arguments of the type `&Vec<...>` or `&String`, suggesting to use `&[...]` or `&str` instead, respectively +[pub_enum_variant_names](https://github.com/rust-lang-nursery/rust-clippy/wiki#pub_enum_variant_names) | allow | enums where all variants share a prefix/postfix +[range_zip_with_len](https://github.com/rust-lang-nursery/rust-clippy/wiki#range_zip_with_len) | warn | zipping iterator with a range when `enumerate()` would do +[redundant_closure](https://github.com/rust-lang-nursery/rust-clippy/wiki#redundant_closure) | warn | redundant closures, i.e. `|a| foo(a)` (which can be written as just `foo`) +[redundant_closure_call](https://github.com/rust-lang-nursery/rust-clippy/wiki#redundant_closure_call) | warn | throwaway closures called in the expression they are defined +[redundant_pattern](https://github.com/rust-lang-nursery/rust-clippy/wiki#redundant_pattern) | warn | using `name @ _` in a pattern +[regex_macro](https://github.com/rust-lang-nursery/rust-clippy/wiki#regex_macro) | warn | use of `regex!(_)` instead of `Regex::new(_)` +[result_unwrap_used](https://github.com/rust-lang-nursery/rust-clippy/wiki#result_unwrap_used) | allow | using `Result.unwrap()`, which might be better handled +[reverse_range_loop](https://github.com/rust-lang-nursery/rust-clippy/wiki#reverse_range_loop) | warn | iteration over an empty range, such as `10..0` or `5..5` +[search_is_some](https://github.com/rust-lang-nursery/rust-clippy/wiki#search_is_some) | warn | using an iterator search followed by `is_some()`, which is more succinctly expressed as a call to `any()` +[serde_api_misuse](https://github.com/rust-lang-nursery/rust-clippy/wiki#serde_api_misuse) | warn | various things that will negatively affect your serde experience +[shadow_reuse](https://github.com/rust-lang-nursery/rust-clippy/wiki#shadow_reuse) | allow | rebinding a name to an expression that re-uses the original value, e.g. `let x = x + 1` +[shadow_same](https://github.com/rust-lang-nursery/rust-clippy/wiki#shadow_same) | allow | rebinding a name to itself, e.g. `let mut x = &mut x` +[shadow_unrelated](https://github.com/rust-lang-nursery/rust-clippy/wiki#shadow_unrelated) | allow | rebinding a name without even using the original value +[short_circuit_statement](https://github.com/rust-lang-nursery/rust-clippy/wiki#short_circuit_statement) | warn | using a short circuit boolean condition as a statement +[should_assert_eq](https://github.com/rust-lang-nursery/rust-clippy/wiki#should_assert_eq) | warn | using `assert` macro for asserting equality +[should_implement_trait](https://github.com/rust-lang-nursery/rust-clippy/wiki#should_implement_trait) | warn | defining a method that should be implementing a std trait +[similar_names](https://github.com/rust-lang-nursery/rust-clippy/wiki#similar_names) | allow | similarly named items and bindings +[single_char_pattern](https://github.com/rust-lang-nursery/rust-clippy/wiki#single_char_pattern) | warn | using a single-character str where a char could be used, e.g. `_.split("x")` +[single_match](https://github.com/rust-lang-nursery/rust-clippy/wiki#single_match) | warn | a match statement with a single nontrivial arm (i.e. where the other arm is `_ => {}`) instead of `if let` +[single_match_else](https://github.com/rust-lang-nursery/rust-clippy/wiki#single_match_else) | allow | a match statement with a two arms where the second arm's pattern is a wildcard instead of `if let` +[string_add](https://github.com/rust-lang-nursery/rust-clippy/wiki#string_add) | allow | using `x + ..` where x is a `String` instead of `push_str()` +[string_add_assign](https://github.com/rust-lang-nursery/rust-clippy/wiki#string_add_assign) | allow | using `x = x + ..` where x is a `String` instead of `push_str()` +[string_extend_chars](https://github.com/rust-lang-nursery/rust-clippy/wiki#string_extend_chars) | warn | using `x.extend(s.chars())` where s is a `&str` or `String` +[string_lit_as_bytes](https://github.com/rust-lang-nursery/rust-clippy/wiki#string_lit_as_bytes) | warn | calling `as_bytes` on a string literal instead of using a byte string literal +[stutter](https://github.com/rust-lang-nursery/rust-clippy/wiki#stutter) | allow | type names prefixed/postfixed with their containing module's name +[suspicious_assignment_formatting](https://github.com/rust-lang-nursery/rust-clippy/wiki#suspicious_assignment_formatting) | warn | suspicious formatting of `*=`, `-=` or `!=` +[suspicious_else_formatting](https://github.com/rust-lang-nursery/rust-clippy/wiki#suspicious_else_formatting) | warn | suspicious formatting of `else if` +[temporary_assignment](https://github.com/rust-lang-nursery/rust-clippy/wiki#temporary_assignment) | warn | assignments to temporaries +[temporary_cstring_as_ptr](https://github.com/rust-lang-nursery/rust-clippy/wiki#temporary_cstring_as_ptr) | warn | getting the inner pointer of a temporary `CString` +[too_many_arguments](https://github.com/rust-lang-nursery/rust-clippy/wiki#too_many_arguments) | warn | functions with too many arguments +[toplevel_ref_arg](https://github.com/rust-lang-nursery/rust-clippy/wiki#toplevel_ref_arg) | warn | an entire binding declared as `ref`, in a function argument or a `let` statement +[transmute_ptr_to_ref](https://github.com/rust-lang-nursery/rust-clippy/wiki#transmute_ptr_to_ref) | warn | transmutes from a pointer to a reference type +[trivial_regex](https://github.com/rust-lang-nursery/rust-clippy/wiki#trivial_regex) | warn | trivial regular expressions +[type_complexity](https://github.com/rust-lang-nursery/rust-clippy/wiki#type_complexity) | warn | usage of very complex types that might be better factored into `type` definitions +[unicode_not_nfc](https://github.com/rust-lang-nursery/rust-clippy/wiki#unicode_not_nfc) | allow | using a unicode literal not in NFC normal form (see [unicode tr15](http://www.unicode.org/reports/tr15/) for further information) +[unit_cmp](https://github.com/rust-lang-nursery/rust-clippy/wiki#unit_cmp) | warn | comparing unit values +[unnecessary_cast](https://github.com/rust-lang-nursery/rust-clippy/wiki#unnecessary_cast) | warn | cast to the same type, e.g. `x as i32` where `x: i32` +[unnecessary_mut_passed](https://github.com/rust-lang-nursery/rust-clippy/wiki#unnecessary_mut_passed) | warn | an argument passed as a mutable reference although the callee only demands an immutable reference +[unnecessary_operation](https://github.com/rust-lang-nursery/rust-clippy/wiki#unnecessary_operation) | warn | outer expressions with no effect +[unneeded_field_pattern](https://github.com/rust-lang-nursery/rust-clippy/wiki#unneeded_field_pattern) | warn | struct fields bound to a wildcard instead of using `..` +[unreadable_literal](https://github.com/rust-lang-nursery/rust-clippy/wiki#unreadable_literal) | warn | long integer literal without underscores +[unsafe_removed_from_name](https://github.com/rust-lang-nursery/rust-clippy/wiki#unsafe_removed_from_name) | warn | `unsafe` removed from API names on import +[unseparated_literal_suffix](https://github.com/rust-lang-nursery/rust-clippy/wiki#unseparated_literal_suffix) | allow | literals whose suffix is not separated by an underscore +[unused_collect](https://github.com/rust-lang-nursery/rust-clippy/wiki#unused_collect) | warn | `collect()`ing an iterator without using the result; this is usually better written as a for loop +[unused_io_amount](https://github.com/rust-lang-nursery/rust-clippy/wiki#unused_io_amount) | deny | unused written/read amount +[unused_label](https://github.com/rust-lang-nursery/rust-clippy/wiki#unused_label) | warn | unused labels +[unused_lifetimes](https://github.com/rust-lang-nursery/rust-clippy/wiki#unused_lifetimes) | warn | unused lifetimes in function definitions +[use_debug](https://github.com/rust-lang-nursery/rust-clippy/wiki#use_debug) | allow | use of `Debug`-based formatting +[used_underscore_binding](https://github.com/rust-lang-nursery/rust-clippy/wiki#used_underscore_binding) | allow | using a binding which is prefixed with an underscore +[useless_attribute](https://github.com/rust-lang-nursery/rust-clippy/wiki#useless_attribute) | warn | use of lint attributes on `extern crate` items +[useless_format](https://github.com/rust-lang-nursery/rust-clippy/wiki#useless_format) | warn | useless use of `format!` +[useless_let_if_seq](https://github.com/rust-lang-nursery/rust-clippy/wiki#useless_let_if_seq) | warn | unidiomatic `let mut` declaration followed by initialization in `if` +[useless_transmute](https://github.com/rust-lang-nursery/rust-clippy/wiki#useless_transmute) | warn | transmutes that have the same to and from types or could be a cast/coercion +[useless_vec](https://github.com/rust-lang-nursery/rust-clippy/wiki#useless_vec) | warn | useless `vec!` +[verbose_bit_mask](https://github.com/rust-lang-nursery/rust-clippy/wiki#verbose_bit_mask) | warn | expressions where a bit mask is less readable than the corresponding method call +[while_let_loop](https://github.com/rust-lang-nursery/rust-clippy/wiki#while_let_loop) | warn | `loop { if let { ... } else break }`, which can be written as a `while let` loop +[while_let_on_iterator](https://github.com/rust-lang-nursery/rust-clippy/wiki#while_let_on_iterator) | warn | using a while-let loop instead of a for loop on an iterator +[wrong_pub_self_convention](https://github.com/rust-lang-nursery/rust-clippy/wiki#wrong_pub_self_convention) | allow | defining a public method named with an established prefix (like "into_") that takes `self` with the wrong convention +[wrong_self_convention](https://github.com/rust-lang-nursery/rust-clippy/wiki#wrong_self_convention) | warn | defining a method named with an established prefix (like "into_") that takes `self` with the wrong convention +[wrong_transmute](https://github.com/rust-lang-nursery/rust-clippy/wiki#wrong_transmute) | warn | transmutes that are confusing at best, undefined behaviour at worst and always useless +[zero_divided_by_zero](https://github.com/rust-lang-nursery/rust-clippy/wiki#zero_divided_by_zero) | warn | usage of `0.0 / 0.0` to obtain NaN instead of std::f32::NaN or std::f64::NaN +[zero_prefixed_literal](https://github.com/rust-lang-nursery/rust-clippy/wiki#zero_prefixed_literal) | warn | integer literals starting with `0` +[zero_ptr](https://github.com/rust-lang-nursery/rust-clippy/wiki#zero_ptr) | warn | using 0 as *{const, mut} T +[zero_width_space](https://github.com/rust-lang-nursery/rust-clippy/wiki#zero_width_space) | deny | using a zero-width space in a string literal, which is confusing -More to come, please [file an issue](https://github.com/Manishearth/rust-clippy/issues) if you have ideas! +More to come, please [file an issue](https://github.com/rust-lang-nursery/rust-clippy/issues) if you have ideas! ## License diff --git a/clippy_lints/Cargo.toml b/clippy_lints/Cargo.toml index 7614c0483..781d77d48 100644 --- a/clippy_lints/Cargo.toml +++ b/clippy_lints/Cargo.toml @@ -10,7 +10,7 @@ authors = [ "Martin Carton " ] description = "A bunch of helpful lints to avoid common pitfalls in Rust" -repository = "https://github.com/Manishearth/rust-clippy" +repository = "https://github.com/rust-lang-nursery/rust-clippy" readme = "README.md" license = "MPL-2.0" keywords = ["clippy", "lint", "plugin"] diff --git a/clippy_lints/README.md b/clippy_lints/README.md index 517969079..b226cdea4 100644 --- a/clippy_lints/README.md +++ b/clippy_lints/README.md @@ -1,3 +1,3 @@ This crate contains Clippy lints. For the main crate, check [*cargo.io*](https://crates.io/crates/clippy) or -[GitHub](https://github.com/Manishearth/rust-clippy). +[GitHub](https://github.com/rust-lang-nursery/rust-clippy). diff --git a/clippy_lints/src/copies.rs b/clippy_lints/src/copies.rs index 8f8bdf472..747a62d05 100644 --- a/clippy_lints/src/copies.rs +++ b/clippy_lints/src/copies.rs @@ -67,7 +67,7 @@ declare_lint! { /// [using `|`](https://doc.rust-lang.org/book/patterns.html#multiple-patterns). /// /// **Known problems:** False positive possible with order dependent `match` -/// (see issue [#860](https://github.com/Manishearth/rust-clippy/issues/860)). +/// (see issue [#860](https://github.com/rust-lang-nursery/rust-clippy/issues/860)). /// /// **Example:** /// ```rust,ignore diff --git a/clippy_lints/src/types.rs b/clippy_lints/src/types.rs index 66cb5671c..b9d371a1f 100644 --- a/clippy_lints/src/types.rs +++ b/clippy_lints/src/types.rs @@ -1072,7 +1072,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for AbsurdExtremeComparisons { /// will mistakenly imply that it is possible for `x` to be outside the range of /// `u8`. /// -/// **Known problems:** https://github.com/Manishearth/rust-clippy/issues/886 +/// **Known problems:** https://github.com/rust-lang-nursery/rust-clippy/issues/886 /// /// **Example:** /// ```rust diff --git a/clippy_lints/src/utils/mod.rs b/clippy_lints/src/utils/mod.rs index cdce1108b..b4a9607a1 100644 --- a/clippy_lints/src/utils/mod.rs +++ b/clippy_lints/src/utils/mod.rs @@ -498,7 +498,7 @@ impl<'a> Drop for DiagnosticWrapper<'a> { impl<'a> DiagnosticWrapper<'a> { fn wiki_link(&mut self, lint: &'static Lint) { if env::var("CLIPPY_DISABLE_WIKI_LINKS").is_err() { - self.0.help(&format!("for further information visit https://github.com/Manishearth/rust-clippy/wiki#{}", + self.0.help(&format!("for further information visit https://github.com/rust-lang-nursery/rust-clippy/wiki#{}", lint.name_lower())); } } diff --git a/mini-macro/Cargo.toml b/mini-macro/Cargo.toml index f884ab480..1b7dc04f7 100644 --- a/mini-macro/Cargo.toml +++ b/mini-macro/Cargo.toml @@ -10,7 +10,7 @@ authors = [ ] license = "MPL-2.0" description = "A macro to test clippy's procedural macro checks" -repository = "https://github.com/Manishearth/rust-clippy" +repository = "https://github.com/rust-lang-nursery/rust-clippy" [lib] name = "clippy_mini_macro_test" diff --git a/tests/ui/doc.rs b/tests/ui/doc.rs index 0be34aa6f..4a34b561d 100644 --- a/tests/ui/doc.rs +++ b/tests/ui/doc.rs @@ -50,7 +50,7 @@ fn test_units() { } /// This test has [a link_with_underscores][chunked-example] inside it. See #823. -/// See also [the issue tracker](https://github.com/Manishearth/rust-clippy/search?q=doc_markdown&type=Issues) +/// See also [the issue tracker](https://github.com/rust-lang-nursery/rust-clippy/search?q=doc_markdown&type=Issues) /// on GitHub (which is a camel-cased word, but is OK). And here is another [inline link][inline_link]. /// It can also be [inline_link2]. /// @@ -142,7 +142,7 @@ fn four_quotes() { /// See [NIST SP 800-56A, revision 2]. /// /// [NIST SP 800-56A, revision 2]: -/// https://github.com/Manishearth/rust-clippy/issues/902#issuecomment-261919419 +/// https://github.com/rust-lang-nursery/rust-clippy/issues/902#issuecomment-261919419 fn issue_902_comment() {} #[cfg_attr(feature = "a", doc = " ```")] diff --git a/tests/ui/methods.rs b/tests/ui/methods.rs index 33c507ed8..a9716d4e7 100644 --- a/tests/ui/methods.rs +++ b/tests/ui/methods.rs @@ -483,7 +483,7 @@ fn single_char_pattern() { // should have done this but produced an ICE // // We may not want to suggest changing these anyway - // See: https://github.com/Manishearth/rust-clippy/issues/650#issuecomment-184328984 + // See: https://github.com/rust-lang-nursery/rust-clippy/issues/650#issuecomment-184328984 x.split("ß"); x.split("ℝ"); x.split("💣"); diff --git a/tests/ui/module_inception.rs b/tests/ui/module_inception.rs index c1dd7958f..e934c6402 100644 --- a/tests/ui/module_inception.rs +++ b/tests/ui/module_inception.rs @@ -14,7 +14,7 @@ mod foo { } } -// No warning. See . +// No warning. See . mod bar { #[allow(module_inception)] mod bar { diff --git a/util/gh-pages/index.html b/util/gh-pages/index.html index 04196eef3..2cac5c6bc 100644 --- a/util/gh-pages/index.html +++ b/util/gh-pages/index.html @@ -94,7 +94,7 @@ - + diff --git a/util/update_lints.py b/util/update_lints.py index ddb5d3ab3..9eeb02de9 100755 --- a/util/update_lints.py +++ b/util/update_lints.py @@ -29,7 +29,7 @@ declare_restriction_lint_re = re.compile(r''' nl_escape_re = re.compile(r'\\\n\s*') -wiki_link = 'https://github.com/Manishearth/rust-clippy/wiki' +wiki_link = 'https://github.com/rust-lang-nursery/rust-clippy/wiki' def collect(lints, deprecated_lints, restriction_lints, fn):