Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-17 02:08:28 +00:00
Code Issues Projects Releases Packages Wiki Activity

Similar names ignore underscore prefixed names

Browse source
This commit is contained in:
Cameron Steffen 2020-11-28 16:56:59 -06:00
parent 13ca5c88f1
commit f2d493504c
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
clippy_lints/src/non_expressive_names.rs
View file

@ -199,6 +199,10 @@ impl<'a, 'tcx, 'b> SimilarNamesNameVisitor<'a, 'tcx, 'b> {
); );
return; return;
} }
if interned_name.starts_with('_') {
// these bindings are typically unused or represent an ignored portion of a destructuring pattern
return;
}
let count = interned_name.chars().count(); let count = interned_name.chars().count();
if count < 3 { if count < 3 {
if count == 1 { if count == 1 {

5
tests/ui/similar_names.rs
View file

@ -101,3 +101,8 @@ pub(crate) struct DirSizes {
pub(crate) numb_reg_cache_entries: u64, pub(crate) numb_reg_cache_entries: u64,
pub(crate) numb_reg_src_checkouts: u64, pub(crate) numb_reg_src_checkouts: u64,
} }
fn ignore_underscore_prefix() {
let hello: ();
let _hello: ();
}