Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-24 13:43:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add macro check

Browse source
This commit is contained in:
Florian Hartwig 2016-01-19 19:43:29 +01:00
parent 01eda52cb5
commit ea26ae3888
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/strings.rs
View file

@ -134,13 +134,13 @@ impl LateLintPass for StringLitAsBytes {
fn check_expr(&mut self, cx: &LateContext, e: &Expr) { fn check_expr(&mut self, cx: &LateContext, e: &Expr) {
use std::ascii::AsciiExt; use std::ascii::AsciiExt;
use syntax::ast::Lit_::LitStr; use syntax::ast::Lit_::LitStr;
use utils::snippet; use utils::{snippet, in_macro};
if let ExprMethodCall(ref name, _, ref args) = e.node { if let ExprMethodCall(ref name, _, ref args) = e.node {
if name.node.as_str() == "as_bytes" { if name.node.as_str() == "as_bytes" {
if let ExprLit(ref lit) = args[0].node { if let ExprLit(ref lit) = args[0].node {
if let LitStr(ref lit_content, _) = lit.node { if let LitStr(ref lit_content, _) = lit.node {
if lit_content.chars().all(|c| c.is_ascii()) { if lit_content.chars().all(|c| c.is_ascii()) && !in_macro(cx, e.span) {
let msg = format!("calling `as_bytes()` on a string literal. \ let msg = format!("calling `as_bytes()` on a string literal. \
Consider using a byte string literal instead: \ Consider using a byte string literal instead: \
`b{}`", `b{}`",