From e6a836e2e801a3c0675b3dd24e0de1c810470813 Mon Sep 17 00:00:00 2001 From: flip1995 Date: Tue, 30 Jul 2019 09:50:56 +0200 Subject: [PATCH] Move UNNECESSARY_UNWRAP to complexity and PANICKING_UNWRAP to correctness --- clippy_lints/src/lib.rs | 6 ++++-- clippy_lints/src/unwrap.rs | 4 ++-- src/lintlist/mod.rs | 4 ++-- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/clippy_lints/src/lib.rs b/clippy_lints/src/lib.rs index 908bbeb5e..1e9e17f59 100644 --- a/clippy_lints/src/lib.rs +++ b/clippy_lints/src/lib.rs @@ -894,6 +894,8 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) { unsafe_removed_from_name::UNSAFE_REMOVED_FROM_NAME, unused_io_amount::UNUSED_IO_AMOUNT, unused_label::UNUSED_LABEL, + unwrap::PANICKING_UNWRAP, + unwrap::UNNECESSARY_UNWRAP, vec::USELESS_VEC, write::PRINTLN_EMPTY_STRING, write::PRINT_LITERAL, @@ -1060,6 +1062,7 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) { types::UNNECESSARY_CAST, types::VEC_BOX, unused_label::UNUSED_LABEL, + unwrap::UNNECESSARY_UNWRAP, zero_div_zero::ZERO_DIVIDED_BY_ZERO, ]); @@ -1121,6 +1124,7 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) { types::UNIT_CMP, unicode::ZERO_WIDTH_SPACE, unused_io_amount::UNUSED_IO_AMOUNT, + unwrap::PANICKING_UNWRAP, ]); reg.register_lint_group("clippy::perf", Some("clippy_perf"), vec![ @@ -1157,8 +1161,6 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>, conf: &Conf) { needless_borrow::NEEDLESS_BORROW, path_buf_push_overwrite::PATH_BUF_PUSH_OVERWRITE, redundant_clone::REDUNDANT_CLONE, - unwrap::PANICKING_UNWRAP, - unwrap::UNNECESSARY_UNWRAP, ]); } diff --git a/clippy_lints/src/unwrap.rs b/clippy_lints/src/unwrap.rs index 568087b36..830e1fc4d 100644 --- a/clippy_lints/src/unwrap.rs +++ b/clippy_lints/src/unwrap.rs @@ -31,7 +31,7 @@ declare_clippy_lint! { /// } /// ``` pub UNNECESSARY_UNWRAP, - nursery, + complexity, "checks for calls of unwrap[_err]() that cannot fail" } @@ -52,7 +52,7 @@ declare_clippy_lint! { /// /// This code will always panic. The if condition should probably be inverted. pub PANICKING_UNWRAP, - nursery, + correctness, "checks for calls of unwrap[_err]() that will always fail" } diff --git a/src/lintlist/mod.rs b/src/lintlist/mod.rs index 49bce5a6c..aa4576640 100644 --- a/src/lintlist/mod.rs +++ b/src/lintlist/mod.rs @@ -1381,7 +1381,7 @@ pub const ALL_LINTS: [Lint; 309] = [ }, Lint { name: "panicking_unwrap", - group: "nursery", + group: "correctness", desc: "checks for calls of unwrap[_err]() that will always fail", deprecation: None, module: "unwrap", @@ -1927,7 +1927,7 @@ pub const ALL_LINTS: [Lint; 309] = [ }, Lint { name: "unnecessary_unwrap", - group: "nursery", + group: "complexity", desc: "checks for calls of unwrap[_err]() that cannot fail", deprecation: None, module: "unwrap",