mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-10 15:14:29 +00:00
Split tests (too long for CI)
This commit is contained in:
ThibsG
parent
b38f173aa3
commit
ddcbac37ae
7 changed files with 430 additions and 338 deletions
|
|
@ -1,261 +0,0 @@
|
|||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:10:22
|
||||
|
|
||||
LL | let _ = v.iter().find(|&x| *x < 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| *x < 0)`
|
||||
|
|
||||
= note: `-D clippy::search-is-some` implied by `-D warnings`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:11:20
|
||||
|
|
||||
LL | let _ = (0..1).find(|x| **y == *x).is_some(); // one dereference less
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| **y == x)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:12:20
|
||||
|
|
||||
LL | let _ = (0..1).find(|x| *x == 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| x == 0)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:13:22
|
||||
|
|
||||
LL | let _ = v.iter().find(|x| **x == 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| *x == 0)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:14:20
|
||||
|
|
||||
LL | let _ = (4..5).find(|x| *x == 1 || *x == 3 || *x == 5).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| x == 1 || x == 3 || x == 5)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:15:20
|
||||
|
|
||||
LL | let _ = (1..3).find(|x| [1, 2, 3].contains(x)).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| [1, 2, 3].contains(&x))`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:16:20
|
||||
|
|
||||
LL | let _ = (1..3).find(|x| *x == 0 || [1, 2, 3].contains(x)).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| x == 0 || [1, 2, 3].contains(&x))`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:17:20
|
||||
|
|
||||
LL | let _ = (1..3).find(|x| [1, 2, 3].contains(x) || *x == 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| [1, 2, 3].contains(&x) || x == 0)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:19:10
|
||||
|
|
||||
LL | .find(|x| [1, 2, 3].contains(x) || *x == 0 || [4, 5, 6].contains(x) || *x == -1)
|
||||
| __________^
|
||||
LL | | .is_some();
|
||||
| |__________________^ help: use `any()` instead: `any(|x| [1, 2, 3].contains(&x) || x == 0 || [4, 5, 6].contains(&x) || x == -1)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `position`
|
||||
--> $DIR/search_is_some_fixable.rs:23:22
|
||||
|
|
||||
LL | let _ = v.iter().position(|&x| x < 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|&x| x < 0)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `rposition`
|
||||
--> $DIR/search_is_some_fixable.rs:26:22
|
||||
|
|
||||
LL | let _ = v.iter().rposition(|&x| x < 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|&x| x < 0)`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:31:27
|
||||
|
|
||||
LL | let _ = "hello world".find("world").is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains("world")`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:32:27
|
||||
|
|
||||
LL | let _ = "hello world".find(&s2).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains(&s2)`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:33:27
|
||||
|
|
||||
LL | let _ = "hello world".find(&s2[2..]).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains(&s2[2..])`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:35:16
|
||||
|
|
||||
LL | let _ = s1.find("world").is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains("world")`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:36:16
|
||||
|
|
||||
LL | let _ = s1.find(&s2).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains(&s2)`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:37:16
|
||||
|
|
||||
LL | let _ = s1.find(&s2[2..]).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains(&s2[2..])`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:39:21
|
||||
|
|
||||
LL | let _ = s1[2..].find("world").is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains("world")`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:40:21
|
||||
|
|
||||
LL | let _ = s1[2..].find(&s2).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains(&s2)`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:41:21
|
||||
|
|
||||
LL | let _ = s1[2..].find(&s2[2..]).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains(&s2[2..])`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:49:13
|
||||
|
|
||||
LL | let _ = v.iter().find(|&x| *x < 0).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!v.iter().any(|x| *x < 0)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:50:13
|
||||
|
|
||||
LL | let _ = (0..1).find(|x| **y == *x).is_none(); // one dereference less
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!(0..1).any(|x| **y == x)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:51:13
|
||||
|
|
||||
LL | let _ = (0..1).find(|x| *x == 0).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!(0..1).any(|x| x == 0)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:52:13
|
||||
|
|
||||
LL | let _ = v.iter().find(|x| **x == 0).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!v.iter().any(|x| *x == 0)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:53:13
|
||||
|
|
||||
LL | let _ = (4..5).find(|x| *x == 1 || *x == 3 || *x == 5).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!(4..5).any(|x| x == 1 || x == 3 || x == 5)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:54:13
|
||||
|
|
||||
LL | let _ = (1..3).find(|x| [1, 2, 3].contains(x)).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!(1..3).any(|x| [1, 2, 3].contains(&x))`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:55:13
|
||||
|
|
||||
LL | let _ = (1..3).find(|x| *x == 0 || [1, 2, 3].contains(x)).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!(1..3).any(|x| x == 0 || [1, 2, 3].contains(&x))`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:56:13
|
||||
|
|
||||
LL | let _ = (1..3).find(|x| [1, 2, 3].contains(x) || *x == 0).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!(1..3).any(|x| [1, 2, 3].contains(&x) || x == 0)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:57:13
|
||||
|
|
||||
LL | let _ = (1..3)
|
||||
| _____________^
|
||||
LL | | .find(|x| [1, 2, 3].contains(x) || *x == 0 || [4, 5, 6].contains(x) || *x == -1)
|
||||
LL | | .is_none();
|
||||
| |__________________^ help: use `!_.any()` instead: `!(1..3).any(|x| [1, 2, 3].contains(&x) || x == 0 || [4, 5, 6].contains(&x) || x == -1)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `position`
|
||||
--> $DIR/search_is_some_fixable.rs:62:13
|
||||
|
|
||||
LL | let _ = v.iter().position(|&x| x < 0).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!v.iter().any(|&x| x < 0)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `rposition`
|
||||
--> $DIR/search_is_some_fixable.rs:65:13
|
||||
|
|
||||
LL | let _ = v.iter().rposition(|&x| x < 0).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!v.iter().any(|&x| x < 0)`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:71:13
|
||||
|
|
||||
LL | let _ = "hello world".find("world").is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!"hello world".contains("world")`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:72:13
|
||||
|
|
||||
LL | let _ = "hello world".find(&s2).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!"hello world".contains(&s2)`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:73:13
|
||||
|
|
||||
LL | let _ = "hello world".find(&s2[2..]).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!"hello world".contains(&s2[2..])`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:75:13
|
||||
|
|
||||
LL | let _ = s1.find("world").is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!s1.contains("world")`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:76:13
|
||||
|
|
||||
LL | let _ = s1.find(&s2).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!s1.contains(&s2)`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:77:13
|
||||
|
|
||||
LL | let _ = s1.find(&s2[2..]).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!s1.contains(&s2[2..])`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:79:13
|
||||
|
|
||||
LL | let _ = s1[2..].find("world").is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!s1[2..].contains("world")`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:80:13
|
||||
|
|
||||
LL | let _ = s1[2..].find(&s2).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!s1[2..].contains(&s2)`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable.rs:81:13
|
||||
|
|
||||
LL | let _ = s1[2..].find(&s2[2..]).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!s1[2..].contains(&s2[2..])`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:97:25
|
||||
|
|
||||
LL | .filter(|c| filter_hand.iter().find(|cc| c == cc).is_none())
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!filter_hand.iter().any(|cc| c == &cc)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable.rs:113:30
|
||||
|
|
||||
LL | .filter(|(c, _)| filter_hand.iter().find(|cc| c == *cc).is_none())
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!filter_hand.iter().any(|cc| c == cc)`
|
||||
|
||||
error: aborting due to 42 previous errors
|
||||
|
||||
|
|
@ -6,44 +6,6 @@ fn main() {
|
|||
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
||||
let y = &&42;
|
||||
|
||||
// Check `find().is_some()`, single-line case.
|
||||
let _ = v.iter().any(|x| *x < 0);
|
||||
let _ = (0..1).any(|x| **y == x); // one dereference less
|
||||
let _ = (0..1).any(|x| x == 0);
|
||||
let _ = v.iter().any(|x| *x == 0);
|
||||
let _ = (4..5).any(|x| x == 1 || x == 3 || x == 5);
|
||||
let _ = (1..3).any(|x| [1, 2, 3].contains(&x));
|
||||
let _ = (1..3).any(|x| x == 0 || [1, 2, 3].contains(&x));
|
||||
let _ = (1..3).any(|x| [1, 2, 3].contains(&x) || x == 0);
|
||||
let _ = (1..3)
|
||||
.any(|x| [1, 2, 3].contains(&x) || x == 0 || [4, 5, 6].contains(&x) || x == -1);
|
||||
|
||||
// Check `position().is_some()`, single-line case.
|
||||
let _ = v.iter().any(|&x| x < 0);
|
||||
|
||||
// Check `rposition().is_some()`, single-line case.
|
||||
let _ = v.iter().any(|&x| x < 0);
|
||||
|
||||
let s1 = String::from("hello world");
|
||||
let s2 = String::from("world");
|
||||
// caller of `find()` is a `&`static str`
|
||||
let _ = "hello world".contains("world");
|
||||
let _ = "hello world".contains(&s2);
|
||||
let _ = "hello world".contains(&s2[2..]);
|
||||
// caller of `find()` is a `String`
|
||||
let _ = s1.contains("world");
|
||||
let _ = s1.contains(&s2);
|
||||
let _ = s1.contains(&s2[2..]);
|
||||
// caller of `find()` is slice of `String`
|
||||
let _ = s1[2..].contains("world");
|
||||
let _ = s1[2..].contains(&s2);
|
||||
let _ = s1[2..].contains(&s2[2..]);
|
||||
}
|
||||
|
||||
fn is_none() {
|
||||
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
||||
let y = &&42;
|
||||
|
||||
// Check `find().is_none()`, single-line case.
|
||||
let _ = !v.iter().any(|x| *x < 0);
|
||||
let _ = !(0..1).any(|x| **y == x); // one dereference less
|
||||
|
|
@ -6,45 +6,6 @@ fn main() {
|
|||
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
||||
let y = &&42;
|
||||
|
||||
// Check `find().is_some()`, single-line case.
|
||||
let _ = v.iter().find(|&x| *x < 0).is_some();
|
||||
let _ = (0..1).find(|x| **y == *x).is_some(); // one dereference less
|
||||
let _ = (0..1).find(|x| *x == 0).is_some();
|
||||
let _ = v.iter().find(|x| **x == 0).is_some();
|
||||
let _ = (4..5).find(|x| *x == 1 || *x == 3 || *x == 5).is_some();
|
||||
let _ = (1..3).find(|x| [1, 2, 3].contains(x)).is_some();
|
||||
let _ = (1..3).find(|x| *x == 0 || [1, 2, 3].contains(x)).is_some();
|
||||
let _ = (1..3).find(|x| [1, 2, 3].contains(x) || *x == 0).is_some();
|
||||
let _ = (1..3)
|
||||
.find(|x| [1, 2, 3].contains(x) || *x == 0 || [4, 5, 6].contains(x) || *x == -1)
|
||||
.is_some();
|
||||
|
||||
// Check `position().is_some()`, single-line case.
|
||||
let _ = v.iter().position(|&x| x < 0).is_some();
|
||||
|
||||
// Check `rposition().is_some()`, single-line case.
|
||||
let _ = v.iter().rposition(|&x| x < 0).is_some();
|
||||
|
||||
let s1 = String::from("hello world");
|
||||
let s2 = String::from("world");
|
||||
// caller of `find()` is a `&`static str`
|
||||
let _ = "hello world".find("world").is_some();
|
||||
let _ = "hello world".find(&s2).is_some();
|
||||
let _ = "hello world".find(&s2[2..]).is_some();
|
||||
// caller of `find()` is a `String`
|
||||
let _ = s1.find("world").is_some();
|
||||
let _ = s1.find(&s2).is_some();
|
||||
let _ = s1.find(&s2[2..]).is_some();
|
||||
// caller of `find()` is slice of `String`
|
||||
let _ = s1[2..].find("world").is_some();
|
||||
let _ = s1[2..].find(&s2).is_some();
|
||||
let _ = s1[2..].find(&s2[2..]).is_some();
|
||||
}
|
||||
|
||||
fn is_none() {
|
||||
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
||||
let y = &&42;
|
||||
|
||||
// Check `find().is_none()`, single-line case.
|
||||
let _ = v.iter().find(|&x| *x < 0).is_none();
|
||||
let _ = (0..1).find(|x| **y == *x).is_none(); // one dereference less
|
||||
139
tests/ui/search_is_some_fixable_none.stderr
Normal file
139
tests/ui/search_is_some_fixable_none.stderr
Normal file
|
|
@ -0,0 +1,139 @@
|
|||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_none.rs:10:13
|
||||
|
|
||||
LL | let _ = v.iter().find(|&x| *x < 0).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!v.iter().any(|x| *x < 0)`
|
||||
|
|
||||
= note: `-D clippy::search-is-some` implied by `-D warnings`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_none.rs:11:13
|
||||
|
|
||||
LL | let _ = (0..1).find(|x| **y == *x).is_none(); // one dereference less
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!(0..1).any(|x| **y == x)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_none.rs:12:13
|
||||
|
|
||||
LL | let _ = (0..1).find(|x| *x == 0).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!(0..1).any(|x| x == 0)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_none.rs:13:13
|
||||
|
|
||||
LL | let _ = v.iter().find(|x| **x == 0).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!v.iter().any(|x| *x == 0)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_none.rs:14:13
|
||||
|
|
||||
LL | let _ = (4..5).find(|x| *x == 1 || *x == 3 || *x == 5).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!(4..5).any(|x| x == 1 || x == 3 || x == 5)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_none.rs:15:13
|
||||
|
|
||||
LL | let _ = (1..3).find(|x| [1, 2, 3].contains(x)).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!(1..3).any(|x| [1, 2, 3].contains(&x))`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_none.rs:16:13
|
||||
|
|
||||
LL | let _ = (1..3).find(|x| *x == 0 || [1, 2, 3].contains(x)).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!(1..3).any(|x| x == 0 || [1, 2, 3].contains(&x))`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_none.rs:17:13
|
||||
|
|
||||
LL | let _ = (1..3).find(|x| [1, 2, 3].contains(x) || *x == 0).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!(1..3).any(|x| [1, 2, 3].contains(&x) || x == 0)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_none.rs:18:13
|
||||
|
|
||||
LL | let _ = (1..3)
|
||||
| _____________^
|
||||
LL | | .find(|x| [1, 2, 3].contains(x) || *x == 0 || [4, 5, 6].contains(x) || *x == -1)
|
||||
LL | | .is_none();
|
||||
| |__________________^ help: use `!_.any()` instead: `!(1..3).any(|x| [1, 2, 3].contains(&x) || x == 0 || [4, 5, 6].contains(&x) || x == -1)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `position`
|
||||
--> $DIR/search_is_some_fixable_none.rs:23:13
|
||||
|
|
||||
LL | let _ = v.iter().position(|&x| x < 0).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!v.iter().any(|&x| x < 0)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `rposition`
|
||||
--> $DIR/search_is_some_fixable_none.rs:26:13
|
||||
|
|
||||
LL | let _ = v.iter().rposition(|&x| x < 0).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!v.iter().any(|&x| x < 0)`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_none.rs:32:13
|
||||
|
|
||||
LL | let _ = "hello world".find("world").is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!"hello world".contains("world")`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_none.rs:33:13
|
||||
|
|
||||
LL | let _ = "hello world".find(&s2).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!"hello world".contains(&s2)`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_none.rs:34:13
|
||||
|
|
||||
LL | let _ = "hello world".find(&s2[2..]).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!"hello world".contains(&s2[2..])`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_none.rs:36:13
|
||||
|
|
||||
LL | let _ = s1.find("world").is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!s1.contains("world")`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_none.rs:37:13
|
||||
|
|
||||
LL | let _ = s1.find(&s2).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!s1.contains(&s2)`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_none.rs:38:13
|
||||
|
|
||||
LL | let _ = s1.find(&s2[2..]).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!s1.contains(&s2[2..])`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_none.rs:40:13
|
||||
|
|
||||
LL | let _ = s1[2..].find("world").is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!s1[2..].contains("world")`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_none.rs:41:13
|
||||
|
|
||||
LL | let _ = s1[2..].find(&s2).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!s1[2..].contains(&s2)`
|
||||
|
||||
error: called `is_none()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_none.rs:42:13
|
||||
|
|
||||
LL | let _ = s1[2..].find(&s2[2..]).is_none();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.contains()` instead: `!s1[2..].contains(&s2[2..])`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_none.rs:58:25
|
||||
|
|
||||
LL | .filter(|c| filter_hand.iter().find(|cc| c == cc).is_none())
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!filter_hand.iter().any(|cc| c == &cc)`
|
||||
|
||||
error: called `is_none()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_none.rs:74:30
|
||||
|
|
||||
LL | .filter(|(c, _)| filter_hand.iter().find(|cc| c == *cc).is_none())
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `!_.any()` instead: `!filter_hand.iter().any(|cc| c == cc)`
|
||||
|
||||
error: aborting due to 22 previous errors
|
||||
|
||||
76
tests/ui/search_is_some_fixable_some.fixed
Normal file
76
tests/ui/search_is_some_fixable_some.fixed
Normal file
|
|
@ -0,0 +1,76 @@
|
|||
// run-rustfix
|
||||
#![allow(dead_code)]
|
||||
#![warn(clippy::search_is_some)]
|
||||
|
||||
fn main() {
|
||||
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
||||
let y = &&42;
|
||||
|
||||
// Check `find().is_some()`, single-line case.
|
||||
let _ = v.iter().any(|x| *x < 0);
|
||||
let _ = (0..1).any(|x| **y == x); // one dereference less
|
||||
let _ = (0..1).any(|x| x == 0);
|
||||
let _ = v.iter().any(|x| *x == 0);
|
||||
let _ = (4..5).any(|x| x == 1 || x == 3 || x == 5);
|
||||
let _ = (1..3).any(|x| [1, 2, 3].contains(&x));
|
||||
let _ = (1..3).any(|x| x == 0 || [1, 2, 3].contains(&x));
|
||||
let _ = (1..3).any(|x| [1, 2, 3].contains(&x) || x == 0);
|
||||
let _ = (1..3)
|
||||
.any(|x| [1, 2, 3].contains(&x) || x == 0 || [4, 5, 6].contains(&x) || x == -1);
|
||||
|
||||
// Check `position().is_some()`, single-line case.
|
||||
let _ = v.iter().any(|&x| x < 0);
|
||||
|
||||
// Check `rposition().is_some()`, single-line case.
|
||||
let _ = v.iter().any(|&x| x < 0);
|
||||
|
||||
let s1 = String::from("hello world");
|
||||
let s2 = String::from("world");
|
||||
// caller of `find()` is a `&`static str`
|
||||
let _ = "hello world".contains("world");
|
||||
let _ = "hello world".contains(&s2);
|
||||
let _ = "hello world".contains(&s2[2..]);
|
||||
// caller of `find()` is a `String`
|
||||
let _ = s1.contains("world");
|
||||
let _ = s1.contains(&s2);
|
||||
let _ = s1.contains(&s2[2..]);
|
||||
// caller of `find()` is slice of `String`
|
||||
let _ = s1[2..].contains("world");
|
||||
let _ = s1[2..].contains(&s2);
|
||||
let _ = s1[2..].contains(&s2[2..]);
|
||||
}
|
||||
|
||||
#[allow(clippy::clone_on_copy, clippy::map_clone)]
|
||||
mod issue7392 {
|
||||
struct Player {
|
||||
hand: Vec<usize>,
|
||||
}
|
||||
fn filter() {
|
||||
let p = Player {
|
||||
hand: vec![1, 2, 3, 4, 5],
|
||||
};
|
||||
let filter_hand = vec![5];
|
||||
let _ = p
|
||||
.hand
|
||||
.iter()
|
||||
.filter(|c| filter_hand.iter().any(|cc| c == &cc))
|
||||
.map(|c| c.clone())
|
||||
.collect::<Vec<_>>();
|
||||
}
|
||||
|
||||
struct PlayerTuple {
|
||||
hand: Vec<(usize, char)>,
|
||||
}
|
||||
fn filter_tuple() {
|
||||
let p = PlayerTuple {
|
||||
hand: vec![(1, 'a'), (2, 'b'), (3, 'c'), (4, 'd'), (5, 'e')],
|
||||
};
|
||||
let filter_hand = vec![5];
|
||||
let _ = p
|
||||
.hand
|
||||
.iter()
|
||||
.filter(|(c, _)| filter_hand.iter().any(|cc| c == cc))
|
||||
.map(|c| c.clone())
|
||||
.collect::<Vec<_>>();
|
||||
}
|
||||
}
|
||||
77
tests/ui/search_is_some_fixable_some.rs
Normal file
77
tests/ui/search_is_some_fixable_some.rs
Normal file
|
|
@ -0,0 +1,77 @@
|
|||
// run-rustfix
|
||||
#![allow(dead_code)]
|
||||
#![warn(clippy::search_is_some)]
|
||||
|
||||
fn main() {
|
||||
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
||||
let y = &&42;
|
||||
|
||||
// Check `find().is_some()`, single-line case.
|
||||
let _ = v.iter().find(|&x| *x < 0).is_some();
|
||||
let _ = (0..1).find(|x| **y == *x).is_some(); // one dereference less
|
||||
let _ = (0..1).find(|x| *x == 0).is_some();
|
||||
let _ = v.iter().find(|x| **x == 0).is_some();
|
||||
let _ = (4..5).find(|x| *x == 1 || *x == 3 || *x == 5).is_some();
|
||||
let _ = (1..3).find(|x| [1, 2, 3].contains(x)).is_some();
|
||||
let _ = (1..3).find(|x| *x == 0 || [1, 2, 3].contains(x)).is_some();
|
||||
let _ = (1..3).find(|x| [1, 2, 3].contains(x) || *x == 0).is_some();
|
||||
let _ = (1..3)
|
||||
.find(|x| [1, 2, 3].contains(x) || *x == 0 || [4, 5, 6].contains(x) || *x == -1)
|
||||
.is_some();
|
||||
|
||||
// Check `position().is_some()`, single-line case.
|
||||
let _ = v.iter().position(|&x| x < 0).is_some();
|
||||
|
||||
// Check `rposition().is_some()`, single-line case.
|
||||
let _ = v.iter().rposition(|&x| x < 0).is_some();
|
||||
|
||||
let s1 = String::from("hello world");
|
||||
let s2 = String::from("world");
|
||||
// caller of `find()` is a `&`static str`
|
||||
let _ = "hello world".find("world").is_some();
|
||||
let _ = "hello world".find(&s2).is_some();
|
||||
let _ = "hello world".find(&s2[2..]).is_some();
|
||||
// caller of `find()` is a `String`
|
||||
let _ = s1.find("world").is_some();
|
||||
let _ = s1.find(&s2).is_some();
|
||||
let _ = s1.find(&s2[2..]).is_some();
|
||||
// caller of `find()` is slice of `String`
|
||||
let _ = s1[2..].find("world").is_some();
|
||||
let _ = s1[2..].find(&s2).is_some();
|
||||
let _ = s1[2..].find(&s2[2..]).is_some();
|
||||
}
|
||||
|
||||
#[allow(clippy::clone_on_copy, clippy::map_clone)]
|
||||
mod issue7392 {
|
||||
struct Player {
|
||||
hand: Vec<usize>,
|
||||
}
|
||||
fn filter() {
|
||||
let p = Player {
|
||||
hand: vec![1, 2, 3, 4, 5],
|
||||
};
|
||||
let filter_hand = vec![5];
|
||||
let _ = p
|
||||
.hand
|
||||
.iter()
|
||||
.filter(|c| filter_hand.iter().find(|cc| c == cc).is_some())
|
||||
.map(|c| c.clone())
|
||||
.collect::<Vec<_>>();
|
||||
}
|
||||
|
||||
struct PlayerTuple {
|
||||
hand: Vec<(usize, char)>,
|
||||
}
|
||||
fn filter_tuple() {
|
||||
let p = PlayerTuple {
|
||||
hand: vec![(1, 'a'), (2, 'b'), (3, 'c'), (4, 'd'), (5, 'e')],
|
||||
};
|
||||
let filter_hand = vec![5];
|
||||
let _ = p
|
||||
.hand
|
||||
.iter()
|
||||
.filter(|(c, _)| filter_hand.iter().find(|cc| c == *cc).is_some())
|
||||
.map(|c| c.clone())
|
||||
.collect::<Vec<_>>();
|
||||
}
|
||||
}
|
||||
138
tests/ui/search_is_some_fixable_some.stderr
Normal file
138
tests/ui/search_is_some_fixable_some.stderr
Normal file
|
|
@ -0,0 +1,138 @@
|
|||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_some.rs:10:22
|
||||
|
|
||||
LL | let _ = v.iter().find(|&x| *x < 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| *x < 0)`
|
||||
|
|
||||
= note: `-D clippy::search-is-some` implied by `-D warnings`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_some.rs:11:20
|
||||
|
|
||||
LL | let _ = (0..1).find(|x| **y == *x).is_some(); // one dereference less
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| **y == x)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_some.rs:12:20
|
||||
|
|
||||
LL | let _ = (0..1).find(|x| *x == 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| x == 0)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_some.rs:13:22
|
||||
|
|
||||
LL | let _ = v.iter().find(|x| **x == 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| *x == 0)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_some.rs:14:20
|
||||
|
|
||||
LL | let _ = (4..5).find(|x| *x == 1 || *x == 3 || *x == 5).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| x == 1 || x == 3 || x == 5)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_some.rs:15:20
|
||||
|
|
||||
LL | let _ = (1..3).find(|x| [1, 2, 3].contains(x)).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| [1, 2, 3].contains(&x))`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_some.rs:16:20
|
||||
|
|
||||
LL | let _ = (1..3).find(|x| *x == 0 || [1, 2, 3].contains(x)).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| x == 0 || [1, 2, 3].contains(&x))`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_some.rs:17:20
|
||||
|
|
||||
LL | let _ = (1..3).find(|x| [1, 2, 3].contains(x) || *x == 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|x| [1, 2, 3].contains(&x) || x == 0)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_some.rs:19:10
|
||||
|
|
||||
LL | .find(|x| [1, 2, 3].contains(x) || *x == 0 || [4, 5, 6].contains(x) || *x == -1)
|
||||
| __________^
|
||||
LL | | .is_some();
|
||||
| |__________________^ help: use `any()` instead: `any(|x| [1, 2, 3].contains(&x) || x == 0 || [4, 5, 6].contains(&x) || x == -1)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `position`
|
||||
--> $DIR/search_is_some_fixable_some.rs:23:22
|
||||
|
|
||||
LL | let _ = v.iter().position(|&x| x < 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|&x| x < 0)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `rposition`
|
||||
--> $DIR/search_is_some_fixable_some.rs:26:22
|
||||
|
|
||||
LL | let _ = v.iter().rposition(|&x| x < 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|&x| x < 0)`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_some.rs:31:27
|
||||
|
|
||||
LL | let _ = "hello world".find("world").is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains("world")`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_some.rs:32:27
|
||||
|
|
||||
LL | let _ = "hello world".find(&s2).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains(&s2)`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_some.rs:33:27
|
||||
|
|
||||
LL | let _ = "hello world".find(&s2[2..]).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains(&s2[2..])`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_some.rs:35:16
|
||||
|
|
||||
LL | let _ = s1.find("world").is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains("world")`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_some.rs:36:16
|
||||
|
|
||||
LL | let _ = s1.find(&s2).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains(&s2)`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_some.rs:37:16
|
||||
|
|
||||
LL | let _ = s1.find(&s2[2..]).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains(&s2[2..])`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_some.rs:39:21
|
||||
|
|
||||
LL | let _ = s1[2..].find("world").is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains("world")`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_some.rs:40:21
|
||||
|
|
||||
LL | let _ = s1[2..].find(&s2).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains(&s2)`
|
||||
|
||||
error: called `is_some()` after calling `find()` on a string
|
||||
--> $DIR/search_is_some_fixable_some.rs:41:21
|
||||
|
|
||||
LL | let _ = s1[2..].find(&s2[2..]).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: use `contains()` instead: `contains(&s2[2..])`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_some.rs:57:44
|
||||
|
|
||||
LL | .filter(|c| filter_hand.iter().find(|cc| c == cc).is_some())
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|cc| c == &cc)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with `find`
|
||||
--> $DIR/search_is_some_fixable_some.rs:73:49
|
||||
|
|
||||
LL | .filter(|(c, _)| filter_hand.iter().find(|cc| c == *cc).is_some())
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `any()` instead: `any(|cc| c == cc)`
|
||||
|
||||
error: aborting due to 22 previous errors
|
||||
|
||||
Loading…
Reference in a new issue