diff --git a/clippy_lints/src/panic.rs b/clippy_lints/src/panic.rs index bbb62a778..a6691db86 100644 --- a/clippy_lints/src/panic.rs +++ b/clippy_lints/src/panic.rs @@ -10,8 +10,7 @@ use utils::{is_direct_expn_of, match_def_path, opt_def_id, paths, resolve_node, /// is not a format string and used literally. So while `format!("{}")` will /// fail to compile, `panic!("{}")` will not. /// -/// **Known problems:** Should you want to use curly brackets in `panic!` -/// without any parameter, this lint will warn. +/// **Known problems:** None. /// /// **Example:** /// ```rust @@ -45,8 +44,9 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass { if let ExprLit(ref lit) = params[0].node; if is_direct_expn_of(expr.span, "panic").is_some(); if let LitKind::Str(ref string, _) = lit.node; - if let Some(par) = string.as_str().find('{'); - if string.as_str()[par..].contains('}'); + let string = string.as_str().replace("{{", "").replace("}}", ""); + if let Some(par) = string.find('{'); + if string[par..].contains('}'); if params[0].span.source_callee().is_none(); if params[0].span.lo() != params[0].span.hi(); then { diff --git a/tests/ui/panic.rs b/tests/ui/panic.rs index f621a5f63..d833d2651 100644 --- a/tests/ui/panic.rs +++ b/tests/ui/panic.rs @@ -11,6 +11,8 @@ fn missing() { } else { assert!(true, "here be missing values: {}"); } + + panic!("{{{this}}}"); } fn ok_single() { @@ -41,6 +43,16 @@ fn ok_nomsg() { assert!(if 1 == ONE { ONE == 1 } else { false }); } +fn ok_escaped() { + panic!("{{ why should this not be ok? }}"); + panic!(" or {{ that ?"); + panic!(" or }} this ?"); + panic!(" {or {{ that ?"); + panic!(" }or }} this ?"); + panic!("{{ test }"); + panic!("{case }}"); +} + fn main() { missing(); ok_single(); @@ -48,4 +60,5 @@ fn main() { ok_bracket(); ok_inner(); ok_nomsg(); + ok_escaped(); } diff --git a/tests/ui/panic.stderr b/tests/ui/panic.stderr index 25113ed80..165c33cac 100644 --- a/tests/ui/panic.stderr +++ b/tests/ui/panic.stderr @@ -18,5 +18,11 @@ error: you probably are missing some parameter in your format string 12 | assert!(true, "here be missing values: {}"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -error: aborting due to 3 previous errors +error: you probably are missing some parameter in your format string + --> $DIR/panic.rs:15:12 + | +15 | panic!("{{{this}}}"); + | ^^^^^^^^^^^^ + +error: aborting due to 4 previous errors