Fix false positives on procedural macros of missing_inline_in_public_items lint

This commit is contained in:
hyd-dev 2021-02-28 20:44:07 +08:00
parent abd2c7ebfb
commit da3a57377e
No known key found for this signature in database
GPG key ID: 74FA7FD5B8DA14B8
3 changed files with 32 additions and 4 deletions

View file

@ -69,21 +69,21 @@ fn check_missing_inline_attrs(cx: &LateContext<'_>, attrs: &[ast::Attribute], sp
}
}
fn is_executable(cx: &LateContext<'_>) -> bool {
fn is_executable_or_proc_macro(cx: &LateContext<'_>) -> bool {
use rustc_session::config::CrateType;
cx.tcx
.sess
.crate_types()
.iter()
.any(|t: &CrateType| matches!(t, CrateType::Executable))
.any(|t: &CrateType| matches!(t, CrateType::Executable | CrateType::ProcMacro))
}
declare_lint_pass!(MissingInline => [MISSING_INLINE_IN_PUBLIC_ITEMS]);
impl<'tcx> LateLintPass<'tcx> for MissingInline {
fn check_item(&mut self, cx: &LateContext<'tcx>, it: &'tcx hir::Item<'_>) {
if rustc_middle::lint::in_external_macro(cx.sess(), it.span) || is_executable(cx) {
if rustc_middle::lint::in_external_macro(cx.sess(), it.span) || is_executable_or_proc_macro(cx) {
return;
}
@ -133,7 +133,7 @@ impl<'tcx> LateLintPass<'tcx> for MissingInline {
fn check_impl_item(&mut self, cx: &LateContext<'tcx>, impl_item: &'tcx hir::ImplItem<'_>) {
use rustc_middle::ty::{ImplContainer, TraitContainer};
if rustc_middle::lint::in_external_macro(cx.sess(), impl_item.span) || is_executable(cx) {
if rustc_middle::lint::in_external_macro(cx.sess(), impl_item.span) || is_executable_or_proc_macro(cx) {
return;
}

View file

@ -0,0 +1,5 @@
#![warn(clippy::missing_inline_in_public_items)]
pub fn foo() {}
fn main() {}

View file

@ -0,0 +1,23 @@
#![warn(clippy::missing_inline_in_public_items)]
#![crate_type = "proc-macro"]
extern crate proc_macro;
use proc_macro::TokenStream;
fn _foo() {}
#[proc_macro]
pub fn function_like(_: TokenStream) -> TokenStream {
TokenStream::new()
}
#[proc_macro_attribute]
pub fn attribute(_: TokenStream, _: TokenStream) -> TokenStream {
TokenStream::new()
}
#[proc_macro_derive(Derive)]
pub fn derive(_: TokenStream) -> TokenStream {
TokenStream::new()
}