Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-27 15:11:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add #7859 FP test case for question_mark

Browse source
This commit is contained in:
dswij 2021-10-22 13:36:13 +08:00 committed by Dharma Saputra Wijaya
parent 075996efd7
commit d4196d0293
1 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
tests/ui/question_mark.rs
View file

@ -2,6 +2,9 @@
#![allow(unreachable_code)]
#![allow(clippy::unnecessary_wraps)]
use std::env;
use std::path::PathBuf;
fn some_func(a: Option<u32>) -> Option<u32> {
if a.is_none() {
return None;
@ -134,7 +137,11 @@ fn func() -> Option<i32> {
Some(0)
}
fn result_func(x: Result<i32, &str>) -> Result<i32, &str> {
fn func_returning_result() -> Result<i32, String> {
Ok(1)
}
fn result_func(x: Result<i32, String>) -> Result<i32, String> {
let _ = if let Ok(x) = x { x } else { return x };
if x.is_err() {
@ -145,9 +152,21 @@ fn result_func(x: Result<i32, &str>) -> Result<i32, &str> {
let y = if let Ok(x) = x {
x
} else {
return Err("some error");
return Err("some error".to_string());
};
// issue #7859
// no warning
let _ = if let Ok(x) = func_returning_result() {
x
} else {
return Err("some error".to_string());
};
if func_returning_result().is_err() {
return func_returning_result();
}
Ok(y)
}