dev: Move DOCS_LINK out of lazy_static and reuse it

This commit is contained in:
Lzu Tao 2020-02-07 08:33:01 +07:00
parent 344603afce
commit cf58537bd6
2 changed files with 12 additions and 9 deletions

View file

@ -30,9 +30,10 @@ lazy_static! {
)
.unwrap();
static ref NL_ESCAPE_RE: Regex = Regex::new(r#"\\\n\s*"#).unwrap();
pub static ref DOCS_LINK: String = "https://rust-lang.github.io/rust-clippy/master/index.html".to_string();
}
pub static DOCS_LINK: &str = "https://rust-lang.github.io/rust-clippy/master/index.html";
/// Lint data parsed from the Clippy source code.
#[derive(Clone, PartialEq, Debug)]
pub struct Lint {
@ -120,7 +121,7 @@ pub fn gen_changelog_lint_list(lints: Vec<Lint>) -> Vec<String> {
if l.is_internal() {
None
} else {
Some(format!("[`{}`]: {}#{}", l.name, DOCS_LINK.clone(), l.name))
Some(format!("[`{}`]: {}#{}", l.name, DOCS_LINK, l.name))
}
})
.collect()

View file

@ -150,7 +150,7 @@ fn print_lints() {
println!(
"* [{}]({}#{}) ({})",
lint.name,
clippy_dev::DOCS_LINK.clone(),
clippy_dev::DOCS_LINK,
lint.name,
lint.desc
);
@ -191,16 +191,18 @@ fn update_lints(update_mode: UpdateMode) {
file_change |= replace_region_in_file(
Path::new("README.md"),
r#"\[There are \d+ lints included in this crate!\]\(https://rust-lang.github.io/rust-clippy/master/index.html\)"#,
&format!(r#"\[There are \d+ lints included in this crate!\]\({}\)"#, DOCS_LINK),
"",
true,
update_mode == UpdateMode::Change,
|| {
vec![
format!("[There are {} lints included in this crate!](https://rust-lang.github.io/rust-clippy/master/index.html)", lint_count)
]
}
).changed;
vec![format!(
"[There are {} lints included in this crate!]({})",
lint_count, DOCS_LINK
)]
},
)
.changed;
file_change |= replace_region_in_file(
Path::new("CHANGELOG.md"),