Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-24 05:33:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2545 from flip1995/sus_arith

Browse source 
Don't lint comparison operators in arithmetic impls
This commit is contained in:
Oliver Schneider 2018-03-17 23:20:51 +01:00 committed by GitHub
commit cb7af65e28
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
clippy_lints/src/suspicious_trait_impl.rs
View file

@ -61,6 +61,10 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for SuspiciousImpl {
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr) { fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx hir::Expr) {
use rustc::hir::BinOp_::*; use rustc::hir::BinOp_::*;
if let hir::ExprBinary(binop, _, _) = expr.node { if let hir::ExprBinary(binop, _, _) = expr.node {
match binop.node {
BiEq | BiLt | BiLe | BiNe | BiGe | BiGt => return,
_ => {},
}
// Check if the binary expression is part of another bi/unary expression // Check if the binary expression is part of another bi/unary expression
// as a child node // as a child node
let mut parent_expr = cx.tcx.hir.get_parent_node(expr.id); let mut parent_expr = cx.tcx.hir.get_parent_node(expr.id);

4
tests/ui/suspicious_arithmetic_impl.rs
View file

@ -59,7 +59,11 @@ impl Sub for Bar {
type Output = Bar; type Output = Bar;
fn sub(self, other: Self) -> Self { fn sub(self, other: Self) -> Self {
if self.0 <= other.0 {
Bar(-(self.0 & other.0)) // OK: UnNeg part of BiExpr as parent node Bar(-(self.0 & other.0)) // OK: UnNeg part of BiExpr as parent node
} else {
Bar(0)
}
} }
} }