mirror of
https://github.com/rust-lang/rust-clippy
synced 2025-02-17 14:38:46 +00:00
lint: fix a few comments
This commit is contained in:
parent
ac0e10aa68
commit
c251f8d8dd
2 changed files with 1 additions and 13 deletions
|
@ -173,18 +173,6 @@ fn check_uninlined_args(cx: &LateContext<'_>, args: &FormatArgsExpn<'_>, call_si
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// FIXME: Properly ignore a rare case where the format string is wrapped in a macro.
|
|
||||||
// Example: `format!(indoc!("{}"), foo);`
|
|
||||||
// If inlined, they will cause a compilation error:
|
|
||||||
// > to avoid ambiguity, `format_args!` cannot capture variables
|
|
||||||
// > when the format string is expanded from a macro
|
|
||||||
// @Alexendoo explanation:
|
|
||||||
// > indoc! is a proc macro that is producing a string literal with its span
|
|
||||||
// > set to its input it's not marked as from expansion, and since it's compatible
|
|
||||||
// > tokenization wise clippy_utils::is_from_proc_macro wouldn't catch it either
|
|
||||||
// This might be a relatively expensive test, so do it only we are ready to replace.
|
|
||||||
// See more examples in tests/ui/uninlined_format_args.rs
|
|
||||||
|
|
||||||
span_lint_and_then(
|
span_lint_and_then(
|
||||||
cx,
|
cx,
|
||||||
UNINLINED_FORMAT_ARGS,
|
UNINLINED_FORMAT_ARGS,
|
||||||
|
|
|
@ -414,7 +414,7 @@ impl FormatString {
|
||||||
|
|
||||||
struct FormatArgsValues<'tcx> {
|
struct FormatArgsValues<'tcx> {
|
||||||
/// Values passed after the format string and implicit captures. `[1, z + 2, x]` for
|
/// Values passed after the format string and implicit captures. `[1, z + 2, x]` for
|
||||||
/// `format!("{x} {} {y}", 1, z + 2)`.
|
/// `format!("{x} {} {}", 1, z + 2)`.
|
||||||
value_args: Vec<&'tcx Expr<'tcx>>,
|
value_args: Vec<&'tcx Expr<'tcx>>,
|
||||||
/// Maps an `rt::v1::Argument::position` or an `rt::v1::Count::Param` to its index in
|
/// Maps an `rt::v1::Argument::position` or an `rt::v1::Count::Param` to its index in
|
||||||
/// `value_args`
|
/// `value_args`
|
||||||
|
|
Loading…
Add table
Reference in a new issue