Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-23 05:03:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix grammar issues

Browse source
This commit is contained in:
Yechan Bae 2021-12-07 10:02:58 -05:00
parent ee0d71e103
commit c0fd250c62
3 changed files with 18 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
clippy_lints/src/non_send_fields_in_send_ty.rs
View file

@ -17,7 +17,7 @@ declare_clippy_lint! {
/// contains fields that are not safe to be sent across threads.
/// It tries to detect fields that can cause a soundness issue
/// when sent to another thread (e.g., `Rc`) while allowing `!Send` fields
/// that are expected to exist in a `Send` type such as raw pointers.
/// that are expected to exist in a `Send` type, such as raw pointers.
///
/// ### Why is this bad?
/// Sending the struct to another thread effectively sends all of its fields,
@ -124,7 +124,7 @@ impl<'tcx> LateLintPass<'tcx> for NonSendFieldInSendTy {
NON_SEND_FIELDS_IN_SEND_TY,
item.span,
&format!(
"there are some fields in `{}` are not safe to be sent to another thread",
"some fields in `{}` are not safe to be sent to another thread",
snippet(cx, hir_impl.self_ty.span, "Unknown")
),
|diag| {

8
tests/ui-toml/strict_non_send_fields_in_send_ty/test.stderr
View file

@ -1,4 +1,4 @@
error: there are some fields in `NoGeneric` are not safe to be sent to another thread
error: some fields in `NoGeneric` are not safe to be sent to another thread
--> $DIR/test.rs:11:1
|
LL | unsafe impl Send for NoGeneric {}
@ -12,7 +12,7 @@ LL | rc_is_not_send: Rc<String>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: use a thread-safe type that implements `Send`
error: there are some fields in `MultiField<T>` are not safe to be sent to another thread
error: some fields in `MultiField<T>` are not safe to be sent to another thread
--> $DIR/test.rs:19:1
|
LL | unsafe impl<T> Send for MultiField<T> {}
@ -37,7 +37,7 @@ LL | field3: T,
| ^^^^^^^^^
= help: add `T: Send` bound in `Send` impl
error: there are some fields in `MyOption<T>` are not safe to be sent to another thread
error: some fields in `MyOption<T>` are not safe to be sent to another thread
--> $DIR/test.rs:26:1
|
LL | unsafe impl<T> Send for MyOption<T> {}
@ -50,7 +50,7 @@ LL | MySome(T),
| ^
= help: add `T: Send` bound in `Send` impl
error: there are some fields in `HeuristicTest` are not safe to be sent to another thread
error: some fields in `HeuristicTest` are not safe to be sent to another thread
--> $DIR/test.rs:41:1
|
LL | unsafe impl Send for HeuristicTest {}

24
tests/ui/non_send_fields_in_send_ty.stderr
View file

@ -1,4 +1,4 @@
error: there are some fields in `RingBuffer<T>` are not safe to be sent to another thread
error: some fields in `RingBuffer<T>` are not safe to be sent to another thread
--> $DIR/non_send_fields_in_send_ty.rs:16:1
|
LL | unsafe impl<T> Send for RingBuffer<T> {}
@ -12,7 +12,7 @@ LL | data: Vec<UnsafeCell<T>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^
= help: add bounds on type parameter `T` that satisfy `Vec<UnsafeCell<T>>: Send`
error: there are some fields in `MvccRwLock<T>` are not safe to be sent to another thread
error: some fields in `MvccRwLock<T>` are not safe to be sent to another thread
--> $DIR/non_send_fields_in_send_ty.rs:24:1
|
LL | unsafe impl<T> Send for MvccRwLock<T> {}
@ -25,7 +25,7 @@ LL | lock: Mutex<Box<T>>,
| ^^^^^^^^^^^^^^^^^^^
= help: add bounds on type parameter `T` that satisfy `Mutex<Box<T>>: Send`
error: there are some fields in `ArcGuard<RC, T>` are not safe to be sent to another thread
error: some fields in `ArcGuard<RC, T>` are not safe to be sent to another thread
--> $DIR/non_send_fields_in_send_ty.rs:32:1
|
LL | unsafe impl<RC, T: Send> Send for ArcGuard<RC, T> {}
@ -38,7 +38,7 @@ LL | head: Arc<RC>,
| ^^^^^^^^^^^^^
= help: add bounds on type parameter `RC` that satisfy `Arc<RC>: Send`
error: there are some fields in `DeviceHandle<T>` are not safe to be sent to another thread
error: some fields in `DeviceHandle<T>` are not safe to be sent to another thread
--> $DIR/non_send_fields_in_send_ty.rs:48:1
|
LL | unsafe impl<T: UsbContext> Send for DeviceHandle<T> {}
@ -51,7 +51,7 @@ LL | context: T,
| ^^^^^^^^^^
= help: add `T: Send` bound in `Send` impl
error: there are some fields in `NoGeneric` are not safe to be sent to another thread
error: some fields in `NoGeneric` are not safe to be sent to another thread
--> $DIR/non_send_fields_in_send_ty.rs:55:1
|
LL | unsafe impl Send for NoGeneric {}
@ -64,7 +64,7 @@ LL | rc_is_not_send: Rc<String>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: use a thread-safe type that implements `Send`
error: there are some fields in `MultiField<T>` are not safe to be sent to another thread
error: some fields in `MultiField<T>` are not safe to be sent to another thread
--> $DIR/non_send_fields_in_send_ty.rs:63:1
|
LL | unsafe impl<T> Send for MultiField<T> {}
@ -89,7 +89,7 @@ LL | field3: T,
| ^^^^^^^^^
= help: add `T: Send` bound in `Send` impl
error: there are some fields in `MyOption<T>` are not safe to be sent to another thread
error: some fields in `MyOption<T>` are not safe to be sent to another thread
--> $DIR/non_send_fields_in_send_ty.rs:70:1
|
LL | unsafe impl<T> Send for MyOption<T> {}
@ -102,7 +102,7 @@ LL | MySome(T),
| ^
= help: add `T: Send` bound in `Send` impl
error: there are some fields in `MultiParam<A, B>` are not safe to be sent to another thread
error: some fields in `MultiParam<A, B>` are not safe to be sent to another thread
--> $DIR/non_send_fields_in_send_ty.rs:82:1
|
LL | unsafe impl<A, B> Send for MultiParam<A, B> {}
@ -115,7 +115,7 @@ LL | vec: Vec<(A, B)>,
| ^^^^^^^^^^^^^^^^
= help: add bounds on type parameters `A, B` that satisfy `Vec<(A, B)>: Send`
error: there are some fields in `HeuristicTest` are not safe to be sent to another thread
error: some fields in `HeuristicTest` are not safe to be sent to another thread
--> $DIR/non_send_fields_in_send_ty.rs:100:1
|
LL | unsafe impl Send for HeuristicTest {}
@ -128,7 +128,7 @@ LL | field4: (*const NonSend, Rc<u8>),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: use a thread-safe type that implements `Send`
error: there are some fields in `AttrTest3<T>` are not safe to be sent to another thread
error: some fields in `AttrTest3<T>` are not safe to be sent to another thread
--> $DIR/non_send_fields_in_send_ty.rs:119:1
|
LL | unsafe impl<T> Send for AttrTest3<T> {}
@ -141,7 +141,7 @@ LL | Enum2(T),
| ^
= help: add `T: Send` bound in `Send` impl
error: there are some fields in `Complex<P, u32>` are not safe to be sent to another thread
error: some fields in `Complex<P, u32>` are not safe to be sent to another thread
--> $DIR/non_send_fields_in_send_ty.rs:127:1
|
LL | unsafe impl<P> Send for Complex<P, u32> {}
@ -154,7 +154,7 @@ LL | field1: A,
| ^^^^^^^^^
= help: add `P: Send` bound in `Send` impl
error: there are some fields in `Complex<Q, MutexGuard<'static, bool>>` are not safe to be sent to another thread
error: some fields in `Complex<Q, MutexGuard<'static, bool>>` are not safe to be sent to another thread
--> $DIR/non_send_fields_in_send_ty.rs:130:1
|
LL | unsafe impl<Q: Send> Send for Complex<Q, MutexGuard<'static, bool>> {}