Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-24 05:33:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

let upper_case_acronyms check the enum name

Browse source 
Signed-off-by: TennyZhuang <zty0826@gmail.com>
This commit is contained in:
TennyZhuang 2022-10-03 10:11:57 +08:00
parent 2be6c4ae5b
commit bf18768219
3 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
clippy_lints/src/upper_case_acronyms.rs
View file

@ -114,6 +114,7 @@ impl LateLintPass<'_> for UpperCaseAcronyms {
check_ident(cx, &it.ident, self.upper_case_acronyms_aggressive);
},
ItemKind::Enum(ref enumdef, _) => {
check_ident(cx, &it.ident, self.upper_case_acronyms_aggressive);
// check enum variants separately because again we only want to lint on private enums and
// the fn check_variant does not know about the vis of the enum of its variants
enumdef

9
tests/ui/upper_case_acronyms.rs
View file

@ -38,4 +38,13 @@ enum ParseErrorPrivate<T> {
Parse(T, String),
}
// do lint here
struct JSON;
// do lint here
enum YAML {
Num(u32),
Str(String),
}
fn main() {}

14
tests/ui/upper_case_acronyms.stderr
View file

@ -54,5 +54,17 @@ error: name `WASD` contains a capitalized acronym
LL | WASD(u8),
| ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wasd`
error: aborting due to 9 previous errors
error: name `JSON` contains a capitalized acronym
--> $DIR/upper_case_acronyms.rs:42:8
|
LL | struct JSON;
| ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json`
error: name `YAML` contains a capitalized acronym
--> $DIR/upper_case_acronyms.rs:45:6
|
LL | enum YAML {
| ^^^^ help: consider making the acronym lowercase, except the initial letter: `Yaml`
error: aborting due to 11 previous errors