Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-23 21:23:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

Apply review comment

Browse source
This commit is contained in:
Yuki Okushi 2020-01-20 21:07:31 +09:00
parent 84e4bc54e0
commit bec5b69e45
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
clippy_lints/src/methods/mod.rs
View file

@ -2563,9 +2563,13 @@ fn lint_skip_while_next<'a, 'tcx>(
) { ) {
// lint if caller of `.skip_while().next()` is an Iterator // lint if caller of `.skip_while().next()` is an Iterator
if match_trait_method(cx, expr, &paths::ITERATOR) { if match_trait_method(cx, expr, &paths::ITERATOR) {
let msg = "called `skip_while(p).next()` on an `Iterator`. \ span_help_and_lint(
This is more succinctly expressed by calling `.find(!p)` instead."; cx,
span_lint(cx, SKIP_WHILE_NEXT, expr.span, msg); SKIP_WHILE_NEXT,
expr.span,
"called `skip_while(p).next()` on an `Iterator`",
"this is more succinctly expressed by calling `.find(!p)` instead",
);
} }
} }

7
tests/ui/skip_while_next.stderr
View file

@ -1,12 +1,13 @@
error: called `skip_while(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(!p)` instead. error: called `skip_while(p).next()` on an `Iterator`
--> $DIR/skip_while_next.rs:14:13 --> $DIR/skip_while_next.rs:14:13
| |
LL | let _ = v.iter().skip_while(|&x| *x < 0).next(); LL | let _ = v.iter().skip_while(|&x| *x < 0).next();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
= note: `-D clippy::skip-while-next` implied by `-D warnings` = note: `-D clippy::skip-while-next` implied by `-D warnings`
= help: this is more succinctly expressed by calling `.find(!p)` instead
error: called `skip_while(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(!p)` instead. error: called `skip_while(p).next()` on an `Iterator`
--> $DIR/skip_while_next.rs:17:13 --> $DIR/skip_while_next.rs:17:13
| |
LL | let _ = v.iter().skip_while(|&x| { LL | let _ = v.iter().skip_while(|&x| {
@ -15,6 +16,8 @@ LL | | *x < 0
LL | | } LL | | }
LL | | ).next(); LL | | ).next();
| |___________________________^ | |___________________________^
|
= help: this is more succinctly expressed by calling `.find(!p)` instead
error: aborting due to 2 previous errors error: aborting due to 2 previous errors