Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-24 05:33:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #7770 - zvavybir:master, r=xFrednet

Browse source 
improved help message for `suspicious_map`

`suspicious_map`'s help message assumes that the literal behavior is never the intended one, although it's sometimes.  This PR adds a mention of `inspect`, offering a idiomatic alternative.

fixes #7767

---

changelog: Improved help message of [`suspicious_map`].
This commit is contained in:
bors 2021-10-05 19:51:09 +00:00
commit b9dedf3959
3 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
clippy_lints/src/methods/mod.rs
View file

@ -1284,8 +1284,9 @@ declare_clippy_lint! {
/// ///
/// ### Why is this bad? /// ### Why is this bad?
/// It looks suspicious. Maybe `map` was confused with `filter`. /// It looks suspicious. Maybe `map` was confused with `filter`.
/// If the `map` call is intentional, this should be rewritten. Or, if you intend to /// If the `map` call is intentional, this should be rewritten
/// drive the iterator to completion, you can just use `for_each` instead. /// using `inspect`. Or, if you intend to drive the iterator to
/// completion, you can just use `for_each` instead.
/// ///
/// ### Example /// ### Example
/// ```rust /// ```rust

2
clippy_lints/src/methods/suspicious_map.rs
View file

@ -28,7 +28,7 @@ pub fn check<'tcx>(cx: &LateContext<'tcx>, expr: &hir::Expr<'_>, count_recv: &hi
expr.span, expr.span,
"this call to `map()` won't have an effect on the call to `count()`", "this call to `map()` won't have an effect on the call to `count()`",
None, None,
"make sure you did not confuse `map` with `filter` or `for_each`", "make sure you did not confuse `map` with `filter`, `for_each` or `inspect`",
); );
} }
} }

4
tests/ui/suspicious_map.stderr
View file

@ -5,7 +5,7 @@ LL | let _ = (0..3).map(|x| x + 2).count();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
= note: `-D clippy::suspicious-map` implied by `-D warnings` = note: `-D clippy::suspicious-map` implied by `-D warnings`
= help: make sure you did not confuse `map` with `filter` or `for_each` = help: make sure you did not confuse `map` with `filter`, `for_each` or `inspect`
error: this call to `map()` won't have an effect on the call to `count()` error: this call to `map()` won't have an effect on the call to `count()`
--> $DIR/suspicious_map.rs:7:13 --> $DIR/suspicious_map.rs:7:13
@ -13,7 +13,7 @@ error: this call to `map()` won't have an effect on the call to `count()`
LL | let _ = (0..3).map(f).count(); LL | let _ = (0..3).map(f).count();
| ^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^
| |
= help: make sure you did not confuse `map` with `filter` or `for_each` = help: make sure you did not confuse `map` with `filter`, `for_each` or `inspect`
error: aborting due to 2 previous errors error: aborting due to 2 previous errors