Stabilize tool lints

README.md

@@ -130,11 +130,10 @@ You can add options to your code to `allow`/`warn`/`deny` Clippy lints:
 
 Note: `deny` produces errors instead of warnings.
 
-Note: To use the new `clippy::lint_name` syntax, `#![feature(tool_lints)]` has to be activated 
+Note: To use the new `clippy::lint_name` syntax, a recent compiler has to be used
 currently. If you want to compile your code with the stable toolchain you can use a `cfg_attr` to
 activate the `tool_lints` feature:
 ```rust
-#![cfg_attr(feature = "cargo-clippy", feature(tool_lints))]
 #![cfg_attr(feature = "cargo-clippy", allow(clippy::lint_name))]
 ```
 

clippy_dev/src/lib.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 #![allow(clippy::default_hash_types)]
 
 use itertools::Itertools;

clippy_lints/src/lib.rs

@@ -18,7 +18,7 @@
 #![allow(unknown_lints, clippy::shadow_reuse, clippy::missing_docs_in_private_items)]
 #![recursion_limit = "256"]
 #![feature(macro_at_most_once_rep)]
-#![feature(tool_lints)]
+
 #![warn(rust_2018_idioms, trivial_casts, trivial_numeric_casts)]
 #![feature(crate_visibility_modifier)]
 #![feature(try_from)]

src/driver.rs

@@ -11,7 +11,7 @@
 // error-pattern:yummy
 #![feature(box_syntax)]
 #![feature(rustc_private)]
-#![feature(tool_lints)]
+
 #![feature(try_from)]
 #![allow(unknown_lints, clippy::missing_docs_in_private_items)]
 

src/lib.rs

@@ -11,7 +11,7 @@
 // error-pattern:cargo-clippy
 #![feature(plugin_registrar)]
 #![feature(rustc_private)]
-#![feature(tool_lints)]
+
 #![allow(unknown_lints)]
 #![allow(clippy::missing_docs_in_private_items)]
 #![warn(rust_2018_idioms)]

src/main.rs

@@ -11,7 +11,7 @@
 // error-pattern:yummy
 #![feature(box_syntax)]
 #![feature(rustc_private)]
-#![feature(tool_lints)]
+
 #![allow(unknown_lints, clippy::missing_docs_in_private_items)]
 
 use rustc_tools_util::*;

tests/run-pass/enum-glob-import-crate.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![deny(clippy::all)]
 #![allow(unused_imports)]

tests/run-pass/ice-1588.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![allow(clippy::all)]
 

tests/run-pass/ice-1969.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![allow(clippy::all)]
 

tests/run-pass/ice-2499.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![allow(dead_code, clippy::char_lit_as_u8, clippy::needless_bool)]
 

tests/run-pass/ice-2760.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![allow(unused_variables, clippy::blacklisted_name,
          clippy::needless_pass_by_value, dead_code)]

tests/run-pass/ice-2774.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 use std::collections::HashSet;
 

tests/run-pass/ice-700.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![deny(clippy::all)]
 

tests/run-pass/ice_exacte_size.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![deny(clippy::all)]
 

tests/run-pass/if_same_then_else.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![deny(clippy::if_same_then_else)]
 

tests/run-pass/match_same_arms_const.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![deny(clippy::match_same_arms)]
 

tests/run-pass/mut_mut_macro.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![deny(clippy::mut_mut, clippy::zero_ptr, clippy::cmp_nan)]
 #![allow(dead_code)]

tests/run-pass/needless_borrow_fp.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #[deny(clippy::all)]
 

tests/run-pass/needless_lifetimes_impl_trait.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![deny(clippy::needless_lifetimes)]
 #![allow(dead_code)]

tests/run-pass/regressions.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![allow(clippy::blacklisted_name)]
 

tests/run-pass/single-match-else.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::single_match_else)]
 

tests/run-pass/used_underscore_binding_macro.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![allow(clippy::useless_attribute)] //issue #2910
 

tests/ui-toml/toml_blacklist/conf_french_blacklisted_name.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![allow(dead_code)]

tests/ui-toml/toml_trivially_copy/test.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 #![allow(clippy::many_single_char_names)]
 
 #[derive(Copy, Clone)]

tests/ui/absurd-extreme-comparisons.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::absurd_extreme_comparisons)]

tests/ui/approx_const.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[warn(clippy::approx_constant)]

tests/ui/arithmetic.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::integer_arithmetic, clippy::float_arithmetic)]

tests/ui/assign_ops.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #[allow(dead_code, unused_assignments)]
 #[warn(clippy::assign_op_pattern)]

tests/ui/assign_ops2.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[allow(unused_assignments)]

tests/ui/attrs.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::inline_always, clippy::deprecated_semver)]

tests/ui/bit_masks.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 const THREE_BITS : i64 = 7;

tests/ui/blacklisted_name.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![allow(dead_code, clippy::similar_names, clippy::single_match, clippy::toplevel_ref_arg, unused_mut, unused_variables)]

tests/ui/block_in_if_condition.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::block_in_if_condition_expr)]

tests/ui/bool_comparison.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[warn(clippy::bool_comparison)]

tests/ui/booleans.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::nonminimal_bool, clippy::logic_bug)]
 

tests/ui/borrow_box.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![deny(clippy::borrowed_box)]

tests/ui/box_vec.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::all)]

tests/ui/builtin-type-shadow.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::builtin_type_shadow)]
 

tests/ui/bytecount.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[deny(clippy::naive_bytecount)]

tests/ui/cast.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[warn(clippy::cast_precision_loss, clippy::cast_possible_truncation, clippy::cast_sign_loss, clippy::cast_possible_wrap, clippy::cast_lossless)]

tests/ui/cast_alignment.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 //! Test casts for alignment issues
 

tests/ui/cast_lossless_float.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #[warn(clippy::cast_lossless)]
 #[allow(clippy::no_effect, clippy::unnecessary_operation)]

tests/ui/cast_lossless_integer.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 #[warn(clippy::cast_lossless)]
 #[allow(clippy::no_effect, clippy::unnecessary_operation)]
 fn main() {

tests/ui/cast_size.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #[warn(clippy::cast_precision_loss, clippy::cast_possible_truncation, clippy::cast_sign_loss, clippy::cast_possible_wrap, clippy::cast_lossless)]
 #[allow(clippy::no_effect, clippy::unnecessary_operation)]

tests/ui/char_lit_as_u8.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::char_lit_as_u8)]

tests/ui/checked_unwrap.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![deny(clippy::panicking_unwrap, clippy::unnecessary_unwrap)]
 #![allow(clippy::if_same_then_else)]

tests/ui/clone_on_copy_mut.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 pub fn dec_read_dec(i: &mut i32) -> i32 {
     *i -= 1;

tests/ui/cmp_nan.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[warn(clippy::cmp_nan)]

tests/ui/cmp_null.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::cmp_null)]
 #![allow(unused_mut)]

tests/ui/cmp_owned.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[warn(clippy::cmp_owned)]

tests/ui/collapsible_if.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[warn(clippy::collapsible_if)]

tests/ui/complex_types.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::all)]
 #![allow(unused, clippy::needless_pass_by_value)]

tests/ui/copies.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![allow(clippy::blacklisted_name, clippy::collapsible_if, clippy::cyclomatic_complexity, clippy::eq_op, clippy::needless_continue,
          clippy::needless_return, clippy::never_loop, clippy::no_effect, clippy::zero_divided_by_zero)]

tests/ui/copy_iterator.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::copy_iterator)]
 

tests/ui/cstring.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 fn main() {}
 

tests/ui/cyclomatic_complexity.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![allow(clippy::all)]
 #![warn(clippy::cyclomatic_complexity)]

tests/ui/cyclomatic_complexity_attr_used.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::cyclomatic_complexity)]
 #![warn(unused)]

tests/ui/decimal_literal_representation.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[warn(clippy::decimal_literal_representation)]

tests/ui/default_trait_access.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::default_trait_access)]
 

tests/ui/derive.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![feature(untagged_unions)]
 

tests/ui/diverging_sub_expression.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![feature(never_type)]
 

tests/ui/dlist.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![feature(alloc)]
 #![feature(associated_type_defaults)]

tests/ui/doc.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 //! This file tests for the DOC_MARKDOWN lint
 

tests/ui/double_neg.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[warn(clippy::double_neg)]

tests/ui/double_parens.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::double_parens)]

tests/ui/drop_forget_copy.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::drop_copy, clippy::forget_copy)]

tests/ui/drop_forget_ref.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::drop_ref, clippy::forget_ref)]

tests/ui/duplicate_underscore_argument.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::duplicate_underscore_argument)]

tests/ui/duration_subsec.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::duration_subsec)]
 

tests/ui/else_if_without_else.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::all)]
 #![warn(clippy::else_if_without_else)]

tests/ui/empty_enum.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![allow(dead_code)]

tests/ui/empty_line_after_outer_attribute.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 #![warn(clippy::empty_line_after_outer_attr)]
 
 // This should produce a warning

tests/ui/entry.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![allow(unused, clippy::needless_pass_by_value)]
 

tests/ui/enum_glob_use.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::all, clippy::pedantic)]
 #![allow(unused_imports, dead_code, clippy::missing_docs_in_private_items)]

tests/ui/enum_variants.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![feature(non_ascii_idents)]
 

tests/ui/enums_clike.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 // ignore-x86
 

tests/ui/eq_op.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[warn(clippy::eq_op)]

tests/ui/erasing_op.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[allow(clippy::no_effect)]

tests/ui/eta.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![allow(unknown_lints, unused, clippy::no_effect, clippy::redundant_closure_call, clippy::many_single_char_names, clippy::needless_pass_by_value, clippy::option_map_unit_fn, clippy::trivially_copy_pass_by_ref)]
 #![warn(clippy::redundant_closure, clippy::needless_borrow)]

tests/ui/eval_order_dependence.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #[warn(clippy::eval_order_dependence)]

tests/ui/excessive_precision.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 #![warn(clippy::excessive_precision)]
 #![allow(clippy::print_literal)]
 

tests/ui/explicit_write.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::explicit_write)]
 

tests/ui/fallible_impl_from.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![deny(clippy::fallible_impl_from)]
 

tests/ui/filter_methods.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::all, clippy::pedantic)]

tests/ui/float_cmp.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::float_cmp)]

tests/ui/float_cmp_const.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::float_cmp_const)]

tests/ui/fn_to_numeric_cast.rs

@@ -9,7 +9,7 @@
 
 
 // only-64bit
-#![feature(tool_lints)]
+
 
 #![warn(clippy::fn_to_numeric_cast, clippy::fn_to_numeric_cast_with_truncation)]
 

tests/ui/for_loop.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 use std::collections::*;

tests/ui/format.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 #![allow(clippy::print_literal)]
 #![warn(clippy::useless_format)]
 

tests/ui/formatting.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::all)]

tests/ui/functions.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::all)]

tests/ui/fxhash.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::default_hash_types)]
 #![feature(rustc_private)]

tests/ui/identity_conversion.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![deny(clippy::identity_conversion)]
 

tests/ui/identity_op.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 const ONE : i64 = 1;

tests/ui/if_let_redundant_pattern_matching.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 
 #![warn(clippy::all)]

tests/ui/if_not_else.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![warn(clippy::all)]
 #![warn(clippy::if_not_else)]

tests/ui/impl.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![allow(dead_code)]
 #![warn(clippy::multiple_inherent_impl)]

tests/ui/inconsistent_digit_grouping.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #[warn(clippy::inconsistent_digit_grouping)]
 #[allow(unused_variables)]

tests/ui/indexing_slicing.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![feature(plugin)]
 #![warn(clippy::indexing_slicing)]

tests/ui/infallible_destructuring_match.rs

@@ -8,7 +8,7 @@
 // except according to those terms.
 
 
-#![feature(tool_lints)]
+
 
 #![feature(exhaustive_patterns, never_type)]
 #![allow(clippy::let_and_return)]