Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-27 07:00:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #7642 - mikerite:fix-7641, r=flip1995

Browse source 
Add `TAU` to `approx_constant`

changelog: [`approx_constant`]: Add `TAU`
This commit is contained in:
bors 2021-09-07 08:16:36 +00:00
commit b7c25e1679
4 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
clippy_lints/src/approx_const.rs
View file

@ -39,7 +39,7 @@ declare_clippy_lint! {
}
// Tuples are of the form (constant, name, min_digits, msrv)
const KNOWN_CONSTS: [(f64, &str, usize, Option<RustcVersion>); 18] = [
const KNOWN_CONSTS: [(f64, &str, usize, Option<RustcVersion>); 19] = [
(f64::E, "E", 4, None),
(f64::FRAC_1_PI, "FRAC_1_PI", 4, None),
(f64::FRAC_1_SQRT_2, "FRAC_1_SQRT_2", 5, None),
@ -58,6 +58,7 @@ const KNOWN_CONSTS: [(f64, &str, usize, Option<RustcVersion>); 18] = [
(f64::LOG10_E, "LOG10_E", 5, None),
(f64::PI, "PI", 3, None),
(f64::SQRT_2, "SQRT_2", 5, None),
(f64::TAU, "TAU", 3, Some(msrvs::TAU)),
];
pub struct ApproxConstant {

1
clippy_utils/src/msrvs.rs
View file

@ -15,6 +15,7 @@ msrv_aliases! {
1,53,0 { OR_PATTERNS }
1,52,0 { STR_SPLIT_ONCE }
1,50,0 { BOOL_THEN }
1,47,0 { TAU }
1,46,0 { CONST_IF_MATCH }
1,45,0 { STR_STRIP_PREFIX }
1,43,0 { LOG2_10, LOG10_2 }

4
tests/ui/approx_const.rs
View file

@ -57,4 +57,8 @@ fn main() {
let my_sq2 = 1.4142;
let no_sq2 = 1.414;
let my_tau = 6.2832;
let almost_tau = 6.28;
let no_tau = 6.3;
}

18
tests/ui/approx_const.stderr
View file

@ -167,5 +167,21 @@ LL | let my_sq2 = 1.4142;
|
= help: consider using the constant directly
error: aborting due to 21 previous errors
error: approximate value of `f{32, 64}::consts::TAU` found
--> $DIR/approx_const.rs:61:18
|
LL | let my_tau = 6.2832;
| ^^^^^^
|
= help: consider using the constant directly
error: approximate value of `f{32, 64}::consts::TAU` found
--> $DIR/approx_const.rs:62:22
|
LL | let almost_tau = 6.28;
| ^^^^
|
= help: consider using the constant directly
error: aborting due to 23 previous errors